This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 25, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix dashboard parameter values in embed preview not working * Fix iframe rerendering unnecessarily * Add E2E reproduction test * Prevent iframe from rerendering unnecessarily
-
Kamil Mielnik authored
Split QueryBuilder.unit.spec.tsx into QueryBuilder.beforeunload-events.unit.spec.tsx, QueryBuilder.unsaved-changes-warning.unit.spec.tsx & test-utils.tsx (#38032)
-
- Jan 24, 2024
-
-
bryan authored
* adds info about what value validate got to the exception message * test fixups * fix the other test * remove inline def
-
Raphael Krut-Landau authored
* Port BrowseHeader to tsx * Use generic type with useSearchListQuery * Allow the query to be specified in setupDatabasesEndpoints * Port EmptyState to tsx * Correct type in FilterableTree * Remove unneeded props
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Braden Shepherdson authored
This regressed in 48 - it only works when either none of the several filters has a value, or when all of them do. This PR restores the 47 behavior: whatever subset of the filters have values (including defaults) will be used, and the others are ignored. The fix is on the BE but the change actually occurred in the FE - previously only those parameters with values were sent in the request. We might want that FE behavior back, but the new BE logic should work either way. Fixes #38012.
-
Jerry Huang authored
* add personal-only to collection endpoint * address some comments * fix test * fix select-collections test * Update src/metabase/api/collection.clj Co-authored-by:
bryan <bryan.maass@gmail.com> * Update src/metabase/api/collection.clj Co-authored-by:
bryan <bryan.maass@gmail.com> * address comments --------- Co-authored-by:
bryan <bryan.maass@gmail.com>
-
Oleg Gromov authored
-
Denis Berezin authored
* Migrate EmbedModalContent to TS * Add basic UI changes to Embed modal * More styling * Add more styling * Self review fixes * Self review fixes * Fix action button * Fix unit tests * Fix e2e tests * Fix e2e tests * Code review and design fixes * Fix unit test * Add Parameters tab text diff and switch to preview * Add code diff display logic for appearance tab * Self review fixes * Fix e2e tests * Button text hotfix * Move state to component, fix diff * Review fixes, action buttons refactor * Implement new code diff * Fix text highlight, fix unit tests * Code review fixes * Design review fixes * New code diff highlight UX * Remove folding * Change code diff logic, add automatic client code switch * Fix code highlight logic * Add unit tests * Fix some e2e tests * Fix e2e tests * Fix code highlight, parameters diff * Add code highlight on locked parameter value change * Add more tests * Review fixes * Refactor unit tests * Rollback preview tab remove, add utm tags * Fix prettier * Add interactive modal header with hover * Review fixes * Review fixes
-
Oisin Coveney authored
-
Romeo Van Snick authored
* Move _lastAutocomplete to a variable in closure * Debounce the initial autocomplete * Add e2e tests * Fix typo in test case Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Remove async from 2e2 tests * Fix wording of comment * Avoid casting in lastAutoComplete * Clarify comment in skip condition for initial autocomplete * Remove outdated comment in e2e test * Describe problem in filename, not assertion * Use early return instead of skip variable * Pass results from last autocomplete to ace * Actually use last autocompletions result * Detect the first autocomplete without looking at the actual prefix * Add test for backspacing to one character in native editor * Rename resultsForAce to prepareResultsForAce * Avoid running autocompleter with prefix of length 1 * Remove unnecessary fallback Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Ryan Laurie authored
Co-authored-by:
Vladimir Zaytsev <vladimir@trunk.io>
-
Chris Truter authored
This reverts commit d78f324c, which reverted 7b0a906a.
-
Uladzimir Havenchyk authored
[QB] Add e2e test for previously broken `SumIf` and `CountIf` functions in custom expressions (#38082) * Add repro for aggregation with SumIf and CountIf * Decrease typing delay * Update e2e/test/scenarios/question/notebook.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Nemanja Glumac authored
* Migrate structured query isEditable method to MLv2 * Migrate all `isQueryEditable` references to MLv2 * Remove `isEditable` methods altogether * Fix failing unit test * [MLv2] Rewrite `QuestionDataSoruce` FE unit test (#38058) * Rewrite `QuestionDataSoruce` FE unit test * Remove unused parameter * Construct empty metadata instance as a fallback
-
Anton Kulyk authored
-
Kamil Mielnik authored
* Add Unit Test Stress Test Flake Fix workflow * Add "frontend" prefix to the workflow to disambiguate between backend and frontend
-
Nemanja Glumac authored
This is a follow-up after #38011. See this comment: https://github.com/metabase/metabase/pull/38011#discussion_r1462885451
-
Chris Truter authored
-
- Jan 23, 2024
-
-
Chris Truter authored
-
Nemanja Glumac authored
* Revert "Fix trailing whitespace (#38057)" This reverts commit 1de0326c. * Revert "Add upload test results to Trunk (#37490)" This reverts commit a36347a1.
-
Nemanja Glumac authored
-
Matt Matheson authored
-
Tim Macdonald authored
* Fix flake in fingerprint test: ``` FAIL in metabase.sync.analyze.fingerprint-test/fingerprint-test (fingerprint_test.clj:287) :sparksql Fingerprints should actually get saved with the correct values Text fingerprints expected: {:global {:distinct-count 100, :nil% 0.0}, :type {:type/Text {:average-length #<Fn@2ee5402f metabase.sync.analyze.fingerprint_test/fn__139755[fn/fn]>, :percent-email 0.0, :percent-json 0.0, :percent-state 0.0, :percent-url 0.0}}} actual: nil ``` * Typo fix
-
Sloan Sparger authored
-
Ryan Laurie authored
-
Braden Shepherdson authored
Fixes #37345.
-
Chris Truter authored
Fixes https://github.com/metabase/metabase/issues/38009 ### Description This makes the feature flag loading code more robust by making the function re-entrant. To understand how this function could deadlock before, see the description in https://github.com/metabase/metabase/pull/38027. It works by ensuring that the call to initialize the nonce comes from the same thread that initially locked on fetching the tokens. There is a subtle behavior change here - was allow for a 10s timeout on each call individually now. Since it is unlikely that both endpoints will timeout consecutively, and the combined wait time is still fairly short, I think this is OK. ### How to verify You can use the same steps as https://github.com/metabase/metabase/pull/38027, either of these PRs are sufficient to fix the bug.
-
Oleg Gromov authored
-
Nemanja Glumac authored
Resolves #38010
-
- Jan 22, 2024
-
-
Mark Bastian authored
* Formatting for time types Currently, the frontend does not do any special formatting for time of day types. These are always formatted as 12 hour AM/PM times. This PR adds a new function to `frontend/src/metabase/lib/formatting/time.ts`, `formatTimeWithOptions`, that applies user-defined formatting to the time. Previously, `formatTime` was called, which takes no formatting options, so none can be applied. Fixes #11398 * e2e tests for time of day formatting. * Update frontend/src/metabase/lib/formatting/time.ts Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu> * Replacing formatTime with formatTimeWithOptions This replaces uses of `formatTime` with `formatTimeWithOptions`, updates unit tests, removes references to `formatTime`, and incorporates some code suggestions. * Unit tests * Adding test id for field info popover. * Refactoring `formatTimeWithOptions` to `formatTime` * Moved `TimeOnlyOptions` interface to formatting types and made it an ancestor of `OptionsType` --------- Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu>
-
Cal Herries authored
-
metamben authored
Fixes #36856.
-
Aleksandr Lesnenko authored
* fix auto y-axis split on native queries * specs
-
Nemanja Glumac authored
* Fix wrong `target` prop type on `DashCardParameterMapper` * Remove unneeded prop from the test setup
-
bryan authored
* Filter out audit tables in search results * add test
-
Anton Kulyk authored
* Use ASCII arrow characters instead of SVG icons * Increase comparison text font size
-
Chris Truter authored
* Fix salt in pulse unsub hash * Workaround for read-only settings not supporting temp overrides yet
-