It's broken there because it tries to capture the Var returned by
`defn` in a `let`. Vars aren't real in CLJS, so this doesn't work.
The compile succeeds but the JS output is subtly broken.

* show all subscriptions in notification management page regardless of collection perms

* strip cards and recipients if necessary

* indentation tweak

* add backend tests

* add cypress repro

* fix permissions check

* slightly different approach

* fix cypress test

* fix test

* address comment

* MLv1 remove unused

* Remove definitely unused methods

* Use internal metadata for `generateQueryDescription`

* Remove `tableMetadata` from `SaveQuestionModal`

* Remove `tableMetadata` from `AggregationPopover`

* Remove `tableMetadata` from `QueryBuilder`

* Remove console.logs

* Fix `_getMLv2Query` call

* Don't fingerprint fields that have (isa? :base_type :type/Structured)

* Add fingerprinting test

* Add function for updating filters

* Support adding and getting filters

* Add current-filters function for handling a conjunction of filters

* fix dashboard opening in editing state when it shouldn't

* unskip reproduction test

* Make `ActionForm` accept an `action` prop

* Make field settings inside `ActionForm` if missing

* Clean date-time values inside `ActionForm`

* WIP

* Clean and filter values on submit in `ActionForm`

* Sort `ActionVizForm` props

* Sort `Action` props

* Use more generic `WritebackAction` type

* Move more logic into the `ActionForm`

* Add `useActionForm` hook

* Fix parameter type in tests

* Fix submitting a form when all parameters mapped

* Move utils to `useActionForm`

* Fix submit button label in public action e2e tests

* Filter changed values only for implicit update actions

* Rename `cleanInitialValues` to `cleanedInitialValues`

* Fix `shouldShowConfirmation` can be a string

* Nice boring code

* Fix types in tests

* Small rename

* Move `useActionForm` utils closer to source (#29328)

* Fix `ActionForm` ignored submit errors

* Fix default values display in the form editor

* Fix names

db/update! -> t2/update!

* Query  D E S C R I P T I O N S

* WIP

* MLv2 Query description

* Test fixes

* More robust error handling

* MLv2 more shuffling things around

* Remove unneeded impl

* Cumulative FE changes

* WIP

* lib.expressions -> lib.expression

* Address PR feedback

* Fix everything

* Oops fix missing metadata

* Test fixes 

* Fixes post-merge

* Fix merge conflict

* JS metadata overhaul

* Test fix 

* Test fix

* Hack to workaround busted JOINs

* Use Braden's better fix

* Cumulative fixes

* Test fixes 

* Remove unused

* Include temporal unit in query description

* Don't change indentation

* Revert e2e browser changes

* Revert bin change

* Meaningless change to kick CI

* Add most of the expression clauses for mlv2

* Add tests for expressions

* Remove duplicate

* Remove test

* Can't use eval in cljs

* Appease kondo

* JS converts 1.0 to integer

* Add missing require

* Fix shadow lint?

* Review changes

* Time now requires a time unit

* Add current-limit setter for a query limit

* Add docstring

* make object detail work for non-logged-in users

* update types to account for optional params

* test public object detail viz

* fix missing group by columns from joined tables

* fix spec

* extract model creation helper

* update model actions test to actually mutate data

* fix merge conflicts and clean up

* Keep NFC root fields in nested queries (#29184)

* build strings for 46

* pull in translations for 46

* last-minute updates and add korean

* Query  D E S C R I P T I O N S

* WIP

* MLv2 Query description

* Test fixes

* More robust error handling

* MLv2 more shuffling things around

* Remove unneeded impl

* lib.expressions -> lib.expression

* Address PR feedback

* Fix custom field type aggregation not showing

When the origin table don't have that field type.

* Add tests

* Remove puzzle driven development comments

* Make `getAggregationOperators` API more apparent

* extract common object detail and table settings

* test object detail column settings