Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 26, 2024
  2. Apr 25, 2024
  3. Apr 24, 2024
  4. Apr 22, 2024
  5. Apr 19, 2024
  6. Apr 18, 2024
  7. Apr 17, 2024
  8. Apr 16, 2024
  9. Apr 15, 2024
  10. Apr 12, 2024
  11. Apr 10, 2024
  12. Apr 08, 2024
    • Alexander Solovyov's avatar
      cache invalidation (#40774) · 84642517
      Alexander Solovyov authored
      New endpoint accepts entity and entity ids in form of `database=1&dashboard=2&question=3`. If you don't supply
      `&include=overrides`, then it tries to find configs directly referencing supplied entities and updates their
      `invalidated_at`. If you supply `&include=overrides`, all the referenced cards are
      updated (`report_card.cache_invalidated_at`).
      
      Cache strategies then select the maximum `invalidated_at` in their logic. EE-only.
      
      resolves #40548
      Unverified
      84642517
  13. Apr 03, 2024
  14. Apr 02, 2024
  15. Mar 28, 2024
    • adam-james's avatar
      Make format export optional (#40606) · 347c5ef4
      adam-james authored
      
      * Make Formatting on Exports Optional
      
      Formatting on exports can be turned off via a middleware key:
      
      `:format-export?` which will control if the 'app style' formatting will be applied to the exported results.
      `:format-export? false` will return the file as in previous Metabase versions.
      
      * format_export's default value provided in the QP middleware
      
      Should still default to formatted for v. 49, as the formatting is intended as a feature. This default value should be
      provided in a central place, so is added to the middleware and is therefore not necessary for the API to provide a default.
      
      * weird indentation
      
      * Add format_export param to dashboard dashcard query endpoint
      
      * Add format_export option to embedded dashboard downloads endpoint
      
      * Move default true value to the streaming-results-writer impls
      
      * Default true but for real this time
      
      * Add format_export to the public Question endpoint
      
      * Add test to card api
      
      * Dashboard exports endpoint test
      
      * Add test to dashboard embeds
      
      Test still fails and I don't know why yet
      
      * the dangers of println debugging....
      
      Well, I was passing a string false the whole time. Turns out the problem was me
      
      * Public Card downloads endpoint now has format_export and test
      
      * export_format also works for adhoc queries using api/dataset
      
      * Let defendpoint do the boolean parsing
      
      * Embed endpoint should now work too.
      
      * Unify format-rows and format-export middlewares
      
      * Sneaky endpoint!
      
      * In xlsx, always parse temporal strings so that viz-settings formatting is applied
      
      * Snuck in an incomplete change by accident. removed it.
      
      * Can now specify format/no format on subscriptions
      
      * Fix and move migration
      
      * default format rows to true in attachments
      
      * Ok, I think that should actually work for subscriptions.
      
      * Change endpoints to use format_rows instead of confusing format_export
      
      * format_rows everywhere
      
      * Fix more test failures
      
      * redef'd function had wrong signature
      
      * Make format export optional (FE part) (#40643)
      
      * Refactor download URL builder code
      
      Need to handle query `params` and request `body` separately
      
      * Export `useHover` from `metabase/ui`
      
      * Add unformatted export for dashboard cards
      
      * Add unformatted export for saved questions
      
      * Fix POST body encoding
      
      * Add unformatted export for ad-hoc questions
      
      * Ensure `format_export` is always false for Excel
      
      * Add unformatted export to public questions
      
      * Add unformatted export to embedded questions and dashboards
      
      * Fix behavior for PNG format
      
      * Add tests for `QueryDownloadPopover`
      
      * Fix e2e downloads helper (allow URL query params)
      
      * Rework alt key handling
      
      * Add e2e test
      
      * Switch to `format_rows` instead of `format_export`
      
      * Add unformatted export option to subscriptions
      
      * Fix `isHoldingAltKey` initial state
      
      * Rework e2e test to use Total column
      
      * Fix initial checkbox state for subscriptions
      
      * Use "Alt" in tooltip label for Windows/Linux
      
      * Show the subscriptions toggle only for CSV attachments
      
      ---------
      
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      
      * Address review feedback
      
      ---------
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      347c5ef4
    • Tim Macdonald's avatar
      ParseSQL: select * (#40637) · df1366e1
      Tim Macdonald authored
      * Parse wildcards in native queries
      
      Add query_field.direct_reference
      
      * Do away with old Model refs in Card model test
      
      * Do not show stale cards with a select *
      Unverified
      df1366e1
  16. Mar 27, 2024
  17. Mar 26, 2024
    • Denis Berezin's avatar
      Embedding SDK - integration commit (#40198) · 98f6cd82
      Denis Berezin authored
      * Minimal SDK code
      
      * Fix viz, styles
      
      * Move SDK code to enterprise folder
      
      * Fix files structure
      
      * Clean-up
      
      * Review fixes
      
      * Review fixes
      
      * Review fixes
      
      * Remove elementid
      
      * Reuse some options from main webpack config
      
      * Actualize package.json
      
      * Actualize package.json
      Unverified
      98f6cd82
  18. Mar 25, 2024
  19. Mar 21, 2024
  20. Mar 20, 2024
  21. Mar 15, 2024
  22. Mar 14, 2024
    • Tim Macdonald's avatar
      SQL Lineage: Track field usage, expose stale queries (#39707) · 3093f7c3
      Tim Macdonald authored
      * SQL Lineage: Create the QueryField model
      
      This links Cards (with native queries) to Fields, showing us which
      queries use which Fields.
      
      QueryFields are automatically maintained as part of the Card lifecycle
      
      Cards with stale queries (powered by QueryField info) are exposed via the `card?f=stale` API
      Unverified
      3093f7c3
  23. Mar 07, 2024
  24. Feb 27, 2024
    • Cam Saul's avatar
      Drop report_card.dataset (#38981) · ddfd9f63
      Cam Saul authored
      
      * Drop report_card.dataset [WIP] [ci skip]
      
      * Drop report_card.dataset
      
      * Some test fixes
      
      * More test fixes
      
      * All OSS tests should be fixed now?
      
      * Remove check for :dataset key from snake-hating-map
      
      * Remove NOCOMMIT stuff
      
      * Remove unused namespaces
      
      * PR feedback
      
      * Migrate dataset attribute in autocomplete suggestions (#39054)
      
      * FE - Migrate `dataset: true` to enum value in Bookmarks (#39056)
      
      * Fix Card["type"] - Bookmark["card_type"] mapping and add an extra assertion
      
      * Fix card-type check out of raw query
      
      * Fix the test
      
      * Fix tests after merge
      
      * Log body when unexpected response code
      
      * Get logging in CI
      
      * Relax is_upload schema for latest mariadb
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Co-authored-by: default avatarCase Nelson <case@metabase.com>
      Co-authored-by: default avatarAlexander Polyankin <alexander.polyankin@metabase.com>
      Unverified
      ddfd9f63
  25. Feb 22, 2024
  26. Feb 09, 2024
    • Oisin Coveney's avatar
      Add snowplow events for embedding setup flow (#37617) · d43863a2
      Oisin Coveney authored
      * Add snowplow events for embedding setup flow
      
      * Fix dashboard model tests
      
      * Fix dashboard tests
      
      * Fix card tests
      
      * Fix dashboard API tests
      
      * Fix type error
      
      * Implement analytics 2/7
      
      1. public_link_copied
      2. public_link_removed
      
      * Fix snowplow schema enum
      
      Removing null as we don't seem to put `null` in `enum`
      
      * Complete the embed_flow snowplow schema
      
      * Modify `initial_published_at` to not be overridden
      
      * Implement analytics 4/7
      
      1. public_link_copied
      2. public_link_removed
      3. public_embed_code_copied
      4. static_embed_published
      5. static_embed_unpublished
      
      * Prevent accidental ESLint log in Cypress
      
      * Differentiate `EmbeddingParametersSettings` from `EmbeddingParametersValues`
      
      We were mixing the type before, as the former one are the type of the
      setting values, not the actual values for the parameters.
      
      * Fix dashboard and card types
      
      * Fix `params` count for `static_embed_published` event
      
      * fixup! Prevent accidental ESLint log in Cypress
      
      * Fix ESlint from the result of upgrading ESLint package
      
      * Fix Snowplow schema enum to include null
      
      * Fully implement `static_embed_code_copied`
      
      * Finish embed_flow snowplow :tada:
      
      
      
      * Fix unit tests because markup change
      
      * Fix E2E tests
      
      * Fix E2E CI failure
      
      Apparently using `.realClick()` on copy button could fail locally,
      but pass on CI and vice-versa. I couldn't replicate this all the time.
      
      I'm not sure why it would fail locally.
      
      * Fix copy to clipboard not working on CI
      
      * Improve test readability
      
      * Remove extra test-id
      
      * Fix refactor `*CodeOptionId`
      
      * Restrict Snowplow schema
      
      * Revert unnecessary change
      
      * Apply Cal's suggestions for BE improvements
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      
      * Update src/metabase/util/embed.clj
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      
      * Fix backend linter error, hopefully.
      
      ---------
      
      Co-authored-by: default avatarMahatthana Nomsawadi <mahatthana.n@gmail.com>
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarNicolò Pretto <info@npretto.com>
      Unverified
      d43863a2
    • Noah Moss's avatar
      Default enable-public-sharing to false for existing instances, and true for new ones (#38609) · 48119c60
      Noah Moss authored
      * Default enable-public-sharing to false for existing instances, and true for new ones
      
      * add rollback
      
      * fix typo
      
      * try to fix e2e test
      
      * invert conditionals
      
      * use derivedSettings instead
      Unverified
      48119c60
    • Noah Moss's avatar
      v2 audit views and migrations (#38531) · 5e8286c9
      Noah Moss authored
      
      * new audit views and migrations
      
      * fix tests
      
      * rename external users group to anonymous, handle api key users, and add query definition to query_execution table
      
      * fix mysql user email field
      
      * update yamls for 49
      
      ---------
      
      Co-authored-by: default avatarLuiz Arakaki <luiz.arakaki@metabase.com>
      Unverified
      5e8286c9
  27. Feb 05, 2024
  28. Feb 01, 2024
    • adam-james's avatar
      Fixed width dashboard migration (#38247) · ffd18732
      adam-james authored
      
      * Migration adding 'width' to Dashboards
      
      3 migrations:
       - 1st adding the width column with default value of 'fixed'
       - 2nd updating all existing dashboards to have width 'full', which corresponds to what the current behaviour is (will
       be the 'old' behaviour after the fixed-width project lands).
         - The rolloback here is necessary but we don't care what happens as the column will be dropped immediately in the
         next rollback anyway
       - 3rd sets the notNullableConstraint. DefaultNull is 'full' here, just in case there's an existing dashboard whose
       width value is not yet set from the 1st migration. Don't know how that could happen, but its here in case
      
      * Dashboard PUT api endpoint accepts width changes and updates appdb
      
      update-dashboard function now is aware of the :width key so those changes can end up in the transaction.
      
      Also added a width test that asserts that the value's default is "fixed", it can be changed, eg. to "full", but cannot
      be changed to other values.
      
      * Add width to revision tests
      
      * Fix dashboard revision tests.
      
      :width key is now needed in some revision tests. As well we need a string communicating that the :width setting has
      changed from 'full' to 'fixed' or vice-versa.
      
      * Fix comments/remarks in migration to be accurate
      
      * Attempt to fix default not working mysql/mariadb
      
      * Set default in dashboard model
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      
      * Revert default :width 'fixed' value.
      
      * Explicitly add default value 'fixed' for MySQL/MariaDB
      
      ---------
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Unverified
      ffd18732
Loading