This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 09, 2024
-
-
Ngoc Khuat authored
-
Elton Okawa authored
-
Romeo Van Snick authored
* Move focus to separate helper * Use focus method to do initial focus * Use focus method for other _editor.focus calls * Move focus to componentDidMount * Cancel focus timeout on unmount * Add delay to broken test * Switch to requestAnimationFrame * Remove wait in test
-
- Jul 08, 2024
-
-
Noah Moss authored
Allow unrestricted data perms to override block even if another table has legacy no-self-service (#45118)
-
Aleksandr Lesnenko authored
-
Aleksandr Lesnenko authored
* fix combined cards crash when some cards have invalid viz settings * fix mock column was not metric * ensure combined scalar column has proper type to handle the case when the card returns empty results
-
metamben authored
Fixes #39789.
-
Raphael Krut-Landau authored
This PR also specifies the 'filled' variant for the question duplication modal, since the previous default 'filled' variant for submit button was added to make that specific button filled.
-
bryan authored
* update e2e test for command pallete to use a valid setting * remove the setting from the ui, make it always true, unless set false from env * remove enable-nested-queries from admin section on fe - fix unused oldValue -> _oldValue * tests aren't allowed to change enable-nested-queries * fix test + disallow setting nested queries from code * we cannot set enable-nested-queries - set the env var instead * add checks for the enable-nested-queries setting * make resolve-source-cards work with enable-nested-queries setting * fix recents uri interception * return enable_nested_queries setting to client * adjust fetchmock url matcher --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
John Swanson authored
* Nicer error messages for linting migrations In general, just throw exceptions instead of using clojure spec here. You'll only get one error per run, but that seems fine. I did keep some specs around, but run them slightly differently. Rather than validating the whole collection of changeSets at once with `s/+`, just `doseq` through the changeSets and validate each one separately. That way, the value that's presented as erroneous is much smaller (a single changeSet) and it's easier to see what went wrong. * Update bin/lint-migrations-file/test/lint_migrations_file_test.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Update bin/lint-migrations-file/src/lint_migrations_file.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Require preConditions for certain liquibase change types to encourage idempotence (#44578) Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * remove `!`s from non-side-effecty fns * add preConditions to a few v51 migrations --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Jeff Bruemmer authored
-
Noah Moss authored
-
Cam Saul authored
* Split unrelated changes into separate PR * Fix test since user perms set reset fix split into other PR * Fix syntax error * Test fixes
* Test fix??? * Test fix -
Noah Moss authored
-
Nemanja Glumac authored
* Use Mantine Modal for QB Newb disclaimer * Add repro for #44754 * Use theme spacing units * Tweak the design slightly * Fix E2E test
-
Nemanja Glumac authored
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
lbrdnk authored
* Move collect-source-tables to util * Add table prefetching * Add test comparing call counts of select * Update comment * Add exception handling * Add nil handling * Handle possibye empty table-ids * Update exception handling and test case * Update src/metabase/models/card.clj Co-authored-by:
Braden Shepherdson <braden@metabase.com> --------- Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
Nick Fitzpatrick authored
* use useClickOutside, add repro test * adjusting aria label
-
Tim Macdonald authored
(Cleans up [#45137])
-
Nemanja Glumac authored
* Do not colide "no results" with "running the query" Fixes #41464 * Add E2E reproduction for #41464
-
Mahatthana (Kelvin) Nomsawadi authored
* Document how to reload Metabase embedding SDK components * Improve readme clarity on useEffect block
-
Uladzimir Havenchyk authored
-
Oisin Coveney authored
-
Uladzimir Havenchyk authored
-
- Jul 05, 2024
-
-
Cal Herries authored
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
* lint: add stylelint support for emotion components * drop comment * fix pattern order * Use one version of typescript * use :focus not :outline * Use the logical CSS property "inset-inline-start:" (not "inline-start:" which doesn't exist) as replacement for the physical css property "left:" * Use mb-color-focus for focus color * Drop dead code --------- Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
Case Nelson authored
* fix: limit xrays on agg models to source fields Fixes #43793 1. `table-like?` was checking aggregations but not breakouts. This meant that legacy metric definitions would try to apply to the second stage which is generally illegal and would cause things like implicit joins to come in where they make no sense. 2. Trying to bin a `count` metric-like model would give a bin span of 0.0 which would blow up those questions. 3. Trying to self reference breakout fields, in the precense of a question's aggregation meant that most fields would not be exposed to the next stage and should be ignored. (similar to 1.) * Fix tests
-
Cal Herries authored
-
Cal Herries authored
-
Anton Kulyk authored
* Show alert sending time in alert form * F
-
Alexander Polyankin authored
-
Alexander Solovyov authored
-
Romeo Van Snick authored
* Add csv-stringify package * Split values at comma WIP: Parse values using json * Add label to ParameterValue and add ParameterValue to value config * Use custom label in FieldValuesWidget * Allow passing displayValue from outside of RemappedValue * Allow passing displayValue in ParameterFieldWidgetValue * Get custom value label in FormatterParameterValue * Allow rendering custom displayValue in FieldValuesWidget * Add custom ParameterValue types * Fix ParameterValuePicker type * Fix jest import for csv-stringify * Add missing RTKQ exports for paramters * Use direct implementation of useGetParameterValues * Fix ValueSourceModal tests * Add tests for value parsing and stringifying * Use custom label in list too * Render the custom label in a parameter value * Setup parameter mocks in embed test * Add info about splitting values with comma * Add model hint when user is using labels * Add test for cusom labels on dashboards * Handle label-value pairs in test * Test custom labels in parameter search input * Use the label to parse the value for text inputs * Fix comma's to commas Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Use strong instead of styling link * Use getInput instead of ignoring eslint rule * Use arrow function * Add newlines between tests * Use uppercase for test value * Name value * Use getLabel and getValue helpers to avoid indexing confusion * Pull out confusing condition * Move out getLabel helper * Be more explicit about non-existent config values Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * Move setupParameterValuesEndpoints to setup * Add loading state * Do not use alert to implement info box * Fix formatting * Remove undefined from getValue signature * Use getLearnUrl * Remove dependency on column * Make custom field labels work in the absence of fields * Support custom values for non-field parameters * Add test for native question parameters * Add newline in test * Add test case for when show-metabase-links is false * Just fall back to rendering value when fetching label, or in case it failed * Add test for loading state of FormattedParameterValue * Do not fetch custom label for FormattedParameterValue * Add table with ip addresses * Add test for IPAddress filter with custom labels * Add test for custom labels on type/Quantity fields * Remove getInput helper in test * Remove unused hasCustomLabel value * Split up into common and premium tests * Make fieldValues a map for performance --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
- Jul 04, 2024
-
-
Elton Okawa authored
-
Nemanja Glumac authored
-
Case Nelson authored
* fix: param-fields when native model is aggregated Fixes #42829 The param-field lookup required result_metadata to match filterable-columns in order to find parameter targets. This adds a fallback where if the param field is missing from result_metadata, then we look at filterable-columns. * Unskip test
-
adam-james authored
Per discussion in Slack, I made a mistake with the migration IDs as I wanted to backport to 50 but used 51 IDs. This PR uses 50 IDs and places the migrations in the correct place. Not sure if it's mergable in this state because Stats has run with the PR containing the incorrect migration IDs.
-