This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 21, 2024
-
-
Anton Kulyk authored
* Auto open the comparison picker * Preselect a single column for "anotherColumn" comparisons * Flip value and label inputs in `StaticNumberForm` * Respect static value's label case * Merge `getInitialColumn` and `getInitialLabel`
-
Jeff Bruemmer authored
-
Jerry Huang authored
* creator sentiment cleanup * change setting to be survey-enabled * fix test * change send-creator-sentiment-emails
-
Raphael Krut-Landau authored
-
Jerry Huang authored
* add if statement for jwt saml * add tests * add tests * fix tests
-
Noah Moss authored
-
adam-james authored
* Do not fetch param_values on Dashboard Load Fixes: #38826 This change removes the *-or-create* behaviour of `field-ids->param-field-values`. This means that on Dashboard Load, if the param values already exist, they'll be grabbed. But, if they don't, we won't try to fetch or create them. This is WIP because it seems to contradict changes related to fixing #30218 * Comment out the other test added for #30218 * Remove the tests from 30218 These tests are asserting that param_values are created on dashboard load when the Field Values don't exist. This is the behaviour we want to revert, so the tests are asserting something we don't want anymore. * Improved test string wording * Update src/metabase/models/params.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Alexander Polyankin authored
-
Anton Kulyk authored
-
Nemanja Glumac authored
-
Oleg Gromov authored
Change selects and add TextInputBlurChange Extract controls Update required parameter toggle Fix e2e toggleRequired helper Migrate ValuesSourceSettings to Mantine Radio Fix all tests Address review feedback Reorganize TagEditorParam components Add TextInputBlurChange component test
-
- Feb 20, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Renaming files for consistency * Combine both container and view component * Add the new selector + improve types * Force user to refresh to see the colors change. * Revert "Add the new selector + improve types" This reverts commit 1587411da685857ee586b3096a58148f6a0ce36c. * Type setting selectors to support enterprise setting keys * Copy changes * Remove unused files * Remove default exports/imports * Add a modal telling users to refresh the page after changing colors * Revert "Add a modal telling users to refresh the page after changing colors" This reverts commit ac8772d01f18c1e5ba80a92d79f18843ac8a50cf. * Makes it obvious to users they need to refresh browser After changing colors, we want to make sure the behavior of colors is consistent across the board. Previously this wasn't the case, some elements will immediately change colors, while some don't. This created confusion. The new behavior is to NOT change any color at all after changing the application colors and let users refresh their browsers themselves. * Update copy according to a discussion * Fix e2e from copy change * Make assertion explicit * Fix the last E2E failure
-
Ryan Laurie authored
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
-
Case Nelson authored
* Wrap literals around expression refs Fixes #27185 Expression refs need to be handled like field refs as far as type hints in opts are concerned. Otherwise we don't pass the correct parameter types to the drivers. * Address pr feedback
-
Jesse Devaney authored
- queryParams: hide_parameters - hiddenParameterSlugs
-
Jerry Huang authored
* Add new email function and send email to creator * remove debug stuff * add tests, address comments * actually add tests * Update src/metabase/email/messages.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * address comments --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Case Nelson authored
* Fixes filters against datetime binned expressions Fixes #33528 Turns out that `mbql/normalize` and `lib/normalize` behaved slightly different and `[:expression "abc" {...}]` refs would drop their opts in the former path. In order to properly query against binned datetimes it's important that expression ref does not lose its type or else the optimizer will not see that `time-interval` needs to convert to a `between` rather than an `=`. * Fix test * Only keep specific keys on expression opts for these expression filters * Don't run checkin dataset on snowflake or athena
-
Uladzimir Havenchyk authored
* Rework findColumnIndexForColumnSetting to MLv2 * Throw an error to find all places without query * Use MLv2 in ChartSettingTable (#38171) * Add a comment why we can't use mlv2 in chart setting table * Use mlv2 findColumnIndexForColumnSetting in ChartSettingTableColumns * Tests completed, so revert throwing * Use mlv2 findColumnIndexForColumnSetting in object detail (#38170) * Use mlv2 findColumnIndexForColumnSetting in object detail * Address review * Use mlv2 findColumnIndexForColumnSetting in Question (#38169) * Use mlv2 findColumnIndexForColumnSetting in Question * Update question tests * Use mlv2 findColumnIndexForColumnSetting in viz settings (#38172) * Use mlv2 findColumnIndexForColumnSetting in Table (#38168) * Cleanup finColumnSettings usage (#38914) * Fix linting
-
Chris Truter authored
-
Kamil Mielnik authored
* Align ESLint & prettier paths in "lint-stage" & "scripts" in package.json * Handle ts files in e2e tests * Manually fix ESLint-reported issues * Format "lint-prettier-pure" script the same way as "prettier" * Run "yarn eslint-fix" * Manually fix remaining issues * Ignore database files in ESLint as they reference a file that is git-ignored but does exist locally * Remove duplicated eslint call
-
Kamil Mielnik authored
* Include e2e directory in prettier scripts * Run "yarn prettier"
-
lbrdnk authored
Swaps with-temporary-setting-values for with-report-timezone-id.
-
Kamil Mielnik authored
* Upgrade eslint-plugin-import * Configure import/order rule for consistent, predictable imports * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line" * Ensure imports are in a single block * Move or remove informative comments between import statements * Remove imports-grouping comments * Configure groups - the difference between the default setting is the presence of "internal" group * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies * Move comment to the same line as import * Run "yarn eslint-fix" 5 times - Remaining: 16 problems (16 errors, 0 warnings) * Manually fix imports order in remaining files * Run "yarn prettier" * Fix import * Fix circular dependency * Fix circular dependency * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency) * Re-add accidentally removed code * Fix typing * ESLint
-
Kamil Mielnik authored
* Use fetchMock.flush() to prevent tests from interfering with each other * Revert "Use fetchMock.flush() to prevent tests from interfering with each other" This reverts commit 03f1277cf2bf481ac36db212e15b4f29511a386b. * Add typing for requests in the redux store * Fix QueryBuilder flakes by introducing waitForLoadingRequests * Simplify interface * Add mocks for requests in redux store, update types * Simplify code * Increase timeout
-
- Feb 19, 2024
-
-
Jeff Bruemmer authored
-
Sloan Sparger authored
-
Jeff Bruemmer authored
-
Ryan Laurie authored
-
Alexander Polyankin authored
* Remove legacy query from parameter targets * Fix for native queries * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getPivotColumnSplit to MLv2 * Fix * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * fix * Another attempt * Another attempt * Another attempt * Another attempt * Another attempt
-
Alexander Polyankin authored
* Migrate getPivotColumnSplit to Mlv2 * Migrate getPivotColumnSplit to Mlv2 * Migrate getPivotColumnSplit to MLv2 * Migrate getPivotColumnSplit to MLv2 * Migrate getPivotColumnSplit to MLv2 * Remove MLv1 breakouts * Remove expressions * Remove expressions * Remove expressions * Remove expressions * Remove expressions * Remove expressions * Fix * Fix tests * Fix tests
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Nicolò Pretto authored
* add getIsEECode selector * isEEBuild function * Revert "add getIsEECode selector" This reverts commit 3fc3fa79a24b73cfc5ba7c8c0be060c5211dc698. * remove isEnterprise * rename plugin to be more explicit
-
Mahatthana (Kelvin) Nomsawadi authored
* Introduce tabs to admin settings * Change route when changing tabs * Reorder whitelabel settings according to the new design * Modify ImageUpload to support value from the setting * Update colors settings copy and style * Update copy in appearance/branding page * Update copy in appearance/conceal-metabase page * Add toggle grouping description * disconnect application colors from chart colors * Update whitelabel/branding copy * Update whitelabel/conceal-metabase toggles * Deprecate the old admin text input widget * Extend the test * Introduce SettingtextInput which uses metabase/ui component * Update Admin Select widget * Convert font Select to metabase/ui * Fix style conflict causing Select dropdown to overflow the page * Prevent repression on other settings page than Appearance * Move landing page (EE) to general settings page * Fix FE type * Fix unit tests * Fix E2E tests * Fix type * Removed commented out code * Fix E2E from master change
-
Anton Kulyk authored
* Implement `dashboard_width_toggled` event * Implement `dashboard_section_added ` event * Add a new snowplow schema file (1-1-4) * Use 1-1-4 schema file
-
Alexander Polyankin authored
-
Oleg Gromov authored
-