* thinking

* killing it

* lab image bundle for lines proper

* linter shutting up

* get rid of viz-settings binding at all

* Remove accidentally re-added categorical-area

* Merged master, and temporarily comment out some tests

* Simplify conditional for detecting chart type

* Remove a few old fns/symbols

* Clean up the detect-chart a bit

* Remove sparkline. It's an old concept that's not used

We can acheive similar results with :line directly. If we care about a trend, we can use a :smartscalar.

* Fix up tests that now also use combo charts

* Missed a key change for area test

* Get rid of deprecated sparkline stuff

* Remove commented out sparkline tests

* Delete this function. I was using it in the REPL, it's not needed

Co-authored-by: Adam James <adam.vermeer2@gmail.com>

* Move Variable in its own package

* TemplateTagVariable package created

* memoizeClass return type

* Renaming Query to QueryInner to follow standards

* Constants added to TemplateTagVariable

* Fixed Query typing

* Misc

Cards can depend on other Cards as their `:source-table`, but the code
to extract `serdes-dependencies` from the MBQL query did not
capture that case.

Many entities have `creator_id` and similar fields. `User`s are not
serialized. Foreign keys to users are serialized as email addresses.

During deserialization in a different instance (eg. a local dev instance
importing a dump from a prod instance) many such users may not exist.
This change creates new `User` entities on the fly with empty names,
generated passwords, and the email set.

* Allow overwriting `SidebarLink` name styles

* Add `DataAppPageSidebarLink` component

* Render data app sidebar page tree

* Hide pages marked as hidden

* Add `getParentDataAppPageId` helper

* Highlight parent page when hidden page is selected

* Extract `getSelectedItems` and add tests

* Fix messed up ordering bug

* Remove `DataAppNewButton`

* Add new item menu

* Fix missing click handler

* Use "pencil" icon for new page

* Fix action buttons look

* Extract `DataAppDataPicker` component

* Rename `scaffold` action

* Add `scaffoldNewPages` action

* Add `ScaffoldDataAppPagesModal` component

* Add `DataAppNavItem` type

* Allow building page URLs out of nav items

* Implement "Add data" flow

* Add implicit action click behavior types

* Add `isImplicitActionButton` helper

* Extract `ActionButtonView` component

* Separate implicit and default action buttons

* Use `DashboardOrderedCard` instead of `DashCard`

* Use `Value` type for PK argument

* Fix type error

* Extract `ImplicitActionClickBehavior` type

* Add `ImplicitInsertModal`

* Add `DashCardDataMap` type

* Add dashboard selectors for implicit update/delete

* Add `ImplicitUpdateModal`

* Add `ImplicitDeleteModal`

* Validate implicit actions in `clickBehaviorIsValid`

* Reload page on action instead of a single dash card

* Tweak successful insert toast message

* Fix eslint error

The YAML file names have an optional `:label` portion that becomes the
latter part of the filename. Reconstructed paths (eg. from
`serdes-dependencies`) don't have those labels.

This change makes the YAML ingestion code able to find a file with a
human-readable label even if the request didn't include it.
No ambiguity results because the file names are always based on the
unique serdes `:id`, usually an `entity_id`.

* allow user-defined select options

* Update frontend/src/metabase/writeback/components/ActionCreator/FormCreator/utils.ts

* update input type when changing field type

* handle unset field type

- Limit the scanning of directories and files to those named after
  models; don't try to ingest `.git`, `README.md`, etc.
- `table_id` and `collection_id` are optional on Cards
- Deserialization was not resolving some deeply nested `:field`s inside MBQL
  queries.

Pass `--collections 123,456,789` to dump only these collections and
their transitive `serdes-descendants`.

* Exclude implicit joins when virtual card table has an explicit join

* Add unit tests

* Refactor debugger output

* Handle small number format

* Hide bar chart values on small bars

This matches the app viz behavior

* [Apps] Add scaffolded pages to existing apps

Reuse app scaffolding in order to add to existing apps. This will not
check that the tables you choose have not been previously added to the app.

Also update scaffolding:
- Add back to list button
- Update list question to order by newest row on top.
- Use linkType: "page" instead of linkType: "dashboard"

* Fix H2 test, no need to add app-id to name

* Remove unused require

* Addressing review comments - suggested test uncovered an ordering bug

* Put priority back to ascending

* Implement navigation between data app pages (#25366)

* Add `DataAppPagePicker`

* Rename `QuestionDashboardPicker`

* Add page to `EntityCustomDestinationClickBehavior`

* Fix comment

* Use ellipsis character

* Fix custom destination type

* Add "page" custom destination to pickers

* Pass router props to dashboard click actions

* Remove not used function arguments

* Implement "page" custom destination click behavior

* Fix "page" click behavior isn't treated as valid

* Reorganize `LinkedEntityPicker`

* Fix drills from the homepage

Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>

* trim the init option in h2 connection string

- it can be lower or mixed-case, so `(dissoc-by str/lower-case ...)`
  will lowercase the map's keys and the dissoc-keys, and dissoc them when
  they are equal.

* refactor

* enforce import order

* reorder all imports

* more import updates

When creating a new question, you can choose an existing saved question
as your starting point. However, we want to exclude is_write cards from
that list.

* derive parameter types from form settings on save

* update template tag types with parameter types

* improve tests

* pass action visualization settings to actionParametersInputForm

* Update FieldSchema to store virtual card table fields using both table_id and field id

* Update the metadata selector to look use field's uniqueId property

* Add tableId arg to Metadata.prototype.field method

* Normalize fields in sample_database_fixture

* Fix incorrect e2e test

* Make the second arg of field optional

* Pull out small fn

* Refactoring + clean up + mocks & tests

* Update metadata.field(...) usage in a few places

* Revert FieldDimension change

* Move complex FieldDimension `field` logic to the instantiation of "virtual" fields by the associated query's `table` method (#25109)

* Add merge method to Field

* add new virtual table utils + tests

* Use new utils in implementation of Structured/NativeQuery table methods + remove unneeded Dimension logic

* let all Questions return dependentMetadata

* Fix types related to query.table() potentially returning null

* Fix updateQuestion tests

* Remove unused Dimension imports

* Fix issue resolving rootTable on queries based on virtual tables

* Fallback to the nested card table stored in the Metadata instance

* Make the nested card Table the main driver in returning fields for nested cards + other misc fixes

* more tweaks related to cloned Tables, source queries

* Don't clobber metadata if something is already there (like a method named 'metadata')

* Fix for nested native query

* Don't use real table for source query

* Update table code to use the actual nested card table fields instead of doing merge logic

* Skip an e2e test

* Workaround for getting Dimensions from joins

* Update arg name

* Try removing the Table fetch from Question's dependentMetadata method

* Don't rerun query when converting question to model

* Fix for source query not showing 'previous results'

* Fix unit tests

* Update models e2e tests not to wait on query

* Unskip repro for #23449

* make sure a join's joinedQuery is not a dataset/model

* use createQuestion in e2e test

* don't use Question redux dispatch method for updating

* split test cases

* Add comment

* Move `DataAppNavbar` to its own directory

* Move `MainNavbarContainer` to its own directory

* Move `BookmarksList` to `MainNavbarContainer`

* Extract `getSelectedItems`

* Extract `DataAppActionPanel`