This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 31, 2024
-
-
Emmad Usmani authored
Part of https://github.com/metabase/metabase/issues/38208 ### Description Adds e2e tests for dashboard card and tab duplication ### Checklist - [x] Tests have been added/updated to cover changes in this PR
-
Emmad Usmani authored
Closes https://github.com/metabase/metabase/issues/38208 ### Description Adds a item to the dashboard tab menu to duplicate the tab. ### How to verify 1. Open a dashboard you can edit 2. Go to edit more, click the tab menu for a tab 3. Click duplicate, tab should be duplicated ### Demo https://www.loom.com/share/d73aad469074440992618ee179518d39 ### Checklist ~~- [ ] Tests have been added/updated to cover changes in this PR~~ e2e tests are added in the next PR in the stack
-
Emmad Usmani authored
Part of https://github.com/metabase/metabase/issues/38208 ### Description Adds another button to the dash card action panel that duplicates that dashcard. ### How to verify Describe the steps to verify that the changes are working as expected. 1. Open a dashboard that you can edit 2. Mouseover a dashcard 3. Click the duplicate icon ### Demo https://www.loom.com/share/d73aad469074440992618ee179518d39 ### Checklist ~~- [ ] Tests have been added/updated to cover changes in this PR~~ e2e tests are added further down the stack
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
* Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader
-
Aleksandr Lesnenko authored
* format native queries * optional clauses, mlv2, specs * remove unnecessary webpack chunk name directive * disable formatting for mssql and sqlite, address review comments
-
- Jan 30, 2024
-
-
Ryan Laurie authored
* use mantine popover in entityMenu * control popover state * more control * fix unit tests to work with snazzy new popover * boringer animation
-
Oleg Gromov authored
Native query editor: Add an explanatory tooltip for the save button when required template tags miss defaults (#38232) * Add an explanatory tooltip for the save button when required template tags miss defaults * Update e2e tests
-
Nemanja Glumac authored
This is purely semantic change. Please see this comment https://github.com/metabase/metabase/pull/37977#discussion_r1467360379
-
Nemanja Glumac authored
* Export `can-run` MLv2 function * Add a TS wrapper `canRun` * Migrate `canRun()` to MLv2 only for structured queries
-
metamben authored
* Support converting aggregation references to legacy references * Pass query and stageIndex to legacyQuery --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Jan 29, 2024
-
-
Anton Kulyk authored
* Hide filters not mapped to current tab's dashcards * Show all filters in edit mode * Fix `text-dashcards.cy.spec.js` * Remove no longer relevant test `dashboard-filters-source.cy.spec.js` * Fix repro test (26230) * Update repro test (16663) * Fix `dashboard-filters-number.cy.spec.js` * Fix repro test (32444) * Fix `click-behavior.cy.spec.js` * Add basic e2e test * Fix e2e tests * Test filter values * Use `undefined` for `hiddenParameterSlugs` * Use `addOrUpdateDashboardCard` over `cy.request` * Remove redundant spread * Remove redundant dashboard name
-
Anton Kulyk authored
* Convert `TableSimple` to TypeScript * Convert `Table` viz to TypeScript * Update frontend/src/metabase/visualizations/components/TableSimple/TableCell.tsx Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Update frontend/src/metabase/visualizations/components/TableSimple/TableSimple.tsx Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Anton Kulyk authored
* Remove `wrapped` arg from `ExplicitSize` * Remove `AutoExpanding` HOC * Convert `ExplicitSize` to TypeScript * Fix `ExplicitSize` mock * Remove redundant type * Revert "Remove `wrapped` arg from `ExplicitSize`" This reverts commit 014bc4c61ae21ff67ae2157c40297f33fd39d95d. * Fix type
-
metamben authored
Fixes #36974. See the Slack [discussion](https://metaboat.slack.com/archives/C04CYTEL9N2/p1706193649444639) for details.
-
- Jan 26, 2024
-
-
Nemanja Glumac authored
* Display chart caption even where there is no card title * Add E2E reproduction for #36788
-
Nemanja Glumac authored
* Migrate `isStructured` method references to MLv2 * Fix broken audit pages Just as with #38123, this is another place where MLv2 invocation broke because it didn't guard against the internal queries. * Remove `isStructured()` method from the `Question` prototype
-
Romeo Van Snick authored
* Reproduction: Run selected text does not use parameter values correctly * Use question instead of card when overriding * Switch to overrideWithQuestion in RELOAD_CARD * Rename run to dataset in e2e test * Use cypress builtins instead of custom selectors * Remove async from e2e test * Avoid assigning editor to variable * Type closing }} on editor * Set type delay to 0 * Add explainer about why the reproduction differs from the issue * Add limit to test case * Test actual vizualisation results instead of implementation detauls of dataset * Clarify that the space is not needed * Simplify cypress check
-
Raphael Krut-Landau authored
* Make embedding-full-app.cy.spec.js and associated components more semantic * Make signin.cy.spec.js and associated components more semantic * Fix comment * minor tweak * Remove aria-label=breadcrumbs * Fix variable name * Fix e2e tests * Remove cy.heading * Restore test name
-
Mahatthana (Kelvin) Nomsawadi authored
* [WIP] ESLint for detecting the use of Metabase links * Add a rule to detect the use of Metabase links * Add tests to the new eslint lint rule that detect Metabase links * Fix all places where errors are caused by the new ESLint rule * Review: Disable rule for admin folder * Review: Remove rule disable reason from files under admin folder
-
Uladzimir Havenchyk authored
-
Oleg Gromov authored
-
Ryan Laurie authored
* remove deprecated event tracking * fix e2e tests * fix types
-
Nemanja Glumac authored
Fixes #38149
-
- Jan 25, 2024
-
-
Nick Fitzpatrick authored
-
Oleg Gromov authored
* Mark parameter on the dashboard with * * Require default value for a required template tag * Add reset to native queries * Remove unused WidgetStatusIcon * Add reset button for native queries only * Rewrite FieldSet in TS to fix typing * Update e2e helper to click "Always require a value" insted of previously "Required?" * Switch to MLv2 * Add e2e tests for required filters * Update e2e tests * Update another test * Fix required untoggling bug * Fix parenthesis in t * Reset to default on input blur * Show correct icons & update behavior for reqiured parameters in native queries * Don't reset default value when toggling required * Update the widgetstatusicon types * Set parameter value when toggling default * Update TagEditorParam unit tests * Add native query tests for number, string and date * Fix re-setting to default from empty state for field widgets * Add e2e tags for field tags
-
Sloan Sparger authored
-
Sloan Sparger authored
-
Raphael Krut-Landau authored
-
Kyle Doherty authored
-
Kyle Doherty authored
-
Nick Fitzpatrick authored
* Load tables when dbid is present in data permissions pages, e2e test * run prettier * cleanup. Fixing #37811 * remove undeeded awaits
-
Nemanja Glumac authored
* Revert "Remove internal query check (#37587)" This reverts commit 16aa9974. * Add a comment Explains why the guard against `internal` queries is needed here.
-
Oleg Gromov authored
* Convert Sidebar to TSX * Move remove button to the sidebar footer * Change styles to styled components * Fix tests
-
Nicolò Pretto authored
* console log snowplow events * wraps it in a env var to not spam the console * remove try catch now that's under a flag * moved reading the env to env.js
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix dashboard parameter values in embed preview not working * Fix iframe rerendering unnecessarily * Add E2E reproduction test * Prevent iframe from rerendering unnecessarily
-
Kamil Mielnik authored
Split QueryBuilder.unit.spec.tsx into QueryBuilder.beforeunload-events.unit.spec.tsx, QueryBuilder.unsaved-changes-warning.unit.spec.tsx & test-utils.tsx (#38032)
-
- Jan 24, 2024
-
-
Raphael Krut-Landau authored
* Port BrowseHeader to tsx * Use generic type with useSearchListQuery * Allow the query to be specified in setupDatabasesEndpoints * Port EmptyState to tsx * Correct type in FilterableTree * Remove unneeded props
-
Oleg Gromov authored
-
Denis Berezin authored
* Migrate EmbedModalContent to TS * Add basic UI changes to Embed modal * More styling * Add more styling * Self review fixes * Self review fixes * Fix action button * Fix unit tests * Fix e2e tests * Fix e2e tests * Code review and design fixes * Fix unit test * Add Parameters tab text diff and switch to preview * Add code diff display logic for appearance tab * Self review fixes * Fix e2e tests * Button text hotfix * Move state to component, fix diff * Review fixes, action buttons refactor * Implement new code diff * Fix text highlight, fix unit tests * Code review fixes * Design review fixes * New code diff highlight UX * Remove folding * Change code diff logic, add automatic client code switch * Fix code highlight logic * Add unit tests * Fix some e2e tests * Fix e2e tests * Fix code highlight, parameters diff * Add code highlight on locked parameter value change * Add more tests * Review fixes * Refactor unit tests * Rollback preview tab remove, add utm tags * Fix prettier * Add interactive modal header with hover * Review fixes * Review fixes
-