Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 15, 2024
  2. Aug 14, 2024
  3. Aug 13, 2024
  4. Aug 12, 2024
  5. Aug 09, 2024
  6. Aug 08, 2024
  7. Aug 07, 2024
  8. Aug 06, 2024
  9. Aug 05, 2024
  10. Aug 02, 2024
    • John Swanson's avatar
      Fix coll permissions for audit collection (#46351) · 7e826d72
      John Swanson authored
      * Fix coll permissions for audit collection
      
      We've had a function in `models.collection` for a while that has taken a
      permissions set and returned a set of collection IDs that the user has
      permissions on. I refactored this recently, but didn't notice that it
      was actually doing the permissions checks slightly incorrectly.
      Specifically, because it only looks at the user's permissions and the
      collection IDs and doesn't use `mi/can-read?` or `mi/can-write?`, it's
      completely indifferent to whether a collection is an audit collection or
      not.
      
      This is arguably not a *permissions* issue: the two errors that could
      come about here are:
      
      - someone sees the audit collection even though the audit feature is
      disabled, or
      
      - someone is presented with the audit collection in a context where only
      writable collections should be present - when they try to actually write
      to it, it fails (since then we're doing the real permissions check).
      
      The primary motivation for this fix was to prevent audit dashboards and
      cards from appearing in the list of stale items.
      
      * Fix hardcoded collection ID
      
      We were creating a timeline in a fixed collection ID, that in tests
      happened to be the ID of the Metabase Analytics collection.
      Unverified
      7e826d72
    • lbrdnk's avatar
      Avoid sorting by missing aggregation reference (#46386) · b4b8f6e9
      lbrdnk authored
      * Update values-from-card-query
      
      * Add test
      
      * Update values-from-card-query
      
      * Add missing issue no
      Unverified
      b4b8f6e9
    • Chris Truter's avatar
      Tighten up queue test (#46420) · 5ba895be
      Chris Truter authored
      Unverified
      5ba895be
    • Ngoc Khuat's avatar
  11. Aug 01, 2024
Loading