Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 18, 2024
    • Case Nelson's avatar
      test: add database feature to test identifiers with spaces (#45680) · bcd5a002
      Case Nelson authored
      * tests for drivers with spaces in their identifiers
      
      * Add driver feature
      
      * Fix tests
      
      * Remove ambiguous alias for sqlite
      
      * Try to fix bigquery and sqlite tests not seeing left-join support
      
      * Add explicit support for left-join because of foreign-keys during test hacks
      
      * Handle left-join support weirdness
      
      * Fix test
      bcd5a002
    • Nemanja Glumac's avatar
    • Uladzimir Havenchyk's avatar
      Remove flakiness from e2e repro but move it to jail anyway (#45791) · e8e87857
      Uladzimir Havenchyk authored
      * Remove flakiness from e2e repro
      
      * add to flaky group anyway
      
      * add to flaky group anyway
      
      * fixup! add to flaky group anyway
      e8e87857
    • Kamil Mielnik's avatar
      Fix flaky test (#45794) · 16eb7df0
      Kamil Mielnik authored
      16eb7df0
    • Chris Truter's avatar
    • Anton Kulyk's avatar
      Clean up dashboard URL management (#44639) · f4f71ea7
      Anton Kulyk authored
      * Fix falsy tabSelected/tabRenamed checks
      
      * Update URL management (WIP)
      
      * Fix tests failing because of whitespace changes
      
      * Fix tests failing because of parameter order
      
      * Use one hook for parameters and tab URL management
      
      * Fix tests failing because of parameter order
      
      * Fix test failing because of whitespace changes
      
      * Revert
      
      * Fix DashboardTabs tests
      
      * Fix tests failing because of parameter order
      
      * Fix test
      
      * Fix test failing because of whitespace changes
      
      * Remove unit tests that should be e2e tests now
      
      * Fix tab navigation
      
      * Fix string encoding/decoding
      
      * Revert test changes
      
      * Consistent question search params
      
      * Update DashboardTabs tests
      
      * Fix `SyncedParametersList`
      
      * Fix e2e tests
      
      * Fix nav usage
      
      * Fix types
      
      * Remove `useSyncedQueryString`
      
      * Fix test
      
      * Move slug utils to dashboard utils
      
      * Fix nav
      
      * Revert nav change
      
      * Fix e2e tests
      
      * Fix public/embedded dashboards, handle site url
      
      * Add repro test
      
      * Bring back and fix `PublicOrEmbeddedDashboardPage` tests
      
      * Move `SyncedParametersList` to qb
      f4f71ea7
    • Nemanja Glumac's avatar
      Do not render `ExecutionTime` if there is no `time` to format (#45749) · c0b63285
      Nemanja Glumac authored
      * Do not render if there is no time to format
      
      * Add a unit test
      
      * Render time if 0
      
      * Simplify the logic with explicit check for `undefined`
      c0b63285
    • github-automation-metabase's avatar
    • Kamil Mielnik's avatar
      Fix - App crashes when navigating back during model creation (#45709) · d62bc6ca
      Kamil Mielnik authored
      * Refactor EditoTabs
      - get rid of options prop
      - use named export
      
      * Remove unused data-testid
      
      * Remove redundant id and aria-labelledby
      
      * Remove redundant props spread
      
      * Bring back data-testid in use
      - Thanks VSCode for randomly showing me search results or not...
      
      * Fix navigation issue
      
      * Add a repro for first issue
      
      * Adjust EntityPickerModal root element so that it works with "be.visible" assertion in Cypress
      
      * Add a repro for second issue
      
      * Refactor tests
      - Fix not enough history entries issue
      
      * Change order of tests to start with simpler one
      
      * Fix invalid request issue
      
      * Add more assertions
      
      * Format code
      d62bc6ca
    • Phoomparin Mano's avatar
      feat(sdk): theme option to customize popover's z-index (#45613) · 1e48f962
      Phoomparin Mano authored
      * customize popover z-index
      
      * make popover z-index customizable
      
      * make the popover z-index customizable
      
      * add tests for popover z-index
      
      * also specify z-index for mantine popover
    • Cam Saul's avatar
      Use single connection for test data loading & big test data loading improvements (#45268) · bab905c0
      Cam Saul authored
      * Reuse connection for test data loading & JDBC data loading overhaul
      
      * Revert silly change
      
      * Remove unneeded logic for recording which datasets are loaded or not-yet-loaded
      
      * Ok so I guess we do need the code to detect duplicate dataset loading after all
      
      * B I G  improvements
      
      * Appease Kondo
      
      * Test fixes :wrench:
      
      * More test fixes :wrench:
      
      * Fix dataset-already-loaded?-test
      
      * Fix test
      
      * Fix Presto JDBC and greatly improve test data load speed for it
      
      * Postgres test fix :wrench:
      
      * Fix compilation errors
      
      * MySQL fixes :wrench:
      
      * Fix syntax error
      
      * MySQL fixes :wrench:
      
      * Implement `dataset-already-loaded?` for Athena and cache the set of existing databases
      
      * Fix Redshift
      
      * Fix Presto JDBC
      
      * Vertica test fix :wrench:
      
      * Fix Oracle dataset-already-loaded?
      
      * Test fixes and parallelize some API tests.
      
      * Test fixes :wrench:
      
      * Oracle test fix? :wrench:
      
      * Another test fix :wrench:
      
      * Stop putting random spaces in code bodies this is not JavaScript code
      
      * with-temp-vals-in-db should merge in original value of Database settings
      
      * The most test fixes :wrench:
      
      * 3 or 4 test fixes :wrench:
      
      * Add schemas around stuff to catch errors
      
      * Appease Kondo
      
      * Implement dataset-already-loaded? for vertica
      
      * Implement dataset-already-loaded? for SQLite and Snowflake
      bab905c0
  2. Jul 17, 2024
  3. Jul 16, 2024
Loading