This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 14, 2024
-
-
github-automation-metabase authored
* fix hiding incorrect y-axis on hover * Update Loki Snapshots --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
- Nov 13, 2024
-
-
github-automation-metabase authored
* wip: Alert component for SDKError * use the alert component for the default sdk error component * fix tests * update e2e Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
github-automation-metabase authored
* Fix flaky models metadata test * Improve hack Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Nov 12, 2024
-
-
github-automation-metabase authored
* add filter picker skeleton * add filter picker skeleton * add picker in popover use case * reuse FilterColumnPicker * add question filter logic * remove fixed width from popover * add onClose handler * add e2e test skeleton * contain FilterBar in Box in story * add a test for adding filters * update e2e tests * add filter picker to the docs * inline props and functions * update the props Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
github-automation-metabase authored
* update subscription checkboxes * update spec Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
Add a force parameter to permission graph endpoints to bypass revision number check (#49856) (#49891) Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
* Fix flaky test * Add a comment Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Fix flaky test * Bring back waiting * Decrease flakiness Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Nov 11, 2024
-
-
Nemanja Glumac authored
* Re-introduce "Upload CSV" button for instances with DWH attached (#49545) * Move the upload CSV button to the main nav bar * Remove the old `SidebarOnboardingSection` * Remove obsolete unit tests * Rework E2E tests * Add some spacing around the button * Fix E2E test * Break `MainNavbar` unit test down * Expand unit tests * Update E2E tests * Fix E2E test failure * Move JSDoc where it belongs * Provide context for translators * Simplify the condition * Make "Add database" more prominent (#49678) * Remove dead code from browse models page * Use the grid to control the gap * Implement "Add database" button * Add basic unit tests * Make sure the feature works when there are no databases * Add analytics to the db list * Add "Add database" button to the sidebar * Add E2E Snowplow tests * Add unit tests * Deal with authentication in each beforeEeach separately * Add Snowplow E2E test for a database card * Slightly tweak the title line height
-
github-automation-metabase authored
* Fix flaky tests * Fix flaky tests Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Nov 08, 2024
-
-
github-automation-metabase authored
* Keep Pivoted Option works in Subscriptions Fixes: #49525 Even though the user could toggle 'Keep data pivoted` in the Sharing Sidebar UI, the setting was not being propagated to the backend, so attachments would not be pivoted. * add a cypress test * add viz settings to get the pivot working * fix for linter * remove eslint ignore --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
github-automation-metabase authored
* Ensure that correct error messages show up in the Edit user modal (#48966) * kick ci --------- Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
* Remove @flaky tag * Unskip test and remove @flaky tag * Remove @flaky tag * Remove @flaky tag * Revert "Remove @flaky tag" This reverts commit 08c57add. Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Try to fix flake * See if timeout is necessary * Revert "See if timeout is necessary" This reverts commit 181f3c5e. * Revert change for coordinates filter Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Remove @flaky tag * Make workaround test pass * Disable workaround test * Uncomment and unquarantine the workaround test * Disable normal test for now * Revert "Disable normal test for now" This reverts commit 68fa2175. * Bring back quarantine * Update comment Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Nov 07, 2024
-
-
github-automation-metabase authored
Fix - Values from the returned rows not present in the visualization are interpolable in the URL but don't have values (#49530) (#49654) * Fix #46318 * Add repro for #46318 * Move setup to beforeEach Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Remove @flaky tag * Fix flake * Try typing delay instead * Improve comment * Bring back original solution Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Nov 06, 2024
-
-
github-automation-metabase authored
* Fix :pivot-measures with column names * Fix the test * Update src/metabase/query_processor/pivot.clj * Add a test * Add a test --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com> Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
github-automation-metabase authored
* Remove @flaky tag * Fix flake * Refactor * Use getDashboardCard * Shorten text * Fix flake * Revert previous changes * Revert "Revert previous changes" This reverts commit 16b56f26. * Fix flake Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Fix scroll for EditableDashboard in fullscreen mode * Fix scroll for InteractiveDashboard in fullscreen mode * Display fullscreen control to dashboards by default * Fix issue with public shared questions empty footer Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
github-automation-metabase authored
* refactor + more specific auth errors * fix linting issues * make tests pass, again * make test pass for real? * continues the refactor and hopefully makes tests pass * try to simplify the logic a little bit more * also logs to the console for the edge case of invalid session * remove setLoginStatus * fix typo * fix debug line that should have been commented * remove dead code * remove test for code that doesnt exist * address feedback from PR * update test copy * Update enterprise/frontend/src/embedding-sdk/store/auth.ts * Update enterprise/frontend/src/embedding-sdk/store/auth.ts * update copy for site settings error * ex -> exception * Update enterprise/frontend/src/embedding-sdk/store/auth.ts * Update enterprise/frontend/src/embedding-sdk/store/auth.ts * update tests to use the updated copy + small typos * refactor: use jest spy on to check for console.error * use full error message in test * renamed response to session * mock implementation of console.log * fix(49482): don't create a new store on each MetabaseProvider render (#49492) * fix(49482): don't create a new store on each MetabaseProvider render * remove store prop as it seems to not be used --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 05, 2024
-
-
github-automation-metabase authored
* Use column names instead of field refs for pivot viz settings (#49414) * CI --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
github-automation-metabase authored
* Update saveDashboard helper to wait for the GET /api/dashboard/:id request - update aliases to be unique so that they don't interfere with aliases used in tests * Remove no longer needed intercept + wait Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Fix dirty yarn.lock * Use fix width popover for filter pickers * Add e2e test to reproduce #49321 * Do not rely on implementation width for test Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
github-automation-metabase authored
feat(sdk): ability to enforce the destination collection to save to and hide the collection picker (#49251) (#49479) * add ability to hide the collection picker * add save options * make sure collectionId is fresh * update sdk question form component * make collectionId accept null * apply saveOptions to sdk components * revert to use initialCollectionId as context name * target the correct collection id * add e2e tests * update e2e tests * move into within * update test * remove collectionId from default args * revert e2e of hide columns * make e2e helper more generic * use saveToCollectionId prop to save to a specific collection * update e2e tests * update comment formatting * clean up leftover changes from an earlier version * readme update * indicate that saveToCollectionId is only applicable to static questions * revert QuestionEditor.isSaveEnabled defaults * update comment format * remove unused initialCollectionId prop * experiment: try to fix failing custom-columns e2e --------- Co-authored-by:
Phoomparin Mano <poom@metabase.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
github-automation-metabase authored
* Assume question is dirty when edited from notebook (#49428) * Consider a modified question dirty as well * Add e2e tests for 48829 * Add missing import --------- Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
github-automation-metabase authored
* Fix flaky #16559 repro * Wait for getCollections * Clean up helper * Wait for cardQuery before saving the dashboard Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Nov 04, 2024
-
-
github-automation-metabase authored
* Fix flaky custom column test * Fix flaky custom column test Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Use list picker when searching a single value (#49323) * WIP: use list picker when searching a single value * Add test case for multi vs non-multi search fields * Update loki snapshots * Add special case to test for multiautocomplete filter * Use single select value in test * Add test for using list picker * Explicitly make sure elements are visible * Do not use list selector when search is disabled * Add margin to multi autocomplete dropdown * Update loki snapshots * Update loki snapshots * Update Loki Snapshots --------- Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
github-automation-metabase authored
* Fix flaky test * Fix flaky test Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Nov 01, 2024
-
-
github-automation-metabase authored
This reverts commit fedd1466. Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
- Oct 31, 2024
-
-
github-automation-metabase authored
* Fix flaky #34574 repro * Format code * Add a wait * Decrease flakiness * Fix flake * Update comment Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
github-automation-metabase authored
* Fix flaky 25374-3 test * Fix flaky 25374-4 test * Fix race conditions * Decrease flakiness * Fix wrong param * Bullet-proofing Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Fix #49036 * Add explanatory comments * Improve comment * Improve comment * Update comment * Add repro for #49036 * Exclude custom Shift + Tab handling Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Manually remove bad matches when preparing results for ACE * Do two-phase autocompletion * Allow single-character completions * Add test for flickering autocomplete results * Fix autocomplete tests * Simplify autocomplete helpers * Handle empty results in autocomplete * Fix e2e test Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-