This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 02, 2023
-
-
Bryan Maass authored
insert next-gen permission paths alongside currently active permission paths + classification (#27911) * implement move, which returns v2 paths - TODO: insert these into the db (move v1-path) => [v2 paths] * cleanup + add some schemas * generative tests 4 permission path classification * whitespace lint * detect data, query, and paths for v2 * calling move on v2 paths is a no-op * differentiate between v1 and v2 permissions quickchecking for move, classify-path, and classify-data-path * fix tests + add idempotency test * add tests for classification of permission paths - rename move to ->v2-path - move some fxns around - ascii art in test * making the legos line up - need to insert both v1 and v2 versions of paths (of course) - valid-path? has to allow v2 paths to be inserted * replace mu/with-api-error-message * linter + code quality fixes * privatize rx->kind * remove some changes that should be 4 anotherbranch * revert ns * delete v2 permissions in - they aren't handled by the perm graph parser, so they don't get propagated into "old graph", so the diff between old and new indicates that they need to be rewritten. * only delete v2 paths for the current group_id - reorder declarations in models.permissions * remove extra line break * Update src/metabase/models/permissions.clj fix typo Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Alexander Polyankin authored
-
Mark Bastian authored
Added bans for print and friends. Fixed issues in kondo config where a macroexpansion put in a print by replacing with (constantly nil) as a no-op.
-
Mahatthana (Kelvin) Nomsawadi authored
* `nock` behave differently between v14 and v16+ * Remove xmlhttprequest * [ci skip] Add a comment warning people to not upgrade CI node version As it might break the unit tests.
-
Aleksandr Lesnenko authored
* polish-tooltips * review
-
dpsutton authored
Originally made all "drivers" tests skip the :mb/once test selected test namespaces. But we use the drivers matrix to test the different app-db types (mysql, postgres). So this moves the `:exclude-tags [:mb/once]` selector off of the drivers job and into particular driver jobs. ```clojure user=> (letfn [(uses-exclude? [[job-name job]] (let [steps (:steps job)] (reduce (fn [uses? step] (if-let [with (:with step)] (if (= ":exclude-tags '[:mb/once]'" (:test-args with)) (reduced true) uses?) uses?)) false steps)))] (-> (group-by uses-exclude? (:jobs (yaml/from-file ".github/workflows/drivers.yml"))) (update-vals (fn [jobs] (map key jobs))))) {true (:be-tests-athena-ee :be-tests-bigquery-cloud-sdk-ee :be-tests-druid-ee :be-tests-googleanalytics-ee :be-tests-mongo-4-2-ee :be-tests-mongo-4-2-ssl-ee :be-tests-mongo-5-0-ee :be-tests-mongo-5-0-ssl-ee :be-tests-mongo-latest-ee :be-tests-oracle-18-4-ee :be-tests-oracle-21-3-ee :be-tests-presto-186-ee :be-tests-presto-jdbc-ee :be-tests-redshift-ee :be-tests-snowflake-ee :be-tests-sparksql-ee :be-tests-sqlite-ee :be-tests-sqlserver-ee :be-tests-vertica-ee), false (:be-tests-google-related-classpath-ee ;; includes an :only selector :be-tests-mariadb-10-2-ee :be-tests-mariadb-latest-ee :be-tests-mysql-5-7-ee :be-tests-mysql-latest-ee :be-tests-postgres-ee :be-tests-postgres-latest-ee)} ``` These maria/mysql/postgres tests all specify `MB_DB_TYPE` so we omit the `exclude-tags` selector to run all tests. The only strange one here is the `:be-tests-google-related-classpath-ee` job which includes an :only selector: ```yaml steps: - uses: actions/checkout@v3 - name: Test Google Related Classpath drivers uses: ./.github/actions/test-driver with: junit-name: 'be-tests-${{ matrix.driver }}-classpath-ee' test-args: ':only "[metabase.query-processor-test.expressions-test metabase.driver.google-test metabase.driver.googleanalytics-test]"' ```
-
dpsutton authored
This includes the stats in ```clojure prometheus=> (troubleshooting/connection-pool-info) {:connection-pools {"metabase-postgres-app-db" {:numConnections 4, :numIdleConnections 4, :numBusyConnections 0, :minPoolSize 1, :maxPoolSize 15, :numThreadsAwaitingCheckoutDefaultUser 0}, "db-52-postgres-clean" {:numConnections 1, :numIdleConnections 1, :numBusyConnections 0, :minPoolSize 1, :maxPoolSize 15, :numThreadsAwaitingCheckoutDefaultUser 0}}} ``` And thus ultimately in c3p0 stats: ``` _# HELP c3p0_num_threads_awaiting_checkout_default_user C3P0 Number of threads awaiting checkout _# TYPE c3p0_num_threads_awaiting_checkout_default_user gauge c3p0_num_threads_awaiting_checkout_default_user{database="metabase-postgres-app-db",} 0.0 c3p0_num_threads_awaiting_checkout_default_user{database="db-52-postgres-clean",} 0.0 ```
-
Ngoc Khuat authored
-
Anton Kulyk authored
-
- Feb 01, 2023
-
-
Cam Saul authored
* Switch Audit App to Honey SQL 2 * Compile using Honey SQL 2 * Mark some more tests as ^:parallel * Remove unused namespace * Backport sql.qp/current-datetime-honeysql-form :mysql Honey SQL 2 support * Add `hx/call` and `hx/raw` * Update enterprise/backend/src/metabase_enterprise/audit_app/pages/common.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * `#schema` => `#hawk/schema` * Mark `metabase.async.streaming-response-test` as `^:mb/once` --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Natalie authored
-
Alexander Polyankin authored
-
dpsutton authored
-
metamben authored
-
Nick Fitzpatrick authored
* Updating viz display picker, adding Visualization type * Adding Tests * Removing title on Display picker sidebar * PR Feedback * adjusting e2e tests
-
Ngoc Khuat authored
-
Jeff Bruemmer authored
-
Noah Moss authored
* initial migrations * autofill permission_id when adding new sandbox * use new table name in backend code * add test for migration * fix migration lint errors * WIP fix tests * small cleanup * use CONCAT to fix migration on mysql * break out fk constraint into a separate migration * address feedback
-
Noah Moss authored
* fix GET api/session endpoint for settings managers * fix test
-
Aleksandr Lesnenko authored
update specs and ensure users need to wait until stats are loaded
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Ngoc Khuat authored
`constantly` evaluates its argument at compile time so when we do `(constantly (deferred-tru))` the user's locale is undefined. Change to `(fn [] (deferred-tru))` so the error message can be returned in user's locale.
-
Ngoc Khuat authored
Parameter with source is a card: - deduplicates values - remove null/empty values - properly search number
-
Tim Macdonald authored
-
Cam Saul authored
* Switch to the new Hawk test runner * Fix some stuff * Fix everything * Commentz * Bump init timeout? * Fix Kondo config * Remove unused * Bump test runner version to get `:exclude-tags` support
-
- Jan 31, 2023
-
-
Mark Bastian authored
Removed pulses from search API and corresponding tests. There _may_ be cruft tied to pulse search elsewhere because we can't blindly remove pulses yet (need to provide legacy support at the model level), but I think I got it all.
-
Jeff Bruemmer authored
-
Mark Bastian authored
Fixing check such that a create-table check failure shows correctly instead of showing as a can-read failure.
-
Natalie authored
-
Anton Kulyk authored
* Remove unused code * Add `<Tab.Link />` component * Allow to customize `TabList's` styled components * Add `tab` arg to model detail URL helper * Add `:tab` routes for model detail page * Use link tabs in model detail page * Open actions tab directly in e2e tests * Add safety checks for tabs * Don't nest `TabLink` under `Tab` * Use explicit tab routes * Use `IndexRedirect` * Don't use `Array.prototype.at` Fails with Node 14.x :(
-
Alexander Polyankin authored
-
Aleksandr Lesnenko authored
* remove database only after additional confirmations * specs * review * fix typos
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Require rendering routes manually * Remove `Link` mocks * Return `history` from `renderWithProviders` * Fix `react-router-redux` doesn't work in Jest * Fix `ViewHeader` tests * Don't pass not used prop * Avoid `@ts-ignore`
-
Cal Herries authored
* Add migration to remove defaults * Add rollback * Fix migration * Fix migration * Fix migrations * whitespace * Add test defaults for DashboardCard * Remove defaults from create-dashboard-card! * Fix test * Fix tests * Tighten API endpoints * Fix endpoints * Formatting * Fix tests * Fix tests * Fix tests * Fix tests * Fix test * Fix e2e tests * Update e2e tests * Fix e2e tests
-
- Jan 30, 2023
-
-
Gustavo Saiani authored
-
Case Nelson authored
* Bump athena driver to 2.0.35 * Include aws core for auth
-
Ngoc Khuat authored
-
Ryan Laurie authored
* convert SelectList to typescript * add SelectList unit tests * add SelectList storybook file * update tests
-