This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 04, 2021
-
-
dpsutton authored
* Annotate collection tree with datasets and cards In order to know which collections have items of interest, they are annotated with two new keys: `:here` and `:below`. These keys will have a collection (in clojure a set, in js an array) which could contain dataset and card, depending if they have those items "here" or in collections below this node. We include information about which subtrees are interesting so we know to show or highlight those. We include information about which nodes have interesting things versus which contain nodes which have things so we can possibly implement drilldown in an intelligent manner. ie ``` . ├── root ``` could expand automatically to ``` . ├── root │ ├── collection │ │ ├── collection that actually has items ``` without requiring someone to click on the intermediate collection which has no items itself, just a collection with items. http://localhost:3000/api/collection/tree?tree=true ```js { "name": "super", "id": 154, "location": "/", "below": ["dataset"] ;; indicates collections below have datasets "children": [{ "name": "parent", "id": 155, "location": "/154/", "below": ["dataset"] ;; indicates the same "children": [{ "children": [], "slug": "contains", "name": "contains", "here": ["dataset"], ;; this node has datasets "id": 157, "location": "/154/155/", }], }, { "children": [], "name": "sibling", "id": 156, "location": "/154/", }], } ``` * docstring * Alignment for readability
-
Jeff Evans authored
* Change all active TEXT columns in MySQL app DB to LONGTEXT Add new text.type Liquibase property to dynamically select the correct text type to use, per DB (which is LONGTEXT for MySQL), very similar to the existing blob.type one Adding new migrations that update all existing app DB TEXT columns to LONGTEXT columns, only for mariadb/mysql Update migrations linter to ensure no new text types get added, via a new predicate that searches for text types being added Do the same logic for "blob" now (should be "${blob.type}"), update rule and test Add test for migrations, that checks the new types, for all types in scope for this PR, to ensure that they have all been changed to their expected DB-specific type (either LONGTEXT for MySQL or TEXT/CLOB for others) Updating a couple migrations to remove special casing that was originally done only for MySQL to simply make them universally "${text.type}", in order to unify behavior and reduce surprises going forward Co-authored-by:
Cam Saul <github@camsaul.com>
-
Alexander Polyankin authored
-
Ariya Hidayat authored
-
Jeff Bruemmer authored
-
- Nov 03, 2021
-
-
Cam Saul authored
* Drop long-unused Table.entity_name column * Add NOT NULL constraint to Card.database_id * Test fix
* Test fix * Fix migration * Add note about H2 shell to deps.edn * Add new SQL migration to attempt to set database_id when unset * Remove data migration that is now done in Liquibase land * Oops, '$.database', not '$.database_id' * Parse ints as signed rather than unsigned just to be safe (they *might* be -1337 if they're really broken) * Don't run for H2 * Update comment * Fix migration indentation * Clean namespace * Use new migration number. * Use the new migration numbers * Adopt new migration numbering scheme * Fix comments * Fix MySQL + MariaDB insanity * Fix ID range validation * Actually 382 is the last legacy ID * Improved validation and tests * Adopt the new-new migration ID format. * Test fixes * Fix merge * Simplify precondition -
Cam Saul authored
* Revert changes from Jeff's PR * Add index to ModerationReview moderated_item_type + moderated_item_id * Add to 0.41.2 instead * Require explicit index name for createIndex * Move 41.2 migrations to after the 41.0 migrations * Adopt new migration numbering scheme * Fix comments * Fix MySQL + MariaDB insanity * Fix ID range validation * Actually 382 is the last legacy ID * Improved validation and tests * Adopt the new-new migration ID format. * Test fixes
-
Cam Saul authored
* Adopt new migration numbering scheme * Fix comments * Fix MySQL + MariaDB insanity * Fix ID range validation * Actually 382 is the last legacy ID * Improved validation and tests * Adopt the new-new migration ID format. * Test fixes
-
Anton Kulyk authored
* Add unit tests for schema utils * Add data bucket step to DataSelector * Go to next steps from the data bucket step * Add different type of AccordionList icons layout * Add back navigation from 'Raw Data' tab * Fix selecting a database in 'Raw Data' * Enable search on data bucket step * Only render data bucket step if there are datasets * Prevent opening the data bucket step without datasets * Update picker search placeholder text * Update searchable models * Fix displaying datasets in search results * Hide "Saved Questions" in "Raw Data" tab * Encode data in schema str * Add ability to request dataset virtual tables * Support datasets in SavedQuestionPicker * Use saved question picker for datasets too * Add E2E tests * Show dataset icon in search results * Fix E2E selectors * Fix AccordionList icon rendering * Fix dataset can't be selected in search * Fix data selector step hydration * Fix JoinStep unit tests * Fix dataset icon size in picker view * Fix schema picker without datasets * Fix DataSelector tests * Fix error about null data selector step * Move schema utils to `metabase/lib` * Fix questions don't appear in pickers after created * Fix JoinStep unit tests * Test can create a question based on a dataset * Simplify schema ID parsing * Fix typo * Fix search models * Fix ellipsis character * Fix "Raw Data" button click area * Remove temp comment * Fix URL in personal collection contents request
-
Ariya Hidayat authored
-
Anton Kulyk authored
* Add visual tests for table visualisation * Wait until spinner disappears
-
- Nov 02, 2021
-
-
Cam Saul authored
-
Ariya Hidayat authored
-
Dalton authored
-
Dalton authored
* fix expression dimension failing to find underlying field * add a repro
-
Dalton authored
* move querystring-syncing logic to new hook * rename <Parameters> to <SyncedParametersList> * Remove syncQueryString prop * remove unused 'query' prop * remove 'isQB' prop * remove ParametersWidget in favor of ParametersList handling empty parameters list * Rely on value-populated parameters objects over parameterValues map * remove unused pass-through prop 'vertical' * make props passed from Dashboard to SyncedParametersList explicit * Update name of component * create a more generic hook for syncing the url query string
-
Alexander Lesnenko authored
-
Ariya Hidayat authored
-
Ariya Hidayat authored
With the suggestions and highlighting being done through via lexical analysis only, there is no need to run the computationally-expensive syntactical analysis on every keystroke anymore. We only need to do that when the user finishes the editing and wants to use the expression.
-
Anton Kulyk authored
-
Anton Kulyk authored
* Fix typo * Don't warn about unused variables prefixed with _ * Fix unused var warning for Icon component * Add `varsIgnorePattern` for JS files too
-
Alexander Polyankin authored
-
- Nov 01, 2021
-
-
Nemanja Glumac authored
-
dpsutton authored
* Move the multimethods over to strings not classes datasets are Cards so don't have a good way to intercept. And this kinda took all of the keywords, turned them into classes, and then didn't actually use those classes-- they were just opaque keys in the hierarchy. No bueno. * Include datasets in search results * Docstring for the linter. Thank you clj-kondo * Fix namespace decls * Update tests * Clean up ns and make test more resilient these tests that test global collections can be sensitive to test order and the CI dbs that continually exist rather than be recreated. Sometimes "table" shows up in these available models. Kinda don't care so just check for subset * Rename for confusion
-
Nemanja Glumac authored
-
dpsutton authored
* tree view for datasets * Update docstring
-
Alexander Lesnenko authored
-
Ngoc Khuat authored
-
Dalton authored
-
Howon Lee authored
There were global audit query limits which defaulted to 1000 previously. This makes them less limited.
-
Alexander Polyankin authored
-
Nemanja Glumac authored
* Expose the e2e downloads helper function * Apply the new e2e downloads helper to the #18382 repro * Apply the new e2e downloads helper to the #18440 repro * Update the helper so it applies both for saved and unsaved questions * Add additional helper options * Redirect to a non-existing page * Reafactor `downloads` spec * Extract repro for #10803
-
- Oct 29, 2021
-
-
Noah Moss authored
-
Nemanja Glumac authored
-
Anton Kulyk authored
* Move UI mocks into separate file * Mock ace and Google Analytics by default * Add helper to run a test in EE environment * Add test ID to CacheTTLField * Migrate tests to new EE helper
-
Alexander Polyankin authored
-
- Oct 28, 2021
-
-
Jeff Evans authored
Delete Secret instances from the app DB, when the corresponding Database instance is deleted Updating existing test (and renamed it to `secret-db-details-integration-test`) to confirm this behavior
-
Ariya Hidayat authored
-
Alexander Lesnenko authored
* fix invalid js * install typings using typesync * upgrade classnames to get its own typings * convert colors, settings, Icon to TS
-