This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 13, 2023
-
-
Nemanja Glumac authored
Follow up after #34892 * Include E2E workflow in file-path triggers * Adjust the glob for "actions" directories
-
Nicolò Pretto authored
* avoid calling fetchCardData in undoRemoveCardFromDashboard for virtual dashcards * test: adds basic e2e test for text card
-
Nemanja Glumac authored
* Fix flake for repro 20393 * Fix flake for repro 22524 [ci skip]
-
Nemanja Glumac authored
[ci skip]
-
- Nov 12, 2023
-
-
Braden Shepherdson authored
This reverts commit d140d676. Co-authored-by:
Case Nelson <case@metabase.com>
-
- Nov 11, 2023
-
-
Noah Moss authored
-
- Nov 10, 2023
-
-
Mark Bastian authored
It appears the code fails when run in parallel due to the `metabot-settings/enum-cardinality-threshold` value. To demonstrate, I ran: ```clojure (frequencies (pmap (fn [_] (clojure.test/run-test inner-query-name-collisions-test)) (range 1000))) ``` and got: ``` {{:test 1, :pass 12, :fail 0, :error 0, :type :summary} 414, {:test 1, :pass 11, :fail 1, :error 0, :type :summary} 586} ``` Running with a simple sequential map produced no errors. Wrapping the second test in `tu/with-temporary-setting-values [metabot-settings/enum-cardinality-threshold 10]` reduced the error count dramatically (in the teens for 1000 samples), but still wasn't bulletproof. I'm guessing the two `testing` directives in the test are run in parallel and the setting is not thread safe. By adding the explicit threshold to the test and breaking it out into a standalone test the error count drops dramatically. ``` (frequencies (pmap (fn [_] (clojure.test/run-test inner-query-name-collisions-with-joins-test)) (range 1000))) ;=> {{:test 1, :pass 6, :fail 0, :error 0, :type :summary} 998, {:test 1, :pass 5, :fail 1, :error 0, :type :summary} 2} ``` I'm still not sure why this fails (only twice in 1000 runs), but apparently something about this operation is not thread safe. However, given the additional isolation added by this PR we go from a 60ish percent failure rate down to a 0.2% failure rate locally. Hopefully this is adequate enough to prevent any substantial level of future flakes.
-
Jerry Huang authored
-
Ryan Laurie authored
-
Jeff Bruemmer authored
-
John Swanson authored
* Audit log CRUD permission failures When we run `metabase.api.common/*-check` functions like `update-check` or `create-check`, publish an event when the check fails, along with enough context that, on the other side, the audit log handler can record the relevant event. Note that we won't fire events for a `read-check` failure. Eventually we will and these events will be handled by the "read log" instead of the audit log. If we throw an event that isn't derived from `:metabase/event` it will throw an exception. That `derive` no longer belongs in the audit log code, and until we have the view log there's not really a logical place to put it. For now, I just commented out the `publish-event!` call, with the assumption that the view log is coming very soon. Otherwise we can just delete it and add it back in when it's needed. Some tangentially related required changes here to make this work include: * allow `audit-log/model-name` to work with RootCollections `(t2/model root-collection)` returns a Class rather than a keyword - `name` doesn't work here, so we'll use `getSimpleName` instead. * add a default model-details clause for dashboards If the event-type is not one that we've explicitly delineated, just return an empty map for the model details. * Migration to fit longer model names in `activity.model` The `NativeQuerySnippet` or `PermissionsGroupMembership` models, for example, were too long to fit in `VARCHAR(16)`. I'm doubling the length of this column to fit the longest model I see, with a little extra room.
-
Uladzimir Havenchyk authored
-
Nemanja Glumac authored
Follow up after #34209
-
Noah Moss authored
Co-authored-by:
bryan <bryan.maass@gmail.com>
-
Nemanja Glumac authored
-
Ryan Laurie authored
-
Jesse Devaney authored
-
John Swanson authored
When a card or dashboard is pinned, the entity itself is not changing, so let's not send the `:event/card-update` or `:event/dashboard-update` events in these cases.
-
Nicolò Pretto authored
* empty commit to allow draft pr * dismiss undo notifications when saving a dashboard (#35243) * dismiss undo notifications when saving a dashboard * e2e test * Update e2e/test/scenarios/dashboard/tabs.cy.spec.js Co-authored-by:
Oisin Coveney <oisin@metabase.com> --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com> * fix z-index issues * Update frontend/src/metabase/dashboard/components/DashCard/DashCard.styled.tsx Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * renames as per feedback on PR * left align dashcard actions on small cards (#35327) * update emotion to support container queries * left align actions with container query * use rems * fix restore z index between resize handle and dashcard actions * refactor: remove renderDashCardActions in favor of a component (#35366) * move DashboardCardActionsPanel inside DashCardActionButtons * move isDashCardTabMenuOpen state to DashCardACtionsButtons * refactor: remove renderDashCardActions * refactor: renamed to DashCardActionsPanel * refactor import type MouseEvent * refactor DashCardActionButtons folder -> DashCardActionsPanel * refactor: move DashCardTabMenu to DashCardActionsPanel * refactor: move buttons to their own subfolder so that it's clear they're sub-components of the actions panel * feat: use name of card in undo toast message (#35378) * feat: use name of card in undo toast message * feat/refactor: truncate via css * denis' patch to use Ellipsified * make toast don't take up all space + add max width * Update frontend/src/metabase/containers/UndoListing.styled.tsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Cal Herries authored
-
Nemanja Glumac authored
* Fix newly created E2E CSV flakes * Do not use `.within()` on multiple elements * Always isolate the correct status element before assertions
-
Alexander Solovyov authored
`load-metabase!` now has an exclamation mark in the name Fixes a breaking change in master caused by merging #35539 before #35530.
-
Alexander Solovyov authored
Cards are not touched, just DashboardCards and DashboardTabs are synchronized with loaded data
-
Cal Herries authored
-
Kamil Mielnik authored
* Add a repro for the basic case * Add more assertions * Remove external tag * Improve test name * Add a test case for visited questions * Fix initial state for lhc display name for visited questions * Refactor duplication * Update test names * Skip test that still fails * Revert "Fix initial state for lhc display name for visited questions" This reverts commit 36aca5469dff6e711725e930eb1b29b6bef7dbef. * Use getNotebookStep * Skip test until issue is fixed
-
Mahatthana (Kelvin) Nomsawadi authored
* Refactor to prepare for new requirement * Hide personal collections and items when configuring click behavior * Remove default export * Add tests * Fix type error * Review: Simplify test util * Update frontend/src/metabase-lib/parameters/utils/click-behavior.ts Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Consolidate collection util functions * Reuse an existing function * Fix conflict from rebasing off master --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Ngoc Khuat authored
-
Ngoc Khuat authored
-
Kamil Mielnik authored
* Display error instead of auto-fixing non-exiting tab id * Make deleted target dashboard tab an invalid click behavior state * Fix saving click behavior * Add a test for showing error when the tab has been removed * Add auto-fix for deleted tab when we don't render tabs dropdown * Update test names
-
Kamil Mielnik authored
* Do not show new question link when database does not support nested queries * Do not show new question link when nested queries are disabled * Add a unit test for disabled nested queries * Add a unit test for databases without nested queries support
-
Cal Herries authored
-
Nemanja Glumac authored
-
Alexander Solovyov authored
keys in serialization are be sorted by historical order first and alphabetically if they are not mentioned
-
Nemanja Glumac authored
-
- Nov 09, 2023
-
-
Cam Saul authored
-
Cam Saul authored
-
Noah Moss authored
Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
Cam Saul authored
-
Ryan Laurie authored
-
Nemanja Glumac authored
* Split visualizations E2E group * Rename visualizations to `visualizations-charts` * Update E2E matrix
-