Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 02, 2021
  2. Nov 01, 2021
  3. Oct 29, 2021
  4. Oct 28, 2021
  5. Oct 27, 2021
    • Pawit Pornkitprasan's avatar
      Fix SSH tunnel with ED25519 keys (#18697) · 24975664
      Pawit Pornkitprasan authored
      `org.apache.sshd` requires `net.i2p.crypto/eddsa` dependency
      to work with ED25519 keys.
      
      This worked in 0.40 because `eddsa` was included as a transitive
      dependency of another unrelated dependency (`buddy`) but stopped
      working in 0.41 because the new version of `buddy` no longer depends
      on `eddsa`. Thus, we must explicitly include the dependency.
      
      To prevent this from breaking again, switched one of the test
      keys to an ED25519 key.
      Unverified
      24975664
    • Dalton's avatar
      move dashboard parameter utils (#18694) · 51174e4a
      Dalton authored
      * move dashboard parameter utils
      
      * Move the ParameterSection type to type/Parameter.js
      Unverified
      51174e4a
    • Ariya Hidayat's avatar
    • Nemanja Glumac's avatar
    • Jeff Evans's avatar
      Handle long running sync in connection pool hash check (#18664) · e0765149
      Jeff Evans authored
      * Handle long running sync in connection pool hash check
      
      Modify the logic in `db->pooled-connection-spec` to check for the latest `DatabaseInstance` from the app DB in case of a hash mismatch, before deciding that the pool needs to be invalidated (based on changing hash of db details)
      
      This is to handle the case where a long running sync keeps passing in a stale version of the `DatabaseInstance` over a period of many minutes/hours, long after the app DB has received an updated version that was saved through the UI
      
      In this case, the connection pool code will get the latest `DatabaseInstance` from the app DB, on a hash mismatch, then compare that against the in-memory has for the given DB ID.  And if it still doesn't match, then the invalidation kicks in
      
      Updating the test accordingly
      Unverified
      e0765149
    • Anton Kulyk's avatar
      Add ability to turn a saved question into a dataset (#18702) · 9da42b9c
      Anton Kulyk authored
      * Add dataset icon
      
      * Add getter and setter for Question's `dataset` flag
      
      * Add action to turn a saved question into a dataset
      
      * Add UI for turning a question into a dataset
      
      * Use dataset icon for questions turned into datasets
      
      * Show datasets on collections page
      
      * Change colors for dataset icons in collections
      
      * Test can turn a question into a dataset
      
      * Fix unit test
      
      * Fix color literal
      
      * Hide "Turn into a dataset" button for datasets
      
      * Rerun non table question when turned into a dataset
      
      * This was a mistake
      Unverified
      9da42b9c
    • Jeff Evans's avatar
      Make the checkins_interval transient datasets more uniquely named in BigQuery test runs (#18600) · 5a76ef70
      Jeff Evans authored
      * Make the checkins_interval transient datasets more uniquely named
      
      Append a timestamp suffix (initialized when the namespace was loaded) to transient dataset names
      
      Add verbose comments explaining what we're doing
      
      Add transient-dataset? functions for both BQ drivers to put logic in one place (which currently just see if the dataset is named `checkins_interval_*`
      
      Ditch the "legacydriver_" prefix from the legacy BigQuery driver when creating new datasets; it's no longer needed now that transient datasets will have a much more unique suffix
      
      Update the logic for the transient dataset suffix so that it can be more easily detected/parsed later (for cleanup)
      
      Remove old (more than 2 hours) transient datasets when test extensions namespaces load
      
      Add various docstrings
      Unverified
      5a76ef70
    • Ariya Hidayat's avatar
Loading