Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 05, 2023
  2. Jul 04, 2023
  3. Jul 03, 2023
  4. Jul 01, 2023
  5. Jun 30, 2023
  6. Jun 29, 2023
    • metamben's avatar
      Add tests for joined-thing (#31966) · cc552817
      metamben authored
      cc552817
    • Mark Bastian's avatar
      Fix TemplateTag id type discrepancy (#31257) · 7d84f6a1
      Mark Bastian authored
      There was a discrepancy between TemplateTag id types as defined in metabase.lib.native (uuid) and metabase.mbql.schema (string). This PR makes string the uniform type for both. This results in errors when code using different specs for the same logical entity is used together. Here's an breaking example:
      
      ```
      (let [card-id 328 ;; This is a valid card locally
            q   (str "SELECT * FROM {{#" card-id "}} LIMIT 2")
            tt  (lib-native/extract-template-tags q)
            res (qp/process-query
                  {:database 1
                   :type     :native
                   :native   {:query         q
                              :template-tags tt}})]
        (is (some? res)))
      ```
      This will break since the tt generated id is a uuid but process-query expects a string id.
      
      Fixes #31252 
      7d84f6a1
    • Noah Moss's avatar
    • Anton Kulyk's avatar
      Migrate notebook aggregations to MLv2 (#31855) · c529a888
      Anton Kulyk authored
      * Migrate notebook aggregations to MLv2 — Operators (1) (#31527)
      
      * Add aggregation types
      
      * Add aggregation TypeScript wrappers
      
      * Move `AggregateStep` to its own directory
      
      * Port basic features to MLv2
      
      * Deprecate `AggregationPopover`
      
      * Fix MLv1's aggregation clause validation
      
      * Fix import
      
      * `requiresField` → `requiresColumn`
      
      * Add basic tests for `AggregationPicker`
      
      * Add `findAggregationOperator` test utility
      
      * Add basic tests for `AggregateStep`
      
      * Make stage index explicit
      
      * Highlight selections, add picker back button
      
      * Use long display name for aggregation clauses
      
      * Remove `React` imports
      
      * Enable temporal bucketing
      
      * Use aggregation JS wrappers
      
      * Fix `Icon` import
      
      * Patch unit test according to BE changes
      
      * Fix E2E test
      
      * Simplify `Aggregation's` `dimension` method
      
      * Fix formatting
      
      * Migrate notebook aggregations to MLv2 — Metrics (2) (#31528)
      
      * Add basic legacy metrics support
      
      * Don't show archived metrics
      
      * Highlight selected metric
      
      * Extract `AggregationPopover` in notebook step
      
      * Fix `onClose` prop
      
      * Fix icon
      
      * Add missing metric types
      
      * Use MLv2 to manage metrics
      
      * Remove legacy query logic
      
      * Add `Aggregatable` type
      
      * Migrate notebook aggregations to MLv2 — Inline expressions (3) (#31529)
      
      * Revert "Remove legacy query logic"
      
      This reverts commit 722804d3a6684762701351c658625b5439c75c2b.
      
      * Use HTML labels in `ExpressionWidget`
      
      * Support inline expressions for aggregations
      
      * Fix import
      
      * Fix picker navigation
      
      * Fix type error
      
      * Remove `ts-expect-error`
      
      * Migrate notebook aggregations to MLv2 — Disable MLv1 validation (4) (#31530)
      c529a888
  7. Jun 28, 2023
  8. Jun 27, 2023
  9. Jun 26, 2023
    • Noah Moss's avatar
      Read is-metabot-enabled setting from env var only (#31827) · 4e350d01
      Noah Moss authored
      
      * read is-metabot-enabled setting from env var only
      
      * change visibility back to public
      
      * skip metabot specs
      
      * skip one more spec
      
      * fix BE tests
      
      * fix indentation
      
      * more indentation
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      4e350d01
    • Emmad Usmani's avatar
      optimize loading questions only for active tab (#31578) · 58c7b0ff
      Emmad Usmani authored
      
      * only load cards and metadata for current dashboard tab
      
      * add e2e test
      
      * refactor
      
      * more refactoring
      
      * fix filters not working
      
      * update e2e test
      
      * fix bug with x-rays
      
      * add dashboard_tab_id to automagic-dashboard response
      
      * use schema check instead
      
      * fix on public dashboards
      
      * remove FE x-ray fix now that BE is fixed
      
      * add test for public dashboards
      
      * fix duplicate request for public dashboards
      
      * fix notification bug
      
      * fix failing unit tests in `reducers.unit.spec.js`
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      58c7b0ff
  10. Jun 24, 2023
  11. Jun 23, 2023
  12. Jun 22, 2023
  13. Jun 21, 2023
Loading