This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 31, 2023
-
-
Cal Herries authored
* Use type/JSON instead of type/SerializedJSON * Tidy migration * Update migration * Fix rollback migration for h2 * whitespace * Add test for migration * Fix test * Add rollback * whitespace * Test JSONB type as well as JSON * Don't fingerprint JSON columns * Remove comment, that might be wrong in the future * Update test * Add tests for fingerprinting * Use base-type JSON for fingerprinting base query * Add test for visibility-type=details-only * undo . * Change migration id * Fix migration test * Merge master * Exclude mariadb from tests * Make is-mariadb? public * Migration for adding nfc_enabled * Add nfc_enabled to field settings * Update describe-nested-field-columns to only unfold fields that have not been disabled * Remove spy * Tidy * Fix * Clear nested fields immediately if folding is disabled * Clear nested fields on nfc_enabled change * Trim trailing whitespace * Tidy * Fix * Add enable-json-unfolding-test * Move to field api test * nfc_enabled -> json_unfolding * Tidy test * Make json-unfolding in database details just the default for new settings * Restore original visibility-type logic * Fix * Sync field json_unfolding according to db json_folding * Rename to json-unfolding-default * Add test for the case when the json-unfolding is false for the database * Implement default json unfolding for first sync * Update comment * Update comment * Restore PUT field * Migration for populating json_unfolding for mysql and postgres * Remove migration and use default on the frontend instead * Update json-unfolding database setting copy * Move Unfold JSON setting under semantic type setting * Separate sentences with spaces * Capitalize * Restore handleChangeSemanticType * Use base_type TYPE.JSON instead * Change order of migrations * Add h2 migration * Add test for migration * Update test description * Remove validCheckSum Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * Use ?? instead of || * Fix tests * Remove outdated serdes stuff * Remove unnecessary and * Fix mysql migration * Remove unused require * Fix test * Add false default value for json_unfolding * Fix json-unfolding nil case * Other suggestions * whitespace * Tidy describe-nested-field-columns * Update comment * Remove unused clear-nested-fields! * Remove unused return value * Fix H2 migration to use base_type not database_type * Always set json-unfolding during sync * Fix test * Fix test * Fix test * Add comment explaining nested-field-column support for MySQL * Fix tests * Fix tests * Fix test * Fix test * Default json_unfolding to false for new fields * Fix merge * Add json_unfolding to mock tables * Don't capitalize prepositions * Update setting description * whitespace * whitespace * Fix fetch_metadata * Fix fetch_metadata * Fix tests * Fix test * Fix clj-kondo * Remove postgres database-supports test * Fix postgres test * Fix postgres test * Fix mysql migration * Fix clj-kondo * Don't test mariadb * Fix mysql test * Fix mysql json-unfolding nil case * Add comments to test * Add upterm step to mariadb test * Move upterm step before tests * Fix postgresql migration * move upterm step to test-driver action * Remove upterm step from drivers.yml * Comment out everything else in test-driver * Fix mariadb migration * Remove upterm action * Whitespace * Only handle JSONObjects with JSON_VALUE, not JSONArray * Fix fields.sync_metadata/update-field-metadata-if-needed! * Add comment explaining `json-unfolding-default` * Add comment for JSON_VALUE test * Update json-unfolding-default-true-test to use fresh db * Fix test descriptions * Don't capitalize setting display name * Fix update json_unfolding * Fix unfolding json for only one JSON column, not all * Add e2e test for JSON unfolding setting * Fix test * whitespace * Fix test * Fix json-unfolding for nested field columns * Fix mysql and postgres tests for nested field columns * Coerce nil json-unfolding to false for sync_metadata * Add test for nil json-unfolding for sync_metadata * Fix test * Don't update json_unfolding from intial sync * Add json_unfolding to update-field-test * Fix tests --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Mar 30, 2023
-
-
uladzimir authored
-
- Mar 29, 2023
-
-
Braden Shepherdson authored
This supports both parsing out the tags and constructing the template tags map, with `card-id` and all. This is not quite a FE no-op because the humanization of text is slightly different between `metabase.util.humanization` and the JS humanization library. This improves JS<->CLJS conversion to handle UUIDs and be smarter about enums, both of which were needed to handle converting template tag maps. Extracted a `js=` test helper to `metabase.test.util.js/=` since many tests need to compare JS objects, which are not JS `==` to each other.
-
Mahatthana (Kelvin) Nomsawadi authored
* Ensure implicit actions are created in a deterministic order * Add missing lint-staged step for JS, TS under `e2e/*`
-
Denis Berezin authored
* Merge outdated ExpressionPopover and ExpressionWidget (#29050) * Refactor negative filters formatting to make them pass isExpression validation - not-null, not-empty, does-not-contain * Refactored ExpressionEditorTextfield to TS (#29337) * Remove footer divider * Fixed issue with aggregation step in admin data-model metrics section
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Mar 28, 2023
-
-
Ryan Laurie authored
* use read only notebook instead of GUI query editor to view queries * remove edit formatting elements for readOnly variant * add unit tests * add back support for native queries * update tests * fix types
-
Mahatthana (Kelvin) Nomsawadi authored
* Add a reproduction for #22230 * Clean up comments
-
Anton Kulyk authored
* Add basic tests to `NotebookStep` * Fix irreversible steps have "remove" button * Use `aria-label` instead of a test ID * Use `IconButtonWrapper`
-
Mahatthana (Kelvin) Nomsawadi authored
Add a reproduction for dashboard sticky filter incorrectly positioned when moving between dashboards (#29497) * Add a repro for #26230 * Move the prep phase to the `beforeEach` * Use `visitDashboard` helper * Wait for the second dashboard to load * You don't have to use `within` here * Add a comment * Add main repro assertion * Greatly simplify creation of the markdown card * Update the test title --------- Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
- Mar 27, 2023
-
-
Nemanja Glumac authored
-
Alexander Polyankin authored
-
- Mar 25, 2023
-
-
Nick Fitzpatrick authored
* keep standalone values when collapsing column * adjusting unit test * PR Feedback * adding space * removing only * Adjusting behavior and tests * adjusting data_grid unit tests
-
- Mar 24, 2023
-
-
Denis Berezin authored
-
Nick Fitzpatrick authored
* Updating to cypress 12 * updating deps * Updating Tests. Be Green Plz * removing custom test id from select button * Select Button Tuning
-
- Mar 23, 2023
-
-
Ryan Laurie authored
-
Emmad Usmani authored
* fix pie chart legend not fading on hover * use `aria-current` in test instead of directly checking style * fix failing test
-
Nick Fitzpatrick authored
-
Tim Macdonald authored
* Add action.dataset_query to search results * Add action.database_id to search results * Unskip repro * better FE error handling for action query display * update repro --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
Nemanja Glumac authored
* Remove usages of `cy.addFilterToDashboard` custom command * Fully remove `cy.addFilterToDashboard` custom command
-
- Mar 22, 2023
-
-
Alexander Polyankin authored
-
Noah Moss authored
* show all subscriptions in notification management page regardless of collection perms * strip cards and recipients if necessary * indentation tweak * add backend tests * add cypress repro * fix permissions check * slightly different approach * fix cypress test * fix test * address comment
-
Alexander Polyankin authored
-
- Mar 21, 2023
-
-
Emmad Usmani authored
* fix dashboard opening in editing state when it shouldn't * unskip reproduction test
-
Cam Saul authored
* Query D E S C R I P T I O N S * WIP * MLv2 Query description * Test fixes * More robust error handling * MLv2 more shuffling things around * Remove unneeded impl * Cumulative FE changes * WIP * lib.expressions -> lib.expression * Address PR feedback * Fix everything * Oops fix missing metadata * Test fixes
* Fixes post-merge * Fix merge conflict * JS metadata overhaul * Test fix * Test fix * Hack to workaround busted JOINs * Use Braden's better fix * Cumulative fixes * Test fixes * Remove unused * Include temporal unit in query description * Don't change indentation * Revert e2e browser changes * Revert bin change * Meaningless change to kick CI
-
- Mar 20, 2023
-
-
Ryan Laurie authored
* make object detail work for non-logged-in users * update types to account for optional params * test public object detail viz
-
Aleksandr Lesnenko authored
* fix missing group by columns from joined tables * fix spec
-
Ryan Laurie authored
* extract model creation helper * update model actions test to actually mutate data * fix merge conflicts and clean up
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix custom field type aggregation not showing When the origin table don't have that field type. * Add tests * Remove puzzle driven development comments * Make `getAggregationOperators` API more apparent
-
Uladzimir Havenchyk authored
-
- Mar 19, 2023
-
-
Emmad Usmani authored
* fix agressive y-axis splitting in charts * e2e tests * check if col settings are different * use `settings.column` instead of redefining default settings * refactor for feedback
-
- Mar 17, 2023
-
-
Aleksandr Lesnenko authored
-
Ngoc Khuat authored
-
Mark Bastian authored
Exposes models as a GenericTable and adds in UI menu option to show the x-ray. There's still work to be done to add filters and more interesting auto-generated charts, but this is the first step.
-
Nemanja Glumac authored
* Extract `parseArguments` into utils * Allow custom browser for Cypress snapshots generation
-
Nick Fitzpatrick authored
-
Nemanja Glumac authored
-
- Mar 16, 2023
-
-
Nick Fitzpatrick authored
* Updating graph.metrics when column is removed * updating logic and adding unit tests
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-