Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 31, 2023
    • Cal Herries's avatar
      Toggle JSON unfolding by field (#28742) · 25a1b259
      Cal Herries authored
      
      * Use type/JSON instead of type/SerializedJSON
      
      * Tidy migration
      
      * Update migration
      
      * Fix rollback migration for h2
      
      * whitespace
      
      * Add test for migration
      
      * Fix test
      
      * Add rollback
      
      * whitespace
      
      * Test JSONB type as well as JSON
      
      * Don't fingerprint JSON columns
      
      * Remove comment, that might be wrong in the future
      
      * Update test
      
      * Add tests for fingerprinting
      
      * Use base-type JSON for fingerprinting base query
      
      * Add test for visibility-type=details-only
      
      * undo .
      
      * Change migration id
      
      * Fix migration test
      
      * Merge master
      
      * Exclude mariadb from tests
      
      * Make is-mariadb? public
      
      * Migration for adding nfc_enabled
      
      * Add nfc_enabled to field settings
      
      * Update describe-nested-field-columns to only unfold fields that have not been disabled
      
      * Remove spy
      
      * Tidy
      
      * Fix
      
      * Clear nested fields immediately if folding is disabled
      
      * Clear nested fields on nfc_enabled change
      
      * Trim trailing whitespace
      
      * Tidy
      
      * Fix
      
      * Add enable-json-unfolding-test
      
      * Move to field api test
      
      * nfc_enabled -> json_unfolding
      
      * Tidy test
      
      * Make json-unfolding in database details just the default for new settings
      
      * Restore original visibility-type logic
      
      * Fix
      
      * Sync field json_unfolding according to db json_folding
      
      * Rename to json-unfolding-default
      
      * Add test for the case when the json-unfolding is false for the database
      
      * Implement default json unfolding for first sync
      
      * Update comment
      
      * Update comment
      
      * Restore PUT field
      
      * Migration for populating json_unfolding for mysql and postgres
      
      * Remove migration and use default on the frontend instead
      
      * Update json-unfolding database setting copy
      
      * Move Unfold JSON setting under semantic type setting
      
      * Separate sentences with spaces
      
      * Capitalize
      
      * Restore handleChangeSemanticType
      
      * Use base_type TYPE.JSON instead
      
      * Change order of migrations
      
      * Add h2 migration
      
      * Add test for migration
      
      * Update test description
      
      * Remove validCheckSum
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * Use ?? instead of ||
      
      * Fix tests
      
      * Remove outdated serdes stuff
      
      * Remove unnecessary and
      
      * Fix mysql migration
      
      * Remove unused require
      
      * Fix test
      
      * Add false default value for json_unfolding
      
      * Fix json-unfolding nil case
      
      * Other suggestions
      
      * whitespace
      
      * Tidy describe-nested-field-columns
      
      * Update comment
      
      * Remove unused clear-nested-fields!
      
      * Remove unused return value
      
      * Fix H2 migration to use base_type not database_type
      
      * Always set json-unfolding during sync
      
      * Fix test
      
      * Fix test
      
      * Fix test
      
      * Add comment explaining nested-field-column support for MySQL
      
      * Fix tests
      
      * Fix tests
      
      * Fix test
      
      * Fix test
      
      * Default json_unfolding to false for new fields
      
      * Fix merge
      
      * Add json_unfolding to mock tables
      
      * Don't capitalize prepositions
      
      * Update setting description
      
      * whitespace
      
      * whitespace
      
      * Fix fetch_metadata
      
      * Fix fetch_metadata
      
      * Fix tests
      
      * Fix test
      
      * Fix clj-kondo
      
      * Remove postgres database-supports test
      
      * Fix postgres test
      
      * Fix postgres test
      
      * Fix mysql migration
      
      * Fix clj-kondo
      
      * Don't test mariadb
      
      * Fix mysql test
      
      * Fix mysql json-unfolding nil case
      
      * Add comments to test
      
      * Add upterm step to mariadb test
      
      * Move upterm step before tests
      
      * Fix postgresql migration
      
      * move upterm step to test-driver action
      
      * Remove upterm step from drivers.yml
      
      * Comment out everything else in test-driver
      
      * Fix mariadb migration
      
      * Remove upterm action
      
      * Whitespace
      
      * Only handle JSONObjects with JSON_VALUE, not JSONArray
      
      * Fix fields.sync_metadata/update-field-metadata-if-needed!
      
      * Add comment explaining `json-unfolding-default`
      
      * Add comment for JSON_VALUE test
      
      * Update json-unfolding-default-true-test to use fresh db
      
      * Fix test descriptions
      
      * Don't capitalize setting display name
      
      * Fix update json_unfolding
      
      * Fix unfolding json for only one JSON column, not all
      
      * Add e2e test for JSON unfolding setting
      
      * Fix test
      
      * whitespace
      
      * Fix test
      
      * Fix json-unfolding for nested field columns
      
      * Fix mysql and postgres tests for nested field columns
      
      * Coerce nil json-unfolding to false for sync_metadata
      
      * Add test for nil json-unfolding for sync_metadata
      
      * Fix test
      
      * Don't update json_unfolding from intial sync
      
      * Add json_unfolding to update-field-test
      
      * Fix tests
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      25a1b259
  2. Mar 30, 2023
  3. Mar 29, 2023
  4. Mar 28, 2023
  5. Mar 27, 2023
  6. Mar 25, 2023
  7. Mar 24, 2023
  8. Mar 23, 2023
  9. Mar 22, 2023
  10. Mar 21, 2023
    • Emmad Usmani's avatar
      fix dashboard opening in editing state when it shouldn't (#29368) · 9ae66ab7
      Emmad Usmani authored
      * fix dashboard opening in editing state when it shouldn't
      
      * unskip reproduction test
      9ae66ab7
    • Cam Saul's avatar
      Port query description logic to MLv2 (#29200) · 8f554528
      Cam Saul authored
      * Query  D E S C R I P T I O N S
      
      * WIP
      
      * MLv2 Query description
      
      * Test fixes
      
      * More robust error handling
      
      * MLv2 more shuffling things around
      
      * Remove unneeded impl
      
      * Cumulative FE changes
      
      * WIP
      
      * lib.expressions -> lib.expression
      
      * Address PR feedback
      
      * Fix everything
      
      * Oops fix missing metadata
      
      * Test fixes :wrench:
      
      * Fixes post-merge
      
      * Fix merge conflict
      
      * JS metadata overhaul
      
      * Test fix :wrench:
      
      * Test fix
      
      * Hack to workaround busted JOINs
      
      * Use Braden's better fix
      
      * Cumulative fixes
      
      * Test fixes :wrench:
      
      * Remove unused
      
      * Include temporal unit in query description
      
      * Don't change indentation
      
      * Revert e2e browser changes
      
      * Revert bin change
      
      * Meaningless change to kick CI
      8f554528
  11. Mar 20, 2023
  12. Mar 19, 2023
  13. Mar 17, 2023
  14. Mar 16, 2023
Loading