Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 01, 2022
  2. Jan 31, 2022
  3. Jan 27, 2022
  4. Jan 26, 2022
  5. Jan 25, 2022
    • Dalton's avatar
      Collections changes feature branch (#19848) · afc53f40
      Dalton authored
      
      * Add PinnedItemCard component (#19765)
      
      * convert Card component to typescript
      
      * add open state class to EntityMenu
      
      * Add PinnedItemCard component
      
      * prevent the bubbling of EntityMenu events
      
      * replace class with styled-component stuff
      
      * define a const
      
      * Replace pinned collection items table with pinned overview section (#19787)
      
      * Add PinnedItemOverview component
      
      * Replace the pinned table with overview
      
      * add types to collection utils
      
      * fix pinning + types
      
      * remvoe the old PinnedItemsTable
      
      * fix/remove e2e tests that no longer make sense
      
      * replace 'Datasets' with 'Models'
      
      * Update frontend/src/metabase/collections/components/PinnedItemOverview/PinnedItemOverview.tsx
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      
      * add unique text for root collection
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      
      * Collections page UI changes (#19792)
      
      * make a bunch of ui tweaks to collections
      
      * resize Titles for PinnedItemCards
      
      * resize collection description headings
      
      * Add tooltip to pin button
      
      * Fix unit test
      
      * fix e2e tests
      
      * add a default description
      
      * Tbody --> TBody
      
      * Hide long titles & add tooltip to show entire title
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      
      * Add card visualizations to the pinned section of collections (#19813)
      
      * First pass at card viz in collections
      
      * minor style fixes
      
      * move redux stuff up to CollectionContent
      
      * padding tweaks
      
      * Make the entire card clickable
      
      * add generic error message
      
      * Add propTypes
      
      * a little cleanup
      
      * create ActionMenu component
      
      * Fix pin action fn
      
      * Fix circular dep & storybook story
      
      * actually import the function
      
      * add comment // use EventSandbox
      
      * Add preventDefault prop to avoid breaking things
      
      * Make pinned cards drag-and-droppable into the collections sidebar (#19829)
      
      * first pass at dnd for pinned cards
      
      * use cards instead of viz for performance
      
      * fix type
      
      * Add tests for collection changes (#19851)
      
      * first pass at dnd for pinned cards
      
      * use cards instead of viz for performance
      
      * fix type
      
      * Add tests for collection changes
      
      * fix Button import
      
      * remove async
      
      * Add empty pinned items section banner (#19857)
      
      Fix e2e test
      
      don't show empty states when loading
      
      styling tweaks
      
      Fix test
      
      * datasets --> models
      
      * fix dragging data models
      
      * Make question icons in collections bg-dark
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      Unverified
      afc53f40
  6. Jan 24, 2022
  7. Jan 21, 2022
  8. Jan 20, 2022
  9. Jan 18, 2022
  10. Jan 14, 2022
    • Nemanja Glumac's avatar
      Fix 19630 (#19655) · 1dae9127
      Nemanja Glumac authored
      * Fix duplicate model tooltip
      
      * Fix archive model title
      
      * Fix edit model modal title
      
      * Fix model verification title
      
      * Fix add model to dashboard title
      
      * Fix failing unit test
      
      * Update model's archive message
      Unverified
      1dae9127
  11. Jan 12, 2022
  12. Jan 07, 2022
  13. Jan 04, 2022
    • adam-james's avatar
      JWT Login URL configured by user may have URL parameters (#19381) · 4448b34d
      adam-james authored
      * JWT Login URL configured by user may have URL parameters
      Since params may already exist in the login URL, a check is performed to make sure the generated URL
      with 'return_to' param formats correctly. If a param already exists, all subsequent params should
      have an '&
      character.
      
      * Sorted ns to pass linting
      
      * added issue number to test string for added context.
      Unverified
      4448b34d
    • Alexander Lesnenko's avatar
      Replace enterprise with license page (#19343) · b0309e2c
      Alexander Lesnenko authored
      * remove old store page
      
      * add license pages
      
      * add remove webpack cache command
      
      * lint
      
      * fix specs
      
      * remove license widget from the oss version
      
      * add missing translation
      
      * show loader only for unput when updating token
      
      * fix specs
      
      * amend the license page
      
      * unactivated state fix
      
      * add premium embedding page, refactor, fix specs
      
      * amend the license page
      
      * amend the license page
      
      * change license page padding
      Unverified
      b0309e2c
    • Alexander Polyankin's avatar
      Improve login flow (#19498) · 62f9ccd2
      Alexander Polyankin authored
      Unverified
      62f9ccd2
  14. Dec 28, 2021
    • Cam Saul's avatar
      Database-local Settings (#19399) · b9bee5dc
      Cam Saul authored
      * Rename setting/get and setting/all; GeoJSON via env var tests
      
      * Fix typo (thanks @noahmoss)
      
      * Support Database-local Settings in metabase.models.setting itself
      
      * Rework Settings code so it can handle possibly-already-deserialized values
      
      * Database-local Settings
      
      * Remove empty part of docstring
      
      * Appease linters
      
      * Update dox again
      
      * Use text.type for the new column
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * Test fix :wrench:
      
      * All negative integer values when setting :integer Setting with a string
      Unverified
      b9bee5dc
  15. Dec 26, 2021
  16. Dec 21, 2021
  17. Dec 16, 2021
  18. Dec 14, 2021
  19. Dec 07, 2021
  20. Dec 02, 2021
  21. Nov 24, 2021
  22. Nov 22, 2021
  23. Nov 18, 2021
    • Dalton's avatar
      Reimplement tooltips using tippy.js (#18880) · 80d81a10
      Dalton authored
      * add tippy and react-is
      
      * add tippy styles to vendor.css
      
      we'll probably override most things but it handles
      apply the triangle to tooltips
      
      * reimplement Tooltip using tippy
      
      * reimplement ChartTooltip using Tooltip
      
      * add tooltip theme styling
      
      * fix StoreLink styling
      
      * remove TooltipPopover
      
      * add util for easy mapping to innerRef
      
      * use innerRef util with StoreLink target
      
      * react-is type defs
      
      * convert Tooltip into tsx
      
      * convert styled-components util into typescript
      
      * fix Tooltip fallback return
      
      * use Tooltip in Icon over Tooltipify
      
      * remove Tooltipify
      
      * pass ref all the way through Icon
      
      * fix DimensionListItem styling caused by missing ref
      
      * fix ChartTooltip event target bug
      
      * fix unit test by making Icon.tsx grosser
      
      * replace popover() util with tooltip() in cy tests
      
      * fix random broken e2e test
      
      * improve types in Tooltip
      
      * move everything to a separate folder + add tests
      
      * add more examples
      
      * rmv accidental deps
      
      * fix run button styling
      
      * add Link tooltip prop to avoid tooltip on icon
      
      * wrap MetabotLogo in forwardRef
      
      * support reduced motion
      
      * remove flow type from dom.js so we can use in ts files
      
      * pass isEnabled prop to tippy's disabled prop
      
      once you've activated "control mode" in tippy you can't turn it off so
      using "visible" as a toggle doesn't work. instead, use disabled.
      
      * fix uncentered tooltip the right way
      
      tippy includes padding/margin in its centering calculations, unlike
      tether, so we will need to be careful about adding one-sides
      padding/margins to a tooltip target, otherwise the tooltip will appear
      offcenter
      
      * workaround for absolutely positioned element
      
      the tooltip appeared on the far end of the target because of a child div
      that is absolutely positioned. quick fix is to instead target the icon
      
      * fix positioning of HintIcon tooltip
      
      * lint fix
      
      * add placement prop
      
      * fix styled component tooltip target styling
      
      * place QuestionNotebookButton tooltip below
      
      * Make the NativeQueryButton an actual button
      
      * set tooltip placement to bottom
      
      * lint fix warning
      Unverified
      80d81a10
  24. Nov 09, 2021
    • Anton Kulyk's avatar
      Add ability to turn a dataset back into a question (#18873) · 6bc2fb9f
      Anton Kulyk authored
      * Add `hasPlugin` check to moderation plugin
      
      * Remove border from QuestionModerationSection
      
      * Remove padding from question description
      
      * Reorder imports and exports
      
      * Remove not used prop
      
      * Manage section border in the sidebar
      
      * Add tests for question details sidebar
      
      * Add basic dataset management section
      
      * Add icon for dataset > question action
      
      * Test dataset —> question change
      
      * Add ability to turn a dataset into a question
      
      * Use HTML buttons for dataset management
      
      * Show question verification section
      
      * Fix datasets e2e test helper
      
      * Fix hover effect for dataset action buttons
      
      * Fix question sidebar button alignment
      
      * Use CSS to handle sidebar border
      Unverified
      6bc2fb9f
  25. Nov 05, 2021
  26. Nov 04, 2021
    • Jeff Evans's avatar
      Change all active TEXT columns in MySQL app DB to LONGTEXT (#18749) · b4610877
      Jeff Evans authored
      
      * Change all active TEXT columns in MySQL app DB to LONGTEXT
      
      Add new text.type Liquibase property to dynamically select the correct text type to use, per DB (which is LONGTEXT for MySQL), very similar to the existing blob.type one
      
      Adding new migrations that update all existing app DB TEXT columns to LONGTEXT columns, only for mariadb/mysql
      
      Update migrations linter to ensure no new text types get added, via a new predicate that searches for text types being added
      
      Do the same logic for "blob" now (should be "${blob.type}"), update rule and test
      
      Add test for migrations, that checks the new types, for all types in scope for this PR, to ensure that they have all been changed to their expected DB-specific type (either LONGTEXT for MySQL or TEXT/CLOB for others)
      
      Updating a couple migrations to remove special casing that was originally done only for MySQL to simply make them universally "${text.type}", in order to unify behavior and reduce surprises going forward
      
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Unverified
      b4610877
  27. Nov 03, 2021
    • Cam Saul's avatar
      Add NOT NULL constraint to Card.database_id; attempt to set database_id if possible (#18472) · 83de3e86
      Cam Saul authored
      * Drop long-unused Table.entity_name column
      
      * Add NOT NULL constraint to Card.database_id
      
      * Test fix :wrench:
      
      * Test fix :wrench:
      
      * Fix migration
      
      * Add note about H2 shell to deps.edn
      
      * Add new SQL migration to attempt to set database_id when unset
      
      * Remove data migration that is now done in Liquibase land
      
      * Oops, '$.database', not '$.database_id'
      
      * Parse ints as signed rather than unsigned just to be safe (they *might* be -1337 if they're really broken)
      
      * Don't run for H2
      
      * Update comment
      
      * Fix migration indentation
      
      * Clean namespace
      
      * Use new migration number.
      
      * Use the new migration numbers
      
      * Adopt new migration numbering scheme
      
      * Fix comments
      
      * Fix MySQL + MariaDB insanity
      
      * Fix ID range validation
      
      * Actually 382 is the last legacy ID
      
      * Improved validation and tests
      
      * Adopt the new-new migration ID format.
      
      * Test fixes :wrench:
      
      * Fix merge
      
      * Simplify precondition
      Unverified
      83de3e86
  28. Nov 01, 2021
  29. Oct 29, 2021
  30. Oct 26, 2021
Loading