This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 30, 2023
-
-
Mahatthana (Kelvin) Nomsawadi authored
This is because `source-field` was missing from a field dimension.
-
Alexander Polyankin authored
-
- May 29, 2023
-
-
Case Nelson authored
* Add initial filterable columns implemenation * Implement filterable-columns Change filters to return internal clauses rather than external operators * Add comments
-
metamben authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Noah Moss authored
-
Cal Herries authored
Hydrate whether actions are enabled/disabled for the database on action dashcards instead of using GET /api/database/:id (#31021) --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
metamben authored
-
Nemanja Glumac authored
-
Anton Kulyk authored
-
Filipe Silva authored
See https://www.kenmuse.com/blog/avoiding-dubious-ownership-in-dev-containers/ for details on how this happens with containers. Fix #30865
-
Filipe Silva authored
Fix #14964
-
Filipe Silva authored
Fix #26402
-
Cal Herries authored
-
- May 27, 2023
-
-
shaun authored
disable submit button in /admin/databases/<id> if fields unchanged
-
- May 26, 2023
-
-
Mark Bastian authored
We use async to monitor ddl execution for MySQL since it does not have the concept of a (non-select) statement timeout. @snoe had originally set this to 10 minutes, but (we believe) this was causing tests to run exceptionally long and 30 seconds felt more reasonable. After receiving customer feedback that we actually do need longer timeouts, we are restoring the timeout to 10 minutes. Links containing context: - https://github.com/metabase/metabase/pull/23443 - https://github.com/metabase/metabase/pull/27858 - https://metaboat.slack.com/archives/CKZEMT1MJ/p1685128597747419 Fixes #31102
-
Denis Berezin authored
* Update underlying records drill - bring to top, label changes (#29984) * Zoom in Drill (#30208) * Add updated zoom drill title * Fix e2e tests * Add title unit tests * Fix for Records drill UI when it is the only one displayed * Review fixes * Add pivot drill common popover (#30275) * Add grouping for Pivot drill options * Reuse filterField type * Fix date formatting after rebase * Move Automatic insight action to a common popover (#30370) * Refactor ChartClickActionsView, reuse it component in drills (#30706) * 26836 separate views for quick cell click filters (#30532) * Added separate views for QuickFilterDrill * Add tests, fix styles issues * 26836 contains/does not contain quick filter for tables (#30778) * Add contains/does not contain quick filter for tables * Self review fixes * Fix for column header filter search options cropped * Fix for icon margin difference for contains / does not contain filters * Fix contains filter actions icon styles * Add quick filters support for aggregated queries * Not show contains filter for joined fields * Fix typecheck * Adjust string field quick filter section title to have column name (#30888) * 26836 Add View details action for quick filters (#30967) * Add View details action to quick filters * Self review fixes * Fix e2e tests * Fix review issues
-
Aleksandr Lesnenko authored
* fix the question description icon placement in the collection view * fix specs
-
metamben authored
-
Aleksandr Lesnenko authored
-
Cam Saul authored
* Fix `:convert-timezone` and `:get-week` schemas * Make sure moment-timezone stuff gets loaded in Cljs
-
Cam Saul authored
* MLv2: TS wrappers for `fields` and `withFields`; minor tweaks * Fix type declaration
-
lbrdnk authored
* Fix native source query handling for mongo * Add test for mongo nested native query * Fix mongo `aggregation-at-index` usage * Add test for source query with aggregation and sort * Adjust test for presto and oracle * Add PR suggestions
-
Natalie authored
-
Braden Shepherdson authored
This has never worked (see #11371) and produces bad results which group by every individual value of the column, rather than binning/bucketing correctly. This can theoretically be supported, but needs BE work to construct correct queries. To be addressed after MLv2.
-
Nemanja Glumac authored
* Install `replay.io` library * Register `replay.io` in the Cypress config * Run E2E tests using Replay chromium browser but only in CI * Upload Replay.io recordings to the dashboard * Manually install Replay.io browser * Always upload recordings * Pass in a custom test run id * Disable asserts and send replays to a separate team * Upload OSS recordings as well * Use specific Ubuntu version * Record and run Replay.io on `master` only * Do not toggle CI browsers in the config * Test run: pass `replay-chromium` browser as CLI flag in a run * Fix multi-line command * Use replay plugin conditionally * Set the flag correctly * Require node process * Remove sourcemap vars * Record using replay.io on schedule * Explicitly name replay runs --------- Co-authored-by:
Jaril <jarilvalenciano@gmail.com>
-
Ngoc Khuat authored
* Dashboard Tab entity (#29802) * add dashboard tab entity * Dashboard tabs CRUD (#29861) * Dashboard tabs frontend (#30189) * rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx` commit-id:7cdfd86a * add tabs to dash commit-id:d3c2fa74 * improve code structure and other fixes * rename `dashboardtab_id` to `dashboard_tab_id` * remove explicit `position` logic * improve code quality * add renaming functionality * add two new tabs when creating first tab * hide tabs if there is only one * add unit test for `DashboardTabs` component * refactor * fix type errors * add `tabId` to text cards * add `tabId` to link cards * add `tabId` to action button * use disabled state when only one tab remains * refetch cards with filter value when changing tabs * add e2e test * fix broken e2e tests * add horizontal scrolling * fix unit test * fix create tab button being on right * fix performance issue when switching tabs * add `ttag` to `tabs.ts` * use `aria-label` in e2e test helper * fix type error after rebasing * making ordered_tabs optional for tests purposes * fix failing unit tests * fix failing e2e tests * fix flaky revision history e2e test * fix type error after merging feature branch with master and rebasing * fix revisions unit test * fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * migrating revision logic to BE * handle description for multiple cards add/remove * test fixes * adds tests * make sures events are started so tests work * remove additional `:maybe` that was added while rebasing * add title and has_multile_changes to revision * fixes potential test flake * more tests * remove debug code * handles collection change description in card and dashboard * fixes fail to build * use backend for revision history (#30772) * use BE response for revision history * update `service.unit.spec.js` * sort revision and moderation events for question timeline * test fixes * create revision directly instead of via API to avoid flake * reverted to an earlier revision => reverted to an earlier version * translate the model name too * Rename functions: - diff-strs -> diff-strings - diff-strings -> diff-strings* - diff-strings* -> diff-string * move the diff to diff-strings* * use case instead of map for model-str->i18n-str * remove title from API response * do not translate test model * rename var `title_text` to `titleText` * address comments * stringify the display name * fix revert button not working * add loading wrapper to fix unit test * fix tests * fix type error * fix QuestionActivityTimeline test * add a dot for edited this --------- Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu>
-
Alexander Polyankin authored
-
Kamil Mielnik authored
* Add a test case for #28981 * Always open ActionParametersInputModal when clicking an action - update unit tests to reflect this behavior
-
Cal Herries authored
* Fix not being able to Enable/Disable Actions when Choose when syncs and scans happen is Enabled * Fix test
-
Kamil Mielnik authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
Uladzimir Havenchyk authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Consolidate auto-apply filters toggle action (#30978) So that when we start tracking the event on Snowplow, we can only do that in a single place. * Track disabling auto-apply filters in Snowplow (#30987) * Fix dashboard ID type
-
Nemanja Glumac authored
-
- May 25, 2023
-
-
metamben authored
-
Cam Saul authored
-
Nick Fitzpatrick authored
-
bryan authored
* fix h2 audit db syncs - typo: s/default-admin-db-id/default-audit-db-id/g - print db id without locale settings in `name-for-logging` - we probably never had a database with and id > 1000, but it would print like "1,000" in logs. - remove 2 more `defendpoint-schema` forms * adds making sure creating spec for *application-db* doesn't fail * Fixes test to only run when ee-avaliable, and only check for no throwing - Also handle case where manuall deleting the database doesn't delete the matching permissions (the path aka object is the same) * linter fix * fix linter error over deprecated hx namespace * add some test logging * update requires * remove logging, continue testing: - db->pooled-connection-spec - connection-details->spec * make sure we call the right ensure-audit-db-installed! * use mbc/ensure-audit-db-installed! directly * clean up test ns + fix clj-kondo linting * tie audit-db creation to running ee edition
-