Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 06, 2024
    • Raphael Krut-Landau's avatar
    • lbrdnk's avatar
      Move database role to url parameters from connection properties on Snowflake (#43602) · 4a88a0c8
      lbrdnk authored
      * Move role to url parameters from connection properties
      
      * Fix test
      Unverified
      4a88a0c8
    • Ryan Laurie's avatar
      Update translations for v50 and add Danish Language Support (#43314) · 2cdae6bc
      Ryan Laurie authored
      * update translations for v50
      
      * add Danish
      
      * update translations for v50 release
      
      * alphabetical order is nice
      Unverified
      2cdae6bc
    • Ryan Laurie's avatar
      Consolidate joins specs (#43717) · 7a9767e1
      Ryan Laurie authored
      Unverified
      7a9767e1
    • Ryan Laurie's avatar
      Consolidate dashboard-card specs (#43716) · 3d1cbd3b
      Ryan Laurie authored
      Unverified
      3d1cbd3b
    • metamben's avatar
      Hydrate can_run_adhoc_query and address review comments (#43747) · 8eeacc60
      metamben authored
      This is a followup on #43625.
      Unverified
      8eeacc60
    • adam-james's avatar
      Multi Series Dashcards Render with Filters Applied To All Series (#43428) · b8907454
      adam-james authored
      
      * Multi Series Dashcards Render with Filters Applied To All Series
      
      Fixes: #39083
      
      Multi-series dashcards now properly render when a subscription is set up with filters that impact the values of each
      card in the multi-series card.
      
      * Small refactor for executing dashcards in a pulse context.
      
      - move execute-dashboard-subscription to pulse.util
      - this fn now will also execute all card series cards
        and put those results into a list on the key :series-results in the dashcard
        which is then used in the render multimethod to send the correct data to the javascript context
      
      A small todo was taken care of as well, we can now use :dashboard-subscription in the :context key
      
      * Fix up render fn
      
      The shape of hte data going into the javascript was a bit unclear before. This keeps things a little more
      understandable.
      
      Next step is probably to create some Malli schemas inside the js_svg namespace to document and enforce the needed data shapes
      
      * pull :data up a level from :result in the series cards
      
      * Update src/metabase/pulse/render/body.clj
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * Remove unneeded let
      
      * set/rename-keys won't work here because we raise the :data key
      
      I've realised a suggested change to just use set/rename-keys won't do what we need. We need instead to raise :data
      from within the result key up to the same level (and dissoc result).
      
      I've renamed the helper function to make its purpose a bit clearer
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      Unverified
      b8907454
    • Alex Yarosh's avatar
      update list of releases (#43754) · 60bb8d61
      Alex Yarosh authored
      Unverified
      60bb8d61
    • Ryan Laurie's avatar
      use correct github api for CI (#43750) · 5a481f98
      Ryan Laurie authored
      Unverified
      5a481f98
    • Sloan Sparger's avatar
      Upgrade to TypeScript v5.4 (#43736) · 18d5388d
      Sloan Sparger authored
      Unverified
      18d5388d
    • Raphael Krut-Landau's avatar
    • Aleksandr Lesnenko's avatar
      make compact formatting consistent across all series (#43472) · b9c10c51
      Aleksandr Lesnenko authored
      * make compact formatting consistent across all series
      
      * fix rebase
      Unverified
      b9c10c51
    • metamben's avatar
      Batch load card metadata (#43625) · 2bfaab28
      metamben authored
      Unverified
      2bfaab28
    • github-automation-metabase's avatar
    • Mahatthana (Kelvin) Nomsawadi's avatar
    • Ngoc Khuat's avatar
    • Alexander Solovyov's avatar
    • Jeff Bruemmer's avatar
      docs - models and caching (#43681) · 18581104
      Jeff Bruemmer authored
      Unverified
      18581104
    • Ryan Laurie's avatar
      Backport reminder bot (#43637) · 01840901
      Ryan Laurie authored
      * WIP backport reminder bot
      
      * polish and automate backport reminder
      
      * do better english
      Unverified
      01840901
    • Ryan Laurie's avatar
      Fix OSS tests in CI (#43660) · 4b66bdba
      Ryan Laurie authored
      * fix OSS tests in CI
      
      * update tests that went on vacation for a while
      
      * do safer cypress things
      
      * better helper name
      Unverified
      4b66bdba
    • Oisin Coveney's avatar
    • Alexander Polyankin's avatar
      Fetch ad-hoc query metadata on the BE (#43675) · 855c840b
      Alexander Polyankin authored
      * adhoc-query-metadata
      
      * Get ad-hoc query metadata from the BE
      
      * Fix broken ad-hoc queries
      
      * Fix broken ad-hoc queries
      
      * Fix tests
      
      * Add a test
      
      * Add tests
      
      * Add tests
      
      * Fix whitespace
      
      * Fix whitespace
      
      * Fix tests
      Unverified
      855c840b
    • Kamil Mielnik's avatar
      Analytic events for time-over-time comparison (#43589) · 49360f68
      Kamil Mielnik authored
      
      * Sort functions
      
      * Add boilerplate for aggregateOffset and tests
      
      * Simplify assertion
      
      * Make basic case work
      
      * Handle name generation
      
      * Do not require "lib/uuid" attribute to be present since MLv2 will normalize it under the hood anyway
      
      * Fix typing
      
      * Group tests
      
      * Refactor offsetClause to return a new clause instead of a new query
      - Move offsetClause to expressions.ts
      - Add assertion
      
      * Revert "Sort functions"
      
      This reverts commit ab9ce2b24ea6bdad5ff7e9bed8ef38d4b5923f00.
      
      * Move tests
      
      * Handle names dynamically
      
      * Shorten a test
      
      * Update comment
      
      * Add TODO
      
      * Update expression types
      
      * Add diffOffsetClause & percentDiffOffsetClause
      
      * Add a test for diffOffsetClause
      
      * Add TODOs
      
      * Add tests for diffOffsetClause and percentDiffOffsetClause
      
      * Unwrap tests
      
      * Add skeleton for new tests
      
      * Refactor first offsetClause tests
      
      * Add tests for names
      
      * Fix case of non-datetime columns
      
      * Handle a case with offset < 1 and no breakouts
      
      * Handle a case with offset < 1 and breakouts on non-datetime column
      
      * Handle a case with offset < 1 and breakouts binned datetime column
      
      * Handle a case with offset < 1 and breakout on non-binned datetime column
      
      * Refactor
      
      * Refactor
      
      * Remove TODO
      
      * Add tests for diffOffsetClause
      
      * Add tests for percentDiffOffsetClause
      
      * Move offset stuff to offset.ts and offset.unit.spec.ts
      
      * Use template string for prefixes
      
      * Use breakoutColumn + isDate to check column type
      
      * Refactor
      
      * Fix error message
      
      * Add boilerplate for CompareAggregations
      
      * Fix title
      
      * Render aggregations list
      
      * Style AccordionList
      
      * Sort props
      
      * Fix bucket name
      
      * Use displayName instead shortName
      
      * Support parseValue prop in NumberInput
      
      * Add period input accepting integers only
      
      * Accept non-negative values only
      
      * Do not accept zeros
      
      * Add state
      
      * Add submit button
      
      * Export offset functions via Lib
      
      * Make it possible to skip rightSection
      
      * Add column picker
      
      * Map offset user input to api input (negative value)
      
      * Add label
      
      * Fix crash
      
      * Extract shouldCreate
      
      * Make onSelect in AggregationPicker support multiple values
      
      * Extract ReferenceAggregationPicker
      
      * Extract ColumnPicker
      
      * Extract getAggregations
      
      * Rename
      
      * Add custom items
      
      * Refactor item component
      
      * Extract OffsetInput
      
      * Remove unused data-testid
      
      * Style OffsetInput
      
      * Generate titles according to specs
      
      * Generate label
      
      * Generate help
      
      * Extract utils
      
      * Use different width for the 1st step
      
      * Format code
      
      * Use MultiSelect directly
      
      * Avoid custom parseValue
      
      * Revert MultiaAutocomplete changes
      
      * Improve typing in describeTemporalInterval and
       describeRelativeDatetime
      
      * Use describeTemporalUnit to pluralize
      
      * Use interface
      
      * Avoid setting value as DOM attribute
      
      * Fix test
      
      * Add onAdd prop to AggregationPicker and revert the change to have onSelect pass multiple aggregations
      
      * Reduce number of props
      
      * Render checkboxes in custom items
      
      * Introduce and use --mb-color-brand-lighter
      
      * Avoid !important
      
      * Remove redundant prop
      
      * Rename ExtractColumn to ExtractColumnAction
      
      * Add lines.svg
      
      * Fix positioning in case dir attribute is not present in any parent component
      
      * Add CompareAggregationsAction
      
      * Fix warning about isSelected being used as DOM attribute
      
      * Fix positioning in case dir attribute is not present in any parent component
      
      * Remove redundant Box
      
      * Compute the title
      
      * Add compareAggregationsDrill boilerplate
      
      * Add compare-aggregations drill stub
      
      * Update comment
      
      * Compute title and aggregation
      
      * Add TODO
      
      * Use proper title when there's only 1 aggregation
      
      * Show visualization on submit
      
      * Limit aggregation choice to 1 in compare aggregations drill
      
      * Redirect to chart upon submission
      
      * Do not navigate to chart view
      
      * Do not navigate to chart view
      
      * Make drill-thru tests expect the new compare-aggregations drill
      
      * Add type attribute to all ListItems
      
      * Add aggregationIndex to drillInfo
      
      * Add aggregationDrillDetails and wire it up
      
      * Add tracking helpers
      
      * Add new schema
      
      * Add tracking in column header
      
      * Add tracking in plus modal
      
      * Add tracking in aggregation picker
      
      * Fix destructuring
      
      * Add functionsUsedByExpression
      
      * Fix schema number
      
      * Add tests boilerplate
      
      * Implement test for notebook editor
      
      * Add test for column header
      
      * Add a test for summarize sidebar
      
      * Add a test for the plus button
      
      * Add expectNoBadSnowplowEvents call in afterEach
      
      * Format code
      
      * Add missing redux store state in tests
      
      ---------
      
      Co-authored-by: default avatarBraden Shepherdson <braden@metabase.com>
      Unverified
      49360f68
    • Kamil Mielnik's avatar
      Time-over-time comparison - Unit tests (#43653) · 54d9fb22
      Kamil Mielnik authored
      * Use createQueryWithClauses in createQueryWithCountAggregation
      
      * Support column-specific aggregations in createQueryWithClauses
      
      * Add tests for compare option presence
      
      * Fix case
      
      * Add a test for onAdd
      
      * Split tests
      
      * Rename tests
      
      * Add boilerplate for CompareAggregations unit tests
      
      * Fix assertion
      
      * Add more tests
      
      * Add offset input tests
      
      * Add tests
      
      * Update frontend/src/metabase/query_builder/components/CompareAggregations/CompareAggregations.unit.spec.tsx
      
      * Update tests after merge
      
      * Use constants instead of factory functions
      Unverified
      54d9fb22
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Followed-up tasks for changelog generation (#43656) · ac6bb7b4
      Mahatthana (Kelvin) Nomsawadi authored
      * Check git tag for an exact match
      
      * Set npm publish to dry run, so I can test
      
      * Uses new github automation account for creating a PR
      
      * Remove unnecessary step
      
      * Automatically set `no-backport` on the SDK doc version bump PR
      
      * Fix step to edit PR with correct permission
      
      * Remove npm dry run after finished testing
      Unverified
      ac6bb7b4
  2. Jun 05, 2024
    • Denis Berezin's avatar
      feat(sdk): SDK theming part 4 - danger, dark, error, filter, focus, saturated, shadow (#43608) · e430b776
      Denis Berezin authored
      * Migrate danger
      
      * Migrate dark
      
      * Migrate error
      
      * Migrate filter
      
      * Migrate focus
      
      * Migrate saturated
      
      * Migrate shadow
      
      * Fix CI
      
      * Fix CI
      
      * Fix CI
      Unverified
      e430b776
    • metamben's avatar
      Unverified
      0ade074b
    • Ryan Laurie's avatar
    • Denis Berezin's avatar
      feat(sdk): SDK theming part 3 - brand, brand-light, brand-lighter (#43598) · 6fcbf23e
      Denis Berezin authored
      * Migrate brand
      
      * Migrate brand-light, brand-lighter
      
      * Fix unit tests
      
      * Code review fixes
      
      * Fix CI
      Unverified
      6fcbf23e
    • Jesse Devaney's avatar
      Fix column scaling ("Multiply by a number") bugs (#43668) · 6ac4fe97
      Jesse Devaney authored
      * return empty string so non-empty labels do not get hidden by empty labels
      
      * fix function name
      
      * apply scaling in transformed dataset
      
      * add missing option to OptionsType
      
      * fix double scaling
      
      * add column scaling to waterfall transformed dataset
      
      * add column value scaling to dataset transform
      
      * fix stacked bar segment labels not responding to column scaling
      
      * fix tooltip values displayed
      
      * since scaling as added to transformedDataset, use transformedDataset for formatters
      
      * revert changes to display percentage instead of absolute value
      
      * fix stacked data labels
      
      * add loki variant for custom y-axis range with column scaling
      
      * fix stack segmented label formatters compact calculation
      
      * scale original dataset and use that instead of modifying transformedDataset
      
      * update loki snapshots
      
      * fix scatter plot dataset scaling
      
      * fix tooltip values being double scaled
      
      * add E2E test to validate behavior
      
      * add helper for not duplicating the column scaling
      
      * port multiple y-axis metrics with column scaling fixes to RowChart
      
      * add waterfall and scatterplot loki variants
      
      * fix type errors and failing unit tests
      
      * fix failing unit tests
      
      * update loki snapshots
      Unverified
      6ac4fe97
    • Nemanja Glumac's avatar
      Add E2E reproduction for #39150 (#43610) · 5bf50a21
      Nemanja Glumac authored
      * Add E2E reproduction for #39150
      
      * Fix typo in the test title
      
      * Move the viewport config to the `describe` block
      
      * Add the second repro scenario as per the review comment
      
      * Scope the variable to the relevant test
      Unverified
      5bf50a21
    • Anton Kulyk's avatar
      Fix long field names handling for series names and in the model editor (#43394) · c7c5b356
      Anton Kulyk authored
      * Fix long names in model editor
      
      * Fix long names in series name input
      Unverified
      c7c5b356
    • Alexander Polyankin's avatar
      Performance fix for getUrlWithParameters when there are no parameters (#43626) · 13aae663
      Alexander Polyankin authored
      * Simple performance fix for getUrlWithParameters
      
      * Fix tests
      Unverified
      13aae663
    • Jeff Bruemmer's avatar
      column heading options (#43409) · f05fa8e6
      Jeff Bruemmer authored
      Unverified
      f05fa8e6
    • Dennis Schridde's avatar
      Expose `attached-dwh` token feature flag to frontend (#43657) · 937e30fb
      Dennis Schridde authored
      This allows frontend code to conveniently check whether the feature
      flag is enabled or disabled.  This is in addition to the raw flag's
      presence (or absence) in `(:features token-status)`.
      
      References: https://github.com/metabase/metabase/issues/42381
      References: https://github.com/metabase/metabase/pull/43511
      Unverified
      937e30fb
    • Denis Berezin's avatar
      feat(sdk): SDK theming part 2 - bg-error, bg-medium, bg-night, bg-white, border (#43512) · 8659846f
      Denis Berezin authored
      * Migrate bg-error
      
      * Migrate bg-medium
      
      * Migrate bg-night
      
      * Migrate bg-white
      
      * Migrate border
      
      * Fix CI
      
      * Fix unit tests
      
      * Fix unit tests
      
      * Code review fixes
      
      * Code review fixes
      Unverified
      8659846f
    • Chris Truter's avatar
    • Chris Truter's avatar
      Unverified
      2a260cc9
    • Kamil Mielnik's avatar
      Previous period comparison shortcut in chill mode - column headers (#43500) · f61a0657
      Kamil Mielnik authored
      
      * Sort functions
      
      * Add boilerplate for aggregateOffset and tests
      
      * Simplify assertion
      
      * Make basic case work
      
      * Handle name generation
      
      * Do not require "lib/uuid" attribute to be present since MLv2 will normalize it under the hood anyway
      
      * Fix typing
      
      * Group tests
      
      * Refactor offsetClause to return a new clause instead of a new query
      - Move offsetClause to expressions.ts
      - Add assertion
      
      * Revert "Sort functions"
      
      This reverts commit ab9ce2b24ea6bdad5ff7e9bed8ef38d4b5923f00.
      
      * Move tests
      
      * Handle names dynamically
      
      * Shorten a test
      
      * Update comment
      
      * Add TODO
      
      * Update expression types
      
      * Add diffOffsetClause & percentDiffOffsetClause
      
      * Add a test for diffOffsetClause
      
      * Add TODOs
      
      * Add tests for diffOffsetClause and percentDiffOffsetClause
      
      * Unwrap tests
      
      * Add skeleton for new tests
      
      * Refactor first offsetClause tests
      
      * Add tests for names
      
      * Fix case of non-datetime columns
      
      * Handle a case with offset < 1 and no breakouts
      
      * Handle a case with offset < 1 and breakouts on non-datetime column
      
      * Handle a case with offset < 1 and breakouts binned datetime column
      
      * Handle a case with offset < 1 and breakout on non-binned datetime column
      
      * Refactor
      
      * Refactor
      
      * Remove TODO
      
      * Add tests for diffOffsetClause
      
      * Add tests for percentDiffOffsetClause
      
      * Move offset stuff to offset.ts and offset.unit.spec.ts
      
      * Use template string for prefixes
      
      * Use breakoutColumn + isDate to check column type
      
      * Refactor
      
      * Fix error message
      
      * Add boilerplate for CompareAggregations
      
      * Fix title
      
      * Render aggregations list
      
      * Style AccordionList
      
      * Sort props
      
      * Fix bucket name
      
      * Use displayName instead shortName
      
      * Support parseValue prop in NumberInput
      
      * Add period input accepting integers only
      
      * Accept non-negative values only
      
      * Do not accept zeros
      
      * Add state
      
      * Add submit button
      
      * Export offset functions via Lib
      
      * Make it possible to skip rightSection
      
      * Add column picker
      
      * Map offset user input to api input (negative value)
      
      * Add label
      
      * Fix crash
      
      * Extract shouldCreate
      
      * Make onSelect in AggregationPicker support multiple values
      
      * Extract ReferenceAggregationPicker
      
      * Extract ColumnPicker
      
      * Extract getAggregations
      
      * Rename
      
      * Add custom items
      
      * Refactor item component
      
      * Extract OffsetInput
      
      * Remove unused data-testid
      
      * Style OffsetInput
      
      * Generate titles according to specs
      
      * Generate label
      
      * Generate help
      
      * Extract utils
      
      * Use different width for the 1st step
      
      * Format code
      
      * Use MultiSelect directly
      
      * Avoid custom parseValue
      
      * Revert MultiaAutocomplete changes
      
      * Improve typing in describeTemporalInterval and
       describeRelativeDatetime
      
      * Use describeTemporalUnit to pluralize
      
      * Use interface
      
      * Avoid setting value as DOM attribute
      
      * Fix test
      
      * Add onAdd prop to AggregationPicker and revert the change to have onSelect pass multiple aggregations
      
      * Reduce number of props
      
      * Render checkboxes in custom items
      
      * Introduce and use --mb-color-brand-lighter
      
      * Avoid !important
      
      * Remove redundant prop
      
      * Rename ExtractColumn to ExtractColumnAction
      
      * Add lines.svg
      
      * Fix positioning in case dir attribute is not present in any parent component
      
      * Add CompareAggregationsAction
      
      * Fix warning about isSelected being used as DOM attribute
      
      * Fix positioning in case dir attribute is not present in any parent component
      
      * Remove redundant Box
      
      * Compute the title
      
      * Add compareAggregationsDrill boilerplate
      
      * Add compare-aggregations drill stub
      
      * Update comment
      
      * Compute title and aggregation
      
      * Add TODO
      
      * Use proper title when there's only 1 aggregation
      
      * Show visualization on submit
      
      * Limit aggregation choice to 1 in compare aggregations drill
      
      * Redirect to chart upon submission
      
      * Do not navigate to chart view
      
      * Do not navigate to chart view
      
      * Make drill-thru tests expect the new compare-aggregations drill
      
      * Add type attribute to all ListItems
      
      * Add aggregationIndex to drillInfo
      
      * Add aggregationDrillDetails and wire it up
      
      * Fix destructuring
      
      * Fix tests
      
      ---------
      
      Co-authored-by: default avatarBraden Shepherdson <braden@metabase.com>
      Unverified
      f61a0657
    • Oisin Coveney's avatar
      Unverified
      5c5f6c39
Loading