This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 12, 2024
-
-
Nick Fitzpatrick authored
* no implicit any on callbacks * cleaning up use of any * small adjustments * PR feedback and unit test adjustment * typing click handler
-
Cal Herries authored
-
Cal Herries authored
-
Cal Herries authored
-
Romeo Van Snick authored
* Add help text icon in expression editor suggestions (#41092) * Add helptext to expression suggestions * Deduplicate getDatabase calls * Allow customising popover width * Split out help text content component * Render an info icon with the help text * Remove duplicated defaults for popover * Explicitly wait for suggestion items in test * Remove commented out code * Use React imports directly * Rename e to evt * Inline getHelpText when creating suggestions * Avoid overlapping content * Remove unnecessary Fragment * Avoid selecting item when clicking link or button inside element * Allow shifting popover * Stop Popover mouse events for bubbling * Use onMouseDown instead of onMouseDownCapture to avoid clicks inside popover from triggering select * Add help text to all suggestions that are know mbql functions * Expression suggestions clean up (#41236) * Move ExpressionEditorSuggestions to tsx * Convert ExpressionEditorSuggestions to functional component * Simplify suggestion match component * Move ExpressionEditorSuggestions a separate folder * Remove default export * Use Popover instead of Tippy for suggestions list * Fix suggestions tests * Remove data-ignore-outside-clicks * Add default for suggestions * Fix e2e test * Move helptext wrapper to ExpressionEditorTextfield * Switch to metabase/ui for Button * Use arrow function
-
Cal Herries authored
-
Oisin Coveney authored
-
Nicolò Pretto authored
* connect the example dashboard id setting to the embedding homepage (#41138) * connect the example dashboard id setting to the embedding homepage * fix types * Update frontend/src/metabase/home/components/EmbedHomepage/StaticTabContent.tsx Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * use isNotNull --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Cam Saul authored
* Fix add-alias-info matching for nominal field literal refs * Minor cleanup * Minimize diff * A bit more cleanup
-
Oisin Coveney authored
Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Nemanja Glumac authored
-
- Apr 11, 2024
-
-
Raphael Krut-Landau authored
-
Cam Saul authored
* Convert `auto-bucket-datetimes` middleware to MLv2 * New Kondo rule time. * Test & lint fixes
* Fix typos * Apply suggestions from code review Co-authored-by:metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .bordered * Migrate .borderBottom, .borderTop * Fix typo * Remove unused classes * Migrate .borderRight * Migrate .borderLeft * Migrate .borderLight * Migrate .borderError * Migrate .borderSuccess * Migrate .borderBrand * Migrate .borderTransparent * Migrate .borderless * Migrate .borderMedium * Review: Add missing CS import
-
Nick Fitzpatrick authored
* collection and db breadcrumbs * compact breadcrumbs * adding navigation keybindings * recent_views and search changes to always include collection or db name * removing breadcrumbs, display parent name * removing unneeded components * e2e and FE unit tests * waitFor * e2e tests for keybindings * help * be tests passing * PR feedback and type adjustments * unit test adjustment
-
Jeff Bruemmer authored
* drop note on sandboxes * model caching * reinstate model caching sandbox warning
-
Chris Truter authored
* Test created_at and schema fields * Coerce nil schema to empty string
-
Oisin Coveney authored
Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Alexander Polyankin authored
* Replace AlertApi * Replace AlertApi * Replace AlertApi * Fix bugs * Fix bugs * Fix typo --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
dependabot[bot] authored
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.11 to 6.2.1. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](https://github.com/isaacs/node-tar/compare/v6.1.11...v6.2.1 ) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
Chris Truter <chris@metabase.com>
-
Uladzimir Havenchyk authored
-
Cal Herries authored
-
Uladzimir Havenchyk authored
-
Oisin Coveney authored
-
Nemanja Glumac authored
* Keep the original question name in the save modal where possible Resolves #41196 * Update tests * Append "- Modified" to a suggested question name * Preserve the original question description * Address reviews - adjust the translation string * Add E2E reproduction * Remove extra space * Improve assertions
-
Nicolò Pretto authored
* .eslintrc -> .eslintrc.js * This might work? * add env for linting css modules class names * avoid extending postcss-modules/recommended, specify just the used rule instead * add missing . on comment * Remove unused .detailName references * Fix ManageApiKeys and GuiQueryEditor * Fix SettingText and DashboardControls * fix missing textUnspaced class * remove usave of S.headerButton, that's actually never used because we never pass headerLink to ReferenceHeader * Remove flexNoShrink --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Kamil Mielnik authored
-
- Apr 10, 2024
-
-
Raphael Krut-Landau authored
-
adam-james authored
* Fix embed download endpoint We have added format_rows as a query parameter. In most endpoints this just works fine. Here, however, the problem is that we use query parameters to pass parameter values. We run some validation over these provided parameter values (eg. don't allow a user to over ride a 'locked' parameter). Since we have these 2 different use cases for query parameters, the validation was failing on :format_rows, which isn't expected to exist at all. Here, I dissoc the :format_rows key prior to this validation step, so normal validation can continue. * Add test that uses this card embedding endpoint
-
Alexander Solovyov authored
-
dpsutton authored
* Nested queries have limits which can defeat their purpose Consider a query ```sql select count(*) from {{#199}} ``` This query should return the number of distinct rows in the query defined by 199. But it's actually limited by the excel limit of 1048575. And that's because when the value of `{{#199}}` is expanded it has that limit applied as normal. ```clojure qp=> (let [card-id 199] ;; use a valid card id for you (-> {:database 1, :type :native, :native {:query "select count(*) from {{ref}}" :template-tags {:ref {:card-id card-id :type :card :name "ref" :display-name "ref"}}} :middleware {:disable-max-results? true}} qp.compile/compile :query (metabase.db.query/format-sql ) println)) select count(*) from ( SELECT "PUBLIC"."ORDERS"."ID" AS "ID", "PUBLIC"."ORDERS"."TOTAL" AS "TOTAL" FROM "PUBLIC"."ORDERS" LIMIT 1048575 ) ``` But we can suppress this limit when substituting a query inside yielding ```sql select count(*) from ( SELECT "PUBLIC"."ORDERS"."ID" AS "ID", "PUBLIC"."ORDERS"."TOTAL" AS "TOTAL" FROM "PUBLIC"."ORDERS" ) ``` And this is proper because we want to limit the _outer_ query, not internal queries. * Remove limit from test expectation * stupid trailing space * another subquery test * Use helper function to disable limit middleware
-
Cal Herries authored
-
dpsutton authored
* Fix #39138 again Fixes #40934 Got unfixed somehow in #40578. seems like some file renames caught it off guard But the long and short is that its possible for a persisted model to end up in the state "refreshing" (possible an instance restart during refreshing). The refreshing job doesn't look for these so they become effectively invisible. Since the job to refresh them will only run one at a time cluster wide, any jobs that are in the "refreshing" state when the refresher begins to refresh are necessarilly stuck (no one else could currently be refreshing them). So we can just add them to the queue of models to refresh. ```clojure (jobs/defjob ^{org.quartz.DisallowConcurrentExecution true ;; <---- :doc "Refresh persisted tables job"} PersistenceRefresh [job-context] (refresh-job-fn! job-context)) ``` * Ensure ee/oss pathways are taken in tests Annoying little footgun here. CI does not run with an ee token, so in order to ensure that test pathway goes through ee version of a defenterprise we _must_ use the `mt/with-premium-features {:cache-granular-controls}`, but we also want to ensure that it goes through the oss version. So two options, a `doseq` on both features (empty set and the feature that triggers this). But want a test in the enterprise folder as well to ensure. The real trickiness comes from running tests at a repl and CLI. My REPL always has an ee token in it. My command line always lacks that as well. So want to be explicit about the token features in effect at test time. That's why I'm essentially duplicating tests (ee in ee folder, oss in regular pathway)
-
Noah Moss authored
-
Tim Macdonald authored
* Support parsing {{variable}}s and such in queries [Fixes #39954] [Fixes #39953]
-
Nick Fitzpatrick authored
* increase activation distance for dashboard parameter dragging * updating drag sensitivity for other places * adjusting e2e tests
-
Cal Herries authored
-
Cal Herries authored
-
Nick Fitzpatrick authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .pointerEventsNone * Remove unused global class * Migrate .faded, .fadeInHover * Migrate .circle * Remove unreachable code * Remove unused props
-