Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 20, 2024
  2. Nov 18, 2024
  3. Nov 14, 2024
  4. Nov 01, 2024
    • Romeo Van Snick's avatar
      Use list picker when searching a single value (#49323) · 896c516d
      Romeo Van Snick authored
      * WIP: use list picker when searching a single value
      
      * Add test case for multi vs non-multi search fields
      
      * Update loki snapshots
      
      * Add special case to test for multiautocomplete filter
      
      * Use single select value in test
      
      * Add test for using list picker
      
      * Explicitly make sure elements are visible
      
      * Do not use list selector when search is disabled
      
      * Add margin to multi autocomplete dropdown
      
      * Update loki snapshots
      
      * Update loki snapshots
      Unverified
      896c516d
  5. Oct 28, 2024
  6. Oct 25, 2024
  7. Oct 23, 2024
    • Anton Kulyk's avatar
      Allow grouping bar chart series into "Other" category (#48265) · dbdef76e
      Anton Kulyk authored
      
      * Add `graph.max_categories` viz setting
      
      * Allow grouping series into "other" category
      
      * Add tooltip
      
      * Toggle "other" series visibility
      
      * WIP: new implementation for `graph.series_order`
      
      * Remove not used function
      
      * Make "other" series a regular `SeriesModel`
      
      * Fix stacked bar charts
      
      * Remove colors from "other" tooltip
      
      * Sort "other" tooltip values
      
      * Update `graph.max_categories` setting
      
      - negative number validation
      - 0 value turns off grouping
      
      * Fix Loki test
      
      * Add basic loki test
      
      * Add loki test for stacked chart
      
      * Add loki test for stacked normalized chart
      
      * slight refactor of series_order setting
      
      * Add screenshots
      
      * Handle different kinds of aggregations for "other"
      
      * Handle different aggregation kinds in tooltips
      
      * Add `graph.other_series_aggregation_fn` viz setting
      
      * Fix type errors
      
      * Fix unit tests
      
      * settings ui
      
      * remove sorting by value to match series order setting, other color
      
      * hide grouped series controls
      
      * Add e2e test
      
      * Update screenshots
      
      * Fix incorrect series grouping for stacked charts
      
      * group series into other settings
      
      * Update e2e test to work with new viz settings
      
      * Disable drills for the "Other" series
      
      * fix max_categories setting popover positioning
      
      * fix total row has misaligned columns on other series values
      
      * Remove redundant `click({ force: true })`
      
      * Rename aggregation fn viz setting
      
      * Move aggregation fn setting to the popover
      
      * WIP
      
      * Update popover
      
      * Fix `it.only`
      
      * Fix legend sync issue
      
      * Disable "Other" category by default (temporary)
      
      * Enable aggregation fn picker for MBQL queries (temporary)
      
      * Move "Other" category summary to a tooltip row
      
      * Add `graph.max_categories_enabled` to viz settings type
      
      * Reuse already computed "Other" value in tooltips
      
      * Add null check
      
      * Fix series length check
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      dbdef76e
  8. Oct 22, 2024
  9. Oct 21, 2024
  10. Oct 17, 2024
  11. Oct 10, 2024
  12. Oct 08, 2024
  13. Oct 07, 2024
  14. Oct 04, 2024
  15. Oct 02, 2024
    • Emmad Usmani's avatar
      add sunburst to pie chart (#47208) · 61e610b3
      Emmad Usmani authored
      * add sunburst to pie chart
      
      * fix type errors
      
      * consider all slice percent values for formatting percent on chart
      
      * fix lint error
      
      * refactor nested functions outside of parent
      
      * create and use getArrayFromMapValues helper
      
      * fix bug with percent significant digits
      
      * improve color picker
      
      * fix total visibility in small dashcards
      
      * fix missing field remappings
      
      * use aggregated value for click behavior
      
      * update minimum slice percentage logic
      
      * fix total text truncation
      
      * remove colors from tooltip for middle and outer slices
      
      * update e2e spec
      
      * update snapshot
      
      * update ring setting titles
      
      * address feedback
      
      * update comment
      Unverified
      61e610b3
  16. Sep 13, 2024
  17. Sep 04, 2024
  18. Aug 30, 2024
  19. Aug 29, 2024
    • Emmad Usmani's avatar
      allow re-ordering and re-naming pie chart slices (#46607) · 0139fd78
      Emmad Usmani authored
      * allow re-ordering and re-naming pie chart slices
      
      * aggregate rows with same dimension value
      
      * show warning when dimension has unaggregated values
      
      * change colors from sidebar
      
      * implement renaming
      
      * styles for slice name widget
      
      * handle numeric slice keys for binned values relative dates etc
      
      * implement slice disabling
      
      * remove old colors setting
      
      * implement merging new and removing existing rows from query results
      
      * fix formatting bugs
      
      * port settings to static viz
      
      * fix bug with unaggregated data
      
      * address todos
      
      * add loki test
      
      * fix measure column settings widget erroring
      
      * fix settings sidebar crashing
      
      * add e2e tests
      
      * update snapshots
      
      * fix pie_chart.cy.spec.js CI-only flakes
      
      * fix #21504 repro failure
      
      * fix click action value
      
      * use nestedSettings instead of seriesSettings
      
      * fix settings sidebar crashing
      
      * fix row with 0 key not being draggable
      
      * fix flaky test
      
      * filter other slices from sidebar
      Unverified
      0139fd78
  20. Aug 27, 2024
  21. Aug 22, 2024
  22. Aug 21, 2024
  23. Aug 19, 2024
  24. Aug 16, 2024
    • Aleksandr Lesnenko's avatar
      use echarts tooltip (#46359) · c6141aa7
      Aleksandr Lesnenko authored
      
      * use ECharts tooltip on cartesian charts
      
      * fix tooltip lag when changing hovered series
      
      * facelift tooltip
      
      * fix static viz crashes due to tooltip option
      
      * facelift
      
      * pie chart echarts tooltip
      
      * facelift
      
      * facelift
      
      * facelift
      
      * tweaks
      
      * e2e specs
      
      * return back the pie other slices tooltip
      
      * more specs
      
      * specs
      
      * fix pie total
      
      * fix tooltip overflow
      
      * fix specs
      
      * fix infinite rerender in embedding mode for charts that have warnings
      
      * Update Loki Snapshots
      
      ---------
      
      Co-authored-by: default avatarMetabase Automation <github-automation@metabase.com>
      Unverified
      c6141aa7
  25. Aug 14, 2024
  26. Aug 13, 2024
  27. Aug 12, 2024
  28. Aug 08, 2024
    • Emmad Usmani's avatar
      automatically use compact formatting for pie chart total (#46505) · a4bec904
      Emmad Usmani authored
      * automatically use compact formatting for pie chart total
      
      * add story and snapshots
      Unverified
      a4bec904
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Follow-up milestone 2 for [Epic] Re-design transparent theme for static... · a4df4eb7
      Mahatthana (Kelvin) Nomsawadi authored
      Follow-up milestone 2 for [Epic] Re-design transparent theme for static embedding and public links (#46491)
      
      * Update new Metabase base colors
      
      * Make hover and selected state consistency
      
      * Fix wrong embed frame border color
      
      * Refactor: extract props
      
      * Fix border color
      
      * Fix pivot table cell hover color
      
      * Fix smart scalar text contrast
      
      * Add smart scalar tests + update text color design
      
      * Theme dashboard card menu
      
      * Remove dashcard action menu tests since they don't work in loki
      
      * Fix storybook background color for dark theme
      
      * Update loki snapshots
      
      * Disable untestable tests
      
      * Make sure all storybook inherit all necessary base styles
      
      * Skip untestable tests
      
      * Update loki snapshots
      Unverified
      a4df4eb7
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Fix unintentional color changes (#46516) · 6fb1e51d
      Mahatthana (Kelvin) Nomsawadi authored
      * Sync storybook colors with the main app
      
      * Fix Metabase badge color
      
      * Fix wrong mixed brand colors
      
      * Add mistakenly removed colors
      
      * Update comments
      
      * Correct `brand-light` color
      
      * Fix wrong Mantine button color when passing `color` prop
      
      * Update loki snapshots
      Unverified
      6fb1e51d
  29. Aug 07, 2024
  30. Aug 05, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [Milestone 2] Re-design transparent theme for static embedding and public links (#46428) · 3d5233bc
      Mahatthana (Kelvin) Nomsawadi authored
      
      * Update popover dark theme on part of ParameterFieldWidget (#45813)
      
      * Add filter visual tests
      
      * Simplify embed CSS colors
      
      * [WIP] theme filter popover
      
      * Move theme to global node, so it affects portal too
      
      * Fix embed colors
      
      * Theme part of ParameterFieldWidget
      
      * Add story for parameter with dropdown
      
      * Update loki snapshots
      
      * Update more popover style
      
      * Update loki snapshots
      
      * Remove outdated snapshots
      
      * Update loki snapshots with production build
      
      * Fix loki not working with `userEvent`
      
      * Theme mantine popover
      
      * Improve dark theme text-brand visibility
      
      * Update loki snapshots from master change
      
      * Fix new colors not working in SDK
      
      * Fix flaky Loki tests
      
      * Filter popover dark theme part 2 (#46284)
      
      * Theme Date all options
      
      * wip add month and year filter
      
      * Fix wrong CSS custom property declaration
      
      * Test hover state
      
      * Update Loki snapshots
      
      * Theme date month and year
      
      * Add quarter and year tests
      
      * Theme date single and date range
      
      * Style relative date
      
      * Update frontend/src/metabase/admin/datamodel/components/filters/pickers/DatePicker/DatePickerHeader.styled.tsx
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Complete theming filter popover night mode (#46365)
      
      * Style unit of time and number widget
      
      * Attempt to fix flaky Loki snapshots
      
      * Address white background checkbox on dark theme
      
      * Style search filter single value
      
      * Fix mis color
      
      * Update snapshots
      
      * Remove duplication on play functions since they're long
      
      * Milestone 2 polishing (#46382)
      
      * Matches the footer padding with header padding
      
      * Update snapshots
      
      * Add E2E to prevent further problem
      
      * Try to reduce flaky Loki tests
      
      * Remove unused color shades (#46421)
      
      * Update no results illustration to work better on dark theme
      
      * Update loki snapshots
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      Unverified
      3d5233bc
    • Kamil Mielnik's avatar
      Update "Clear" and "Reset" buttons (#46050) · 35d9a817
      Kamil Mielnik authored
      * Refactor dashboard helpers to TypeScript
      
      * Reuse existing helper
      
      * Refactor cy.createQuestionAndDashboard to a function helper
      - there was no good place to put it, so I also created new helpers/api directory
      - and I moved all helpers using cy.request (with 1 exception, where a CSV download helper also does a bunch of assertions) in there
      
      * Merge TS command definitions into a single file
      
      * Export types
      
      * Make dashboardDetails optional
      
      * Export StructuredQuestionDetails
      
      * Remove duplicated function
      
      * Extract createNativeQuestion to separate file
      - 1 exported helper per file, no exceptions!
      
      * Reuse const
      
      * Add test for unit of time parameters
      
      * Improve assertions
      
      * Extract createDashboardWithParameters
      
      * Add tests for time parameters
      
      * Fix hardcoded parameter_mappings ids
      
      * Format code
      
      * Extract checkButtonVisible
      
      * Improve test names
      
      * Add tests for location parameters
      
      * Reuse const
      
      * Update test name
      
      * Add WidgetStatusButton
      
      * Add unit tests for WidgetStatusButton
      
      * Rename handler
      
      * Remove redundant assertions
      
      * Add iconSize prop
      
      * Fix styling
      
      * Replace WidgetStatusIcon with WidgetStatusButton
      - Remove WidgetStatusIcon
      
      * Fix tooltip issue
      
      * Fix tooltip for good
      
      * Use default compact button size
      
      * Prevent overflow
      
      * Fix alignment issues in parameter sidebar
      - Remove iconSize prop
      - Simplify StatusConfig
      
      * Update padding in Unit of Time input to make it consistent with other inputs in dashboard parameter sidebar
      
      * Update unit tests
      
      * Rename WidgetStatusButton to WidgetStatus
      
      * Explicitly specify what is a button
      
      * Update helpers in tests
      
      * Update when buttons are displayed according to the new spec, update tests
      
      * Simplify label
      
      * Remove utils
      
      * Adjust padding
      
      * Update reset icon
      
      * Make the button gray when color is undesired
      
      * Remove old definitions
      
      * Add missing export
      
      * Remove unused type
      
      * Add test for location (single value)
      
      * Add test for id (single value)
      
      * Add more assertions
      
      * Add test for id (multiple values)
      
      * Improve name
      
      * Add tests for number (single and multi value)
      
      * Add tests for text (single and multi value)
      
      * Rename file
      
      * Update comment
      
      * Update test name
      
      * Use unique ids
      
      * Use new color name
      
      * Add a test for chevron icons alignment
      
      * Lift className up
      
      * Make types more specific
      
      * Sort attributes
      
      * Revert "Make types more specific"
      
      This reverts commit 2e6994b5.
      
      * Revert "Use new color name"
      
      This reverts commit 2cc68df6.
      
      * Remove TODO
      
      * Introduce editFilter util, refactor chevron assertions to work with any number of chevrons
      
      * Connect label to the default value input in ParameterSettings
      
      * Add a whitespace in the default value label when required "(required)" is shown
      
      * Add parameter sidebar tests for unit of time
      
      * Add parameter sidebar tests for date filters
      
      * Extract checkParameterSidebarDefaultValue
      
      * Add parameter sidebar tests for location - single values
      
      * Add parameter sidebar tests for location - multiple values
      
      * Use constants for test case names
      
      * Add parameter sidebar tests for id parameters - single values
      
      * Add parameter sidebar tests for id parameters - multi values
      
      * Add parameter sidebar tests for number parameters - single values
      
      * Add parameter sidebar tests for number parameters - multi values
      
      * Add parameter sidebar tests for text parameters - single values
      
      * Add parameter sidebar tests for text parameters - multi values
      
      * Extract checkDashboardFilters
      
      * Use checkDashboardFilters in time parameters
      
      * Use checkParameterSidebarDefaultValue in checkDashboardFilters
      
      * Use checkDashboardFilters everywhere
      
      * Sort helpers
      
      * Rename checkDashboardFilters to checkDashboardParameters
      
      * Rename checkOnlyOneButtonVisible to checkStatusIcon
      
      * Add test suite for sql filters, coverage for text filter - single value
      
      * Add a whitespace in the default value label when required "(required)" is shown - SQL filters
      - Similar to 930dd3a5
      
      * Add test suite for sql filters, coverage for number filters
      
      * Add test for sql filters - date
      
      * Remove unused things, rename placeholder to labelOrPlaceholder
      
      * Apply label only to 1 input
      
      * Add test for sql filters - field parameters
      
      * Fix date tests
      
      * Make all sql filters tests work
      
      * Add assertions for required without default in text filters
      
      * Add assertions for required without default in date filters
      
      * Add assertions for required without default in field filters
      
      * Allow clearing required SQL filters without default value
      
      * Add a test to ensure comma-separated numeric values work
      
      * Update unit test
      
      * Update helper
      
      * Update e2e tests
      
      * Use != null and == null checks with defaultValue instead of just checking if its truthy/falsy
      
      * Run `yarn test-visual:loki` and then `yarn loki approve`
      - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069
      
      * Use parameterHasNoDisplayValue to account for empty strings
      
      * Run `yarn test-visual:loki` and then `yarn loki approve` after merging master
      - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069
      
      * Run `yarn test-visual:loki` and then `yarn loki approve`
      - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069
      
      * Run `yarn test-visual:loki` and then `yarn loki approve`
      - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069
      Unverified
      35d9a817
    • Emmad Usmani's avatar
      add both option for pie chart percentages (#46399) · 6eaff50e
      Emmad Usmani authored
      * add both option for pie chart percentages
      
      * create story snapshot
      Unverified
      6eaff50e
Loading