Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 13, 2024
  2. Mar 12, 2024
  3. Mar 11, 2024
    • Ngoc Khuat's avatar
      0b0ea8fe
    • Braden Shepherdson's avatar
      [MLv2] Introduce `swap-clauses` to reorder aggregations, etc. (#39850) · 796256c5
      Braden Shepherdson authored
      This includes some generative testing, since that felt like
      a great way to try all kinds of permutations of swapping clauses.
      
      This also patches `metabase.types/assignable?` to memoize it.
      Deeply nested `assignable?` calls made 100 tests of swapping
      filters take 1600ms rather than the 50-60ms of the other clauses.
      
      I think this is safe and reasonable on memory to cache forever,
      but speak up if you're concerned. There's perhaps O(60) type
      keywords, so `type X type -> Boolean` is a small space impact.
      
      Fixes #39215.
      796256c5
    • Case Nelson's avatar
      [Metrics V2] query processor phase 1 (#39955) · 7a5912e1
      Case Nelson authored
      * [Metrics V2] query processor phase 1
      
      * Use :sources drop and :metric-dimensions for now
      
      * Fix tests, address review comments
      
      * Fix as bug
      7a5912e1
    • Cam Saul's avatar
      Convert QP to MLv2 Part 2 (#39824) · 5bbc0aa7
      Cam Saul authored
      * Keep fetch_source_query.clj
      
      * Copy fetch_source_query.clj into fetch_source_query_legacy.clj
      
      * Set back fetch_source_query.clj file
      
      * Convert QP to MLv2, part 1
      
      * Keep legacy implementation around for time being
      
      * Port thru convert-to-legacy
      
      * expand-macros is converted to legacy
      
      * Test fixes :wrench:
      
      * Test fixes and better keys
      
      * Test fixes
      
      * Test fixes :wrench:
      
      * More test fixes :wrench:
      
      * Test fix? :wrench:
      
      * Wow, maybe I finally fixed everything :wrench:
      
      * Last few test fixes :wrench:
      
      * PR feedback; lib.walk should support splicing in multiple replacement stages
      
      * Update fetch-source-query to use improved lib.walk
      
      * Have I fixed everything now? :wrench:
      
      * Remove stray println
      
      * Another MongoDB fix :wrench:
      
      * Convert QP to MLv2 Part 2
      
      * Remove most of the fetch-source-query-legacy stuff
      
      * Remove the changes to expand-macros for now, we can do that in a follow-on PR.
      
      * Test fix
      
      * Test fix
      
      * TEST FIXES?! :wrench:
      
      * Kondo & test fixes
      
      * Oops, make sure we have the updated tests
      
      * Fixes :wrench:
      
      * Test fixes :wrench:
      
      * Convert resolve-source-table
      
      * Appease Kondo
      
      * Unparallelize the tests
      
      * Another test that shouldn't be parallel
      
      * Make tests more robust
      
      * Test fixes :wrench:
      5bbc0aa7
Loading