Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 20, 2024
    • Jeff Bruemmer's avatar
      docs - requiring a filter (#38813) · ef81cfb6
      Jeff Bruemmer authored
      ef81cfb6
    • Uladzimir Havenchyk's avatar
    • Case Nelson's avatar
      Wrap literals around expression refs (#38886) · 922b1fdc
      Case Nelson authored
      * Wrap literals around expression refs
      
      Fixes #27185
      
      Expression refs need to be handled like field refs as far as type hints
      in opts are concerned. Otherwise we don't pass the correct parameter
      types to the drivers.
      
      * Address pr feedback
      922b1fdc
    • Jesse Devaney's avatar
      use all hidden parameters to determine visibility (#38882) · e5d9913a
      Jesse Devaney authored
      - queryParams: hide_parameters
      - hiddenParameterSlugs
      e5d9913a
    • Jerry Huang's avatar
      Add Creator Sentiment Email task (#38787) · a634189a
      Jerry Huang authored
      
      * Add new email function and send email to creator
      
      * remove debug stuff
      
      * add tests, address comments
      
      * actually add tests
      
      * Update src/metabase/email/messages.clj
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * address comments
      
      ---------
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      a634189a
    • Case Nelson's avatar
      Fixes filters against datetime binned expressions (#38874) · 7f9afb07
      Case Nelson authored
      * Fixes filters against datetime binned expressions
      
      Fixes #33528
      
      Turns out that `mbql/normalize` and `lib/normalize` behaved slightly
      different and `[:expression "abc" {...}]` refs would drop their opts in
      the former path. In order to properly query against binned datetimes
      it's important that expression ref does not lose its type or else the
      optimizer will not see that `time-interval` needs to convert to a
      `between` rather than an `=`.
      
      * Fix test
      
      * Only keep specific keys on expression opts for these expression filters
      
      * Don't run checkin dataset on snowflake or athena
      7f9afb07
    • Uladzimir Havenchyk's avatar
      Rework findColumnIndexForColumnSetting to MLv2 (#37854) · e94ea96a
      Uladzimir Havenchyk authored
      * Rework findColumnIndexForColumnSetting to MLv2
      
      * Throw an error to find all places without query
      
      * Use MLv2 in ChartSettingTable (#38171)
      
      * Add a comment why we can't use mlv2 in chart setting table
      
      * Use mlv2 findColumnIndexForColumnSetting in ChartSettingTableColumns
      
      * Tests completed, so revert throwing
      
      * Use mlv2 findColumnIndexForColumnSetting in object detail (#38170)
      
      * Use mlv2 findColumnIndexForColumnSetting in object detail
      
      * Address review
      
      * Use mlv2 findColumnIndexForColumnSetting in Question (#38169)
      
      * Use mlv2 findColumnIndexForColumnSetting in Question
      
      * Update question tests
      
      * Use mlv2 findColumnIndexForColumnSetting in viz settings (#38172)
      
      * Use mlv2 findColumnIndexForColumnSetting in Table (#38168)
      
      * Cleanup finColumnSettings usage (#38914)
      
      * Fix linting
      e94ea96a
    • Chris Truter's avatar
    • Kamil Mielnik's avatar
    • Kamil Mielnik's avatar
      Align paths in Prettier & ESLint scripts (#38951) · 750638e4
      Kamil Mielnik authored
      * Align ESLint & prettier paths in "lint-stage" & "scripts" in package.json
      
      * Handle ts files in e2e tests
      
      * Manually fix ESLint-reported issues
      
      * Format "lint-prettier-pure" script the same way as "prettier"
      
      * Run "yarn eslint-fix"
      
      * Manually fix remaining issues
      
      * Ignore database files in ESLint as they reference a file that is git-ignored but does exist locally
      
      * Remove duplicated eslint call
      750638e4
    • Kamil Mielnik's avatar
      Include e2e directory in prettier scripts (#38948) · 22684b87
      Kamil Mielnik authored
      * Include e2e directory in prettier scripts
      
      * Run "yarn prettier"
      22684b87
    • lbrdnk's avatar
      Use macro that does pre and post cleanup (#38929) · 21c5df97
      lbrdnk authored
      Swaps with-temporary-setting-values for with-report-timezone-id.
      21c5df97
    • Kamil Mielnik's avatar
      RFC 70 - Automate sorting imports (#33883) · 2aa3cec6
      Kamil Mielnik authored
      * Upgrade eslint-plugin-import
      
      * Configure import/order rule for consistent, predictable imports
      
      * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line"
      
      * Ensure imports are in a single block
      
      * Move or remove informative comments between import statements
      
      * Remove imports-grouping comments
      
      * Configure groups
      - the difference between the default setting is the presence of "internal" group
      
      * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies
      
      * Move comment to the same line as import
      
      * Run "yarn eslint-fix" 5 times
      - Remaining: 16 problems (16 errors, 0 warnings)
      
      * Manually fix imports order in remaining files
      
      * Run "yarn prettier"
      
      * Fix import
      
      * Fix circular dependency
      
      * Fix circular dependency
      
      * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency)
      
      * Re-add accidentally removed code
      
      * Fix typing
      
      * ESLint
      2aa3cec6
    • Kamil Mielnik's avatar
      Fix - Flaky QueryBuilder tests (#38860) · ebb5500c
      Kamil Mielnik authored
      * Use fetchMock.flush() to prevent tests from interfering with each other
      
      * Revert "Use fetchMock.flush() to prevent tests from interfering with each other"
      
      This reverts commit 03f1277cf2bf481ac36db212e15b4f29511a386b.
      
      * Add typing for requests in the redux store
      
      * Fix QueryBuilder flakes by introducing waitForLoadingRequests
      
      * Simplify interface
      
      * Add mocks for requests in redux store, update types
      
      * Simplify code
      
      * Increase timeout
      ebb5500c
  2. Feb 19, 2024
  3. Feb 16, 2024
Loading