This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 20, 2024
-
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
-
Case Nelson authored
* Wrap literals around expression refs Fixes #27185 Expression refs need to be handled like field refs as far as type hints in opts are concerned. Otherwise we don't pass the correct parameter types to the drivers. * Address pr feedback
-
Jesse Devaney authored
- queryParams: hide_parameters - hiddenParameterSlugs
-
Jerry Huang authored
* Add new email function and send email to creator * remove debug stuff * add tests, address comments * actually add tests * Update src/metabase/email/messages.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * address comments --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Case Nelson authored
* Fixes filters against datetime binned expressions Fixes #33528 Turns out that `mbql/normalize` and `lib/normalize` behaved slightly different and `[:expression "abc" {...}]` refs would drop their opts in the former path. In order to properly query against binned datetimes it's important that expression ref does not lose its type or else the optimizer will not see that `time-interval` needs to convert to a `between` rather than an `=`. * Fix test * Only keep specific keys on expression opts for these expression filters * Don't run checkin dataset on snowflake or athena
-
Uladzimir Havenchyk authored
* Rework findColumnIndexForColumnSetting to MLv2 * Throw an error to find all places without query * Use MLv2 in ChartSettingTable (#38171) * Add a comment why we can't use mlv2 in chart setting table * Use mlv2 findColumnIndexForColumnSetting in ChartSettingTableColumns * Tests completed, so revert throwing * Use mlv2 findColumnIndexForColumnSetting in object detail (#38170) * Use mlv2 findColumnIndexForColumnSetting in object detail * Address review * Use mlv2 findColumnIndexForColumnSetting in Question (#38169) * Use mlv2 findColumnIndexForColumnSetting in Question * Update question tests * Use mlv2 findColumnIndexForColumnSetting in viz settings (#38172) * Use mlv2 findColumnIndexForColumnSetting in Table (#38168) * Cleanup finColumnSettings usage (#38914) * Fix linting
-
Chris Truter authored
-
Kamil Mielnik authored
* Align ESLint & prettier paths in "lint-stage" & "scripts" in package.json * Handle ts files in e2e tests * Manually fix ESLint-reported issues * Format "lint-prettier-pure" script the same way as "prettier" * Run "yarn eslint-fix" * Manually fix remaining issues * Ignore database files in ESLint as they reference a file that is git-ignored but does exist locally * Remove duplicated eslint call
-
Kamil Mielnik authored
* Include e2e directory in prettier scripts * Run "yarn prettier"
-
lbrdnk authored
Swaps with-temporary-setting-values for with-report-timezone-id.
-
Kamil Mielnik authored
* Upgrade eslint-plugin-import * Configure import/order rule for consistent, predictable imports * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line" * Ensure imports are in a single block * Move or remove informative comments between import statements * Remove imports-grouping comments * Configure groups - the difference between the default setting is the presence of "internal" group * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies * Move comment to the same line as import * Run "yarn eslint-fix" 5 times - Remaining: 16 problems (16 errors, 0 warnings) * Manually fix imports order in remaining files * Run "yarn prettier" * Fix import * Fix circular dependency * Fix circular dependency * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency) * Re-add accidentally removed code * Fix typing * ESLint
-
Kamil Mielnik authored
* Use fetchMock.flush() to prevent tests from interfering with each other * Revert "Use fetchMock.flush() to prevent tests from interfering with each other" This reverts commit 03f1277cf2bf481ac36db212e15b4f29511a386b. * Add typing for requests in the redux store * Fix QueryBuilder flakes by introducing waitForLoadingRequests * Simplify interface * Add mocks for requests in redux store, update types * Simplify code * Increase timeout
-
- Feb 19, 2024
-
-
Jeff Bruemmer authored
-
Sloan Sparger authored
-
Jeff Bruemmer authored
-
Ryan Laurie authored
-
Alexander Polyankin authored
* Remove legacy query from parameter targets * Fix for native queries * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getPivotColumnSplit to MLv2 * Fix * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * Migrate getParameterTargetField to MLv2 * fix * Another attempt * Another attempt * Another attempt * Another attempt * Another attempt
-
Alexander Polyankin authored
* Migrate getPivotColumnSplit to Mlv2 * Migrate getPivotColumnSplit to Mlv2 * Migrate getPivotColumnSplit to MLv2 * Migrate getPivotColumnSplit to MLv2 * Migrate getPivotColumnSplit to MLv2 * Remove MLv1 breakouts * Remove expressions * Remove expressions * Remove expressions * Remove expressions * Remove expressions * Remove expressions * Fix * Fix tests * Fix tests
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Nicolò Pretto authored
* add getIsEECode selector * isEEBuild function * Revert "add getIsEECode selector" This reverts commit 3fc3fa79a24b73cfc5ba7c8c0be060c5211dc698. * remove isEnterprise * rename plugin to be more explicit
-
Mahatthana (Kelvin) Nomsawadi authored
* Introduce tabs to admin settings * Change route when changing tabs * Reorder whitelabel settings according to the new design * Modify ImageUpload to support value from the setting * Update colors settings copy and style * Update copy in appearance/branding page * Update copy in appearance/conceal-metabase page * Add toggle grouping description * disconnect application colors from chart colors * Update whitelabel/branding copy * Update whitelabel/conceal-metabase toggles * Deprecate the old admin text input widget * Extend the test * Introduce SettingtextInput which uses metabase/ui component * Update Admin Select widget * Convert font Select to metabase/ui * Fix style conflict causing Select dropdown to overflow the page * Prevent repression on other settings page than Appearance * Move landing page (EE) to general settings page * Fix FE type * Fix unit tests * Fix E2E tests * Fix type * Removed commented out code * Fix E2E from master change
-
Anton Kulyk authored
* Implement `dashboard_width_toggled` event * Implement `dashboard_section_added ` event * Add a new snowplow schema file (1-1-4) * Use 1-1-4 schema file
-
Alexander Polyankin authored
-
Oleg Gromov authored
-
- Feb 16, 2024
-
-
Sloan Sparger authored
-
Ryan Laurie authored
-
Jesse Devaney authored
-
Ryan Laurie authored
* add bookmarks fetching hook * hookify collections content * refactor to make everything much prettier
-
Sloan Sparger authored
* impl feature * makes use of existing form components and deletes custom widget * e2e tests * fix lints * fixes lint around Metabase name usage * removed the select keys line to allow for whatever setting to be updated * fix defaulting logic for ldap and jwt, fixes unit test * snip snap snip snap * fix unit and maybe lint tests * fix ldap code * fixes trimming null * fixes e2e ldap tests * e2e progress * breaking local e2e in hopes of fixing ci... --------- Co-authored-by:
Jerry Huang <jhuang37050@gmail.com>
-
Mark Bastian authored
* Add per viz-type card template sizes in x-rays Previously, any card without a size (width or height) set in their yaml definition was set to a default of `default-card-width` or `default-card-width`, respectively. This PR adds a map of default and min dimensions per viz type (the `:display`) key and fills that in for each template. The template is merged into this result, keeping anything that already existed in the yaml file. Before merging this we should consider if we want to use the min values and where this data should be stored. It is currently in `metabase.automagic-dashboards.dashboard-templates`, but was lifted from [sizes.ts](https://github.com/metabase/metabase/blob/master/frontend/src/metabase/visualizations/shared/utils/sizes.ts ). * Moving card sizing constants to cljc The default card sizes were found in `sizes.ts` and were duplicated into `metabase.automagic-dashboards.dashboard-templates`. This PR consolidates those changes into `metabase.shared.automagic-dashboards.constants`. Note that @kulyk and @JesseSDevaney might want to consider further consolidation of dashboard related constants into this namespace. * Incorporating Feedback Changes - Explicitly defined two constants in the shared file that are clj and js friendly - Set case to CARD_SIZE_DEFAULTS_JSON - Updated `metabase.automagic-dashboards.dashboard-templates/set-default-card-dimensions` to use a helper * Update src/metabase/shared/automagic_dashboards/constants.cljc Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> * Updating ns name per Jesse --------- Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
-
Anton Kulyk authored
* Convert `dashboard/actions/ui` to TypeScript * Extract `setDashboardWidth` action
-
Anton Kulyk authored
* Make filters sticky * Fix hidden parameters still taking vertical space * Bump z-index * Conditional sticky filters on small screens * Don't render `ParametersWidgetContainer` without parameters * Add border to filters panel when scrolling * Fix e2e tests * Fix filter panel background color * Disable sticky filters for "transparent" embed theme
-
Chris Truter authored
-
Chris Truter authored
-
Nemanja Glumac authored
* Remove unused `breakout` parameter * Evaluate `clear()` inline * Evaluate `getBreakoutClause([])` inline * Simplify `clearBreakouts` query helper 1. The second argument of `setBreakoutClause` is aways `undefined` which means that we can remove it. 2. No need to export this helper since it's used only within this file * Remove unused `clearBreakouts` helper from breakout helpers * Simplify `clearFields` helper * Simplify `clearOrderBy` helper * Remove unused `clear` util
-
Nemanja Glumac authored
* Remove unused `StructuredQuery.prototype.topLevelQuery` * Remove unused `StructuredQuery.prototype.lastSummarizedQuery` * Remove unused `StructuredQuery.prototype._keyForFK` * Remove unused `isSegmentOption` helper
-
Alexander Solovyov authored
-