Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jan 28, 2022
  2. Jan 27, 2022
  3. Jan 26, 2022
  4. Jan 25, 2022
    • Jeff Evans's avatar
      Add program_name connectionAttribute for MySQL (#18707) · 56e0ad15
      Jeff Evans authored
      * Add program_name connectionAttribute for MySQL
      
      Set the program_name connection attribute when creating a MySQL connection, to the same value that we do for other drivers - `config/mb-version-and-process-identifier`
      
      Updating tests
      
      Add test for mysql to ensure `:connectionAttributes` aren't emitted when they are given in `additional-options`
      
      Set `:connectionAttributes` directly in the `jdbc-spec` map (which in turn becomes a property for the JDBC connection) instead of putting in `additional-options`
      
      Fixing some bugs in `additional-options->map`
      
      Relevant links:
      
      * https://dev.mysql.com/doc/refman/8.0/en/performance-schema-connection-attribute-tables.html#performance-schema-connection-attributes-available
      * https://mariadb.com/kb/en/performance-schema-session_connect_attrs-table/
      * http://mysqlblog.fivefarmers.com/2013/03/26/connection-attributes-in-mysql-5-6/
      Unverified
      56e0ad15
    • Jeff Evans's avatar
      Apply schema inclusion/exclusion filtering to sql-jdbc drivers (#19651) · b6d542f8
      Jeff Evans authored
      * Apply schema inclusion/exclusion filtering to sql-jdbc drivers
      
      Update `sql-jdbc` namespaces to handle schema inclusion/exclusion patterns when filtering schemas
      
      Add new generic schema inclusion/exclusion test for sql-jdbc drivers that define the property
      
      Update Snowflake and Redshift driver manifests to include schema filtering property
      
      Create `db-details->schema-filter-patterns` util fn to turn DB details into the inclusion/exclusion patterns
      
      Move schema inclusion/exclusion filtering code to new namespace (since it's not strictly used by `:sql-jdbc` derived drivers)
      
      Move existing tests accordingly
      
      Add schema inclusion/exclusion check to the new `filtered-syncable-schemas` multimethod (and updating docstring)
      
      Change `:redshift` impl of `filtered-syncable-schemas` to call the `:sql-jdbc` version instead
      
      Use new multimethod instead for `filtered-syncable-schemas`, and have default impl of `syncable-schemas` call that
      
      Mark `syncable-schemas` as deprecated and include notes on the new method (and update driver markdown file accordingly)
      Unverified
      b6d542f8
    • Nemanja Glumac's avatar
      Unskip repro for #17512 (#19891) · 9c8e38ce
      Nemanja Glumac authored
      Unverified
      9c8e38ce
    • Dalton's avatar
      Collections changes feature branch (#19848) · afc53f40
      Dalton authored
      
      * Add PinnedItemCard component (#19765)
      
      * convert Card component to typescript
      
      * add open state class to EntityMenu
      
      * Add PinnedItemCard component
      
      * prevent the bubbling of EntityMenu events
      
      * replace class with styled-component stuff
      
      * define a const
      
      * Replace pinned collection items table with pinned overview section (#19787)
      
      * Add PinnedItemOverview component
      
      * Replace the pinned table with overview
      
      * add types to collection utils
      
      * fix pinning + types
      
      * remvoe the old PinnedItemsTable
      
      * fix/remove e2e tests that no longer make sense
      
      * replace 'Datasets' with 'Models'
      
      * Update frontend/src/metabase/collections/components/PinnedItemOverview/PinnedItemOverview.tsx
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      
      * add unique text for root collection
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      
      * Collections page UI changes (#19792)
      
      * make a bunch of ui tweaks to collections
      
      * resize Titles for PinnedItemCards
      
      * resize collection description headings
      
      * Add tooltip to pin button
      
      * Fix unit test
      
      * fix e2e tests
      
      * add a default description
      
      * Tbody --> TBody
      
      * Hide long titles & add tooltip to show entire title
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      
      * Add card visualizations to the pinned section of collections (#19813)
      
      * First pass at card viz in collections
      
      * minor style fixes
      
      * move redux stuff up to CollectionContent
      
      * padding tweaks
      
      * Make the entire card clickable
      
      * add generic error message
      
      * Add propTypes
      
      * a little cleanup
      
      * create ActionMenu component
      
      * Fix pin action fn
      
      * Fix circular dep & storybook story
      
      * actually import the function
      
      * add comment // use EventSandbox
      
      * Add preventDefault prop to avoid breaking things
      
      * Make pinned cards drag-and-droppable into the collections sidebar (#19829)
      
      * first pass at dnd for pinned cards
      
      * use cards instead of viz for performance
      
      * fix type
      
      * Add tests for collection changes (#19851)
      
      * first pass at dnd for pinned cards
      
      * use cards instead of viz for performance
      
      * fix type
      
      * Add tests for collection changes
      
      * fix Button import
      
      * remove async
      
      * Add empty pinned items section banner (#19857)
      
      Fix e2e test
      
      don't show empty states when loading
      
      styling tweaks
      
      Fix test
      
      * datasets --> models
      
      * fix dragging data models
      
      * Make question icons in collections bg-dark
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      Unverified
      afc53f40
    • Michiel Borkent's avatar
      Linting improvements: 0 errors in src + shared/src (#19836) · a4475dab
      Michiel Borkent authored
      * Linting improvements: 0 errors in src + shared/src
      
      * satisfy other linter
      Unverified
      a4475dab
    • Cam Saul's avatar
      Add test for #15863 (#19896) · a626dad5
      Cam Saul authored
      * Add test for #15863
      
      * Remove dead code
      Unverified
      a626dad5
    • Anton Kulyk's avatar
      Fix metadata editor sidebar formatting UI (#19916) · e40e295c
      Anton Kulyk authored
      * Fix metadata editor sidebar formatting UI
      
      * Fix styling
      Unverified
      e40e295c
Loading