This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 23, 2024
-
-
Uladzimir Havenchyk authored
-
- Feb 22, 2024
-
-
Luis Paolini authored
Remove note
-
adam-james authored
* WIP flow :semantic-type through QP for aggregations Fixes: #38022 WIP need to add and fix some tests and confirm if this is the most correct place to fix the problem. Seems like it's a good spot to put things though. * Add test asserting that :semantic_type does flow through QP Also fix a couple tests that now have a :semantic_type key. * Add different aggregation types to semantic-type test Working on adding tests and fixing various aggregation semantic types * Test :semantic-type for all aggregations and adjust some metadata-methods * Better use of existing methods via derive * Properly set hierarchy between ::count-aggregation and ::quantity-aggregation
-
Jeff Bruemmer authored
-
Vamsi Peri authored
* Include filters when exporting dashboard to PDF * Fix missing dashcard borders * Fix title padding * Fix filters panel background color * Fix parameters panel spacing * Extract `DASHBOARD_PDF_EXPORT_ROOT_ID` const --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Alexander Polyankin authored
-
Luiz Arakaki authored
* update content for 49 * add date filter to question overview
-
Alexander Polyankin authored
-
Nick Fitzpatrick authored
* initial stuff * remove check for sub collections in personal collections * remove test * cleanup and adjusting tests * import spacint --------- Co-authored-by:
Jerry Huang <jhuang37050@gmail.com>
-
Braden Shepherdson authored
`cljs.core/hash` mutates vanilla JS arrays to attach a UID to them for hashing purposes. Before this change, given a `DatasetColumn` with a frozen `field_ref` array, we would use it directly on the `:metadata/column`, and `(hash column)` would try to mutate the frozen array and throw. This clones the array while converting the legacy column to MLv2 form, so there's no issue with mutating it. Fixes the `closure_uid_123456789` issue. Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
Ngoc Khuat authored
* add an api change log about replacing report_card.dataset with report_card.type * Update docs/developers-guide/api-changelog.md
-
Romeo Van Snick authored
* Add regression test for #35344 * Clear undo's when first opening editor * Make sure normal undo's still work
-
Kamil Mielnik authored
* Migrate changes from https://github.com/metabase/metabase/pull/38544 * Migrate changes from https://github.com/metabase/metabase/pull/38714 * Migrate changes from diff with metrics-v2 branch
-
Mahatthana (Kelvin) Nomsawadi authored
* Remove full-app to a newer term * Fix dashboard not loading in interactive embedding with header=false header=false * Fix can't choose dashboard tabs in interactive embedding w/ header=false
-
- Feb 21, 2024
-
-
Braden Shepherdson authored
The desired order is: own columns, explicitly joined, implicitly joined. Explicit joins are ordered among themselves by join alias. Implicit joins are ordered by the join alias of the FK (own columns first), then by the name of the FK column. Previously this order has usually been at least close to the desired order by accident, since it's close to the iteration order of `visible-columns`. However, `group-columns` uses `group-by`, which returns a map. If there are enough groups (more than 8 I think) the map implementation will switch from a `[key1 value1 key2 value2 ...]` array to a real map, and the iteration order is undefined. This change enforces the desired order, including a test that `shuffle`s the columns. (And fixing the expectations for a few other tests.)
-
Anton Kulyk authored
* Auto open the comparison picker * Preselect a single column for "anotherColumn" comparisons * Flip value and label inputs in `StaticNumberForm` * Respect static value's label case * Merge `getInitialColumn` and `getInitialLabel`
-
Jeff Bruemmer authored
-
Jerry Huang authored
* creator sentiment cleanup * change setting to be survey-enabled * fix test * change send-creator-sentiment-emails
-
Raphael Krut-Landau authored
-
Jerry Huang authored
* add if statement for jwt saml * add tests * add tests * fix tests
-
Noah Moss authored
-
adam-james authored
* Do not fetch param_values on Dashboard Load Fixes: #38826 This change removes the *-or-create* behaviour of `field-ids->param-field-values`. This means that on Dashboard Load, if the param values already exist, they'll be grabbed. But, if they don't, we won't try to fetch or create them. This is WIP because it seems to contradict changes related to fixing #30218 * Comment out the other test added for #30218 * Remove the tests from 30218 These tests are asserting that param_values are created on dashboard load when the Field Values don't exist. This is the behaviour we want to revert, so the tests are asserting something we don't want anymore. * Improved test string wording * Update src/metabase/models/params.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Alexander Polyankin authored
-
Anton Kulyk authored
-
Nemanja Glumac authored
-
Oleg Gromov authored
Change selects and add TextInputBlurChange Extract controls Update required parameter toggle Fix e2e toggleRequired helper Migrate ValuesSourceSettings to Mantine Radio Fix all tests Address review feedback Reorganize TagEditorParam components Add TextInputBlurChange component test
-
- Feb 20, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Renaming files for consistency * Combine both container and view component * Add the new selector + improve types * Force user to refresh to see the colors change. * Revert "Add the new selector + improve types" This reverts commit 1587411da685857ee586b3096a58148f6a0ce36c. * Type setting selectors to support enterprise setting keys * Copy changes * Remove unused files * Remove default exports/imports * Add a modal telling users to refresh the page after changing colors * Revert "Add a modal telling users to refresh the page after changing colors" This reverts commit ac8772d01f18c1e5ba80a92d79f18843ac8a50cf. * Makes it obvious to users they need to refresh browser After changing colors, we want to make sure the behavior of colors is consistent across the board. Previously this wasn't the case, some elements will immediately change colors, while some don't. This created confusion. The new behavior is to NOT change any color at all after changing the application colors and let users refresh their browsers themselves. * Update copy according to a discussion * Fix e2e from copy change * Make assertion explicit * Fix the last E2E failure
-
Ryan Laurie authored
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
-
Case Nelson authored
* Wrap literals around expression refs Fixes #27185 Expression refs need to be handled like field refs as far as type hints in opts are concerned. Otherwise we don't pass the correct parameter types to the drivers. * Address pr feedback
-
Jesse Devaney authored
- queryParams: hide_parameters - hiddenParameterSlugs
-
Jerry Huang authored
* Add new email function and send email to creator * remove debug stuff * add tests, address comments * actually add tests * Update src/metabase/email/messages.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * address comments --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Case Nelson authored
* Fixes filters against datetime binned expressions Fixes #33528 Turns out that `mbql/normalize` and `lib/normalize` behaved slightly different and `[:expression "abc" {...}]` refs would drop their opts in the former path. In order to properly query against binned datetimes it's important that expression ref does not lose its type or else the optimizer will not see that `time-interval` needs to convert to a `between` rather than an `=`. * Fix test * Only keep specific keys on expression opts for these expression filters * Don't run checkin dataset on snowflake or athena
-
Uladzimir Havenchyk authored
* Rework findColumnIndexForColumnSetting to MLv2 * Throw an error to find all places without query * Use MLv2 in ChartSettingTable (#38171) * Add a comment why we can't use mlv2 in chart setting table * Use mlv2 findColumnIndexForColumnSetting in ChartSettingTableColumns * Tests completed, so revert throwing * Use mlv2 findColumnIndexForColumnSetting in object detail (#38170) * Use mlv2 findColumnIndexForColumnSetting in object detail * Address review * Use mlv2 findColumnIndexForColumnSetting in Question (#38169) * Use mlv2 findColumnIndexForColumnSetting in Question * Update question tests * Use mlv2 findColumnIndexForColumnSetting in viz settings (#38172) * Use mlv2 findColumnIndexForColumnSetting in Table (#38168) * Cleanup finColumnSettings usage (#38914) * Fix linting
-
Chris Truter authored
-
Kamil Mielnik authored
* Align ESLint & prettier paths in "lint-stage" & "scripts" in package.json * Handle ts files in e2e tests * Manually fix ESLint-reported issues * Format "lint-prettier-pure" script the same way as "prettier" * Run "yarn eslint-fix" * Manually fix remaining issues * Ignore database files in ESLint as they reference a file that is git-ignored but does exist locally * Remove duplicated eslint call
-
Kamil Mielnik authored
* Include e2e directory in prettier scripts * Run "yarn prettier"
-
lbrdnk authored
Swaps with-temporary-setting-values for with-report-timezone-id.
-