Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 03, 2023
  2. Jul 01, 2023
  3. Jun 30, 2023
  4. Jun 29, 2023
    • metamben's avatar
      Add tests for joined-thing (#31966) · cc552817
      metamben authored
      Unverified
      cc552817
    • Mark Bastian's avatar
      Fix TemplateTag id type discrepancy (#31257) · 7d84f6a1
      Mark Bastian authored
      There was a discrepancy between TemplateTag id types as defined in metabase.lib.native (uuid) and metabase.mbql.schema (string). This PR makes string the uniform type for both. This results in errors when code using different specs for the same logical entity is used together. Here's an breaking example:
      
      ```
      (let [card-id 328 ;; This is a valid card locally
            q   (str "SELECT * FROM {{#" card-id "}} LIMIT 2")
            tt  (lib-native/extract-template-tags q)
            res (qp/process-query
                  {:database 1
                   :type     :native
                   :native   {:query         q
                              :template-tags tt}})]
        (is (some? res)))
      ```
      This will break since the tt generated id is a uuid but process-query expects a string id.
      
      Fixes #31252 
      Unverified
      7d84f6a1
    • Noah Moss's avatar
    • Anton Kulyk's avatar
      Migrate notebook aggregations to MLv2 (#31855) · c529a888
      Anton Kulyk authored
      * Migrate notebook aggregations to MLv2 — Operators (1) (#31527)
      
      * Add aggregation types
      
      * Add aggregation TypeScript wrappers
      
      * Move `AggregateStep` to its own directory
      
      * Port basic features to MLv2
      
      * Deprecate `AggregationPopover`
      
      * Fix MLv1's aggregation clause validation
      
      * Fix import
      
      * `requiresField` → `requiresColumn`
      
      * Add basic tests for `AggregationPicker`
      
      * Add `findAggregationOperator` test utility
      
      * Add basic tests for `AggregateStep`
      
      * Make stage index explicit
      
      * Highlight selections, add picker back button
      
      * Use long display name for aggregation clauses
      
      * Remove `React` imports
      
      * Enable temporal bucketing
      
      * Use aggregation JS wrappers
      
      * Fix `Icon` import
      
      * Patch unit test according to BE changes
      
      * Fix E2E test
      
      * Simplify `Aggregation's` `dimension` method
      
      * Fix formatting
      
      * Migrate notebook aggregations to MLv2 — Metrics (2) (#31528)
      
      * Add basic legacy metrics support
      
      * Don't show archived metrics
      
      * Highlight selected metric
      
      * Extract `AggregationPopover` in notebook step
      
      * Fix `onClose` prop
      
      * Fix icon
      
      * Add missing metric types
      
      * Use MLv2 to manage metrics
      
      * Remove legacy query logic
      
      * Add `Aggregatable` type
      
      * Migrate notebook aggregations to MLv2 — Inline expressions (3) (#31529)
      
      * Revert "Remove legacy query logic"
      
      This reverts commit 722804d3a6684762701351c658625b5439c75c2b.
      
      * Use HTML labels in `ExpressionWidget`
      
      * Support inline expressions for aggregations
      
      * Fix import
      
      * Fix picker navigation
      
      * Fix type error
      
      * Remove `ts-expect-error`
      
      * Migrate notebook aggregations to MLv2 — Disable MLv1 validation (4) (#31530)
      Unverified
      c529a888
  5. Jun 28, 2023
  6. Jun 27, 2023
  7. Jun 26, 2023
  8. Jun 24, 2023
  9. Jun 23, 2023
  10. Jun 22, 2023
  11. Jun 21, 2023
  12. Jun 20, 2023
    • Cam Saul's avatar
      MLv2: Handle missing Field metadata as long as it is present in Saved Question metadata (#31706) · 72911ffe
      Cam Saul authored
      * MLv2: Handle missing Field metadata as long as it is present in Saved Question metadata
      
      * Address PR feedback
      Unverified
      72911ffe
    • Cam Saul's avatar
      MLv2: Remove `metabase.lib.dev` and "unresolved" functions (#31738) · 8feb3c27
      Cam Saul authored
      * Implement `suggested-join-condition`
      
      * Update docstring
      
      * OOOF fix typo in `filter-clause`
      
      * Fix premature i18n lookup
      
      * Address PR feedback
      
      * MLv2 JS join function wrappers
      
      * PR feedback from #31590
      
      * `join-conditions` returns raw MBQL clauses!
      
      * WIP
      
      * Simplify `with-join-alias` and `with-join-fields`
      
      * Simplify join and add with-join-conditions
      
      * Un-revert dev
      
      * Wow! Remove unresolved nonsense.
      
      * Remove dev
      
      * Remove dev
      
      * Test fixes :wrench:
      
      * PR feedback
      
      * WIP
      
      * defop doesn't need query or stage-number anymore
      
      * Fix Cljs tests for base PR
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * Update JS wrappers
      Unverified
      8feb3c27
    • Cam Saul's avatar
      MLv2 Join API Simplification; implement `with-join-conditions`; make join... · a5d3f0d9
      Cam Saul authored
      MLv2 Join API Simplification; implement `with-join-conditions`; make join `:alias` required (#31679)
      
      * Implement `suggested-join-condition`
      
      * Update docstring
      
      * OOOF fix typo in `filter-clause`
      
      * Fix premature i18n lookup
      
      * Address PR feedback
      
      * MLv2 JS join function wrappers
      
      * PR feedback from #31590
      
      * `join-conditions` returns raw MBQL clauses!
      
      * WIP
      
      * Simplify `with-join-alias` and `with-join-fields`
      
      * Simplify join and add with-join-conditions
      
      * Un-revert dev
      
      * Test fixes :wrench:
      Unverified
      a5d3f0d9
    • Jerry Huang's avatar
      Snowplow: Index model entities (#31681) · bb39c5fc
      Jerry Huang authored
      * initial commit
      
      * add snowplow schema
      
      * change indexmodel to model
      Unverified
      bb39c5fc
    • metamben's avatar
      Include refs for all expressions in :fields whenever present (#31692) · 68a5393b
      metamben authored
      * Include refs for all expressions in :fields whenever present
      * Remove the :fields clause if only expressions remain in it
      Unverified
      68a5393b
    • Cam Saul's avatar
      MLv2: Cljs and TypeScript wrappers for existing join functions (#31675) · 919d279e
      Cam Saul authored
      * Implement `suggested-join-condition`
      
      * Update docstring
      
      * OOOF fix typo in `filter-clause`
      
      * Fix premature i18n lookup
      
      * Address PR feedback
      
      * MLv2 JS join function wrappers
      
      * PR feedback from #31590
      
      * `join-conditions` returns raw MBQL clauses!
      Unverified
      919d279e
    • Noah Moss's avatar
      Connection impersonation (#30714) · f85ccd77
      Noah Moss authored
      * initial prototype w/out statement count parameter
      
      * new approach
      
      * default-database-role driver method
      
      * migration for connection_impersonations table
      
      * conn impersonation model, API and tests
      
      * impersonation fetch and deletion endpoints
      
      * switch test to t2 with-temp
      
      * read conn impersonation settings from DB
      
      * fix merge issue
      
      * add impersonated key to data perms graph and treat it the same as full self-service access
      
      * include impersonated key in returned permissions graph
      
      * make sure impersonated graph passes StrictDataPerms validation
      
      * fix boolean logic
      
      * make sure impersonated keyword doesnt cause error when deleting gtaps
      
      * clear impersonations as necessary when perms graphs changes
      
      * add impersonation support for postgres
      
      * fix typo
      
      * make sure impersonation updates are a non-lazy seq
      
      * add impersonated-user? fn
      
      * fix impersonation api tests
      
      * fix snippet tests
      
      * fix build & exclude connection impersonations from serialization
      
      * switch a test to use t2.with-temp
      
      * add with-impersonations helper and util tests
      
      * move macro and add a connection impersonation driver-level test for postgres
      
      * fix rebase issue
      
      * more tests and code reorganization
      
      * add snowflake test
      
      * clarify comment
      
      * fix lint errors
      
      * fix final kondo error
      
      * reorganization
      
      * fix one test
      
      * fix lint errors
      
      * revert change to sql_jdbc.execute from bad merge
      
      * make sure perms for all users gets reset after conn impersonation tests
      
      * ignore exceptions when restoring perms
      
      * fix postgres test
      
      * refactor to address bryan's comment
      
      * add note about new methods to database changelog
      
      * driver method refactor
      Unverified
      f85ccd77
Loading