This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 26, 2024
-
-
Cal Herries authored
-
Alexander Polyankin authored
* Add a test * Add a unit test for TextLike
-
- Jul 25, 2024
-
-
Raphael Krut-Landau authored
fix(admin/nav): Ensure that the "Exit admin" button can be clicked regardless of locale or viewport size (#45882) Closes #45876
-
adam-james authored
* fix conditional formatting color lookup with correct col names The column names for color lookup are expected to be the same as the :name key of each column, and applying column formatting broke this lookup. This fixes it. * move overflow-x into pulse body div to exlude card title from scroll * add a test for conditional formatting w/ a hidden row. This still fails at the moment, working on a fix yet. * apply conditional formatting in static viz even when col is hidden Conditional formatting that depends on a hidden column was not being rendered in the static viz, but now we pass all columns into the color selector fn, thus when rendering the table with the ordered/hidden columns, all other columns will still use their appropriate conditional formatting * I missed a linter warning * fix tab rendering * fix test * fix up tests with some better structural searching
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Do not store elements in a `const` * Remove mid-test save and edit dashboard
-
metamben authored
Add Azure managed identity support --------- Co-authored-by:
Case Nelson <case@metabase.com>
-
Uladzimir Havenchyk authored
-
Raphael Krut-Landau authored
Closes #45127
-
Raphael Krut-Landau authored
Closes #45916
-
Uladzimir Havenchyk authored
-
bryan authored
* Adds a middleware that sets 2 dynamic vars - These vars will be used to insert context for embedding analytics * migration adding embedding_client and embedding_version to qe and vl tables * clarify function api * headers come in -> dynamic vars -> written to db When the vars are set we insert their values into query execution and query_log under embedding_client and embedding_version. * update update migrations * add predconditions to migrations * fix tablenames + dataset_test * Code Review responses - remove commented out requires - clarify test for merge-count-maps
-
Raphael Krut-Landau authored
feat(question): Make two messages in the question footer - query runtime and cache age - more useful (#46072) Closes #46009
-
John Swanson authored
* Lock down the trash collection more Oops. I was very thorough in checking that you couldn't modify the trash collection in the sense of moving things to or from it. I missed the most obvious thing: actually modifying the trash collection itself. So if someone wanted, they could change the name of the Trash to "Definitely Not the Trash". * Remove the Trash Collection from serialization Serialization tests were failing due to the previous change, but this got me thinking, and I realized that serializing the Trash collection is completely unnecessary. We want to create it programatically on startup (which we are) and then nothing should change it afterwards.
-
John Swanson authored
I tightened this up by removing the condition here, thinking that CI would catch it if it was necessary - but I'm getting failures in development. Oops - didn't realize that this defmethod wasn't actually applied during CI runs.
-
Noah Moss authored
Co-authored-by:
bryan <bryan.maass@gmail.com>
-
Raphael Krut-Landau authored
Closes #46123
-
Oisin Coveney authored
-
use-tusk[bot] authored
* Updating Tusk Sanity GitHub workflow * fix: automatic Tusk self-review --------- Co-authored-by:
use-tusk[bot] <144006087+use-tusk[bot]@users.noreply.github.com>
-
bryan authored
* add mu/defn- * use new built-in mu/defn- * mu/defn- preserves metadata --------- Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Nemanja Glumac authored
* Rewrite repro for 27643 * Add TODO for the remaining tasks * Make a test name consistent with others * Finish the E2E test for #27643 * Fix the test to use PostgresDB Since H2 originally doesn't fail the test * Attempt to fix a flake on CI by waiting for table to finish syncing * Create QA snapshot with fully synced field metadata * Fix failed tests from field metadata change * Simplify question scenarios * Simplify dashboard scenarios * Fix permissions * Rework titles * Add comment about PG * Add limit to speed things up * Fix and improve dashboard assertions * Fix and improve question assertions --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
adam-james authored
* Bigquery Pagination Use next page to get proper results Fixes 45953 WIP * use new-page in values-iterator * disable just the part of the test that is still flaky Want to keep the other part of the test that does prove we're not getting duplicates due to incorrect pagination.
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
Noah Moss authored
Make the sandbox cleanup logic more robust, and reorganize some perms code for better testing (#46102)
-
adam-james authored
* Number formatter Reports correct Decimal places for negative Numbers Fixes #41640 Prior to this, the number formatter would get the incorrect number of decimal places for negative numbers. The way the decimal places count is derived works as follows: - convert number to a string - split the string on the separator (decimal, comma, whatever the instance has set) - destructure that split into [int decimal] - count decimal to get the number of decimals. That all works for positive numbers, but for negative numbers, the regex was just splitting on 'not digits', so we got an extra group due to the leading negative sign. This would incorrectly destructure the 'int' part of the number into the count, thus we would always get 1 instead of the correct value. This fixes it by just taking last instead of destructuring. * correct comparison to always use abs value in conditonal check * tiny incorrectness in the test
-
Anton Kulyk authored
* Don't show "Download" button until query complete * Fix `PublicOrEmbeddedDashboardPage` tests * Add tests * Remove redundant dataset error checks * Revert "Remove redundant dataset error checks" This reverts commit fc7810f0.
-
Mahatthana (Kelvin) Nomsawadi authored
* Modify the E2E stress test workflow to allow running PostgresDB * Fix syntax * Add qa_db to workflow summary * Only run necessary containers * Fix QA DB snapshots running when QA_DB_ENABLED=false * Use more generic option that's not only specific to postgres
-
Cal Herries authored
-
Luis Paolini authored
* Make drivers build in parallel rather than sequentially * Make the whitespace linter happy * Add duration to steps
-
use-tusk[bot] authored
Co-authored-by:
use-tusk[bot] <144006087+use-tusk[bot]@users.noreply.github.com>
-
Oleksandr Yakushev authored
* perf: Add explicit .entryAt method for SnakeHatingMap Otherwise, SHM invokes .keySet on itself which triggers the contstruction of the list of keys on each map access. * perf: Cache (un)successful requiring of EE in dynamic-ee-oss-fn * perf: Add a quicker path for getting metadatas from cache * perf: Minor improvements
-
lbrdnk authored
-
Anton Kulyk authored
* Add repro * Fix onOpenQuestion uses unexpected card object
-
Kamil Mielnik authored
* Refactor dashboard helpers to TypeScript * Reuse existing helper
-
Kamil Mielnik authored
-
- Jul 24, 2024
-
-
Braden Shepherdson authored
It's based on a (global, synchronized) `WeakHashMap` using the query map itself as the key. That gives the cache the same lifespan as the query map, which is generally brief but often includes many calls to expensive, cached functions like `visible-columns`.
-
Alexander Polyankin authored
This reverts commit 6495def0.
-
Nemanja Glumac authored
* Make filter corrupted again™ * Speed up the test by limiting the number of rows * Make the repro more correct, and more resilient * Remove intercepts * Improve assertions
-
Alexander Polyankin authored
* Fix a race condition with models creation * Fix the test * Fix the test
-
Jeff Bruemmer authored
* notes on view data vis * Update docs/permissions/data.md Co-authored-by:
Alex Yarosh <alexandra@metabase.com> --------- Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-