Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 26, 2024
    • Nick Fitzpatrick's avatar
      Migrate DatasetFieldMetadataSidebar to new Forkmik components (#41571) · fda53853
      Nick Fitzpatrick authored
      * temp
      
      * rework DatasetFieldMetadataSidebar to use new form components
      
      * temp
      
      * removing unneeded import
      
      * fixing display name form field
      
      * temp
      
      * more temp
      
      * onChange for form elements
      
      * e2e adjustment
      fda53853
    • Romeo Van Snick's avatar
      Static extract examples (#41778) · 8e111abc
      Romeo Van Snick authored
      * Add subTitle to ClickActions
      
      * Add examples to column extractions
      
      * Add test for examples
      
      * Add test for examples
      
      * Use rem helper
      
      * Use JSDoc for todo
      
      * Disambiguate between ColumnExtraction and ColumnExtractionInfo
      
      * Update type of getExample
      
      * Use rem helper
      8e111abc
    • Romeo Van Snick's avatar
      Notebook custom expression editor "combine columns" shortcut (#41872) · 304308e7
      Romeo Van Snick authored
      
      * Notebook combine columns (#41379)
      
      * Add CombineColumns dialog component
      
      * Add combine columns to the expression editor widget
      
      * Add placeholder for empty and space to the input
      
      * Drop the first separator
      
      * Remove empty string from eventual concat
      
      * Add example to Combine Colunmns builder
      
      * Show example in monospace
      
      * Do not collapse spaces in example
      
      * Use monospace in separator input
      
      * Reorganise column flatten helper
      
      * Add back button on combine buttons modal
      
      * Select text when focussing separator input
      
      * Add minimum height to example
      
      * Use that same separator as the last row
      
      * Use ExpressionWidgetHeader instead of hand-rolled header
      
      * Fix type when generating example
      
      * Correctly update default separator when a url column gets set
      
      * Swap url and email checks
      
      * Move column input into separate component
      
      * Use QuerySelector for column select
      
      * WIP: customise dropdown
      
      * Export Input
      
      * Use a button to render the column selector
      
      * Add combine icon
      
      * Use shortcut suggestion shortcut for combine columns
      
      * Allow interacting with buttons inside the popover
      
      * Use longDisplayName for button label
      
      * Add asReturned
      
      * Use asReturned in CombineColumns modal
      
      * Make faux-select button styles match normal input
      
      * Return focus to button when select closes
      
      * Fix type of focus event
      
      * Move ColumnInput component to a separate file
      
      * Only show combine column shortcut on custom column
      
      * Add missing test ids
      
      * Add e2e test for combine column shortcut
      
      * Remove white fill from paths
      
      * Add color to combine icon
      
      * Use function expression, not declaration
      
      * Remove comment
      
      * Move initial default separator to constant
      
      * Remove unused select option helpers
      
      * Add isInteger helper to Lib
      
      * Add case for integer columns
      
      * Add unit tests for util
      
      * Add SuggestionShortcut type to props for Suggestions
      
      * Remove {enter} which broke test
      
      * Do not use !important
      
      * Simplify classname into object-style
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      
      * Use direct override on Button instead of class
      
      * Fix formatting issue
      
      * Use .select() to select input
      
      * Avoid selecting placeholder text
      
      * Avoid losing focus when window loses focus
      
      * Rename evt to event
      
      * Add monospace variant to Text
      
      * Use monospace variant in Example
      
      * Use monospace font from theme
      
      * Match faux-select label styles to our TextInput label styles
      
      * Remove empty default variant
      
      * Add limit to the test case
      
      * Remove unnecessary within wrapper
      
      * Use rem
      
      Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
      
      ---------
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
      
      * Remove intercept we're not waiting for
      
      * Use have.text instead of contain
      
      * Use cy.button
      
      * Expand cancel test
      
      * Remove duplicate title
      
      ---------
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
      304308e7
    • Nemanja Glumac's avatar
      Fix broken E2E reproduction for #39221 (#41875) · 09b56609
      Nemanja Glumac authored
      * Re-write E2E repro for 39221
      
      * Convert to TS
      09b56609
  2. Apr 25, 2024
    • Braden Shepherdson's avatar
      [MBQL lib] Add `column-extractions` to the top level (#41525) · dd9e126b
      Braden Shepherdson authored
      Column extractions are "canned" expressions based on a column's
      type. For example, we might extract the weekday from a temporal column,
      or the domain from an email or URL column.
      
      This logic already existed inside the `column-extract` drill; this pulls
      it out as a top-level concept, since extractions are also being
      integrated into the notebook editor apart from drills.
      
      Part of the follow-up for Extract Column epic #38964.
      dd9e126b
  3. Apr 23, 2024
  4. Apr 22, 2024
  5. Apr 19, 2024
  6. Apr 18, 2024
    • Denis Berezin's avatar
      Fix Embedded dashboard parameters parse runtime error (#41545) · 198ebcf5
      Denis Berezin authored
      * Fix parameters parse
      
      * Add e2e test
      
      * Add e2e test
      198ebcf5
    • Ryan Laurie's avatar
      Question + Model Picker (#40207) · 784c26ac
      Ryan Laurie authored
      * WIP questionpicker
      
      * use to replace dashcard content
      
      * much better stuff
      
      * question picker
      
      * values source card modal
      
      * create action form
      
      * awesome hacky fix for crashing model detail page
      
      * use entity picker in sandboxing modal
      
      * deprecate ye olde question picker
      
      * keep old question picker in add-card dashboard sidebar
      
      * better last level check
      
      * update types
      
      * make stuff better
      
      * fix rebase conflicts
      
      * better initial value handling
      
      * update e2e tests
      
      * sweet sweet unit tests
      
      * fix sandbox tests
      
      * fix tests
      
      * type fix
      
      * fixes
      
      * search style improvements
      
      * remove unused prop
      
      * safer path detection
      
      * delayed loading spinner
      
      * change confirm default
      
      * set default collection for placeholder card
      
      * address review comments
      
      * update unit tests
      
      * update e2e tests
      
      * fix re-rebase
      
      * add some happy little comments
      784c26ac
  7. Apr 17, 2024
  8. Apr 16, 2024
    • Romeo Van Snick's avatar
      Add most used functions to suggestions when they open (#41267) · 176f6317
      Romeo Van Snick authored
      * Add list of most popular functions and aggregations
      
      * Render 'All functions' link on expression dropdown
      
      * Suggest popular functions when no input is given
      
      * Do not return focus to search bar
      
      * Default to not matching any substring
      
      * Open suggestions when the expression editor opens
      
      * Group expressions by group
      
      * Render group titles in dropdown
      
      * Match the expression suggestions height to the design
      
      * Add tests for popular functions
      
      * Convert tests to it-style
      
      * Only return supported popular functions
      
      * Limit most used functions group to 5 items
      
      * Make the suggestion footer keyboard-accessible
      
      * Make a different group for popular aggregations
      
      * Remove padding on suggestion list
      
      * Resize list
      
      * Add test for popular functions in suggest
      
      * Move showMetabaseLinks into args
      
      * Remove unneeded optional chain
      
      * Clarify popup issue in ACE hack
      
      * Use correct target for links
      
      * Reference correct method in comment
      
      * Split up popular expressions
      
      * Remove Set around popular functions/aggregations
      
      * Do not allow interacting with suggestion header
      
      * Do not use _ prefix for variable
      
      * Add verb in test
      
      * Remove unused async in test
      
      * Test if functions are in document
      
      * Move tests for suggestWithFooter to separate file
      
      * Use correct target in link
      
      * Fix typo in key
      
      * Allow picking suggestion when textbox is empty
      
      * Remove unnecessary cast
      
      * Avoid double scroll bars
      
      * Only show link to all functions when editor is empty
      
      * Split up popular functions between expressions and filters
      
      * Fix type of popular variable
      
      * Use the same heuristic for footer as for popular expressions
      
      * Close suggestions when the editor is not focused
      
      * Add missing open prop in test
      
      * Simplify test
      
      * Add selector for expression editor widget
      
      * Fix e2e tests
      
      Fix e2e tests
      
      * Avoid non-interactive clicks from closing the dropdown
      
      * Use custom expression helpers in broken test
      
      * Fix test
      
      * Remove should exist check for selector
      176f6317
    • Uladzimir Havenchyk's avatar
      03e9e1c6
  9. Apr 15, 2024
  10. Apr 12, 2024
    • Uladzimir Havenchyk's avatar
    • Romeo Van Snick's avatar
      Expression editor suggestion improvements (#41304) · b355cc24
      Romeo Van Snick authored
      * Add help text icon in expression editor suggestions (#41092)
      
      * Add helptext to expression suggestions
      
      * Deduplicate getDatabase calls
      
      * Allow customising popover width
      
      * Split out help text content component
      
      * Render an info icon with the help text
      
      * Remove duplicated defaults for popover
      
      * Explicitly wait for suggestion items in test
      
      * Remove commented out code
      
      * Use React imports directly
      
      * Rename e to evt
      
      * Inline getHelpText when creating suggestions
      
      * Avoid overlapping content
      
      * Remove unnecessary Fragment
      
      * Avoid selecting item when clicking link or button inside element
      
      * Allow shifting popover
      
      * Stop Popover mouse events for bubbling
      
      * Use onMouseDown instead of onMouseDownCapture to avoid clicks inside popover from triggering select
      
      * Add help text to all suggestions that are know mbql functions
      
      * Expression suggestions clean up (#41236)
      
      * Move ExpressionEditorSuggestions to tsx
      
      * Convert ExpressionEditorSuggestions to functional component
      
      * Simplify suggestion match component
      
      * Move ExpressionEditorSuggestions a separate folder
      
      * Remove default export
      
      * Use Popover instead of Tippy for suggestions list
      
      * Fix suggestions tests
      
      * Remove data-ignore-outside-clicks
      
      * Add default for suggestions
      
      * Fix e2e test
      
      * Move helptext wrapper to ExpressionEditorTextfield
      
      * Switch to metabase/ui for Button
      
      * Use arrow function
      b355cc24
  11. Apr 11, 2024
  12. Apr 10, 2024
  13. Apr 09, 2024
  14. Apr 08, 2024
    • Nemanja Glumac's avatar
      Preserve notebook native preview user preferences (#41064) · dd8e0728
      Nemanja Glumac authored
      * Add new user-local setting `notebook-native-preview-preferences`
      
      * Update user settings on FE
      
      * Use two distinct setting entries
      
      * Update FE types
      
      * More explicit `notebook-native-preview-sidebar-width` definition
      
      * Add selectors
      
      * Initialize QB uiControls based on the BE settings
      
      * Rename QB store entry
      
      `isNativePreviewSidebarOpen` -> `isShowingNotebookNativePreview`
      
      * Rename QB store entry
      
      `nativePreviewSidebarWidth` -> `notebookNativePreviewSidebarWidth`
      
      * Add Redux actions
      
      * Dispatch user settings on top of Redux store
      
      * Fix test title typo
      
      * Add E2E test to make sure sidebar is resizable
      
      * Expand the E2E test to cover persisting settings across sessions
      
      * Be more explicit that we're resizing along x axis
      
      * Store window breakpoint as a variable
      
      * Calculate handle's left position more explicitly
      dd8e0728
    • Ryan Laurie's avatar
      Make Collection Picker child-aware (#40655) · 9be788d1
      Ryan Laurie authored
      * make collectionpicker child-aware
      
      * update unit tests
      
      * add another unit test
      
      * move test some place more sensible
      
      * fix rebase
      9be788d1
    • Nemanja Glumac's avatar
      Make notebook native preview sidebar resizable (#40984) · f85e1724
      Nemanja Glumac authored
      * Display sql preview on sizes less than 1280px
      
      * Handle min notebook width using Mantine responsitve style prop
      
      * Display the resizable sidebar on sizes >= 1280px
      
      * Set sidebar width on resize
      
      * Add custom handle
      
      * Simplify window resizing with `useWindowSize` hook
      
      * Use "white" from the theme colors
      
      * Improve sidebar semantics with `aside`
      
      * Define the `NativeQueryPreviewSidebar` as `aside`
      
      * Use Mantine style props instead of CSS module
      
      * Run the E2E test again using regular browser
      
      We removed the nested media query that ReplayIO doesn't support.
      Now this test can run using Replay Chromium as all other tests do.
      
      * Add some breathing room between the scrollbar and the resizable sidebar
      f85e1724
  15. Apr 05, 2024
    • Nicolò Pretto's avatar
      embed-homepage - ms1 PR (#40382) · 9402bd68
      Nicolò Pretto authored
      
      * create ui for the full embedding homepage, without any logic (#40251)
      
      * wip ui for the full embedding homepage
      
      * adds missing link + fix keys
      
      * remove done TODO
      
      * Update frontend/src/metabase/home/components/EmbedHomepage/InteractiveTabContent.tsx
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * destructure props in the function arguments
      
      * rename customerFacingAnalyticsDocsUrl to analyticsDocsUrl
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * add new settings for embedding homepage (#40455)
      
      * remove old minimal version
      
      * adds new embedding homepage settings and sets them at the end of the setup
      
      * comment e2e test
      
      * add tests for embedding homepage flags
      
      * more tests
      
      * remove unit tests related to old minimal version
      
      * fixes flags descriptions
      
      * :keyword for embedding-homepage
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * replace reloadSettings and refreshSettingsList with initializeSettings
      
      * `value => value === true` -> `Boolean`
      
      * toMatchObject -> toEqual for more strict tests
      
      * remove useless undefined check for settings, the component is conditionally rendered based on a setting so it means they're loaded anyway
      
      * fix: use :hidden as we changed the type to :keyword
      
      * specifically check for the `embedding` feature in the tokenFeatures object instead of checking if any feature is active
      
      * remove double \n
      
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      
      * connect settings to the embed homepage and show it (#40528)
      
      * fix nested a warnings in browser console
      
      * connect settings to the embed homepage and show it
      
      * fix stories
      
      * remove localStorage.clear() as we're not using it in the logic anymore
      
      * dismiss without feedback for the embedding homepage (#40587)
      
      * feat: add dismiss functionality to the embed homepage
      
      * update setup e2e to check for the dismissal of embedding homepage
      
      * use List from metabase/ui (#40638)
      
      * set embedding-secret-key when embedding is enabled (#40813)
      
      * set embedding-secret-key when embedding is enabled
      
      * use "named" setters and getters as suggested by Noah
      
      * Fix tests for ms1 after updating on master (#41069)
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarNoah Moss <32746338+noahmoss@users.noreply.github.com>
      9402bd68
Loading