This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 22, 2024
-
-
github-automation-metabase authored
* Unify banners * Fix and update unit tests Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Mahatthana (Kelvin) Nomsawadi authored
-
github-automation-metabase authored
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 21, 2024
-
-
github-automation-metabase authored
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
github-automation-metabase authored
* hide pivoted exports under env var * only export pivoted when the env var is true Also added tests to confirm. * must specify :export for public settings * spec * change setting to :internal since it's only via env var * use correct visibility add setting to settings.yaml for serialization --------- Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by: Adam James <adam.vermeer2@gmail.com> Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
-
github-automation-metabase authored
Fixes #48721 Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
-
github-automation-metabase authored
* track items being moved to trash * fix spelling * fix unit tests Co-authored-by: Sloan Sparger <sloansparger@users.noreply.github.com>
-
github-automation-metabase authored
* add alert to prompt admins to clean up a collection * clean up * pr feedback * fix i18n issue * copy changes Co-authored-by: Sloan Sparger <sloansparger@users.noreply.github.com>
-
github-automation-metabase authored
On MySQL 8.0.17, the following is prohibited: ``` WITH RECURSIVE MyRecursiveCTE (...) AS ( SELECT ... FROM bar UNION ALL SELECT ... FROM bar JOIN MyRecursiveCTE ON ... ) ``` Instead, you need to do: ``` WITH RECURSIVE MyRecursiveCTE (...) AS ( SELECT ... FROM bar UNION ALL SELECT ... FROM MyRecursiveCTE JOIN bar ON ... ) ``` Basically, just putting the CTE on the left vs. the right side of the join (which is exactly equivalent under the hood) fixes the issue. I can't actually find any documentation of this change, but it seems that sometime between MySQL 8.0.17 and MySQL 8.0.33, MySQL started allowing this, perhaps just an optimization where it now notices the equivalence and does the right thing. I originally tested this on what I believed was the oldest version of MySQL we supported, but didn't read carefully enough. We recommend 8.0.33 or higher here: https://www.metabase.com/docs/latest/databases/connections/mysql But that's not for the AppDB - for that, we recommend 8.0.17 or higher. Co-authored-by: John Swanson <john.swanson@metabase.com>
-
github-automation-metabase authored
* note about metrics permissions * clarify viewing and editing * clollection Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
* Do not show `PaymentBanner` on hosted instances * Add test for the missing token status Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
github-automation-metabase authored
* fix padding on published embeds list * add border to public links shared list to be consistent with embeds Co-authored-by: Nicolò Pretto <info@npretto.com>
-
github-automation-metabase authored
* Fix serdes of missing cards in click behavior When exporting a dashboard, we export its dashcards, including cards referenced inside its viz_settings. The problem is that viz_settings might have references to now-nonexistent cards. This is an initial stab at cleaning up the problem, specifically for click behavior. If Dashboard D has Dashcard DC, which has a click-behavior that links to Card C, then when we collect the descendants of D, we'll include a reference to C - even if C has been deleted. So this makes two changes: first, when calculating the descendants of a dashcard, don't include links to cards that don't exist. And, when exporting the click behavior, remove the whole thing entirely if the card it points to doesn't exist. Co-authored-by: John Swanson <john.swanson@metabase.com>
-
github-automation-metabase authored
-
github-automation-metabase authored
fix(sdk): entity picker's hover and accent colors are not mappable via sdk theming (#50299) (#50331) * add stories for dark theme * add dark theme editor stories * add entity picker colors * add editor-only picker * remove redundant story wrapper for dark theme stories * add theme keys to docs * add warning message Co-authored-by: Phoomparin Mano <poom@metabase.com>
-
github-automation-metabase authored
* emit typescript when in a typescript project * also check dependencies for typescript dep Co-authored-by: Phoomparin Mano <poom@metabase.com>
-
github-automation-metabase authored
-
- Nov 20, 2024
-
-
github-automation-metabase authored
Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by: Nick Fitzpatrick <nickfitz.582@gmail.com>
-
github-automation-metabase authored
* actually return values from getHidden - Arrow functions with {}'s do not implicitly return! * boolean fiddling Co-authored-by: bryan <bryan.maass@gmail.com>
-
github-automation-metabase authored
* feat(sdk): revamp CreateQuestion and create question behaviour (#50088) * revamp the create question component * docs updates * add stories and update styles * prevent switching to visualization when it is not ready * ensure CreateQuestion works in flex parents * add basic e2e tests for CreateQuestion * ensure that switching between editor and visualization works * use the save button for the disabled state * update the question title when the question is saved * implement updating questions in place * rename replaceQuestion * make CreateQuestion props all optional * add background color to modal header * hide the save button if question is dirty * hide save button instead of disabling per design feedback * update e2e tests * revert e2e helpers * add title update assertions * whitespace changes * fix test import --------- Co-authored-by: Phoomparin Mano <poom@metabase.com> Co-authored-by: Phoomparin Mano <phoomparin@gmail.com>
-
github-automation-metabase authored
* update suggested import path * update suggested import path * add small tests for import paths * update comments * clarify the import path message --------- Co-authored-by: Phoomparin Mano <poom@metabase.com> Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
* Add new strings for v51.4 * Update translations * kick ci --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Ryan Laurie <iethree@gmail.com>
-
github-automation-metabase authored
-
github-automation-metabase authored
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
Co-authored-by: lbrdnk <lbrdnk@users.noreply.github.com>
-
github-automation-metabase authored
* Allow navigating with arrow up/down between lines in expression editor * Do not hijack up/down arrow keys for autocomplete suggestions navigation when there's only 1 suggestion * Add explanatory comments * Convert tokenizer to TS * Add a test * Format code * Add basic test case * Fix a deprecation * Handle incomplete bracket identifier tokens * Shorten code * Add comment * Fix suggestion not always getting selected * Fix computation * Fix types * Update comment * Add repros for #49882 * Add repro * Fix comment * Deprecate a HOC * Update assertion * Remove _.compose and default export * Fix types in ExplicitSize * Fix typing in ExpressionEditorTextfield * Fix types * Fix error handling * Fix showing errors when expression is invalid * Do not submit null expressions * Fix typing * Update assertion * Fix flaky test * Fix filter * Decrease flakiness * Fix crashing * Add comment * Fix incomplete bracket idenfitiers * Fix type * Improve typing * Add an explanatory comment Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Refactor: Speed up E2E tests by not relying on UI * Quarantine flaky E2E assertions Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
github-automation-metabase authored
* Update Readme version references and published npm version to 0.51.5 * Update CHANGELOG.md --------- Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 19, 2024
-
-
github-automation-metabase authored
Prevent an exception in api.table/batch-fetch-card-query-metadatas when cards is empty (#50115) (#50246) * Don't try to fetch dbs for zero cards in api.table/batch-fetch-card-query-metadatas Closes #48461 Ensure we don't throw an exception by attempting to fetch the Databases associated with potentially-deleted card ids in api.table/batch-fetch-card-query-metadatas. In particular, this ensures we don't generate an exception if the user does the following 1. Create a card "Source Card" 2. Create another card "Derived Card" with a :source-table of "Source Card" 3. Add Derived Card to a dashboard 4. Permanently delete (not just archive) the Source Card * Add test for virtual-table query-metadata with deleted source card * Add test for dataset query_metadata with deleted source card * Add test for dashboard query-metadata with deleted source card * Add test for card query-metadata with deleted source card * Add metabase.api.test-util and use it in query-metadata-with-deleted-card tests * Replace copy/pasted debug helpers with select-query-metadata-keys-for-debugging Co-authored-by: appleby <86076+appleby@users.noreply.github.com>
-
github-automation-metabase authored
* chore: forbid legacyQuery usage with eslint * fixup * fixup Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
* Add v0.51.4 to the list of releases * add 50.34 --------- Co-authored-by: Metabase bot <metabase-bot@metabase.com> Co-authored-by: Alex Yarosh <alexandra@metabase.com>
-
github-automation-metabase authored
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
feat(sdk): ability to render question layout when drilling down in interactive dashboard (#50017) (#50237) * allow passing custom views to underlying ad-hoc questions * update readme docs * accept component instead * tweak layout story * update docs * add e2e tests * cleanup tests * remove incorrect tests * simplify tests * rename prop to renderDrillThroughQuestion and update docs * swap docs order * add missing marker * clarify drill-through naming * replace dead links Co-authored-by: Phoomparin Mano <poom@metabase.com>
-
github-automation-metabase authored
* allow more iframe attributes * make iframe sandbox more permissive * update spec Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
# Conflicts: # src/metabase/email/slack_token_error.mustache # test/metabase/notification/payload/impl/system_event_test.clj Co-authored-by: Ryan Laurie <iethree@gmail.com>
-
github-automation-metabase authored
* trigger save handlers on question create * add skeleton example stories for save forms * update storybook stories * add tests for saving questions * docs update * add createCard assertions * rollback docs Co-authored-by: Phoomparin Mano <poom@metabase.com>
-