This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 12, 2024
-
-
Noah Moss authored
-
Oisin Coveney authored
-
- Nov 08, 2024
-
-
Phoomparin Mano authored
-
Phoomparin Mano authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Correct embedding hash options type semantically * Pass `X-Metabase-Locale` to embed downloads * wip locale header middleware * Allow smart scalar text to be translated * Stop using global variable * Add more details to embedding types * Extend the E2E util type and correct some properties types * Add e2e test * Fix dashboard name * Add a test for static embed question * Make a type name follows a convention Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Fix failed E2E tests due to missing default values * Fix public embed not working with `?locale` anymore * Revert "wip locale header middleware" This reverts commit 83d8d135. * Preserve locale when in the `as-admin` macro is used Motivating issue: ```shell ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Count" ] ``` I'm running a query that has aggregated columns and it is returning the untranslated. Note that these are computed and dynamically given a display name. ```clojure (case tag :count (i18n/tru "Count") :cum-count (i18n/tru "Cumulative count")) ``` The problem is that we run embedding things as admin. And that gets the current user, which in embed and public spaces is nil, and so binds a nil to user-locale, which defaults to english when translating. After: ``` ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Nombre de lignes" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:zh -pb | jq '.data|.cols|map(.display_name)' [ "State", "行数" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124 ' x-metabase-locale:es -pb | jq '.data|.cols|map(.display_name)' [ "State", "Contar" ] ``` This is fetching a dashboard's card which is a query of orders grouped by created at month, sum of total. --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- Nov 07, 2024
-
-
Nicolò Pretto authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
github-automation-metabase authored
-
- Nov 06, 2024
-
-
Phoomparin Mano authored
* move the database prompt to the very beginning * ability to use sample database for cli * print username and password in console * no tenancy isolation as a default option * highlight sample credentials file * update credential log messages Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * continue without tenancy isolation --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Jeff Bruemmer authored
-
Nicolò Pretto authored
Co-Authored-by:
Poom <poom@poom.dev>
-
Nicolò Pretto authored
* refactor + more specific auth errors * fix linting issues * make tests pass, again * make test pass for real? * continues the refactor and hopefully makes tests pass * try to simplify the logic a little bit more * also logs to the console for the edge case of invalid session * remove setLoginStatus * fix typo * fix debug line that should have been commented * remove dead code * remove test for code that doesnt exist * address feedback from PR * update test copy * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * update copy for site settings error * ex -> exception * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * update tests to use the updated copy + small typos * refactor: use jest spy on to check for console.error Co-authored-by:
"Mahatthana (Kelvin) Nomsawadi" <me@bboykelvin.dev> * use full error message in test * renamed response to session * mock implementation of console.log * fix(49482): don't create a new store on each MetabaseProvider render (#49492) * fix(49482): don't create a new store on each MetabaseProvider render * remove store prop as it seems to not be used --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 05, 2024
-
-
Denis Berezin authored
* Add possibility to hide columns in CollectionBrowser * Add tests * Review fixes * Fix e2e
-
Denis Berezin authored
* Add isOpen prop to control CreateDashboardModal * Add props to storybook
-
- Nov 04, 2024
-
-
Phoomparin Mano authored
feat(sdk): ability to enforce the destination collection to save to and hide the collection picker (#49251) * add ability to hide the collection picker * add save options * make sure collectionId is fresh * update sdk question form component * make collectionId accept null * apply saveOptions to sdk components * revert to use initialCollectionId as context name * target the correct collection id * add e2e tests * update e2e tests * move into within * update test * remove collectionId from default args * revert e2e of hide columns * make e2e helper more generic * use saveToCollectionId prop to save to a specific collection * update e2e tests * update comment formatting Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * clean up leftover changes from an earlier version * readme update * indicate that saveToCollectionId is only applicable to static questions * revert QuestionEditor.isSaveEnabled defaults * update comment format * remove unused initialCollectionId prop * experiment: try to fix failing custom-columns e2e --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Nov 01, 2024
-
-
Denis Berezin authored
* Fix scroll for EditableDashboard in fullscreen mode * Fix scroll for InteractiveDashboard in fullscreen mode * Display fullscreen control to dashboards by default * Fix issue with public shared questions empty footer
-
- Oct 31, 2024
-
-
Jeff Bruemmer authored
-
- Oct 30, 2024
-
-
Denis Berezin authored
* fix(sdk): Editable dashboard should not overlap content below it * Add sizing note
-
- Oct 29, 2024
-
-
Nicolò Pretto authored
have them in the real codebase + to remove warnings from test output
-
Oisin Coveney authored
-
- Oct 28, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
-
Phoomparin Mano authored
-
- Oct 25, 2024
-
-
Phoomparin Mano authored
* investigate hide columns * add update viz settings in the sdk * cleanup implementation * add storybook for interactive question * use the question callback to update viz settings * remove onUpdateVisualizationSettings * revert change to onUpdateVisualizationSettings * add click action behaviour * fix misspelling * add onUpdateQuestion mock function * add unit test for click action behaviour * add e2e test for hiding question column header
-
Nicolò Pretto authored
* test(sdk): add tests for auth flow * make the fetch token fn return something that will pass the validations we'll add in the next project * waitForRequest helper + add expects for card endpoints on api key test
-
Phoomparin Mano authored
* cancel request on unmount in static question * use deferred promise * remove logs * alias cancelled to deferred.promise * extract useLoadStaticQuestion hook * add tests for request cancellation * change updateQuestion method * add sanity check with fetchMock
-
- Oct 24, 2024
-
-
Phoomparin Mano authored
* implement saving questions in interactive question * close modal on create question * add e2e test for saving questions
-
Denis Berezin authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Oct 21, 2024
-
-
Nicolò Pretto authored
* run prettier on sdk readme * fix code snippets so that prettier can format them * put back the empty new line on the package.json
-
- Oct 18, 2024
-
-
Nicolò Pretto authored
* defineEmbeddingSdkConfig to make typing easier when the config is created outside of the jsx * also add defineEmbeddingSdkTheme, move them to index.ts as i don't have a good name for what file to put them into :shrugs: * updated the readme to use the defineXXX functions
-
Oisin Coveney authored
-
- Oct 17, 2024
-
-
Phoomparin Mano authored
* hide downloads by default in the sdk * update readme to reflect withDownloads prop * update readme formatting * update tests
-
Mahatthana (Kelvin) Nomsawadi authored
-
github-automation-metabase authored
-
- Oct 16, 2024
-
-
github-automation-metabase authored
-
Nicolò Pretto authored
* faster --watch command for the sdk * apparently we want an empty line at the end of jsons, but prettier removes it? * format tasks.json with prettier
* vscods tasks, move watch task from webpack config to the fixup script * cleanup webpack config * adds clean + waits for dist folder when not existing * minimal doc for the sdk commands
-
- Oct 15, 2024
-
-
Uladzimir Havenchyk authored
* fix circular deps in query_builder/components * js -> ts
-
- Oct 14, 2024
-
-
Oisin Coveney authored
-
- Oct 11, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Add Next.js to SDK readme * Fix typo
-