This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 10, 2023
-
-
Kamil Mielnik authored
* Add a repro for the basic case * Add more assertions * Remove external tag * Improve test name * Add a test case for visited questions * Fix initial state for lhc display name for visited questions * Refactor duplication * Update test names * Skip test that still fails * Revert "Fix initial state for lhc display name for visited questions" This reverts commit 36aca5469dff6e711725e930eb1b29b6bef7dbef. * Use getNotebookStep * Skip test until issue is fixed
-
Mahatthana (Kelvin) Nomsawadi authored
* Refactor to prepare for new requirement * Hide personal collections and items when configuring click behavior * Remove default export * Add tests * Fix type error * Review: Simplify test util * Update frontend/src/metabase-lib/parameters/utils/click-behavior.ts Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Consolidate collection util functions * Reuse an existing function * Fix conflict from rebasing off master --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Ngoc Khuat authored
-
Ngoc Khuat authored
-
Kamil Mielnik authored
* Display error instead of auto-fixing non-exiting tab id * Make deleted target dashboard tab an invalid click behavior state * Fix saving click behavior * Add a test for showing error when the tab has been removed * Add auto-fix for deleted tab when we don't render tabs dropdown * Update test names
-
Kamil Mielnik authored
* Do not show new question link when database does not support nested queries * Do not show new question link when nested queries are disabled * Add a unit test for disabled nested queries * Add a unit test for databases without nested queries support
-
Cal Herries authored
-
Nemanja Glumac authored
-
Alexander Solovyov authored
keys in serialization are be sorted by historical order first and alphabetically if they are not mentioned
-
Nemanja Glumac authored
-
- Nov 09, 2023
-
-
Cam Saul authored
-
Cam Saul authored
-
Noah Moss authored
Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
Cam Saul authored
-
Ryan Laurie authored
-
Nemanja Glumac authored
* Split visualizations E2E group * Rename visualizations to `visualizations-charts` * Update E2E matrix
-
Mark Bastian authored
* Attempting to fix x-ray back timeout issues with smaller card count It looks like the flakes on https://www.deploysentinel.com/ci/analysis?tab=flake for "dashboard back navigation should display a back to the dashboard button in table x-ray dashboards" and "dashboard back navigation should display a back to the dashboard button in model x-ray dashboards" frequently fail at the `cy.wait("@dataset")` stage. I'm guessing this is because the dashboard code is so slow. This PR limits the number of cards produce to `MAX_CARDS` (5) in order to speed up card generation and help with the flakes. * Adding a timeout to slow x-rays for back button. Hopefully, the small number of max cards makes this unnecessary, though. * Bumped timeout to 15s instead of 5s. Looks like it was already 5. Again, hopefully the change to minimized the number of generated cards will fix this flake and not take as long. * Fixing the `show` query param for x-rays `show` in `core` can be either `:all` or an integer. However, the API layer only exposes the `:all` or `nil` options. This PR exposes the integer path as well. Note that this is incremental to get flakes working faster. I'll still need to add API tests for this. * Adding API unit tests to `metabase.api.automagic-dashboards-test` for `show` cases. * Fixed deftest name to be unique. * Fixing reference to new card in flaky test
-
Noah Moss authored
Co-authored-by:
Luiz Arakaki <luiz.arakaki@metabase.com>
-
Braden Shepherdson authored
Adding unit tests for bug bash. Closes #14775.
-
Cam Saul authored
-
Luiz Arakaki authored
-
Case Nelson authored
* [MLv2] Test for 27323 Fixes #27323 * Address PR review
-
Case Nelson authored
Fixes #28609
-
Jesse Devaney authored
* separate SMTP connection settings from other email settings * update tests based on now setup flow - some tests were removed as the behaviors of the app have changed - some tests were updated to validate the new SMTP connection card and setup process * improve tests * replace styled component with mantine flex * fix type errors * refactor breadcrumbs to use native solution in SettingsBatchForm * only show breadcrumbs if email is already configured * catch and handle error if form submission fails * fix tests * remove dead code * fix test failure and consolidate similar E2E tests * update unit tests to account for new behavior * fix type error - remove unused dispatch prop * update unit tests to account for redirect behavior * move dispatch to useEffect and convert file to typescript * fix button state on save error * add unit tests for hiding SMTP configuration when cloud-hosted
-
Cal Herries authored
-
Cam Saul authored
-
Ryan Laurie authored
* enable actions on databases on a per-test basis * debug logging * try some stuff * optimistic sync * put some stuff back * revert formatting changes * revert debug changes [ci skip]
-
Nick Fitzpatrick authored
* Adding Stacked Checkbox component * Switching to checkbox variant * PR Feedback * Storybook cleanup * including description
-
Cal Herries authored
-
Nemanja Glumac authored
[ci skip]
-
- Nov 08, 2023
-
-
Ryan Laurie authored
-
Braden Shepherdson authored
This greatly improves the performance of `ML.display_info`, which is taking a lot of the cumulative time in the various MLv2 slowdown bugs recently: #35205, #25296.
-
Case Nelson authored
Fixes #12625
-
Case Nelson authored
Fixes #31384
-
Noah Moss authored
-
Jesse Devaney authored
* Add opt-in option to CC recipients in admin email settings * fix type errors * add E2E tests for CC/BCC email option
-
Jesse Devaney authored
* initial frontend commit * add authorized origins check with note * update interactive embedding unit test * add samesite cookie to embedding E2E * add unit tests for conditional note display * fix types * fix translations * use alert instead of custom component
-
Luis Paolini authored
-
Noah Moss authored
-
Mark Bastian authored
* Fixing dropdown filter value GET #32126 When GET "/:id/params/:param-key/values" is invoked, the endpoint looks for valid values to populate for the filter dropdowns using the resolved field-ids for the underlying item in the dashboard. In some cases, such as nested queries, the field is not referenced by id, but using the field name. This PR adds a branch that will look for fields by field ref (e.g. `[:field "SOURCE" {:base-type :type/Text}]`) if the field cannot be resolved by id. Fixes #32126 * lint fix
-