Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 28, 2024
    • Jeff Bruemmer's avatar
      docs - app db note (#43239) · 1670832a
      Jeff Bruemmer authored
      Unverified
      1670832a
    • Cal Herries's avatar
    • Jesse Devaney's avatar
      Implement graceful error handling for trend charts (#43090) · 8770ea27
      Jesse Devaney authored
      * fix trend charts erroring on latest value being null
      
      * refactor previousRowIndex calculation
      
      * handle errors gracefully
      
      * refactor error messages
      
      * update computeTrend unit tests
      
      * add error handling integration test
      
      * add E2E test to check that errors are gracefully handled
      
      * add integration test to enforce the fix
      
      * fix static viz
      
      * display more meaningful error on static-viz trend charts
      
      * move error handling out of trend chart and fix error handling in Visualization.tsx
      
      * update compute.unit.spec.js
      
      * update SmartScalar.unit.spec.js
      
      * use separate error handler for ErrorBoundary errors in Visualization.jsx
      
      * update E2E test
      
      * update error handling
      
      * update compute.unit.spec.js
      
      * fix react state change error in render function
      
      * show generic error message for ErrorBoundary caught errors
      
      * revert ErrorBoundary changes
      
      * remove generic error border for visualizations
      Unverified
      8770ea27
    • Jeff Bruemmer's avatar
      add 49.12 to list of releases (#43236) · cebf9a96
      Jeff Bruemmer authored
      Unverified
      cebf9a96
    • Phoomparin Mano's avatar
      feat(sdk): expose color and typography options for smart scalar in embedding SDK (#42915) · 8fc52d22
      Phoomparin Mano authored
      
      * feat(sdk): allow overriding positive and negative values
      
      * docs(sdk): add positive and negative colors to docs
      
      * feat(sdk): add smart scalar font size
      
      * feat(sdk): add smart scalar line height settings
      
      * feat(sdk): get rid of custom embedding mantine theme type
      
      * wip: setup storybook and loki for smart scalar
      
      * fix missing state for rendering visualizations
      
      * docs(sdk): add scalar customizations to readme
      
      * test(sdk): add test cases to loki
      
      * add smart scalar reference image
      
      * use css variables for brand
      
      * make embedding theme options partial
      
      * fix scalar value wrapper line height
      
      * update loki snapshot
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      8fc52d22
    • Kamil Mielnik's avatar
      Disable offset() in custom columns (#43224) · 3b3dcd86
      Kamil Mielnik authored
      * Disable offset in custom columns
      
      * Remove .only
      
      * Update CLJS tests
      Unverified
      3b3dcd86
    • Uladzimir Havenchyk's avatar
    • Oisin Coveney's avatar
      Convert ParametersList to TS (#42822) · ed3cfb60
      Oisin Coveney authored
      Unverified
      ed3cfb60
    • Alexander Solovyov's avatar
    • Anton Kulyk's avatar
      Fix rare axis ticks for timeseries axes (#43127) · cc660510
      Anton Kulyk authored
      * Fix typos
      
      * Tweak `maxTicksForChartWidth` calculation
      
      * Update Loki screenshots
      
      * Tweak `PIXELS_PER_CHARACTER`
      
      * Update test
      Unverified
      cc660510
    • Romeo Van Snick's avatar
      Allow creating new items by inserting comma in MultiAutocomplete (#42824) · b6bb9d18
      Romeo Van Snick authored
      
      * Pass current values to shouldCreate
      
      * Allow comma to create new item
      
      * Simplify getAvailableSelectItems
      
      * Add unit test for MultiAutocomplete input
      
      * Use text instead of Text in paste
      
      * Handle spaces in MultiAutocomplete
      
      * Remove cast
      
      * Reuse last var
      
      * Use haveLastBeenCalledWith over haveBeenCalledWith
      
      * Handle pasting when there is text in the input already
      
      * Accept quote-delimited values
      
      * Add info icon
      
      * Handle tab as a separator
      
      * Fix test cases for unsanitized parseValues
      
      * Add csv-parse
      
      * Use csv-parse to parse values
      
      * Apply the correct color to the info icon
      
      * Rename util to utils
      
      * Break up tooltip text
      
      * Only return unique values
      
      * Be more accepting around quotes in the middle of unescaped values
      
      * provide Buffer for csv-parse package in storybook
      
      * Use browser-friendly version of csv-parse
      
      * Remove unused eslint rule
      
      * Add specital case for csv-parse to jest config
      
      * Put uniqueness check in each state update
      
      * Only add partial value if it is valid
      
      * Only add partial value if it is valid
      
      * Fix test case for FilterValuePicker
      
      * Just use Set
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      * Allow parsing more than one value
      
      * Use isValid everywhere it makes sense
      
      * Add test for RTL languages
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      b6bb9d18
    • Kamil Mielnik's avatar
      Copy question link from dashboard (#42892) · e7948a72
      Kamil Mielnik authored
      * Remove dead CSS
      
      * Use proper types
      
      * Properly type parameterValues
      
      * Add href prop support to LegendCaption
      
      * Extract getNewCardUrl
      - move getParametersMappedToDashcard
      
      * Use href in CartesianChart
      
      * Handle RowChart
      
      * Handle Funnel
      
      * Format code
      
      * Fix types
      
      * Update first test in title-drill
      
      * Update test
      
      * Update test
      
      * Update tests
      - pass questionId in createQuestionAndDashboard
      
      * Add test for links
      
      * Fix createDashboardWithQuestions
      
      * Add missing click handler
      
      * Fix crash
      
      * Fix typo
      
      * Add a workaround for #42999
      
      * Fix tests
      
      * Fix hover color
      
      * Update comment
      
      * Get rid of mapStateToProps in DashboardGrid
      
      * Invert condition
      
      * Use useCallback instead useMemo
      
      * Do not pass getNewCardUrl down if navigateToNewCardFromDashboard is not present
      - Remove default noop for navigateToNewCardFromDashboard in PublicDashboard
      
      * Remove explicit undefined prop
      Unverified
      e7948a72
    • Phoomparin Mano's avatar
      feat(sdk): override chart colors (#42960) · 8cbacf75
      Phoomparin Mano authored
      * add color types for chart sdk colors
      
      * simplify chart color types
      
      * chart color mappings
      
      * apply mapping to master branch
      
      * add chart mapping to mantine
      
      * feat(sdk): apply chart accent colors to mantine and color getter
      
      * rename tint and shade
      
      * remove chart color logic from mantine
      
      * add a color mapping test
      
      * docs(sdk): add chart customizations to readme
      
      * add type comments on MappableSdkColor
      
      * cleanup sdk colors
      Unverified
      8cbacf75
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Fix typo (#43194) · 0c6b9355
      Mahatthana (Kelvin) Nomsawadi authored
      Unverified
      0c6b9355
    • Cal Herries's avatar
      Fix flaky migration rollback test for mysql:... · 92daf0cc
      Cal Herries authored
      Fix flaky migration rollback test for mysql: metabase.db.custom-migrations-test/migrate-uploads-settings-test-1 (#43210)
      
      Unverified
      92daf0cc
  2. May 27, 2024
  3. May 24, 2024
Loading