This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 16, 2024
-
-
Nick Fitzpatrick authored
* adding back events on persist and unpersist * adding e2e test * using cy.clock to speed up timers
-
Jeff Bruemmer authored
-
Jerry Huang authored
* add updatefirst and last name for google sso * Update src/metabase/integrations/google.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * address comments --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Sloan Sparger authored
-
Braden Shepherdson authored
`metabase.lib.types.isa/valid-filter-for?` returns true if the two columns belong to the same type family (strings, numbers, temporal) or the type of one column `isa?` subtype of the other. Fixes #37501. (Unblocks #37438.) Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Alexander Polyankin authored
* Remove table links * Remove possibly unused code from QuestionDataSource * Migrate QuestionDataSource to MLv2 * Migrate QuestionDataSource to MLv2 * Fix tests * Fix legacy query issue * Fix sandboxing issues * Add a comment * Format code --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Ngoc Khuat authored
-
Uladzimir Havenchyk authored
* Migrate dataset.js to TS * Make code more predictable
-
John Swanson authored
Originally I had planned on using this to ensure uniqueness of the ApiKey name. However, a) this is no longer a requirement, as we have a uniqueness constraint on `:name` of the ApiKey directly, b) it would be buggy anyway, because email addresses are case insensitive and `u/slugify` will in some cases return the same slug for different names, and c) it causes issues when you attempt to create a new ApiKey with the same name as a deleted ApiKey (because the old user still exists). The email can just be random - it's an implementation detail that shouldn't be exposed to users.
-
Romeo Van Snick authored
-
Chris Truter authored
* Add kondo for missing :export? on defsetting * And tons of explicit ignores, including some inadvertent test vars, probably * Disable linter in tests * Handle multi settings
-
Kamil Mielnik authored
* Migrate StructuredQuery.prototype.filter in ObjectDetailView * [MLv2] Add `legacy-column->metadata` for converting `DatasetColumn` The query and stage are unfortunately required to correctly handle aggregation references. Note that the JS version of this name is `legacy_column__GT_metadata`, with the double underscore. * Add TS wrapper * Use fromLegacyColumn * Make code more backwards-compatible * Make code more backwards-compatible * Remove type argument from startNewCard * Migrate startNewcard in actions/object-detail to MLv2 * Fix filter clause * Use numberFilterClause when dealing with numbers * Use numberFilterClause when dealing with numbers in ObjectDetailView * Update frontend/src/metabase/visualizations/components/ObjectDetail/ObjectDetailView.tsx Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * Do not pass tableId to Question.create * Get databaseId from Question instea of raw dataset query * Fix code order * Allow Field to be passed to fromLegacyColumn * Prettier --------- Co-authored-by:
Braden Shepherdson <braden@metabase.com> Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Nemanja Glumac authored
-
Nemanja Glumac authored
Fixes #37635
-
- Jan 15, 2024
-
-
Braden Shepherdson authored
Fixes #36973.
-
Braden Shepherdson authored
This is how legacy worked but MLv2 changed this behavior. Even if the metadata for a native column includes `:semantic-type :type/FK` and `:fk-target-field-id`, it can't be used for a JOIN unless it's a real field in the database. This undoes some hacks from #37079 that were misguided. Fixes #37067.
-
Case Nelson authored
* [MLv2] Visible columns should not see breakout binning or bucketing Fixes #37463 * Fix geographic drill through to look at returned columns first, fix quick filter test to match v.47 * Fix lint * Fix lint * Fix cljs compile * Address pr review * Fix test * Fix e2e test to reflect pre-mlv2 behavior
-
Nick Fitzpatrick authored
* Show Loading state while checking dashboard redirect * adding e2e test
-
Nick Fitzpatrick authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Braden Shepherdson authored
-
Sloan Sparger authored
-
Ngoc Khuat authored
-
Chris Truter authored
* Replace global var with explicit export? opt-ins * Rename helper and add proper docstring
-
Oleg Gromov authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Add `draftParameterValues` type to dashboard state * Fix type in `getParameterMappingOptions` * Convert dashboard selectors to TypeScript * Merge `selectors` and `selectors-typed` * Remove `selectors` directory * Fix `getDashboard` selector in public/embedded env
-
Chris Truter authored
* Pull out common method for pulling out settings for frontend or export * Migrate application-colors to use explicit :export? key * Add setting key to schema * Add tests
-
Luis Paolini authored
-
Cal Herries authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Add show metabase links toggle admin setting * Hide Metabase links * Fix type error * Add selector tests * Hide a link in HomeHelpCard * Make test names more consistent with existing test suites * Add tests to `NewModelOptions` * Prepare `VisualizationError` for testing * Add tests to `VisualizationError` * Hide link and add tests to `PreviewQueryModal` * Extract components to make it easier to test * Move the new component into its own folder * Hide Metabase link in `ActionDashcardSettings` * Prepare `EmptyFormPlaceholder` for testing * Hide Metabase link in `EmptyFormPlaceholder` * Extract Metabase link from `FormCreator` for testing * Hide Metabase link in `FormCreator` * Extract link from `DashCardCardParameterMapper` to prepare for testing * Hide Metabase link in `DashCardParameterMapper` * Clean up the test setup function * Hide Metabase link in `ExpressionEditorHelpText` * Hide Metabase link in `TagEditorHelp` * Hide Metabase links in `MetricList` * Hide Metabase link in `SegmentList` * Prepare `CaveatMessage` for testing * Hide Metabase link in `CaveatMessage` * Hide Metabase link in `CustomMapFooter` * Hide Metabase link in `ImpossibleToCreateModelModal` * Hide Metabase link in `ExpressionWidget` * Hide Metabase link in `ExpressionWidget` * Add BE tests * Update sample database description * Fix TypeScript type-check * Fix failed unit tests * Fix wrong test names * Add missing translations * Make tests looks like tests from other components * Update enterprise/frontend/src/metabase-enterprise/whitelabel/components/MetabaseLinksToggleWidget/MetabaseLinksToggleWidget.tsx Co-authored-by:
Nicolò Pretto <info@npretto.com> * Simplify the change * Fix weird import directory * Fix wrapped translation copy * Fix test name * Move comment next to the component * Fix test names * Review: Make code easier to review * Fix wrong document link * Update src/metabase/public_settings.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Update src/metabase/public_settings.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Address review: BE changes --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Chris Truter authored
* Add tests and non-redact criteria for csv validation * Set redaction rules and test validation for remaining types * Test that our format test coverage has not slipped * Test we have defined the redaction logic
-
- Jan 13, 2024
-
-
Braden Shepherdson authored
The QP sometimes provides a `:source-alias` and no `:join-alias` for a joined column. Then its MLv2 ref would be missing a `:join-alias` and it would not match its own column under `lib.equality/find-matching-column`. Fixes #36861.
-
- Jan 12, 2024
-
-
Gustavo Saiani authored
-
Nick Fitzpatrick authored
* building out partial graphs * Set up change deteected modal, graph loading states * e2e tests. Load admin permissions * reset permissions from memory on cancel * fixing types and tests
-
Oleg Gromov authored
-