This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 28, 2024
-
-
Aleksandr Lesnenko authored
* pie chart crashes when light or dark accents of instance colors overriden * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
- Oct 25, 2024
-
-
Aleksandr Lesnenko authored
* fix invalid pie other slice percentage label * fix invalid percentages of grouped into other rows * spec * spec * Update Loki Snapshots * Update Loki Snapshots * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
- Oct 18, 2024
-
-
Anton Kulyk authored
-
- Oct 08, 2024
-
-
Aleksandr Lesnenko authored
* isomorphic viz settings computation * stories * drop duplicated static formatter * drop formatValue from the renderingContext * clean up * stories * fix static charts stories * clean up mocked env * update sunburst formatters * no longer injecting formatValue * exclude modules without name * Update Loki Snapshots * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
- Oct 04, 2024
-
-
Emmad Usmani authored
* sunburst improvements * fix dimension picker styles * simplify styles * update e2e test * add loki specs * add missing newlines
-
- Oct 02, 2024
-
-
Emmad Usmani authored
* add sunburst to pie chart * fix type errors * consider all slice percent values for formatting percent on chart * fix lint error * refactor nested functions outside of parent * create and use getArrayFromMapValues helper * fix bug with percent significant digits * improve color picker * fix total visibility in small dashcards * fix missing field remappings * use aggregated value for click behavior * update minimum slice percentage logic * fix total text truncation * remove colors from tooltip for middle and outer slices * update e2e spec * update snapshot * update ring setting titles * address feedback * update comment
-
- Sep 13, 2024
-
-
Aleksandr Lesnenko authored
* dedupe a bit * remove pie row settings for values not from dataset * remove unnecessary filtering * series -> rows * extend spec * feedback
-
- Sep 09, 2024
-
-
Anton Kulyk authored
* Add series visibility props to `ChartWithLegend` * Mark pie slices as visible or hidden * Don't let to hide the last visible slice * Add space between legend dot and title * Fix legend dot outer circle is clipped by overflow * Use `ChartSettingSeriesOrder` for `pie.rows` setting * Actually hide slices and exclude from total calc * Don't show "0%" next to hidden slice legend items * Hide the "Other" slice * Make overflow slices popover interactive * Fix hover * Fix incorrect visibility state in legend popover * Add e2e test * Remove debug stuff * Fix hover and drill issues with slice index calc * Fix `pie.rows` ordering bug * Revert "Fix hover and drill issues with slice index calc" This reverts commit f104aaa5. * Fix hover and drill issues with slice index calc (2) `dataIndex` based approach * Use a special data key for the "Other" slice * Fixed viewport size in legend e2e test * Fix jumping legend width * Fix dot and label vertical alignment * Rework pie e2e test * Fix legend dot and label alignment
-
- Aug 29, 2024
-
-
Emmad Usmani authored
* allow re-ordering and re-naming pie chart slices * aggregate rows with same dimension value * show warning when dimension has unaggregated values * change colors from sidebar * implement renaming * styles for slice name widget * handle numeric slice keys for binned values relative dates etc * implement slice disabling * remove old colors setting * implement merging new and removing existing rows from query results * fix formatting bugs * port settings to static viz * fix bug with unaggregated data * address todos * add loki test * fix measure column settings widget erroring * fix settings sidebar crashing * add e2e tests * update snapshots * fix pie_chart.cy.spec.js CI-only flakes * fix #21504 repro failure * fix click action value * use nestedSettings instead of seriesSettings * fix settings sidebar crashing * fix row with 0 key not being draggable * fix flaky test * filter other slices from sidebar
-
- Aug 20, 2024
-
-
Uladzimir Havenchyk authored
* refactor: sort import members inside destructuring * Show an error message when the temporal unit is not applicable to a dashboard card (#46983) * Fix tests * Add tests * Add tests * Fix types * Fix types --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Jul 31, 2024
-
-
Emmad Usmani authored
* echarts pie * setup rendering pipeline for static pie chart (#43547) * setup rendering pipeline for static pie chart * remove more donut code from BE * compute viz settings for static pie chart (#43548) * compute viz settings for static pie chart * create chartModel for pie chart (#43549) * create chartModel for pie chart * render static pie chart (#43550) * render static pie chart * render static pie chart legend (#43551) * disable animation * alter static-viz pie chart be tests to account for echarts-impl The old implementation had a different implementation for legends, separate from the 'categorical/donut' js render. Echarts nicely combines the legend into the pie render, so we don't need to worry about that stuff anymore. Instead, I've written a simple set of assertions on the echarts pie implementation now. * Get rid of this test that was attempting to use old code path * echarts pie * One last spot where we don't need old pie stuff anymore. * add loki specs * save snapshots * fix small slices disappearing * update snapshots * add repro story for exteremely small slice * add snapshot * fix rounded total * fix percent formatting in legend * fix date dimension formatting * fix binned and relative date dimension labels on legend * add specs and snapshots for null and unaggregated dimensions * hide overlaping labels on chart * fix null dimension color * show error when metric column has a negative value * move legend to botom * make dot margin smaller * add columns to legend * sort legend vertically * dont use grid if only one row for legend * never hide legend in static viz * fix empty column culling * show single legend item * add long dimension name story * fix long dimension name in legend * right justify percentages in legend * remove negative error and re-add stories * handle negative values * create chart definition for dynamic pie chart * render chart with responsiveness * add comment for borderWidth calculation * center legend * fix legend centering * add story for missing currency formatting * fix missing currency formatting * fix graalvm crashing * fix column settings computation * add another currency formatting repro * fix wrong order of col settings computations * convert colors to hex * fix colors missing from viz settings * temp todo comment * fix colors in dynamic viz * update snapshots * fix crashing due to invalid dimension/metric setting * fix chart crashing for boolean dimension with labels on chart * add repro * fix regression in label formatting * fix labels on small slices * update specs * emphasis state for slice hover * recreate old label hiding logic * include height measurement in getIsLabelVisible * move d3 slices to chart model * fix labels on static viz * wip basic hover state and tooltip * fix emphasis style getting stuck by memoizing everything * update total display value * fix stuck emphasis by setting notMerge to false for pie only * handle other slice in tooltip * fix bugs in total graphic * use OTHER_SLICE_KEY const in static viz legend * implement legend and connect to hover state * implement click actions * fix slice not clickable * handle all zero slices * add repro * update specs * update pie_chart.cy.spec.js * update chart_drill.cy.spec.js * add repro for single column legend * use minimum 2 legend columns * fix legend text overlap * use more margin for single row legend * update specs * add repro for 28568 * add repro for 38424 * fix percent label not showing on large slices * hide total text when chart is small * replace comment about animations * show warning for mixed positive and negative values * delete old chart files * fix type errors * update d3 import * update specs * remove branch from uberjar.yml * dont put single slice into other * fix lint errors and pie render test * update more d3 imports * remove unused settings * revert preview-card-width change * remove unused import * remove majorWidth option from formatting * use debounceLeading refresh mode in ChartWithLegend * remove TOTAL_GRAPHIC_OPTION constant * delete unit test for pie chart * fix failing test by doing set comparison instead * fix typo in comment * remove SUNBURST_SERIES_OPTION constant * fix lint by removing unused eslint-disable * move default color computation to getValue * fix static pie test to show that we will always render the legend * update pie border color for night mode and embedding * fix styles for embedding case and add stories * skip embedding stories --------- Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-