Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 02, 2024
  2. Apr 01, 2024
  3. Mar 29, 2024
  4. Mar 28, 2024
    • Nick Fitzpatrick's avatar
      Fix for userEvents 14 on Master (#40761) · 589a665e
      Nick Fitzpatrick authored
      * Nick is sad
      
      * tests passing
      Unverified
      589a665e
    • John Swanson's avatar
      Fix `:dataset_query` (#40652) · c451e286
      John Swanson authored
      ... among other things.
      
      The order of arguments was wrong here, causing the default
      implementation of `post-process-collection-childre` to be called. The
      implementation for `:card` ends up removing the `:dataset_query`
      entirely, which is what was intended.
      Unverified
      c451e286
    • John Swanson's avatar
      Add `location` and `effective_location` to search (#40687) · 9961c354
      John Swanson authored
      For collections retrieved from the Search API, attach `location` and
      `effective_location` so the frontend knows... where they're located.
      Unverified
      9961c354
    • dpsutton's avatar
      Throttle reset_password endpoint (#40760) · e0d24077
      dpsutton authored
      Unverified
      e0d24077
    • adam-james's avatar
      Cards with Results Should Show up in Subscriptions (#40743) · 23bda114
      adam-james authored
      * Cards with Results Should Show up in Subscriptions
      
      Fixes: #40726
      
      This PR fixes a bug where setting 'Hide thie card if there are no results' in a Dashcard's viz-settings would hide the
      card even when there were results.
      
      * adjust test to show that the setting is respected
      
      Before, the setting would always hide the card. Now, the card is only hidden when there are no results. This test sets
      up 4 cards: 2 are normal, 2 have no results, but 1 has the setting to hide empty. THerefore, we should expect to see 3 results.
      Unverified
      23bda114
    • Sloan Sparger's avatar
      Upgrade @testing-library/user-event to v14 (#40269) · 3522a5cc
      Sloan Sparger authored
      
      * upgrades @testing-library/user-event to v14, updates test to accomidate events always returning promises and other breaking API changes
      
      * Fixing up broken suites. Half way
      
      * rest of tests
      
      * green plz
      
      * Fix new entries of userEvent usage
      
      * unit test adjustments
      
      ---------
      
      Co-authored-by: default avatarNick Fitzpatrick <nickfitz.582@gmail.com>
      Co-authored-by: default avatarUladzimir Havenchyk <uladzimir.dev@gmail.com>
      Unverified
      3522a5cc
    • adam-james's avatar
      Make format export optional (#40606) · 347c5ef4
      adam-james authored
      
      * Make Formatting on Exports Optional
      
      Formatting on exports can be turned off via a middleware key:
      
      `:format-export?` which will control if the 'app style' formatting will be applied to the exported results.
      `:format-export? false` will return the file as in previous Metabase versions.
      
      * format_export's default value provided in the QP middleware
      
      Should still default to formatted for v. 49, as the formatting is intended as a feature. This default value should be
      provided in a central place, so is added to the middleware and is therefore not necessary for the API to provide a default.
      
      * weird indentation
      
      * Add format_export param to dashboard dashcard query endpoint
      
      * Add format_export option to embedded dashboard downloads endpoint
      
      * Move default true value to the streaming-results-writer impls
      
      * Default true but for real this time
      
      * Add format_export to the public Question endpoint
      
      * Add test to card api
      
      * Dashboard exports endpoint test
      
      * Add test to dashboard embeds
      
      Test still fails and I don't know why yet
      
      * the dangers of println debugging....
      
      Well, I was passing a string false the whole time. Turns out the problem was me
      
      * Public Card downloads endpoint now has format_export and test
      
      * export_format also works for adhoc queries using api/dataset
      
      * Let defendpoint do the boolean parsing
      
      * Embed endpoint should now work too.
      
      * Unify format-rows and format-export middlewares
      
      * Sneaky endpoint!
      
      * In xlsx, always parse temporal strings so that viz-settings formatting is applied
      
      * Snuck in an incomplete change by accident. removed it.
      
      * Can now specify format/no format on subscriptions
      
      * Fix and move migration
      
      * default format rows to true in attachments
      
      * Ok, I think that should actually work for subscriptions.
      
      * Change endpoints to use format_rows instead of confusing format_export
      
      * format_rows everywhere
      
      * Fix more test failures
      
      * redef'd function had wrong signature
      
      * Make format export optional (FE part) (#40643)
      
      * Refactor download URL builder code
      
      Need to handle query `params` and request `body` separately
      
      * Export `useHover` from `metabase/ui`
      
      * Add unformatted export for dashboard cards
      
      * Add unformatted export for saved questions
      
      * Fix POST body encoding
      
      * Add unformatted export for ad-hoc questions
      
      * Ensure `format_export` is always false for Excel
      
      * Add unformatted export to public questions
      
      * Add unformatted export to embedded questions and dashboards
      
      * Fix behavior for PNG format
      
      * Add tests for `QueryDownloadPopover`
      
      * Fix e2e downloads helper (allow URL query params)
      
      * Rework alt key handling
      
      * Add e2e test
      
      * Switch to `format_rows` instead of `format_export`
      
      * Add unformatted export option to subscriptions
      
      * Fix `isHoldingAltKey` initial state
      
      * Rework e2e test to use Total column
      
      * Fix initial checkbox state for subscriptions
      
      * Use "Alt" in tooltip label for Windows/Linux
      
      * Show the subscriptions toggle only for CSV attachments
      
      ---------
      
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      
      * Address review feedback
      
      ---------
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      347c5ef4
    • Jeff Bruemmer's avatar
    • Alex Yarosh's avatar
      fix typo (#40744) · 036de067
      Alex Yarosh authored
      Unverified
      036de067
    • Oisin Coveney's avatar
      Fix wrong icon (#40738) · dac5a001
      Oisin Coveney authored
      Unverified
      dac5a001
    • Kamil Mielnik's avatar
      Fix some warnings in JS console (#40727) · 907a4160
      Kamil Mielnik authored
      * Fix warning about passing a ref to a function component
      - this didn't work and fortunately was not used (anymore) at all
      
      * Move comment where it belongs
      
      * Fix warning that functions cannot be react children
      Unverified
      907a4160
    • Alexander Polyankin's avatar
    • Oisin Coveney's avatar
    • Oisin Coveney's avatar
Loading