Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 18, 2024
    • Jeff Bruemmer's avatar
      docs - sdk cli guide (#50098) · 2be5130e
      Jeff Bruemmer authored
      Unverified
      2be5130e
    • Nicolò Pretto's avatar
      refactor(sdk): use ignore flag instead of mounted ref (#50069) · b3a46a77
      Nicolò Pretto authored
      * Revert "fix(sdk): put a bandage on the flashing error on static question in strict mode (#49659)"
      
      This reverts commit c57b3a38.
      
      * refactor(sdk): use ignore flag instead of mounted ref
      Unverified
      b3a46a77
    • lbrdnk's avatar
      Add temporal unit to display name (#48946) · 5203a15c
      lbrdnk authored
      * Add temporal unit to display name
      
      * Remove temporal unit adjustments from FE
      
      * formatColumn to displayNameForColumn
      
      * Factor out getFriendlyName
      
      * Adjust BE tests
      
      * Add require
      
      * Adjust FE unit tests
      
      * Adjust temporal-unit-parameters.cy.spec.js
      
      * Adjust dashboard-reproductions.cy.spec
      
      * Convert formatColumn occurrence
      
      * Adjust legacy display name logic generation
      
      After `getFriendlyName` was removed from FE, capitalization
      of display name should happen here. Logic is similar, should
      be adjusted prior merging the PR.
      
      * Adjust embedding-linked-filters.cy.spec.js
      
      * Adjust joins-reproductions.cy.spec.js
      
      * Adjust metrics-editing.cy.spec.js
      
      * Adjust timelines-question.cy.spec.js
      
      * Adjust offset.cy.spec.ts
      
      * TMP Avoid duplication of temporal unit in display name in MLv2 code
      
      * Probably FE fix: add default temporal bucket only if not present
      
      * WIP Add ends-with-temporal-unit? function
      
      Current strategy is to add temporal units to display names if same is not already present
      
      * Adjust display-name-method :metadata/column
      
      Append TU to display name only if different to what's already present
      
      * Adjust FE: show temporal unit that's present on field instead of default on hover on QueryColumnPicker element
      
      * Return also temporal-unit from visible-columns
      
      * Enable tempora-unit to be returned from previous-stage-or-source-visible-columns
      
      * WIP Adjust multi breakout multi stage e2e multiple-column-breakouts.cy.spec
      
      * Adjust multiple-column-breakouts.cy.spec.ts
      
      * It was not a bug.
      
      * Revert changes in _BaseBucketPickerPopover
      
      * Restore temporal-unit for next stages removal in stage.cljc
      
      * Add inherent-temporal-unit
      
      * Adjust display name temporal bucket logic
      
      * Rename to inherited-temporal-unit
      
      * Shutdown too broad display name capitalization
      
      * Eastwood
      
      * Adjust pivot-rows-order-test
      
      * Adjust pivot-non-numeric-values-in-aggregations
      
      * Adjust inherent to inherited
      
      * Rename to inherited
      
      * Add inherent-temporal-unit only to returned-columns
      
      * Update e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.js
      
      * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts
      
      * Update consistent-date-formatting-test
      
      * Update dashboard/x-rays.cy.spec.js
      
      * Update waterfall.cy.spec.js
      
      * Return month default for default inherited-temporal-unit
      
      * Update reproductions-3.cy.spec.js
      
      * Update downloads/downloads.cy.spec.js
      
      * Update legend.cy.spec.js
      
      * Update pie_chart.cy.spec.js
      
      * Update click-behavior.cy.spec.js
      
      * Update embedding-linked-filters.cy.spec.js
      
      * Return QueryColumnPicker's condition to original state
      
      * Remove reundant export
      
      * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts
      
      * Comment
      
      * Update nested.cy.spec.js
      
      * Update e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js
      
      * Adjust to TS types
      
      * Adjust for cljfmt
      
      * Capitalize
      
      * Add propagation tests
      
      * Add inherited-temporal-unit propagation for expressions
      
      * Add default inherited-temporal-unit test cases
      
      * Add qp temporal-bucket-test ns
      
      * Simplify default unit logic
      
      * Comment
      
      * Use NULL_DISPLAY_VALUE
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Comment
      
      * Remove redundant code (for now)
      
      * Update comments
      
      * Comment
      
      * Restore way too daring simplification
      
      * cljfmt
      
      * Adjust capitalize
      
      * Update comment
      
      * Update test
      
      * Address remarks in tests
      
      * Update test
      
      * Address remarks
      
      * typo
      Unverified
      5203a15c
  2. Nov 15, 2024
  3. Nov 14, 2024
  4. Nov 13, 2024
  5. Nov 12, 2024
  6. Nov 08, 2024
  7. Nov 07, 2024
  8. Nov 06, 2024
  9. Nov 05, 2024
  10. Nov 04, 2024
    • Phoomparin Mano's avatar
      feat(sdk): ability to enforce the destination collection to save to and hide... · de559f49
      Phoomparin Mano authored
      feat(sdk): ability to enforce the destination collection to save to and hide the collection picker (#49251)
      
      * add ability to hide the collection picker
      
      * add save options
      
      * make sure collectionId is fresh
      
      * update sdk question form component
      
      * make collectionId accept null
      
      * apply saveOptions to sdk components
      
      * revert to use initialCollectionId as context name
      
      * target the correct collection id
      
      * add e2e tests
      
      * update e2e tests
      
      * move into within
      
      * update test
      
      * remove collectionId from default args
      
      * revert e2e of hide columns
      
      * make e2e helper more generic
      
      * use saveToCollectionId prop to save to a specific collection
      
      * update e2e tests
      
      * update comment formatting
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * clean up leftover changes from an earlier version
      
      * readme update
      
      * indicate that saveToCollectionId is only applicable to static questions
      
      * revert QuestionEditor.isSaveEnabled defaults
      
      * update comment format
      
      * remove unused initialCollectionId prop
      
      * experiment: try to fix failing custom-columns e2e
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Unverified
      de559f49
  11. Nov 03, 2024
  12. Nov 01, 2024
  13. Oct 31, 2024
  14. Oct 30, 2024
  15. Oct 29, 2024
  16. Oct 28, 2024
  17. Oct 25, 2024
    • Phoomparin Mano's avatar
      fix(sdk): support hiding columns in InteractiveQuestion (#49013) · 6a927dee
      Phoomparin Mano authored
      * investigate hide columns
      
      * add update viz settings in the sdk
      
      * cleanup implementation
      
      * add storybook for interactive question
      
      * use the question callback to update viz settings
      
      * remove onUpdateVisualizationSettings
      
      * revert change to onUpdateVisualizationSettings
      
      * add click action behaviour
      
      * fix misspelling
      
      * add onUpdateQuestion mock function
      
      * add unit test for click action behaviour
      
      * add e2e test for hiding question column header
      Unverified
      6a927dee
    • Nicolò Pretto's avatar
      test(sdk): add tests for auth flow (#49108) · d7e56b26
      Nicolò Pretto authored
      * test(sdk): add tests for auth flow
      
      * make the fetch token fn return something that will pass the validations
      we'll add in the next project
      
      * waitForRequest helper + add expects for card endpoints on api key test
      Unverified
      d7e56b26
    • Phoomparin Mano's avatar
      fix(sdk): static question should cancel requests on component unmount (#48808) · 2fd311c5
      Phoomparin Mano authored
      * cancel request on unmount in static question
      
      * use deferred promise
      
      * remove logs
      
      * alias cancelled to deferred.promise
      
      * extract useLoadStaticQuestion hook
      
      * add tests for request cancellation
      
      * change updateQuestion method
      
      * add sanity check with fetchMock
      Unverified
      2fd311c5
Loading