This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 11, 2023
-
-
Braden Shepherdson authored
No `metabase.lib.js` wrapping yet.
-
Ryan Laurie authored
-
metamben authored
* Keep breakout and order-by columns as selectable Fixes #30568. The already selected columns are kept in the lists returned by breakoutable-columns and orderable-column, but they are marked with their position in the breakouts and order-bys list, respectively. * Add test for orderable-columns display-info * Add test for orderByPosition after a roundtrip * Cherry pick order-by cleanup fix * Fix breakoutable and orderable columns after round trip * Declare breakoutPosition in ColumnDisplayInfo * Address review feedback --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Mark Bastian authored
Removes display of underlying type of x-ray card (e.g. model, question) in title. Adds tests.
-
metamben authored
* Support expression options and fields only case and coalasce exprs Fixes #29938. Fixes #29950.
-
Ryan Laurie authored
* don't allow unscoped text selectors in e2e tests * properly scope some recent tests * disable eslint for legacy violations * scope selectors in dashboard drill test
-
metamben authored
* Prevent fields hiding joined fields (#30644) Fixes #29904. * Resolve join columns in the join stages The original implementation got into infinite loops.
-
Natalie authored
-
Anton Kulyk authored
* Add field dimension options types * Add dimension options to sample database mock
-
Alexander Polyankin authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Remove unused props * Remove `index` prop * Do not pass unneeded prop that's not even defined * Remove seven year old TODO * Render `ListItem` with the `li` HTML element
-
Nemanja Glumac authored
-
Anton Kulyk authored
* Add field values to mock sample database * Use correct `has_field_values` in mock sample database * Add `PEOPLE_SOURCE_VALUES` to mock sample database
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
Tim Macdonald authored
-
Cal Herries authored
* Add schemas driver feature flag * Add sql_jdbc schemas test * Add more general test * Make schemas feature default to true * Implement supports? for other drivers * Add feature to the driver changelog * Remove redundant schemas from h2 * Spelling fix Pre-rebase SHA: 8a2c7e0 or 5686b2f * MySQL does *not* support schemas * Bad rebase * Typo? Co-Authored-By:
Tim Macdonald <tim@metabase.com>
-
Ngoc Khuat authored
* Dashboard, DashboardCard, DashboardSeries to toucan2
-
Ngoc Khuat authored
* revert remove hydrate param values in #22836 * fix tests in ee ns * fix param field tests * Add e2e test * Add e2e tests * Add e2e tests * fix failed test and use t2 instead of db * fix wrong t2 call spec * fix failing tests * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values * apply Tamas's suggestions and unskip e2e tests * delete the e2e tests that AlexP previously added in this PR but brought it into a seperated PR" " * create Field values if not found * add a tests for when field values is not existed, we create them * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values * Fix the e2e test suite for remapping * Fix the e2e test suite for remapping * Fix the e2e test suite for remapping * Fix the e2e test suite for remapping * Fix the e2e test suite for remapping * revert the changes to create full values on demand * remove unused requires * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values * fix tests * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values Co-Authored-By:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- May 10, 2023
-
-
Natalie authored
-
dpsutton authored
* Alternative GEOJSON.io fix rather than not testing, just accept that we might get an expected location back or we might get nil. This actually represents how the application will behave and will seamlessly work as the service improves or continues throwing errors: ```shell ❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23" <html> <head><title>500 Internal Server Error</title></head> <body> <center><h1>500 Internal Server Error</h1></center> <hr><center>openresty</center> </body> </html> ❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73" [{"area_code":"0","organization_name":"GOOGLE","country_code":"US", "country_code3":"USA","continent_code":"NA","ip":"8.8.8.8", "region":"California","latitude":"34.0544","longitude":"-118.2441", "accuracy":5,"timezone":"America\/Los_Angeles","city":"Los Angeles", "organization":"AS15169 GOOGLE","asn":15169,"country":"United States"}, {"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US", "country_code3":"USA","continent_code":"NA","ip":"136.49.173.73", "region":"Texas","latitude":"30.2423","longitude":"-97.7672", "accuracy":5,"timezone":"America\/Chicago","city":"Austin", "organization":"AS16591 GOOGLE-FIBER","asn":16591,"country":"United States"}] ``` Changes are basically ```clojure (schema= (s/conditional some? <original-expectation-schema> nil? (s/eq nil) response-from-geojson) ``` * Filter to login error messages ```clojure (into [] (map (fn [[log-level error message]] [log-level (type error) message])) error-messages-captured-in-test) [[:error clojure.lang.ExceptionInfo "Error geocoding IP addresses {:url https://get.geojs.io/v1/ip/geo.json?ip=127.0.0.1}"] [:error clojure.lang.ExceptionInfo "Authentication endpoint error"]] ``` * check timestamps with regex seems like they fixed the service ```shell curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23" [{"country":"United States","latitude":"34.0544","longitude":"-118.2441","accuracy":5,"timezone":"America\/Los_Angeles","ip":"8.8.8.8","organization":"AS15169 GOOGLE","country_code3":"USA","asn":15169,"area_code":"0","organization_name":"GOOGLE","country_code":"US","city":"Los Angeles","continent_code":"NA","region":"California"},{"country":"United States","latitude":"30.2423","longitude":"-97.7672","accuracy":5,"timezone":"America\/Chicago","ip":"136.49.173.73","organization":"AS16591 GOOGLE-FIBER","country_code3":"USA","asn":16591,"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US","city":"Austin","continent_code":"NA","region":"Texas"},{"country":"France","latitude":"48.8582","longitude":"2.3387","accuracy":500,"timezone":"Europe\/Paris","ip":"185.233.100.23","organization":"AS198985 AQUILENET","country_code3":"FRA","asn":198985,"area_code":"0","organization_name":"AQUILENET","country_code":"FR","continent_code":"EU"}] ``` whereas a few hours ago that returned a 500. And now the timestamps are different ``` ;; from schema "2021-03-18T19:52:41.808482Z" ;; results "2021-03-18T20:52:41.808482+01:00" ``` kinda sick of dealing with this and don't want to deal with a schema that matches "near" to a timestamp. * Restore these i copied changes over from tim's fix and it included these fixes. But now the service is fixed and these are the original values from cam's original fixes
-
Ryan Laurie authored
-
Jesse Devaney authored
-
Ryan Laurie authored
-
Ryan Laurie authored
* update upload button tooltip * add upload tooltip subtitle * update test
-
Nemanja Glumac authored
* Fix wrong operator formatting in filter popover header * Replace custom `field.displayName` implementations * Improve displayName `metabase-lib` method * Evaluate to an actual display name value * Add repro for #27104 * Guard against the missing table
-
Alexander Polyankin authored
-
- May 09, 2023
-
-
-
Noah Moss authored
* initial fix * unskip repro * use as-admin in more places * macro tweak and unit tests * tweak macro again and add a sandboxing test * fix test
-
metamben authored
Fixes #29904.
-
metamben authored
-
metamben authored
* Omit :effective-type from legacy MBQL queries Fixes #30461.
-
Case Nelson authored
* Ignore provided metadata on new cards Fixes #30610 Removed an optimization that was put in place for copying cards that trusted the front end to pass in the correct result_metadata. Now, on new cards we ignore the passed in metadata and recalculate fresh. On models, however, we recalculate fresh metadata and combine it with the provided metadata. * Update test based on PR feedback
-
Nemanja Glumac authored
-
Ryan Laurie authored
* use syncable_schemas endpoint for upload settings * add syncable_schemas endpoint to mock * add e2e test for empty schema
-
Nemanja Glumac authored
* Do not render menu item that has both `action` and `link` props * Add unit tests * Address PR comment and refactor tests
-
Cal Herries authored
* Parse numbers according to number_separators setting * Add more test cases * Fix error * Dedupe tests * Make fn private * Doc fixes etc. --------- Co-authored-by:
Tim Macdonald <tim@tsmacdonald.com>
-