Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 27, 2022
  2. Jun 26, 2022
  3. Jun 24, 2022
    • Natalie's avatar
      docs - troubleshooting models (#23544) · 4c55a0e6
      Natalie authored
      4c55a0e6
    • Diogo Mendes's avatar
      Removing cancel on concurrency (#23536) · c7926fb8
      Diogo Mendes authored
      c7926fb8
    • Aleksandr Lesnenko's avatar
      Fix alerts and subscriptions bugs (#23523) · 85be305a
      Aleksandr Lesnenko authored
      * fix subscriptions and alerts
      
      * review
      
      * specs
      85be305a
    • Nick Fitzpatrick's avatar
      Updating Dashboard Action Menu, Moving bookmark action (#23528) · 2486c54f
      Nick Fitzpatrick authored
      * Updating Dashboard Action Menu, Moving bookmark action
      
      * Fixing Tests
      2486c54f
    • Alexander Polyankin's avatar
      da76aaa0
    • Anton Kulyk's avatar
      Respect DB management permission for model caching (#23507) · c191c47f
      Anton Kulyk authored
      * Add `can-manage` property to `Database` types
      
      * Only show enable/disable caching with DB access
      
      * Rename `tooltip` which is not a tooltip anymore
      
      * Remove redundant variable
      c191c47f
    • Anton Kulyk's avatar
      Move model cache section back to OSS (#23485) · 8655a146
      Anton Kulyk authored
      * Move model cache section to OSS
      
      * Don't handle "off" state as it won't be shown
      
      * Tweak copy
      8655a146
    • Alexander Polyankin's avatar
      Fix e2e tests (#23541) · 96d4efe4
      Alexander Polyankin authored
      96d4efe4
    • dpsutton's avatar
      Join slack channels with slack-id (#23495) · f25b6115
      dpsutton authored
      * Join slack channels with slack-id
      
      Fixes https://github.com/metabase/metabase/issues/23229
      
      We upload images to a channel and then send messages to the desired
      channel referencing those images from the channel we uploaded. But the
      slack bot must be in the channel to upload images.
      
      We handle this in `slack/upload-image!` where we watch the error message
      and join the channel if we recognize that is our issue. This special
      upload channel is set in the admin section when setting up, typed in by
      a human.
      
      Slack now requires us to use the internal id of the channel when
      joining. IE we used to use "metabase_files" but now we need to use
      something like "C87LQNL0Y23". But we do not have this information and we
      don't want humans to have to look this up.
      
      SOLUTION:
      change our cache. We currently just get a list of channels and users
      ```
      ["#general" "@dan" ...]
      ```
      
      Change this to
      ```
      {:version 2,
       :channels [{:display-name "#random",
                   :name "random",
                   :id "CT2FNGZSRPL",
                   :type "channel"}
                  {:display-name "#general",
                   :name "general",
                   :id "C87LQNL0Y23",
                   :type "channel"}
                  {:display-name "@dan",
                   :type "user",
                   :name "dan",
                   :id "UR65C4ZJVIW"}
                  ...]}
      ```
      
      Now we have slack internal ids present. When we attempt to join the
      slack channel, look for this id and attempt to use that.
      
      This has some knock-on effects. The UI still lists the channels in a
      channel picker when sending pulses. The list sent over the wire still
      mimics the previous shape (a flat list) and the choice is still the
      human readable name.
      
      In the future we should switch over to using the stable ids rather than
      solely channel names. Channel names can be renamed.
      
      I didn't go down this route because of the files channel. It is set at
      setup before we have a channel list. We could do some kind of run time
      migration but it is difficult because it would change the type of
      `slack-files-channel` from string to :json to handle the more complex
      type. Or perhaps we could make another setting to hold the json form and
      set that when we can positively identify things.
      
      In either case, these changes were not required yet to fix our slack
      issue. We just upgrade the information we have about slack channels,
      downgrade it when it hits the wire so the UI needs no changes, and use
      the extra information in the one spot where we need it.
      
      The cache is populated at startup and every four hours after that. So we
      do not need to worry about the old cache shape. If the new code is
      running, its the new cache.
      
      * Send #channel and @user forms over wire
      
      We store `{"channel": "#slack-pulses"}` in the pulse_channel.details
      column so we should keep those types of values around.
      
      We use the bare portion ("slack-pulses") rather than with the hash on it
      so we seem to be mixing usernames and channels. But these sets are
      distinct and you cannot create a channel with the same name as a
      user. Also, channel names are lowercase while channel-ids are uppercase
      so those are also non-overlapping sets.
      
      * Put slack token so slack reports as configured
      
      * Errant tap>
      
      * Alignment and docstring fixes
      
      * Remove slack-cache version information
      
      remove the `:version 2` from the cache. We are always in charge of the
      cache, and we compute it on startup so there's little risk of other data
      shapes being present.
      f25b6115
    • Natalie's avatar
      docs - known issues (#23522) · 0544f7d1
      Natalie authored
      0544f7d1
    • Aleksandr Lesnenko's avatar
      fix tooltip overflow (#23475) · 908375c2
      Aleksandr Lesnenko authored
      * fix tooltip overflow
      
      * explicit default for preventOverflow
      
      * check ci
      908375c2
    • metamben's avatar
      a99ec1df
    • Ariya Hidayat's avatar
    • Alexander Polyankin's avatar
    • Ryan Laurie's avatar
      Bulk Filter Modal: Show autocomplete options in popover (#23516) · a1e23ac7
      Ryan Laurie authored
      * show field options in popover
      a1e23ac7
    • Alexander Polyankin's avatar
      Fix editable text issues (#23532) · d1a2294a
      Alexander Polyankin authored
      d1a2294a
    • Diogo Mendes's avatar
    • Cal Herries's avatar
      Specify table for id column (#23525) · 2e34bd0d
      Cal Herries authored
      2e34bd0d
  4. Jun 23, 2022
    • adam-james's avatar
      application-colors have new keys that may be added via the getter (#23493) · 4bfd682f
      adam-james authored
      * application-colors have new keys that may be added via the getter
      
      Some colors previously had multiple usage contexts. For example, `accent1` was used both in charts and other parts of
      the summarize UI. Now, those notions are being separated, so `accent1` remains a valid key, and `summarize` is a new
      valid key. To make sure behaviour remains the same for existing whitelabel users who may have set these keys, when
      such a key exists, it is 'split' by the getter.
      
      For example, if the existing application-colors json contains `accent1`, the getter will add a new key `summarize`
      with the same value as `accent1`, but only if `accent1` already exists, otherwise it does nothing. This is also true
      for keys `brand`, which adds `accent0`, and `accent7`, which adds `filter`
      
      * Make application colors getter make change only once
      
      * Premium feature flag for test
      4bfd682f
    • Ariya Hidayat's avatar
Loading