This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 14, 2024
-
-
Nemanja Glumac authored
* Fix broken metric revision API call Fixes #42633 * Add E2E repro for #42633 * Fix metrics revision history in the data reference * Add repro for #42633 for the reference page * Consolidate tests * Do not use hard coded id * Fix lint errors
-
Ryan Laurie authored
* Disable Error Diagnostic Modal In Embedding * add e2e test for diagnostic modal
-
Ryan Laurie authored
* add recents tab type updates fix unit test change where we filter recents WIP Recents Tab wip recents design updates update recents design to match search use new recents format initial recents implementation fix types * fix e2e tests * update more e2e tests * allow recents filters * update test mocks * add unit tests for recents tab * update e2e tests * add e2e tests for recents picker tab * fix lost access test
-
Nemanja Glumac authored
* Expand the single or multi-selectable string filter choices * Mark operators as `multi` * Wrap an existing test in a separate `describe` block * Test multiple values settings * Expand repro to include multiple dashboard filter values * Ease the load by limiting the card results * Switch to the more flexible data structure for the dashboard filters * Expand the assertions * Fix typo Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- May 13, 2024
-
-
Emmad Usmani authored
-
Uladzimir Havenchyk authored
From now we allow mismatch between `base-type` if we need to match columns and columnSettings
-
Romeo Van Snick authored
* Copy question event to new version * Add new events for adding column via plus modal * Add plus modal variants * Track combine column via plus header * Track extract column via plus header * Add test for combine question event * Add e2e test for extract column shortcut snowplow events
-
Romeo Van Snick authored
* Add index file to CombineColumns * Add CombinColumnAction * Add CombinColumnsAction to default and embedding modes * Fix outdated --color-brand references * Set up sequenced close handler in combine columns * Allow outside clicks to happen when popover is not open * Add e2e test for combine column shortcut * Remove unused prop * Rename file to match component name: CombineColumnsAction * Simplify test assertion * Set width on combine columns action * Remove superflouous ? check
-
Kamil Mielnik authored
* Add repro for 32323 * Fix offset not working in case * Make offset function return any * Add a repro for #42377 * Fix order of adjustments * Revert unrelated changes * Remove commented code * Revert unrelated changes * Refactor test * Type offset aggregation * Add a test for no order by or breakout clause * Add a basic test for breakout clause * Fix assertion * Remove problematic dependency * Fix uuids generation * Remove redundant limit * Add a test for multiple breakouts * Update test names * Extract OFFSET_SUM_TOTAL_AGGREGATION * Add a repro for metabase#42509 * Add a test for multiple aggregations and breakouts * Remove unused intercept * Move uuid utils to separate file - it wasn't possible to import the utils file in e2e tests without it * Make isUuid a type guard * Add tests for sorting * Tag the test * Add extra assertion to verify expression parsing * Add a complex scenario * Reverse isFirst logic
-
Romeo Van Snick authored
* Render plus button in interactive table header * Add columnShortcuts on ClickObject * Dispatch click action for columnShortcuts on plus button * Make onCancel an optional prop * Add ExtractColumn action * Add ExtractColumn action to Default and Embedding mode * Use arrow_split icon for extract column action * Add title to extract column popover * Add e2e test for Extract column shortcut * Use asReturned in extract column * Rename to Extract part of column * Add a custom title to the new column shortcut * Add onClose to ExtractColumn popover * Hide shortcuts icon when question is not editable * Fix null error * Do not use submodules in import * Scroll more in test
-
- May 10, 2024
-
-
Emmad Usmani authored
* fix percent change across DST * add e2e tests
-
Raphael Krut-Landau authored
-
Kamil Mielnik authored
* Fix offset not working in case * Make offset function return any * Add a repro for #42377 * Fix order of adjustments * Revert unrelated changes * Remove commented code * Revert unrelated changes
-
Raphael Krut-Landau authored
-
- May 09, 2024
-
-
Ryan Laurie authored
* add upload management API * add upload management interface * remove trailing slash * add e2e upload management test * add upload management to token_features * jsdoc cleanup * fixes tests - include :upload_management in session_test - fix list-url in upload management - ensure local tests have upload management disabled (causes tests locally to 422 instead of 402: it has sufficient permissions from a local token to try to delete the table but the table is not an upload table, so you get a 422) * add card archive param * update tests * use common component * add success/error toasts * test success/error notifications * update e2e tests * address review comments * make sure we have fresh data --------- Co-authored-by:
dan sutton <dan@dpsutton.com>
-
Kamil Mielnik authored
* Fix flaky question management test * Update assertions order to reduce probability of a flake * Use explicit assertions * Change assertion order * Decrease flakiness
-
Ryan Laurie authored
* update e2e tests * rework linked entity picker * remove deprecated pickers * remove dead picker code * another one bites the dust * remove create collection on the go * update linkedEntityPicker unit tests- * update timeline move modal * remove unused import
-
- May 08, 2024
-
-
Ryan Laurie authored
* wip dashboard picker * use in homepage selector * remove dead code * remove generateKey prop * add unit tests * cleanup * WIP unit tests * update personal/public interactions and tests * update e2e tests * allow disabling items in dashboardPicker * add new dashboard tag invalidation * use rtk in dashboardpicker * use collection_id from api * horrendous way of disabling read only items * remove badness * disallow selecting read-only dashboards in dashboard picker search * pass search filter as prop * update types and tests * update types and tests * address review comments
-
Raphael Krut-Landau authored
-
adam-james authored
* Dashboard Param Values Common Impl for Embedding/Preview Embedding Refactor the embedding api namespace to allow a bit of reuse between the embedding api and the embedding preview api. In some cases, the implementations are not identical (in terms of the shape of data expected/endpoints available), so this is a first step to making them the same. Related: https://www.notion.so/metabase/Make-embedding-preview-behave-consistently-with-actual-static-embeds-855353d8e5e8411d8164c7ac563c7d2f * Add a test to verify that preview-embed param-values endpoint works * Use preview embed endpoint and fix relevant tests * Add tests * Change name to reflect what actually happens in the function --------- Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
Uladzimir Havenchyk authored
-
Nemanja Glumac authored
-
- May 07, 2024
-
-
Romeo Van Snick authored
* Add suffix to name if column already exists * Add test for duplicate combine columns * Use direct question in test Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Fix formatting * Use createQuestion for other tests too * Fix table references --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Nick Fitzpatrick authored
* initial attempt * search button * small adjustments * adding back the search bar * adding an extra check in e2e * i18n adjustment * impls pr feedback --------- Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
- May 06, 2024
-
-
Ryan Laurie authored
* add basic table component * use basic table in api keys UI * tweak padding * replace test id * update e2e test ids
-
Ryan Laurie authored
* Make bulk action bar reusable * unify bulk action usage * skip obsolete test
-
Emmad Usmani authored
* add percent change to timeseries tooltip * move computeChange to lib/numeric * cleaning up code in numeric.js * color text * add unit to key * move change to tooltip footer * fix extra bottom spacing * remove color * handle gaps in data * clean up code * add change to funnel tooltip * move retained to footer in funnel * update copy * remove min decimal count * rename events.tsx -> events.ts * add test cases to line-bar-tooltips.cy.spec.js * add specs for edge cases * readd exports to fix numeric.unit.spec.js * don't show for change for scatterplot * translate retained * use parseTimestamp instead of String * handle quarter interval * remove redundant dayjs calls * handle quarter with Feburary correctly
-
Alexander Polyankin authored
-
- May 03, 2024
-
-
Nicolò Pretto authored
* use css modules instead of inline styles for cursor: default (#41644) * add toast notification after the feedback (#41575) * fix modal submit sending data while button says skip (#41784) * fix: it should not send the feedback if button says skip * add comment explaining why we check that getLastFeedbackCall() is undefined * embedding homepage analytics (#41725) * rename defaultTab -> initialTab * add events schema for embedding-homepage * fix stories * add analytics, e2e tests and fix typo in dismiss reason * copy embed_flow schema for better diff in the next commit * adds isExampleDashboard to trackStaticEmbedPublished * utm tags * fix bug of is_example_dashboard * better test names * refactor embed homepage status type * "() => {}" => "_.noop" * add "Setup embedding" to the admin setup checklist (#41638) * add setup embedding to the admin setup checklist * restore whitespace as it was before * i miss prettier (whitespace again) * Clean up check list for embedding Largely making a new entry for the embedding info just to fight long lines. `:embedding-homepage-dismissed-as-done` just made the maps really long. If we have a `:done?` under an `:embedding` keyword it reads much more naturally. Also, The previous diff was calling `boolean` on a var rather than invoking the var: ```clojure :embedding-app-origin (boolean embed.settings/embedding-app-origin) ;; ^^^^^^^^^^^^^^ needs to be (invoked) ``` --------- Co-authored-by:
dan sutton <dan@dpsutton.com> * Change utm tags for embedding homepage links (#42042) * update utm tags * utm_media -> utm_content * add description to the checklist setup step (#42200) --------- Co-authored-by:
dan sutton <dan@dpsutton.com>
-
Anton Kulyk authored
* Rename "Line style" to "Line shape" * Add "line.style" viz setting * Add "line.size" viz setting * Apply new viz settings in line/area charts * Clean up `ChartSettings` test suite * Fix default values not applied * Add visual test * Add E2E test * Rework default values * Use constant S/M/L values for "line.size" setting
-
Raphael Krut-Landau authored
Lets the `ItemsTable` component have customizable columns. The logic for this is contained in `BaseItemsTable`. This is preliminary work for #41614 This doesn't introduce any new UI, but there is a unit test for the new logic. The main thing to check is whether the table on the collections page stills work correctly. Note how the columns adjust as you resize the viewport horizontally. (In fact, the columns will sometimes adjust as you close and open the sidebar, because the width they are paying attention to is the width of the area to the right of the sidebar.) Closes #41908
-
Romeo Van Snick authored
* Add snowplow event for column combine via header * Add test for snowplow event * Remove unnecessary within wrapper * Fix linting issues
-
Romeo Van Snick authored
* Add helper to track column extractions * Track column extractions * Add text for column extraction * Pass correct extraction to trackColumnExtractViaShortcut
-
Romeo Van Snick authored
-
Romeo Van Snick authored
* Add test for email extractions * Fix swapped domain and host examples * Add tests for URL columns * Fix examples for shortcut too * Use arrow function instead of function
-
- May 02, 2024
-
-
Uladzimir Havenchyk authored
-
Romeo Van Snick authored
* Add trackColumnExtractViaHeader helper * Add Lib.extract wrapper * Track column extractions via header * Fix analytics event name * Add tests for extract action analytics * Set up extractions metadata helper * Use functionsUseByExtraction in analytics * Add custom type for ExtractionTag * Use ExtractionTag in analytics * [MBQL lib] Add `Lib.columnExtractDrillExtractions` This gets the extractions from a column-extract drill, which is needed in the UI. * Add extractionExpression wrapper * Add extractionsForDrill helper * Fix type signature of extractionExpression * Use expressionParts for getting expression function * Walk expression to get functions used * Simplify ColumnExtractionTag * Fix expected expression * Be more explicit with what the guard does --------- Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
Nemanja Glumac authored
* Explicitly wait for the result to load * Remove the drill-through part from the repro
-
Nick Fitzpatrick authored
* Adding Descriptions to search results in palette * Palette Results List component * adjusting e2e and unit tests * type fix * removing duplicate theme font * fix typo, palette types adjustment
-
lbrdnk authored
-