Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 14, 2024
    • Nemanja Glumac's avatar
      Fix broken metric revision API call (#42634) · f4c7b9f0
      Nemanja Glumac authored
      * Fix broken metric revision API call
      
      Fixes #42633
      
      * Add E2E repro for #42633
      
      * Fix metrics revision history in the data reference
      
      * Add repro for #42633 for the reference page
      
      * Consolidate tests
      
      * Do not use hard coded id
      
      * Fix lint errors
      f4c7b9f0
    • Ryan Laurie's avatar
      Disable Error Diagnostic Modal In Embedding (#42641) · 5437e3d3
      Ryan Laurie authored
      * Disable Error Diagnostic Modal In Embedding
      
      * add e2e test for diagnostic modal
      5437e3d3
    • Ryan Laurie's avatar
      Recents Picker Tab (#42079) · 52d32c15
      Ryan Laurie authored
      * add recents tab
      
      type updates
      
      fix unit test
      
      change where we filter recents
      
      WIP Recents Tab
      
      wip recents
      
      design updates
      
      update recents design to match search
      
      use new recents format
      
      initial recents implementation
      
      fix types
      
      * fix e2e tests
      
      * update more e2e tests
      
      * allow recents filters
      
      * update test mocks
      
      * add unit tests for recents tab
      
      * update e2e tests
      
      * add e2e tests for recents picker tab
      
      * fix lost access test
      52d32c15
    • Nemanja Glumac's avatar
      Allow multiple values for string operators in the dashboard (#42013) · 1a44a83c
      Nemanja Glumac authored
      
      * Expand the single or multi-selectable string filter choices
      
      * Mark operators as `multi`
      
      * Wrap an existing test in a separate `describe` block
      
      * Test multiple values settings
      
      * Expand repro to include multiple dashboard filter values
      
      * Ease the load by limiting the card results
      
      * Switch to the more flexible data structure for the dashboard filters
      
      * Expand the assertions
      
      * Fix typo
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      1a44a83c
  2. May 13, 2024
    • Emmad Usmani's avatar
      47148ce7
    • Uladzimir Havenchyk's avatar
      Partially fix columns and viz settings mismatch (#42344) · 1fe63c52
      Uladzimir Havenchyk authored
      From now we allow mismatch between `base-type` if we need to match columns and columnSettings
      1fe63c52
    • Romeo Van Snick's avatar
      Combine/extract shortcuts snowplow events (#42445) · 9665e569
      Romeo Van Snick authored
      * Copy question event to new version
      
      * Add new events for adding column via plus modal
      
      * Add plus modal variants
      
      * Track combine column via plus header
      
      * Track extract column via plus header
      
      * Add test for combine question event
      
      * Add e2e test for extract column shortcut snowplow events
      9665e569
    • Romeo Van Snick's avatar
      Combine column shortcut (#42442) · e3dffcc4
      Romeo Van Snick authored
      * Add index file to CombineColumns
      
      * Add CombinColumnAction
      
      * Add CombinColumnsAction to default and embedding modes
      
      * Fix outdated --color-brand references
      
      * Set up sequenced close handler in combine columns
      
      * Allow outside clicks to happen when popover is not open
      
      * Add e2e test for combine column shortcut
      
      * Remove unused prop
      
      * Rename file to match component name: CombineColumnsAction
      
      * Simplify test assertion
      
      * Set width on combine columns action
      
      * Remove superflouous ? check
      e3dffcc4
    • Kamil Mielnik's avatar
      Cover `Offset()` in aggregations with e2e tests (#42455) · f596f0b0
      Kamil Mielnik authored
      * Add repro for 32323
      
      * Fix offset not working in case
      
      * Make offset function return any
      
      * Add a repro for #42377
      
      * Fix order of adjustments
      
      * Revert unrelated changes
      
      * Remove commented code
      
      * Revert unrelated changes
      
      * Refactor test
      
      * Type offset aggregation
      
      * Add a test for no order by or breakout clause
      
      * Add a basic test for breakout clause
      
      * Fix assertion
      
      * Remove problematic dependency
      
      * Fix uuids generation
      
      * Remove redundant limit
      
      * Add a test for multiple breakouts
      
      * Update test names
      
      * Extract OFFSET_SUM_TOTAL_AGGREGATION
      
      * Add a repro for metabase#42509
      
      * Add a test for multiple aggregations and breakouts
      
      * Remove unused intercept
      
      * Move uuid utils to separate file
      - it wasn't possible to import the utils file in e2e tests without it
      
      * Make isUuid a type guard
      
      * Add tests for sorting
      
      * Tag the test
      
      * Add extra assertion to verify expression parsing
      
      * Add a complex scenario
      
      * Reverse isFirst logic
      f596f0b0
    • Romeo Van Snick's avatar
      Extract column shortcut (#42261) · eca348ea
      Romeo Van Snick authored
      * Render plus button in interactive table header
      
      * Add columnShortcuts on ClickObject
      
      * Dispatch click action for columnShortcuts on plus button
      
      * Make onCancel an optional prop
      
      * Add ExtractColumn action
      
      * Add ExtractColumn action to Default and Embedding mode
      
      * Use arrow_split icon for extract column action
      
      * Add title to extract column popover
      
      * Add e2e test for Extract column shortcut
      
      * Use asReturned in extract column
      
      * Rename to Extract part of column
      
      * Add a custom title to the new column shortcut
      
      * Add onClose to ExtractColumn popover
      
      * Hide shortcuts icon when question is not editable
      
      * Fix null error
      
      * Do not use submodules in import
      
      * Scroll more in test
      eca348ea
  3. May 10, 2024
  4. May 09, 2024
    • Ryan Laurie's avatar
      Allow Admins to clean up uploaded tables in bulk (#42183) · 06cd458d
      Ryan Laurie authored
      
      * add upload management API
      
      * add upload management interface
      
      * remove trailing slash
      
      * add e2e upload management test
      
      * add upload management to token_features
      
      * jsdoc cleanup
      
      * fixes tests
      
      - include :upload_management in session_test
      - fix list-url in upload management
      - ensure local tests have upload management disabled
        (causes tests locally to 422 instead of 402: it has sufficient
        permissions from a local token to try to delete the table but the
        table is not an upload table, so you get a 422)
      
      * add card archive param
      
      * update tests
      
      * use common component
      
      * add success/error toasts
      
      * test success/error notifications
      
      * update e2e tests
      
      * address review comments
      
      * make sure we have fresh data
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      06cd458d
    • Kamil Mielnik's avatar
      Fix flaky question management e2e test (#42444) · 6c9099bf
      Kamil Mielnik authored
      * Fix flaky question management test
      
      * Update assertions order to reduce probability of a flake
      
      * Use explicit assertions
      
      * Change assertion order
      
      * Decrease flakiness
      6c9099bf
    • Ryan Laurie's avatar
      Remove Dead Pickers (#41801) · 7ce86613
      Ryan Laurie authored
      * update e2e tests
      
      * rework linked entity picker
      
      * remove deprecated pickers
      
      * remove dead picker code
      
      * another one bites the dust
      
      * remove create collection on the go
      
      * update linkedEntityPicker unit tests-
      
      * update timeline move modal
      
      * remove unused import
      7ce86613
  5. May 08, 2024
  6. May 07, 2024
  7. May 06, 2024
    • Ryan Laurie's avatar
      Basic Table Component (+ use it for API Keys) (#42287) · 2205ece6
      Ryan Laurie authored
      * add basic table component
      
      * use basic table in api keys UI
      
      * tweak padding
      
      * replace test id
      
      * update e2e test ids
      2205ece6
    • Ryan Laurie's avatar
      Make bulk action bar reusable (#42296) · a3b1d795
      Ryan Laurie authored
      * Make bulk action bar reusable
      
      * unify bulk action usage
      
      * skip obsolete test
      a3b1d795
    • Emmad Usmani's avatar
      add percent change to timeseries tooltip (#42059) · 9a2fa4a8
      Emmad Usmani authored
      * add percent change to timeseries tooltip
      
      * move computeChange to lib/numeric
      
      * cleaning up code in numeric.js
      
      * color text
      
      * add unit to key
      
      * move change to tooltip footer
      
      * fix extra bottom spacing
      
      * remove color
      
      * handle gaps in data
      
      * clean up code
      
      * add change to funnel tooltip
      
      * move retained to footer in funnel
      
      * update copy
      
      * remove min decimal count
      
      * rename events.tsx -> events.ts
      
      * add test cases to line-bar-tooltips.cy.spec.js
      
      * add specs for edge cases
      
      * readd exports to fix numeric.unit.spec.js
      
      * don't show for change for scatterplot
      
      * translate retained
      
      * use parseTimestamp instead of String
      
      * handle quarter interval
      
      * remove redundant dayjs calls
      
      * handle quarter with Feburary correctly
      9a2fa4a8
    • Alexander Polyankin's avatar
      649de4ff
  8. May 03, 2024
    • Nicolò Pretto's avatar
      Embed homepage, MS4 (#41990) · 55500108
      Nicolò Pretto authored
      
      * use css modules instead of inline styles for cursor: default (#41644)
      
      * add toast notification after the feedback (#41575)
      
      * fix modal submit sending data while button says skip (#41784)
      
      * fix: it should not send the feedback if button says skip
      
      * add comment explaining why we check that getLastFeedbackCall() is undefined
      
      * embedding homepage analytics (#41725)
      
      * rename defaultTab -> initialTab
      
      * add events schema for embedding-homepage
      
      * fix stories
      
      * add analytics, e2e tests and fix typo in dismiss reason
      
      * copy embed_flow schema for better diff in the next commit
      
      * adds isExampleDashboard to trackStaticEmbedPublished
      
      * utm tags
      
      * fix bug of is_example_dashboard
      
      * better test names
      
      * refactor embed homepage status type
      
      * "() => {}" => "_.noop"
      
      * add "Setup embedding" to the admin setup checklist (#41638)
      
      * add setup embedding to the admin setup checklist
      
      * restore whitespace as it was before
      
      * i miss prettier (whitespace again)
      
      * Clean up check list for embedding
      
      Largely making a new entry for the embedding info just to fight long
      lines. `:embedding-homepage-dismissed-as-done` just made the maps really
      long. If we have a `:done?` under an `:embedding` keyword it reads much
      more naturally.
      
      Also, The previous diff was calling `boolean` on a var rather than
      invoking the var:
      
      ```clojure
      :embedding-app-origin (boolean embed.settings/embedding-app-origin)
      ;;                             ^^^^^^^^^^^^^^ needs to be (invoked)
      ```
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      
      * Change utm tags for embedding homepage links (#42042)
      
      * update utm tags
      
      * utm_media -> utm_content
      
      * add description to the checklist setup step (#42200)
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      55500108
    • Anton Kulyk's avatar
      Add viz settings to manage line style and thickness to line/area charts (#42043) · 434e4202
      Anton Kulyk authored
      * Rename "Line style" to "Line shape"
      
      * Add "line.style" viz setting
      
      * Add "line.size" viz setting
      
      * Apply new viz settings in line/area charts
      
      * Clean up `ChartSettings` test suite
      
      * Fix default values not applied
      
      * Add visual test
      
      * Add E2E test
      
      * Rework default values
      
      * Use constant S/M/L values for "line.size" setting
      434e4202
    • Raphael Krut-Landau's avatar
      Enable customization of columns in ItemsTable (#41777) · 5f3cca25
      Raphael Krut-Landau authored
      Lets the `ItemsTable` component have customizable columns.
      
      The logic for this is contained in `BaseItemsTable`. This is preliminary work for #41614
      
      This doesn't introduce any new UI, but there is a unit test for the new logic.
      
      The main thing to check is whether the table on the collections page stills work correctly. Note how the columns adjust as you resize the viewport horizontally. (In fact, the columns will sometimes adjust as you close and open the sidebar, because the width they are paying attention to is the width of the area to the right of the sidebar.)
      
      Closes #41908
      5f3cca25
    • Romeo Van Snick's avatar
      Add snowplow event for combining columns via chill mode header (#42173) · 3b4af163
      Romeo Van Snick authored
      * Add snowplow event for column combine via header
      
      * Add test for snowplow event
      
      * Remove unnecessary within wrapper
      
      * Fix linting issues
      3b4af163
    • Romeo Van Snick's avatar
      Snowplow event for extract action via notebook shortcut (#42095) · 021c35aa
      Romeo Van Snick authored
      * Add helper to track column extractions
      
      * Track column extractions
      
      * Add text for column extraction
      
      * Pass correct extraction to trackColumnExtractViaShortcut
      021c35aa
    • Romeo Van Snick's avatar
      0691779d
    • Romeo Van Snick's avatar
      Add tests for url and email columns (#42144) · a616d3b6
      Romeo Van Snick authored
      * Add test for email extractions
      
      * Fix swapped domain and host examples
      
      * Add tests for URL columns
      
      * Fix examples for shortcut too
      
      * Use arrow function instead of function
      a616d3b6
  9. May 02, 2024
Loading