Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 14, 2022
  2. Oct 13, 2022
  3. Oct 12, 2022
    • Cam Saul's avatar
      Add CLI SerDes command for seeding entity IDs (#25655) (#25870) · ad103807
      Cam Saul authored
      * Add CLI SerDes command for seeding entity IDs (#25655)
      
      * Remove stray comment
      
      * Fix Kondo error
      
      * Fix Eastwood error
      
      * Update identity-hash-fields to multimethod for ModelAction
      
      * Fix identity-hash-fields for Dimension and DashboardCardSeries
      ad103807
    • metamben's avatar
      Return models used by the app in GET /app/:id (#25823) · 1154cad4
      metamben authored
      * Return models used in scaffolding in GET /app/:id
      * Return models added to an app page
      * Return models referenced by queries on app pages
      1154cad4
    • Ryan Laurie's avatar
      Data apps: faster action adding (#25846) · 98da65ac
      Ryan Laurie authored
      
      * [Apps] Model Actions
      
      WIP Adding migration and endpoints for model_action.
      
      * WIP model action execution
      
      Changing the execution endpoints again, still working on implicit action
      execution tests. Need to also test the parameters fetch.
      
      * Re-add execution route for dashcard action_id until Front End catches up
      
      * Add name to model_action GET
      
      * Hydrate model-action on dashcards
      
      * Rename and combine hydration of model_action to action
      
      * Implicit action execution support. Use slug columns as parameter ids
      
      * Go through model-action when using GET /action
      
      * FE integration fixes
      
      * Move action execution to use new parameter shape
      
      Now, parameters should be a map of parameter-id to value
      Parameter-id should be mapped on the FE. So the action parameter-id not the unmapped
      dashboard parameter-id.
      
      * Bring ModelAction into copy code
      
      * Generate target of implicit actions to match http actions
      
      * Update action test to place action on model
      
      * Add unique constraint to model_action for (card_id, slug)
      
      * Add missing require
      
      * model_action.slug needs to be varchar for mysql constraint
      
      * Fix test from unique constraint
      
      * Consistent ordering for tests
      
      * Addressing Code Reviews and Scaffold changes
      
      * Add type: implicit to implicit model actions
      
      * Update src/metabase/api/model_action.clj
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Allow changing card_id with PUT to dashcard for model-actions
      
      * Update tests after merge
      
      * Fix implicit delete and add better test coverage
      
      * Addressing review changes
      
      Add PUT test
      Add schema for dashboard-id and dashcard-id params
      Fix select ordering in test
      
      * save actions in models
      
      * list model actions on detail page (#25648)
      
      * Link Dashcards to model-based actions (#25770)
      
      * Link dashcards to model-based actions
      
      * address review comments
      
      * Data apps model actions implicit creator (#25807)
      
      * Link dashcards to model-based actions
      
      * address review comments
      
      * Link dashcards to model-based actions
      
      * Allow implicit actions to be used like explicit ones
      
      * address review comments
      
      * update action types
      
      * add action sidebar
      
      * remove action selection from click behavior sidebar
      
      * rework action picker
      
      * add shortcut to create an action for a model
      
      * update tests
      
      * address review comments
      
      Co-authored-by: default avatarCase Nelson <case@metabase.com>
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      98da65ac
    • Nick Fitzpatrick's avatar
      25453 merge axis labels tab (#25886) · 4c401fca
      Nick Fitzpatrick authored
      * Initial Attempt
      
      * Adding Divider
      
      * PR Feedback
      4c401fca
    • Case Nelson's avatar
      [Apps] Small scaffolding bug fixes (#25883) · 087bce5b
      Case Nelson authored
      * [Apps] Small scaffolding bug fixes
      
      Detail Object should use dimension target
      List link should use pk-field-name
      
      * Fix test - ordered_cards behaving oddly
      
      * source id should be pk-field name
      087bce5b
    • Nick Fitzpatrick's avatar
      Viz settings field partition dnd (#25882) · e03acb29
      Nick Fitzpatrick authored
      * Refactoring ChartSettingFieldsPartition DnD logic
      
      * small adjustments
      
      * removing unneeded state
      
      * PR Feedback, clean up dragEnd Logic
      
      * Updating cypress test
      
      * More PR Feedback
      e03acb29
    • Braden Shepherdson's avatar
      Serdes v2: Improved selective serialization; several fixes for Stats (#25834) · b64e3d65
      Braden Shepherdson authored
      These changes resulted from the effort to serialize and deserialize some
      collections from our internal Stats instance, which did not
      (de)serialize correctly out of the box.
      
      The main improvement is more robust "escape" analysis - making sure that
      all dashboards, cards, models, etc. required by the curated collections
      actually belong to those curated collections. (Many cards on Stats were
      actually in people's personal collections and publicly readable - that
      doesn't work with the curated git workflow.)
      
      This adds some new tests, trying to capture some complex MBQL queries
      and make sure they're correctly (de)serialized.
      b64e3d65
    • Jeff Bruemmer's avatar
      docs - date expressions (#25887) · 4f17bde2
      Jeff Bruemmer authored
      4f17bde2
    • Noah Moss's avatar
      fix flaky test (#25894) · c46e3628
      Noah Moss authored
      c46e3628
    • Noah Moss's avatar
      Fix a serialization test by not hardcoding tmp directory (#25880) · 09f98f6f
      Noah Moss authored
      * fix serialization test by not hardcoding tmp directory
      
      * clean imports
      
      * cleanup
      
      * change approach
      09f98f6f
    • Alexander Polyankin's avatar
    • Anton Kulyk's avatar
      Hide ID filters in data app pages (#25873) · cf364378
      Anton Kulyk authored
      * Hide ID filters in data app pages
      
      * Extend existing `getVisibleParameters` utility
      
      * Use existing `getVisibleParameters` in Dashboard
      cf364378
  4. Oct 11, 2022
    • Nemanja Glumac's avatar
    • Case Nelson's avatar
      [Apps] Scaffolding cleanup (#25805) · 627ff148
      Case Nelson authored
      * [Apps] Scaffolding cleanup
      
      * Make the back to list button bigger so it doesn't wrap on some screens
      * Remove the Query prefix from cards
      
      * Increase size of list and detail cards to 18x12
      627ff148
    • Anton Kulyk's avatar
      Fix data app page style (#25881) · 2e01bd53
      Anton Kulyk authored
      * Remove info sidebar for data app pages
      
      * Fix "Last edited by" text behavior
      2e01bd53
    • Case Nelson's avatar
      [Apps] Scaffold implicit actions (#25815) · a68e9880
      Case Nelson authored
      
      When scaffolding, we should be automatically adding the
      insert,update,delete implicit actions.
      
      * Add order by on test
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      a68e9880
    • Case Nelson's avatar
      [Apps] Actions on models (#25767) · f1eb2772
      Case Nelson authored
      
      * [Apps] Model Actions
      
      Adding migration and endpoints for model_action.
      
      * model action execution
      
      Changing the execution endpoints again, still working on implicit action
      execution tests. Need to also test the parameters fetch.
      
      * Re-add execution route for dashcard action_id until Front End catches up
      
      * Add name to model_action GET
      
      * Hydrate model-action on dashcards
      
      * Rename and combine hydration of model_action to action
      
      * Implicit action execution support. Use slug columns as parameter ids
      
      * Go through model-action when using GET /action
      
      * FE integration fixes
      
      * Move action execution to use new parameter shape
      
      Now, parameters should be a map of parameter-id to value
      Parameter-id should be mapped on the FE. So the action parameter-id not the unmapped
      dashboard parameter-id.
      
      * Bring ModelAction into copy code
      
      * Generate target of implicit actions to match http actions
      
      * Update action test to place action on model
      
      * Add unique constraint to model_action for (card_id, slug)
      
      * Add missing require
      
      * model_action.slug needs to be varchar for mysql constraint
      
      * Fix test from unique constraint
      
      * Consistent ordering for tests
      
      * Addressing Code Reviews and Scaffold changes
      
      * Add type: implicit to implicit model actions
      
      * Update src/metabase/api/model_action.clj
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Allow changing card_id with PUT to dashcard for model-actions
      
      * Update tests after merge
      
      * Fix implicit delete and add better test coverage
      
      * Addressing review changes
      
      Add PUT test
      Add schema for dashboard-id and dashcard-id params
      Fix select ordering in test
      
      * Model Actions: Frontend (#25646)
      
      * save actions in models
      
      * list model actions on detail page (#25648)
      
      * Link Dashcards to model-based actions (#25770)
      
      * Link dashcards to model-based actions
      
      * address review comments
      
      * Data apps model actions implicit creator (#25807)
      
      * Link dashcards to model-based actions
      
      * address review comments
      
      * Link dashcards to model-based actions
      
      * Allow implicit actions to be used like explicit ones
      
      * address review comments
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
      f1eb2772
    • Nick Fitzpatrick's avatar
      Adding maxDimensions to waterfall charts (#25714) · ae496969
      Nick Fitzpatrick authored
      * Adding maxDimensions to waterfall charts
      
      * Adding test
      
      * removing added default column behaviour, adjusting test
      ae496969
    • Alexander Polyankin's avatar
      Fix cljs compilation (#25878) · f8baaad7
      Alexander Polyankin authored
      f8baaad7
    • Aleksandr Lesnenko's avatar
      Static row chart (#25829) · 23837a6f
      Aleksandr Lesnenko authored
      * support static row chart on the backend
      
      * update and add types
      
      * update types
      
      * add chart columns helper, dataset grouping
      
      * add viz settings helpers
      
      * fix text measuring
      
      * add generic row chart component for static and dynamic rendering
      
      * update deps
      
      * fix jest config for d3
      
      * allow importing cljs in static viz
      
      * add a hook for getting chart columns and series
      
      * add a static row chart
      
      * build cljs before static viz
      
      * specs
      
      * add stories, moved isomorphic row chart component to the shared folder
      
      * update import
      
      * fix backend merge
      
      * remove an extra line
      
      * one more extra line
      
      * exclude unused props from the row chart
      
      * cleanup
      
      * review
      
      * fix types
      
      * fix log scale
      
      * add visual spec, fix goal label truncate
      
      * review
      
      * fix mock path
      
      * fix specs
      23837a6f
    • Gustavo Saiani's avatar
      a1e98eb3
    • Alexander Polyankin's avatar
      Fix cljs compilation (#25876) · 2cb377fc
      Alexander Polyankin authored
      2cb377fc
    • Dalton's avatar
      Move some parameter utils to `metabase-lib` (#25863) · 490925b1
      Dalton authored
      * Move parameter target utils to metabase-lib
      
      * Move parameter-type utils to metabase-lib
      
      * Move parameter constants to metabase-lib
      
      * Use Parameter interface, not UiParameter type, in operator utils
      
      * Move operator utils to metabase-lib
      
      * Move filter utils to metabase-lib
      490925b1
Loading