Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Dec 10, 2024
  2. Dec 04, 2024
  3. Dec 03, 2024
  4. Nov 19, 2024
  5. Nov 01, 2024
  6. Oct 17, 2024
  7. Sep 02, 2024
  8. Aug 12, 2024
  9. Jul 17, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [Milestone 1] Re-design transparent theme for static embedding and public links (#45633) · ffa54f0f
      Mahatthana (Kelvin) Nomsawadi authored
      
      * refactor: Simplify code (#44275)
      
      * Remove dead code
      
      * Remove values same as default options
      
      * Simplify hook API: Removing unused argument
      
      * review: Remove redundant code
      
      * Update look and feel copy (#44277)
      
      * Update static embed tab name
      
      * Update copies + rearrange settings
      
      * Use Mantine Select
      
      * Fix E2E tests by applying new copies
      
      * Fix unit tests
      
      * Fix more E2E tests
      
      * review: Add a comment on Mantine `value` quirk
      
      * Adjust spacing and relevant tests
      
      * Move `transparent` theme to its own toggle option (#44362)
      
      * Reorder the function to match the visual order
      
      * Make function name consistent
      
      * Introduce the new background option (do nothing yet)
      
      * Remove redundant exports
      
      * Tighten up values to reduce confusion
      
      * Make the parameters order consistent
      
      * Only show background option on dashboads (spec)
      
      * Allow dashboard embed background to be transparent
      
      * Make filter background and header/footer transparent
      
      * Fix type error
      
      * Fix unit tests
      
      * Fix E2E tests
      
      * Fix checkerboard pattern not showing when no background
      
      * Add unit tests
      
      * Add missing copy update
      
      * Remove remnants from outdated solutions within the PR
      
      * Improve code comment references
      
      * Fix E2E tests since the last copy change
      
      * Fix type errors from merging master
      
      * Update light theme style (#44488)
      
      * Add background to dashboard filter on light theme
      
      * Make position sticky works with transparent background
      
      * Fix sticky filters not working on theme=transparent
      
      * Fix unit tests
      
      * Simplify IntersectionObserver components + fix E2E tests
      
      * Add storybook for embedded dashboard
      
      * Clarify the use of ExplicitSize context
      
      * Remove unused code
      
      * Formatting
      
      * Review: Better mock `isWithinIframe`
      
      * Update dark theme to match the new design (#45134)
      
      * Update light theme checkerboard colors
      
      * Update checkerboard colors
      
      * Consolidate dashboard light/dark border style
      
      * Use `--mb-color-text-primary` for light theme dashboard
      
      * Update embed dashboard dark theme primary color
      
      * Migrate dashboard text-secondary color
      
      * Migrate text-tertiary color
      
      * Migrate gold, axis, and split line to CSS custom properties
      
      * Fix failed e2e tests
      
      * Fix static viz not working
      
      * Update loki snapshots
      
      * Remove unnecessary CSS custom property
      
      * Make diff more consistent
      
      * Address review: reusing type
      
      * Support backward compatibility when passing `theme=transparent` (#45214)
      
      * Match preview query with the actual code query
      
      * Handle backward compatibility when `theme=transparent` on dashboard
      
      * Add unit tests
      
      * Address review: Make tests less repetitive
      
      * Update Metabase banner upsell UI (#45424)
      
      * Prepare folder for nested components
      
      * Update upsell UI
      
      - add `fullWidth` variant
      - align title to the left
      
      * Fix Upsell banner having horizontal scroll on full width
      
      * Add new Metabase banner upsell component
      
      * Fix unit tests
      
      * Address review: Fix typo
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      
      * Address review: Move upsel UI to `admin/upsells`
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      
      * Remove unnecessary ESLint disable comment
      
      We can remove it since the file is in admin folder, and is already excluded from the rule.
      
      * Address review: remove default value property
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Address review: Extract magic number
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * More UI updates (#45450)
      
      * Update dark theme text colors to match the new design
      
      * Update powered by metabase logo
      
      * Update loki snapshots
      
      * Fix unit tests
      
      * Fix formatting
      
      * Fix wrong dark theme metabase logo badge color
      
      * Address review: Compress SVG with svgo
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Fix E2E tests
      
      * Update loki snapshots
      
      * Clarify Metabase base colors with comments
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Add more tests (#45628)
      
      * Add static embed question stories
      
      * Add loki snapshots
      
      * Add transparent theme for static dashboard tests
      
      * Add transparent theme tests for static questions
      
      * Assert `background` option in analytics tests
      
      * Remove tests for logic that has been moved
      
      * Update loki snapshots
      
      * Fix failed E2E tests from merging master
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      ffa54f0f
  10. Jul 16, 2024
    • Nicolò Pretto's avatar
      Embed pdf export - MS2 (#44463) · f4d1d873
      Nicolò Pretto authored
      
      * add pdf export button to static embed and public sharing (#43743)
      
      * add export button to embed frame, it works on static embed and public sharing
      
      * move css around to make dashcard border show up on static/public embed pdf exports
      the library we use to render an html node to an image doesn't seem to support box shadow
      the original fix was done in ParametersAndCardsContainer, but that component is not used in the static/public embeds
      
      * fix types
      
      * fix night theme pdf export
      - use padding for the title instead of starting to draw the image from 60px, to keep the bg color
      - change the css to also apply the bg-color to the first child of the EmbedFrame, to make it work when exporting to pdfs, where the EmbedFrame is not part of the exported dom
      
      * refactor: exportTabAsPdfButtonText function
      
      * give a default to the filename, even though it should always be there
      
      * exportTabAsPdfButtonText -> getExportTabAsPdfButtonText
      
      * introduce .WithThemeBackground to not have a css rule too much generic
      
      * feat: adds endpoint to download results of a dashcard part of a public dashboard (#44156)
      
      * Flag to hide download buttons (#44206)
      
      * pass down downloadsEnabled to hide downloads buttons in public and embedded questions or dashcards
      
      * Update frontend/src/metabase/dashboard/components/DashCard/DashCardMenu/DashCardMenu.tsx
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * PLUGIN_DOWNLOADS_ENABLED -> PLUGIN_RESOURCE_DOWNLOADS
      
      * adds comment to areDownloadsEnabled function to explain what it does
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * logic to handle downloads url parameter (#44363)
      
      * minimal support for downloads url parameter
      
      * updates StaticEmbedSetupPane test to epxect downloads=false instead of hide_download_button=true
      
      * fix prettier mistakes
      
      * tmp fix to the tests until we have the new analytics events
      
      * fix eslint issues
      
      * update embedding snippets e2e
      
      * update embedding questions e2e
      
      * try to clean up the mess of downloads/downloadsEnabled
      
      * adds `hasPremiumFeature` check to the plugin, adds unit test for the logic
      
      * adds TODOS for analytics
      
      * unit tests for downloads flag (#45178)
      
      * fix download pdf button not showing up when titled=false and there's only one tab
      
      * unit tests for downloads flag on dashboards and questions
      
      * adds test about the container id, not sure if we should keep it
      
      * adds a comment to explain why we enable premium features in the tests
      
      * move downloadsEnabled outside of the Boolean cast as it's already a boolean
      
      * E2E tests for public/static downloads (#45240)
      
      * wip e2e tests
      
      * make downloadUtils ts friendly
      
      * assertNotEmpty function
      
      * adds tests for public questions
      
      * e2e tests for static embed downloads
      
      * publicUid -> publicUuid
      
      * fix assertNotEmpty
      
      * fix parameter not renamed
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * remove duplicated test
      
      * fix another typo i forgot to rename
      
      * fix another rename issue
      
      * convert e2e-downloads-helpers to ts
      
      * refactor: put method calculation in getEndpoint function
      
      * adds note to downloadUtils
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Update e2e/test/scenarios/embedding/embedding-snippets.cy.spec.js
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * change requires to import to reflect that we changed to export the source code in downloadUtils
      
      * makes downloadsEnabled prop more consistent across components
      
      * colocate downloadsEnabled with hideDownloadButton in embed-display-options
      
      * defaults displayOptions.downloads to true to simplify logic
      
      * remove unused queryString parameter in tests setup function
      
      * reword TODO
      
      * Revert "defaults displayOptions.downloads to true to simplify logic"
      
      This reverts commit aebf4cf3cf3528deefb9c40dfc48d2f39a278b97.
      
      * fix png export when on dark theme (public/embed) not having the dark … (#45497)
      
      * fix png export when on dark theme (public/embed) not having the dark background
      
      * move the border-radius fix for the dashcard export to saveChartImage
      
      * remove comments
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      f4d1d873
  11. Jul 15, 2024
  12. Jul 11, 2024
    • Denis Berezin's avatar
      feat(sdk): Add event handlers docs, refactor handlers naming (#45374) · 7e6adfaa
      Denis Berezin authored
      * Add event handlers docs for SDK
      
      * Invert events logic and update documentation
      
      * Apply prettier
      7e6adfaa
    • Phoomparin Mano's avatar
      feat(sdk): support multiple interactive questions by decoupling from query builder reducer (#45133) · 49926e68
      Phoomparin Mano authored
      * create sdk load question
      
      * store question result in sdk context
      
      * remove dataset data type
      
      * update question
      
      * handle navigate to new card
      
      * add loading states
      
      * fix on query change
      
      * update question change logic
      
      * refactor question loading and query params
      
      * fix ad-hoc question in dashboards
      
      * extract useLoadQuestion into a separate hook
      
      * cleanup run question on load
      
      * revert changes in interactive question component
      
      * store original question in the question result state
      
      * turn the question into ad-hoc questions
      
      * refactor run question methods
      
      * add a separate isQueryRunning state for better ux
      
      * isQueryRunning should default to false
      
      * simulate re-running the query in unit tests
      
      * add tests for rendering multiple valid questions
      
      * refactor sync question method
      
      * extract raw series and computed pivot logic
      
      * add getCardAfterVisualizationClick
      
      * separate single and multiple question tests
      
      * fix import paths
      
      * is question native
      
      * pass queryResult instead of queryResults
      
      * temporarily remove checkNotNull for aggregation picker to avoid sdk crash
      49926e68
  13. Jul 09, 2024
  14. Jul 01, 2024
  15. Jun 27, 2024
  16. Jun 26, 2024
    • Denis Berezin's avatar
      feat(sdk): Improve dashboard to question navigation (#44648) · 7091c9eb
      Denis Berezin authored
      * Add dashboard question header
      
      * Add dashboard data preserve after question drill
      
      * Review fixes
      
      * Review fixes
      
      * Potential fix for e2e
      
      * Potential fix for e2e
      
      * Add basic unit tests
      
      * Fix Dashboard reloading on unmount, fix ad hoc question title in SDK
      
      * Move dashboard reset to SDK component
      
      * Fix issue with dashboard rerender
      
      * Fix one more reported issue with rerender
      7091c9eb
  17. Jun 19, 2024
    • Denis Berezin's avatar
      feat(sdk): Add interactive dashboards to embedding SDK (#44161) · fa320932
      Denis Berezin authored
      * Temp
      
      * Add support for saved questions
      
      * Try to fix question not found issue
      
      * Try to fix question not found issue
      
      * Fix unit tests
      
      * Add basic unit test
      
      * Fix unit tests
      
      * Fix unit tests, fix question not found issue
      
      * Review fixes
      
      * Review fixes
      
      * Refactor components structure, review fixes
      
      * Adjust readme
      fa320932
Loading