Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 05, 2024
    • Ryan Laurie's avatar
    • Denis Berezin's avatar
      feat(sdk): SDK theming part 3 - brand, brand-light, brand-lighter (#43598) · 6fcbf23e
      Denis Berezin authored
      * Migrate brand
      
      * Migrate brand-light, brand-lighter
      
      * Fix unit tests
      
      * Code review fixes
      
      * Fix CI
      6fcbf23e
    • Jesse Devaney's avatar
      Fix column scaling ("Multiply by a number") bugs (#43668) · 6ac4fe97
      Jesse Devaney authored
      * return empty string so non-empty labels do not get hidden by empty labels
      
      * fix function name
      
      * apply scaling in transformed dataset
      
      * add missing option to OptionsType
      
      * fix double scaling
      
      * add column scaling to waterfall transformed dataset
      
      * add column value scaling to dataset transform
      
      * fix stacked bar segment labels not responding to column scaling
      
      * fix tooltip values displayed
      
      * since scaling as added to transformedDataset, use transformedDataset for formatters
      
      * revert changes to display percentage instead of absolute value
      
      * fix stacked data labels
      
      * add loki variant for custom y-axis range with column scaling
      
      * fix stack segmented label formatters compact calculation
      
      * scale original dataset and use that instead of modifying transformedDataset
      
      * update loki snapshots
      
      * fix scatter plot dataset scaling
      
      * fix tooltip values being double scaled
      
      * add E2E test to validate behavior
      
      * add helper for not duplicating the column scaling
      
      * port multiple y-axis metrics with column scaling fixes to RowChart
      
      * add waterfall and scatterplot loki variants
      
      * fix type errors and failing unit tests
      
      * fix failing unit tests
      
      * update loki snapshots
      6ac4fe97
    • Nemanja Glumac's avatar
      Add E2E reproduction for #39150 (#43610) · 5bf50a21
      Nemanja Glumac authored
      * Add E2E reproduction for #39150
      
      * Fix typo in the test title
      
      * Move the viewport config to the `describe` block
      
      * Add the second repro scenario as per the review comment
      
      * Scope the variable to the relevant test
      5bf50a21
    • Anton Kulyk's avatar
      Fix long field names handling for series names and in the model editor (#43394) · c7c5b356
      Anton Kulyk authored
      * Fix long names in model editor
      
      * Fix long names in series name input
      c7c5b356
    • Alexander Polyankin's avatar
      Performance fix for getUrlWithParameters when there are no parameters (#43626) · 13aae663
      Alexander Polyankin authored
      * Simple performance fix for getUrlWithParameters
      
      * Fix tests
      13aae663
    • Jeff Bruemmer's avatar
      column heading options (#43409) · f05fa8e6
      Jeff Bruemmer authored
      f05fa8e6
    • Dennis Schridde's avatar
      Expose `attached-dwh` token feature flag to frontend (#43657) · 937e30fb
      Dennis Schridde authored
      This allows frontend code to conveniently check whether the feature
      flag is enabled or disabled.  This is in addition to the raw flag's
      presence (or absence) in `(:features token-status)`.
      
      References: https://github.com/metabase/metabase/issues/42381
      References: https://github.com/metabase/metabase/pull/43511
      937e30fb
    • Denis Berezin's avatar
      feat(sdk): SDK theming part 2 - bg-error, bg-medium, bg-night, bg-white, border (#43512) · 8659846f
      Denis Berezin authored
      * Migrate bg-error
      
      * Migrate bg-medium
      
      * Migrate bg-night
      
      * Migrate bg-white
      
      * Migrate border
      
      * Fix CI
      
      * Fix unit tests
      
      * Fix unit tests
      
      * Code review fixes
      
      * Code review fixes
      8659846f
    • Chris Truter's avatar
      50e4cf77
    • Chris Truter's avatar
      2a260cc9
    • Kamil Mielnik's avatar
      Previous period comparison shortcut in chill mode - column headers (#43500) · f61a0657
      Kamil Mielnik authored
      
      * Sort functions
      
      * Add boilerplate for aggregateOffset and tests
      
      * Simplify assertion
      
      * Make basic case work
      
      * Handle name generation
      
      * Do not require "lib/uuid" attribute to be present since MLv2 will normalize it under the hood anyway
      
      * Fix typing
      
      * Group tests
      
      * Refactor offsetClause to return a new clause instead of a new query
      - Move offsetClause to expressions.ts
      - Add assertion
      
      * Revert "Sort functions"
      
      This reverts commit ab9ce2b24ea6bdad5ff7e9bed8ef38d4b5923f00.
      
      * Move tests
      
      * Handle names dynamically
      
      * Shorten a test
      
      * Update comment
      
      * Add TODO
      
      * Update expression types
      
      * Add diffOffsetClause & percentDiffOffsetClause
      
      * Add a test for diffOffsetClause
      
      * Add TODOs
      
      * Add tests for diffOffsetClause and percentDiffOffsetClause
      
      * Unwrap tests
      
      * Add skeleton for new tests
      
      * Refactor first offsetClause tests
      
      * Add tests for names
      
      * Fix case of non-datetime columns
      
      * Handle a case with offset < 1 and no breakouts
      
      * Handle a case with offset < 1 and breakouts on non-datetime column
      
      * Handle a case with offset < 1 and breakouts binned datetime column
      
      * Handle a case with offset < 1 and breakout on non-binned datetime column
      
      * Refactor
      
      * Refactor
      
      * Remove TODO
      
      * Add tests for diffOffsetClause
      
      * Add tests for percentDiffOffsetClause
      
      * Move offset stuff to offset.ts and offset.unit.spec.ts
      
      * Use template string for prefixes
      
      * Use breakoutColumn + isDate to check column type
      
      * Refactor
      
      * Fix error message
      
      * Add boilerplate for CompareAggregations
      
      * Fix title
      
      * Render aggregations list
      
      * Style AccordionList
      
      * Sort props
      
      * Fix bucket name
      
      * Use displayName instead shortName
      
      * Support parseValue prop in NumberInput
      
      * Add period input accepting integers only
      
      * Accept non-negative values only
      
      * Do not accept zeros
      
      * Add state
      
      * Add submit button
      
      * Export offset functions via Lib
      
      * Make it possible to skip rightSection
      
      * Add column picker
      
      * Map offset user input to api input (negative value)
      
      * Add label
      
      * Fix crash
      
      * Extract shouldCreate
      
      * Make onSelect in AggregationPicker support multiple values
      
      * Extract ReferenceAggregationPicker
      
      * Extract ColumnPicker
      
      * Extract getAggregations
      
      * Rename
      
      * Add custom items
      
      * Refactor item component
      
      * Extract OffsetInput
      
      * Remove unused data-testid
      
      * Style OffsetInput
      
      * Generate titles according to specs
      
      * Generate label
      
      * Generate help
      
      * Extract utils
      
      * Use different width for the 1st step
      
      * Format code
      
      * Use MultiSelect directly
      
      * Avoid custom parseValue
      
      * Revert MultiaAutocomplete changes
      
      * Improve typing in describeTemporalInterval and
       describeRelativeDatetime
      
      * Use describeTemporalUnit to pluralize
      
      * Use interface
      
      * Avoid setting value as DOM attribute
      
      * Fix test
      
      * Add onAdd prop to AggregationPicker and revert the change to have onSelect pass multiple aggregations
      
      * Reduce number of props
      
      * Render checkboxes in custom items
      
      * Introduce and use --mb-color-brand-lighter
      
      * Avoid !important
      
      * Remove redundant prop
      
      * Rename ExtractColumn to ExtractColumnAction
      
      * Add lines.svg
      
      * Fix positioning in case dir attribute is not present in any parent component
      
      * Add CompareAggregationsAction
      
      * Fix warning about isSelected being used as DOM attribute
      
      * Fix positioning in case dir attribute is not present in any parent component
      
      * Remove redundant Box
      
      * Compute the title
      
      * Add compareAggregationsDrill boilerplate
      
      * Add compare-aggregations drill stub
      
      * Update comment
      
      * Compute title and aggregation
      
      * Add TODO
      
      * Use proper title when there's only 1 aggregation
      
      * Show visualization on submit
      
      * Limit aggregation choice to 1 in compare aggregations drill
      
      * Redirect to chart upon submission
      
      * Do not navigate to chart view
      
      * Do not navigate to chart view
      
      * Make drill-thru tests expect the new compare-aggregations drill
      
      * Add type attribute to all ListItems
      
      * Add aggregationIndex to drillInfo
      
      * Add aggregationDrillDetails and wire it up
      
      * Fix destructuring
      
      * Fix tests
      
      ---------
      
      Co-authored-by: default avatarBraden Shepherdson <braden@metabase.com>
      f61a0657
    • Oisin Coveney's avatar
      5c5f6c39
    • Ryan Laurie's avatar
      Add team devex (#43662) · a691754a
      Ryan Laurie authored
      * Add DevEx to team.json
      
      * no trailing commas in json
      a691754a
    • Ryan Laurie's avatar
      Put New Tests in Flake Jail + Parole Well Behaved Tests (#43623) · 7251aa83
      Ryan Laurie authored
      * tag flakiest tests as such
      
      * let well behaved tests out of flake jail
      
      * more bad actors off the streets
      
      * add another flake
      
      * sandboxes re-offended already
      7251aa83
    • Alexander Polyankin's avatar
      f2899145
    • Aleksandr Lesnenko's avatar
      Set min bar height for non-zero bars (#43485) · f025758d
      Aleksandr Lesnenko authored
      * set min bar height for non-zero values
      
      * fix y-axis split logic uses transformed dataset instead of actual data
      f025758d
    • Aleksandr Lesnenko's avatar
      Fix RowChart shrinks on hover (#43634) · 0fb138af
      Aleksandr Lesnenko authored
      * fix memoization
      
      * extend the basic row chart e2e spec
      0fb138af
    • Tim Macdonald's avatar
      Use a more obvious test error message (#43642) · 4ec415a0
      Tim Macdonald authored
      (When scrolling through CI logs I always do a double-take when I see a
      huge stack trace with "Just an error". I think this is a little
      clearer?)
      4ec415a0
    • Oisin Coveney's avatar
      Convert Pagination Controls to TS (#43586) · 7c636450
      Oisin Coveney authored
      7c636450
    • Ngoc Khuat's avatar
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Fix flaky `interactive-embedding.cy.spec.js` (#43588) · 44fb3171
      Mahatthana (Kelvin) Nomsawadi authored
      * Fix flaky test
      
      * Fix the flake for real
      
      * Fix stress test failing because of mismatched height
      
      * Review: Move viewport setting to shared config
      44fb3171
    • Alexander Solovyov's avatar
  2. Jun 04, 2024
Loading