Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 03, 2024
    • Ngoc Khuat's avatar
    • Lena's avatar
      Clarify that backport/no-backport is an internal thing (#40954) · 359a8dac
      Lena authored
      
      * Clarify that backport/no-backport is an internal thing
      
      A few times per month, external contributors ask about the notion doc they can't access and about the labels they are not expected to set. This is not the experience we should give to people who not only take their time to contribute to metabase, but also actually read the PR template.
      
      (slightly duplicated condition in the beginning and the end of the paragraph — "For those employed [...] If you're not employed [...]" — is on purpose)
      
      * Add linebreaks in PR template
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      Unverified
      359a8dac
    • Nick Fitzpatrick's avatar
      Command Palette UI adjustments (#40650) · 9c477a75
      Nick Fitzpatrick authored
      * Command Palette UI adjustments
      
      * move search to end of results list
      
      * ellipsis long command palette items, min icon size and showing debounced text
      
      * setting fixed width. adjusting admin result icons and text
      
      * fixing e2e test
      Unverified
      9c477a75
    • Alexander Polyankin's avatar
      Deprecate MLv1 metadata (#40947) · 1235d9a8
      Alexander Polyankin authored
      Unverified
      1235d9a8
    • Jeff Bruemmer's avatar
      add 49.3 to list of releases (#40943) · 7e899cff
      Jeff Bruemmer authored
      Unverified
      7e899cff
    • Uladzimir Havenchyk's avatar
      Fix row id mapping in object detail modal displaying (#40874) · 54ed7544
      Uladzimir Havenchyk authored
      * Map row id on object detail id
      
      * Add a fallback
      
      * Add e2e test
      
      * Add a limit
      
      * Provide a fix for #34070
      
      * Simplify test
      Unverified
      54ed7544
    • Nemanja Glumac's avatar
      Use MLv2 to determine whether a query can be previewed (#40609) · 2cf94320
      Nemanja Glumac authored
      * Use MLv2 to determine whether a query can be previewed
      
      * Add E2E repro for #40608
      
      * Expand E2E repro
      
      * Fix test
      
      * Make sure the step is active and visible before offering to preview its query
      
      * Expand E2E test
      
      * Address review comment - use `getNotebookStep` helper
      Unverified
      2cf94320
    • Jeff Bruemmer's avatar
      docs - formatting exports (#40921) · 95218284
      Jeff Bruemmer authored
      Unverified
      95218284
    • Uladzimir Havenchyk's avatar
      Do not put js code into page title (#40901) · d12c549a
      Uladzimir Havenchyk authored
      
      * Do not put js code into page title
      
      * Typecheck
      
      * Add e2e test
      
      * Update e2e/test/scenarios/question/document-title.cy.spec.js
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      d12c549a
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [MS2] 1. Analytics (#40681) · af54379a
      Mahatthana (Kelvin) Nomsawadi authored
      * Remove old config + fix typo
      
      * Add new analytics for 4 new illustration settings
      Unverified
      af54379a
    • Cal Herries's avatar
      Unverified
      e5f9d2c4
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Migrate `dashboard.module.css` (#40918) · f94ec2cc
      Mahatthana (Kelvin) Nomsawadi authored
      * Migrate .DashEditing
      
      * Migrate .CardTitle
      
      * Migrate .PinMap
      
      * Migrate .PinMapUpdateButtonDisabled
      
      * Migrate .BrandColorResizeHandle
      
      * Migrate .VisualizationSlowSpinner
      
      * Migrate .AddSeriesModal
      
      * Migrate 2 more classes
      Unverified
      f94ec2cc
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Remove unused CSS files (#40908) · 1299f251
      Mahatthana (Kelvin) Nomsawadi authored
      * Fix default export
      
      * Remove unused classes
      
      * Remove unused components
      Unverified
      1299f251
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [M1] Metabase illustration settings (#40219) · 715174d3
      Mahatthana (Kelvin) Nomsawadi authored
      
      * Add login page illustration (#39299)
      
      * Move Metabot setting to a new place
      
      * Add setting for login page illustration
      
      * fix UI styling
      
      * Fix not able to upload the same file twice
      
      * Update the admin > appearance > conceal metabase copy
      
      * Prepare the component for tests
      
      * Add some unit tests
      
      * Prevent settings not saved sometimes
      
      After setting the value to/from `custom` one of the setting could be
      failed to save, I suspect this happens because the race condition from
      trying to save the setting values relatively at the same time.
      
      * Make unit tests easier to read
      
      * Add all unit test test cases
      
      * Add basic E2E test
      
      * Show fallback icon for broken images
      
      * Make use of the proper component
      
      * Update the comment to affect the reality
      
      * Add an error message when file size is over 2MB
      
      * Show an error message when the file size > 2MB
      
      * Add the error message tests
      
      * Preserve the preview image aspect-ratio
      
      * Detect corrupted images
      
      * Fix failing unit tests
      
      * Address feedback: Type
      
      * Feedback: Create meaningful variables
      
      * Feedback: Make selector API more sensible
      
      * Prevent race condition
      
      Makes sure we save the settings completely before making other actions
      that also change settings otherwise, there could be race conditions.
      
      * Feedback: tighten up a type
      
      * Feedback: Fix inconsistency callback calls
      
      * 2. Add the rest 3 illustration settings (#40487)
      
      * Add the rest 3 illustration settings
      
      * Don't make the X icon feel lonely
      
      * Fix illustration widget saving
      
      * Fix type error
      
      * 3. Update the select UX to match new design (#40491)
      
      * Update the select UX to match new design
      
      * Move info dot next to file upload button
      
      * Simplify IllustrationWidget API
      
      * Update setting title copy
      
      * Clean up test comments
      
      * Feedback: Clarify `any` type
      
      * Feedback: Use shorthand object creation
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Feedback: Use global CSS glass instead of inlining values
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Feedback: Remove unnecessary curly brackets in JSX
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * 4. Connect illustrations to new setting values (#40139)
      
      * Wire landing page illustration to the setting value
      
      * Wire the unsubscribe page to the setting value
      
      * Prepare no rows error to be wired to the setting value
      
      * Wire no question results illustration to the setting value
      
      * Wire no search results illustration to setting value
      
      * Fix error from fixing conflict
      
      * Fix required unnecsseary prop on Image
      
      * Use Image component
      
      * Link dashboard card no results image to the setting value
      
      * Move the no data results to more a generic directory
      
      * Link collection picker no results image to the setting value
      
      * Make illustrations more accessible
      
      * Fix failed tests
      
      * Test unscribe page illustration + test no illustration
      
      * Add landing page tests
      
      * Simplify Cypress selectors
      
      * Refactor: Rename settings to match the new requirements
      
      No question data -> No Data
      No search results -> No object
      
      These changes are made so, these 2 settings are generic enough to
      include other illustrations later on.
      
      * Add no data illustration test
      
      * Add no object illustration tests
      
      * Fix unsubscribe page background style
      
      * Fix not able to build static viz
      
      * 5. Follow-up on milestone 1 (#40710)
      
      * Update custom background illustration scale behavior
      
      * Remove the need to put an SVG file in static folder
      
      * Fix test from rebasing off master with @testing-library/user-event upgrade
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      Unverified
      715174d3
  2. Apr 02, 2024
  3. Apr 01, 2024
Loading