This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 15, 2024
-
-
Denis Berezin authored
-
Uladzimir Havenchyk authored
-
Oisin Coveney authored
-
- Apr 12, 2024
-
-
Uladzimir Havenchyk authored
-
Romeo Van Snick authored
* Add help text icon in expression editor suggestions (#41092) * Add helptext to expression suggestions * Deduplicate getDatabase calls * Allow customising popover width * Split out help text content component * Render an info icon with the help text * Remove duplicated defaults for popover * Explicitly wait for suggestion items in test * Remove commented out code * Use React imports directly * Rename e to evt * Inline getHelpText when creating suggestions * Avoid overlapping content * Remove unnecessary Fragment * Avoid selecting item when clicking link or button inside element * Allow shifting popover * Stop Popover mouse events for bubbling * Use onMouseDown instead of onMouseDownCapture to avoid clicks inside popover from triggering select * Add help text to all suggestions that are know mbql functions * Expression suggestions clean up (#41236) * Move ExpressionEditorSuggestions to tsx * Convert ExpressionEditorSuggestions to functional component * Simplify suggestion match component * Move ExpressionEditorSuggestions a separate folder * Remove default export * Use Popover instead of Tippy for suggestions list * Fix suggestions tests * Remove data-ignore-outside-clicks * Add default for suggestions * Fix e2e test * Move helptext wrapper to ExpressionEditorTextfield * Switch to metabase/ui for Button * Use arrow function
-
- Apr 11, 2024
-
-
Nick Fitzpatrick authored
* collection and db breadcrumbs * compact breadcrumbs * adding navigation keybindings * recent_views and search changes to always include collection or db name * removing breadcrumbs, display parent name * removing unneeded components * e2e and FE unit tests * waitFor * e2e tests for keybindings * help * be tests passing * PR feedback and type adjustments * unit test adjustment
-
Uladzimir Havenchyk authored
-
Uladzimir Havenchyk authored
-
Nemanja Glumac authored
* Keep the original question name in the save modal where possible Resolves #41196 * Update tests * Append "- Modified" to a suggested question name * Preserve the original question description * Address reviews - adjust the translation string * Add E2E reproduction * Remove extra space * Improve assertions
-
- Apr 10, 2024
-
-
Nick Fitzpatrick authored
* increase activation distance for dashboard parameter dragging * updating drag sensitivity for other places * adjusting e2e tests
-
- Apr 09, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Remove unused CSS custom properties * Migrate .ModalContainer * Migrate .Modal * Migrate .ModalBackdrop * Migrate Modal transition classes * Migrate modal sizes * Fix tests * Add missing classes from migration * Address review: use `data-testid` * Remove unused classes * Revert the util that selects Mantine modal
-
Nemanja Glumac authored
* Improve the fetching logic in a notebook native preview * Rely on `isFetching` always * Show a disabled convert button when there's no query
-
- Apr 08, 2024
-
-
Nemanja Glumac authored
* Add new user-local setting `notebook-native-preview-preferences` * Update user settings on FE * Use two distinct setting entries * Update FE types * More explicit `notebook-native-preview-sidebar-width` definition * Add selectors * Initialize QB uiControls based on the BE settings * Rename QB store entry `isNativePreviewSidebarOpen` -> `isShowingNotebookNativePreview` * Rename QB store entry `nativePreviewSidebarWidth` -> `notebookNativePreviewSidebarWidth` * Add Redux actions * Dispatch user settings on top of Redux store * Fix test title typo * Add E2E test to make sure sidebar is resizable * Expand the E2E test to cover persisting settings across sessions * Be more explicit that we're resizing along x axis * Store window breakpoint as a variable * Calculate handle's left position more explicitly
-
Ryan Laurie authored
* make collectionpicker child-aware * update unit tests * add another unit test * move test some place more sensible * fix rebase
-
Nemanja Glumac authored
* Display sql preview on sizes less than 1280px * Handle min notebook width using Mantine responsitve style prop * Display the resizable sidebar on sizes >= 1280px * Set sidebar width on resize * Add custom handle * Simplify window resizing with `useWindowSize` hook * Use "white" from the theme colors * Improve sidebar semantics with `aside` * Define the `NativeQueryPreviewSidebar` as `aside` * Use Mantine style props instead of CSS module * Run the E2E test again using regular browser We removed the nested media query that ReplayIO doesn't support. Now this test can run using Replay Chromium as all other tests do. * Add some breathing room between the scrollbar and the resizable sidebar
-
- Apr 05, 2024
-
-
Nicolò Pretto authored
* create ui for the full embedding homepage, without any logic (#40251) * wip ui for the full embedding homepage * adds missing link + fix keys * remove done TODO * Update frontend/src/metabase/home/components/EmbedHomepage/InteractiveTabContent.tsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * destructure props in the function arguments * rename customerFacingAnalyticsDocsUrl to analyticsDocsUrl --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * add new settings for embedding homepage (#40455) * remove old minimal version * adds new embedding homepage settings and sets them at the end of the setup * comment e2e test * add tests for embedding homepage flags * more tests * remove unit tests related to old minimal version * fixes flags descriptions * :keyword for embedding-homepage Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * replace reloadSettings and refreshSettingsList with initializeSettings * `value => value === true` -> `Boolean` * toMatchObject -> toEqual for more strict tests * remove useless undefined check for settings, the component is conditionally rendered based on a setting so it means they're loaded anyway * fix: use :hidden as we changed the type to :keyword * specifically check for the `embedding` feature in the tokenFeatures object instead of checking if any feature is active * remove double \n Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * connect settings to the embed homepage and show it (#40528) * fix nested a warnings in browser console * connect settings to the embed homepage and show it * fix stories * remove localStorage.clear() as we're not using it in the logic anymore * dismiss without feedback for the embedding homepage (#40587) * feat: add dismiss functionality to the embed homepage * update setup e2e to check for the dismissal of embedding homepage * use List from metabase/ui (#40638) * set embedding-secret-key when embedding is enabled (#40813) * set embedding-secret-key when embedding is enabled * use "named" setters and getters as suggested by Noah * Fix tests for ms1 after updating on master (#41069) --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Cam Saul authored
* Use window functions for SQL drivers for cumulative count and sum * H2/Snowflake/Redshift implementation * Test fixes
* Use SELECT expression positions as the default window function implementation * Some test fixes. * Fix bugs in add-alias-info * MongoDB fixes * Another pass * BigQuery should use positions? * Disable tests for the failing drivers, we can fix in follow-on PRs. * Extra info * Add GH issue numbers * Update more GH issue numbers * Fix SQL Server!!!! wooo * I THOUGHT WE WERE DISABLING SPARK SQL!!!!!!!!!!1 * Cleanup to get things ready for review. * Snowflake + Vertica shouldn't use output column numbers for ORDER BY in OVER * Code cleanup * Test fix? -
Uladzimir Havenchyk authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Moved a CSS rule, so we could only migrate 1 CSS file * Migrate .ListSectionHeader * Migrate .ListItem * Migrate .ListItemArrow * Migrate .ListSectionHeaderCursor * Migrate .ListSectionToggleAble * Migrate .ListSectionTitle * Migrate .ListSectionExpanded * Migrate .ListSectionIcon * Migrate .ListItemCursor * Migrate .ListItemDisabled * Migrate .ListItemSelected * Migrate .ListItemTitle * Migrate .ListItemDescription * Migrate a CSS class used in tests * Fix tests from migrating global CSS classes
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .LineAreaBarChart * Migrated .LineAreaBarChartRenderer * Migrate .mute-* * Fix tests that rely on a static class * Fix wrong DOM query selector syntax * Address review: Remove CSS comment noise
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Apr 04, 2024
-
-
lbrdnk authored
* Enable not emptyable arguments for is-empty and not-empty clauses * Add review remarks * Shorten dataset name so it is usable with some drivers * Disable test for Athena * Handle possibly missing base type * Update comment * Missing base type field is treated as not emptyable * Update desugar middleware Now middleware adds base type to fields with integer id that are missing that first. This ensures correct function of is-empty expansion. * Update desugar middleware Cleanup base types necessary for desugaring is-empty * Update desugar middleware cleanup * Update test * Adjust tests * Remove now redundant e2e test * Update comment
-
Kamil Mielnik authored
* Repro #23103 - Wrong number of distinct values in a native model * Fix flake
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix flaky test caused by unmounted HoverCard * Remove unused test util
-
Oisin Coveney authored
-
- Apr 03, 2024
-
-
Braden Shepherdson authored
This logic was trying to match `[name join-alias]` pairs previously, but that won't work since the later stage field doesn't have a `:join-alias` on it. This falls back to matching on only the ID or name, but only if it's unambiguous. Fixes #40252.
-
Nemanja Glumac authored
* Bump the question schema and update it with the new events * Enable snowplow tracking on the frontend * Add E2E test for tracking snowplow events related to native preview sidebar * Fix question id type in the schema
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix overflow static dashboard * Fix `frame` event's height for interactive dashboards * Fix E2E tests * Fix test names to match the correct GitHub issue numbers * Use `data-element-id` for consistency * Make the test selector more consistent
-
Nick Fitzpatrick authored
* Command Palette UI adjustments * move search to end of results list * ellipsis long command palette items, min icon size and showing debounced text * setting fixed width. adjusting admin result icons and text * fixing e2e test
-
Uladzimir Havenchyk authored
* Map row id on object detail id * Add a fallback * Add e2e test * Add a limit * Provide a fix for #34070 * Simplify test
-
Nemanja Glumac authored
* Use MLv2 to determine whether a query can be previewed * Add E2E repro for #40608 * Expand E2E repro * Fix test * Make sure the step is active and visible before offering to preview its query * Expand E2E test * Address review comment - use `getNotebookStep` helper
-
Uladzimir Havenchyk authored
* Do not put js code into page title * Typecheck * Add e2e test * Update e2e/test/scenarios/question/document-title.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .DashEditing * Migrate .CardTitle * Migrate .PinMap * Migrate .PinMapUpdateButtonDisabled * Migrate .BrandColorResizeHandle * Migrate .VisualizationSlowSpinner * Migrate .AddSeriesModal * Migrate 2 more classes
-
Mahatthana (Kelvin) Nomsawadi authored
* Add login page illustration (#39299) * Move Metabot setting to a new place * Add setting for login page illustration * fix UI styling * Fix not able to upload the same file twice * Update the admin > appearance > conceal metabase copy * Prepare the component for tests * Add some unit tests * Prevent settings not saved sometimes After setting the value to/from `custom` one of the setting could be failed to save, I suspect this happens because the race condition from trying to save the setting values relatively at the same time. * Make unit tests easier to read * Add all unit test test cases * Add basic E2E test * Show fallback icon for broken images * Make use of the proper component * Update the comment to affect the reality * Add an error message when file size is over 2MB * Show an error message when the file size > 2MB * Add the error message tests * Preserve the preview image aspect-ratio * Detect corrupted images * Fix failing unit tests * Address feedback: Type * Feedback: Create meaningful variables * Feedback: Make selector API more sensible * Prevent race condition Makes sure we save the settings completely before making other actions that also change settings otherwise, there could be race conditions. * Feedback: tighten up a type * Feedback: Fix inconsistency callback calls * 2. Add the rest 3 illustration settings (#40487) * Add the rest 3 illustration settings * Don't make the X icon feel lonely * Fix illustration widget saving * Fix type error * 3. Update the select UX to match new design (#40491) * Update the select UX to match new design * Move info dot next to file upload button * Simplify IllustrationWidget API * Update setting title copy * Clean up test comments * Feedback: Clarify `any` type * Feedback: Use shorthand object creation Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Feedback: Use global CSS glass instead of inlining values Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Feedback: Remove unnecessary curly brackets in JSX Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * 4. Connect illustrations to new setting values (#40139) * Wire landing page illustration to the setting value * Wire the unsubscribe page to the setting value * Prepare no rows error to be wired to the setting value * Wire no question results illustration to the setting value * Wire no search results illustration to setting value * Fix error from fixing conflict * Fix required unnecsseary prop on Image * Use Image component * Link dashboard card no results image to the setting value * Move the no data results to more a generic directory * Link collection picker no results image to the setting value * Make illustrations more accessible * Fix failed tests * Test unscribe page illustration + test no illustration * Add landing page tests * Simplify Cypress selectors * Refactor: Rename settings to match the new requirements No question data -> No Data No search results -> No object These changes are made so, these 2 settings are generic enough to include other illustrations later on. * Add no data illustration test * Add no object illustration tests * Fix unsubscribe page background style * Fix not able to build static viz * 5. Follow-up on milestone 1 (#40710) * Update custom background illustration scale behavior * Remove the need to put an SVG file in static folder * Fix test from rebasing off master with @testing-library/user-event upgrade --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
- Apr 02, 2024
-
-
Nick Fitzpatrick authored
* command palette trigger in app bar search * remove tabbing to the trigger button
-
Nemanja Glumac authored
* Move all notebook containers styles to one place * Make NotebookStep wide again * Tweak sidebar width and breakpoints * Remove top margin from NotebookSteps * Stop line wrapping in an ace editor * Uniform width between step header and step body * Remove stray styles * Scroll content independently * Use named export * Use Mantine button for "Visualize" * Convert notebook step width to rem * Adjust the position of the step close button * Adjust notebook step max-width to 1200px * Remove the `cx` where not needed * Use HTML 5 `aside` element for the sidebar * Use Mantine responsive styles * Fix E2E test
-
Uladzimir Havenchyk authored
Add repro test for a model that uses another model and both have custom column with the same name (#40851) * Add repro test for a model that uses another model and both have custom column with the same name * Skip test * Update e2e/test/scenarios/models/reproductions/39150-model-with-same-custom-column-name.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Update e2e/test/scenarios/models/reproductions/39150-model-with-same-custom-column-name.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Convert to ts and add question --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrated .PopoverContainer, .PopoverBody * Make global CSS more prominent * Migrate 2 classes * Remove unused class * Migrate .PopoverBodyWithArrow * Remove unused class * Migrate .PopoverBodyMarginBottom * Remove unused class * Migrate .PopoverFooter * Remove unused class * Preserve classes order for easier review * Fix unit tests
-
Uladzimir Havenchyk authored
Add repro for "Dashboard filters do not work with custom columns on saved questions used in models" (#40784)
-
Uladzimir Havenchyk authored
* Add a repro for 'GUI model joining native ones break with column not found error' * Rename test * Add await * Skip test
-