This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 17, 2023
-
-
Nemanja Glumac authored
* Fix missing React keys in embedding settings page [Resolves: ##32395] * Address code review comments We're adding prefix `-` to the keys that are not meant to represent backend settings.
-
Alexander Polyankin authored
-
Cam Saul authored
-
Uladzimir Havenchyk authored
* Fix setup alert right after question creation * Provide keys to react elements * Rework class based components to functional
-
Cam Saul authored
-
Alexander Polyankin authored
-
- Jul 14, 2023
-
-
Ngoc Khuat authored
-
Cam Saul authored
-
Jeff Bruemmer authored
-
Cam Saul authored
* Fix infinite loop when logging error when fetching `:site-locale` Setting * Fix bad performance change * Remove more dumb optimizations * Fix references to removed var
-
Jeff Bruemmer authored
-
Ngoc Khuat authored
-
Braden Shepherdson authored
Previously this was done by checking if the FE had included `:collection "some_table"` on the native query, but that's been included for SQL queries lately, and broke "Explore Results". Includes new e2e tests: one for this issue itself, and another that the fix doesn't break real Mongo native queries. Fixes #32121.
-
Nick Fitzpatrick authored
* adjusting minimum size for scalar (number) cards * adjusting resize e2e test * simplfying cy intercept * reverting e2e test change
-
Oisin Coveney authored
-
Kamil Mielnik authored
Fix - Clicking Saved Questions option in data selector when instance have no questions leads to Raw Data option instead (#32173) * Fix #29760 * Refactor data types computation * Refactor DataPickerContainer - replace HOC entity loaders with hooks - extract useDataPickerConfig * Extract useDataPickerConfig * Use named exports * Move DATA_BUCKET to DataPicker container * Move DEFAULT_DATA_PICKER_FILTERS to constants * Update DATA_BUCKET to match DataPickerDataType * Use useDataPickerConfig in DataSelectorDataBucketPicker * Reuse DATA_BUCKET in DataPicker utils * Rename DataPickerContainer to DataPicker - refactor default export to named export * Sort imports * Fix import * Rename identifiers * Move database filtering out of useDataPickerConfig - Reuse DataTypeInfoItem type - Remove Bucket type - Make getDataTypes conditionally return raw data option * Simplify condition * Extract hasDataAccess out of useDataPickerConfig * Extract constants out of getDataTypes * Fix typo * Simplify approach, remove hooks * Improve diff * Lift getDataTypes call * Fix build * Add more DataSelectorDataBucketPicker unit tests * Remove unused hasUsableSavedQuestions * Extract utils unit tests * Extract setup function * Fix hasNestedQueriesEnabled selector * Fix onChangeDataBucket * Fix displaying saved questions * Add repro unit tests * Move constants to appropriate file * Use the same setup in tests * Fix typo * Make sure tests pass * Use data-testid instead of making assumptions about DOM structure
-
Cam Saul authored
-
- Jul 13, 2023
-
-
Oisin Coveney authored
-
Jeff Bruemmer authored
-
Jerry Huang authored
* initial commit * remove imports * update test * fix test * update test
-
Jerry Huang authored
-
Tim Macdonald authored
[Fixes #32263]
-
Tim Macdonald authored
[Fixes #32265]
-
Ryan Laurie authored
* fade link cards in parameter mapping mode * fade link cards when mapping parameters
-
Ngoc Khuat authored
* switch search to use malli schema
-
Nick Fitzpatrick authored
* Adding toast when setting custom homepage * PR Feedback
-
Nemanja Glumac authored
* Fix `public-dashboard` E2E flake Closes #32334.
-
Kamil Mielnik authored
* Fix #28677 * Add issue tag
-
- Jul 12, 2023
-
-
Uladzimir Havenchyk authored
* Rework e2e test to make it less flaky * Fixup * Another attempt to improve test
-
Denis Berezin authored
* Address left code review comments for #32093 * Update e2e helpers file name
-
Noah Moss authored
-
- Jul 11, 2023
-
-
Aleksandr Lesnenko authored
-
Kyle Doherty authored
* add CODEOWNERS + kdoh entry for design system dir * use CODENOTIFY [ci skip]
-
Braden Shepherdson authored
This reverts commit 793577c8.
-
Braden Shepherdson authored
Some premium features (and in theory even non-premium EE features) use parts of others, and the token might not have those other features enabled. This mechanism allows dynamically overriding the set of features the token is considered to have, enabling eg. `:audit-app` code to use `:serialization` internally even if the user's token doesn't support `:serialization`. ```clojure (premium-features/with-premium-feature-overiddes [:foo :bar] (has-feature? :foo)) ;=> true ```
-
Nemanja Glumac authored
The failure was caused by the change in the token activation logic in E2E tests. Most likely because #32186 was longer in queue than #32212. By the time #32212 landed, E2E tests were still starting with the full premium token active by default. #32186 changed that and that's when we see the first failure for this test.
-
Mahatthana (Kelvin) Nomsawadi authored
* Organize tests to make them easier to follow * Allow downloading query result even after the native query has changed * Add ad-hoc question test * Address review: Group rendering tests together * Addrsess review: Add comment regarding tests living in different files
-
Ngoc Khuat authored
* expose new feature flags: :official_collections, :snippets_collections, :disable_password_login
-
Nemanja Glumac authored
* Start all tests without a token * Update tests * Fix tests in `admin` group * Fix tests in `dashboard-filters` group * Fix tests `visualizations` group * Batch fixes * Fix database banner snowplow test * Fix full-app mobile view banner test * Simplify and remove `isPremiumActive` check * Fix the helper * Fix helper to fail fast * Fix tests * Ensure token scope is set * Ensure CYPRESS_ env tokens are present * Set token only if running Metabase ee * Improve JSDoc * Slightly tweak log message * Update E2E dev guide * Update cross-version tests * Remove premium token from Cypress backend setup * Improve a comment * Fix test * Update embedding copy --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
Diego Rocha authored
* Fix dashboard scroll jank is some cases The behavior defined by stickyParameters.js was updating the dashboard's parametersWidgetOffsetTop state with undefined at every scroll event, causing jank. This was caused by mistakenly assuming that a dashboard component always has its parametersWidgetRef set to something other than an empty React ref, when in fact it can be null when the dashboard has no filters. This changes also fix how a React ref is used to make parametersWidgetRef reference the HTMLElement the parameters widget. * Remove initializeWidgetOffsetTop altogether
-