Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 03, 2024
    • Raphael Krut-Landau's avatar
      Basic cache admin UI (#39234) · c1f4bff8
      Raphael Krut-Landau authored
      Adds:
      * Performance tab 
      * Data caching settings tab
      * Two-panel strategy editor
      * "Don't cache" strategy
      * "TTL" strategy
      * "Duration" strategy
      * "Use default" option for databases
      * OSS page
      * Unit tests
      
      [Loom](https://www.loom.com/share/b1b173a52be9401588ffb63f718e052a?sid=bed4bdf5-f967-4d93-af55-9b96b6b52730)
      Unverified
      c1f4bff8
    • Uladzimir Havenchyk's avatar
      Do not put js code into page title (#40901) · d12c549a
      Uladzimir Havenchyk authored
      
      * Do not put js code into page title
      
      * Typecheck
      
      * Add e2e test
      
      * Update e2e/test/scenarios/question/document-title.cy.spec.js
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      d12c549a
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [MS2] 1. Analytics (#40681) · af54379a
      Mahatthana (Kelvin) Nomsawadi authored
      * Remove old config + fix typo
      
      * Add new analytics for 4 new illustration settings
      Unverified
      af54379a
    • Cal Herries's avatar
      Unverified
      e5f9d2c4
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [M1] Metabase illustration settings (#40219) · 715174d3
      Mahatthana (Kelvin) Nomsawadi authored
      
      * Add login page illustration (#39299)
      
      * Move Metabot setting to a new place
      
      * Add setting for login page illustration
      
      * fix UI styling
      
      * Fix not able to upload the same file twice
      
      * Update the admin > appearance > conceal metabase copy
      
      * Prepare the component for tests
      
      * Add some unit tests
      
      * Prevent settings not saved sometimes
      
      After setting the value to/from `custom` one of the setting could be
      failed to save, I suspect this happens because the race condition from
      trying to save the setting values relatively at the same time.
      
      * Make unit tests easier to read
      
      * Add all unit test test cases
      
      * Add basic E2E test
      
      * Show fallback icon for broken images
      
      * Make use of the proper component
      
      * Update the comment to affect the reality
      
      * Add an error message when file size is over 2MB
      
      * Show an error message when the file size > 2MB
      
      * Add the error message tests
      
      * Preserve the preview image aspect-ratio
      
      * Detect corrupted images
      
      * Fix failing unit tests
      
      * Address feedback: Type
      
      * Feedback: Create meaningful variables
      
      * Feedback: Make selector API more sensible
      
      * Prevent race condition
      
      Makes sure we save the settings completely before making other actions
      that also change settings otherwise, there could be race conditions.
      
      * Feedback: tighten up a type
      
      * Feedback: Fix inconsistency callback calls
      
      * 2. Add the rest 3 illustration settings (#40487)
      
      * Add the rest 3 illustration settings
      
      * Don't make the X icon feel lonely
      
      * Fix illustration widget saving
      
      * Fix type error
      
      * 3. Update the select UX to match new design (#40491)
      
      * Update the select UX to match new design
      
      * Move info dot next to file upload button
      
      * Simplify IllustrationWidget API
      
      * Update setting title copy
      
      * Clean up test comments
      
      * Feedback: Clarify `any` type
      
      * Feedback: Use shorthand object creation
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Feedback: Use global CSS glass instead of inlining values
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Feedback: Remove unnecessary curly brackets in JSX
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * 4. Connect illustrations to new setting values (#40139)
      
      * Wire landing page illustration to the setting value
      
      * Wire the unsubscribe page to the setting value
      
      * Prepare no rows error to be wired to the setting value
      
      * Wire no question results illustration to the setting value
      
      * Wire no search results illustration to setting value
      
      * Fix error from fixing conflict
      
      * Fix required unnecsseary prop on Image
      
      * Use Image component
      
      * Link dashboard card no results image to the setting value
      
      * Move the no data results to more a generic directory
      
      * Link collection picker no results image to the setting value
      
      * Make illustrations more accessible
      
      * Fix failed tests
      
      * Test unscribe page illustration + test no illustration
      
      * Add landing page tests
      
      * Simplify Cypress selectors
      
      * Refactor: Rename settings to match the new requirements
      
      No question data -> No Data
      No search results -> No object
      
      These changes are made so, these 2 settings are generic enough to
      include other illustrations later on.
      
      * Add no data illustration test
      
      * Add no object illustration tests
      
      * Fix unsubscribe page background style
      
      * Fix not able to build static viz
      
      * 5. Follow-up on milestone 1 (#40710)
      
      * Update custom background illustration scale behavior
      
      * Remove the need to put an SVG file in static folder
      
      * Fix test from rebasing off master with @testing-library/user-event upgrade
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      Unverified
      715174d3
  2. Apr 02, 2024
  3. Mar 28, 2024
  4. Mar 27, 2024
    • Sloan Sparger's avatar
    • John Swanson's avatar
      Allow group managers to view all people (#40619) · c6dd2765
      John Swanson authored
      Fixes #40328
      
      [Our documentation](https://www.metabase.com/docs/latest/people-and-groups/managing#group-managers) states that:
      
      > Group managers can:
      >
      > - View all people in the Admin settings > People tab.
      
      This fixes enforcement to be aligned with the documentation. This behavior makes sense, because as the docs also state, Group Managers should be allowed to *add* people to the group they manage, which they can only do if they can see those people!
      
      Initially, I also removed a faulty test, which was described as:
      ```
      ;; Non-segmented users are allowed to ask for a list of all of the users in the Metabase instance. Pulse email lists
      ;; are an example usage of this. Segmented users should not have that ability. Instead they should only see
      ;; themselves. This test checks that GET /api/user for a segmented user only returns themselves
      ```
      
      but actually failed to test this in a relevant way (because it was testing the `GET /api/user` endpoint rather than the `GET /api/user/recipients` endpoint). The test had continued to pass only because the user was the only member of the group they managed.
      
      I initially thought this behavior wasn't desired, but as it turns out, it *is* in fact documented behavior to disallow sandboxed users from seeing any email suggestions. Investigating, I found that a bug was allowing sandboxed users to see all users on the `/api/user/recipients` endpoint if the user-visibility setting was set to `:all`.
      
      Thus, the second commit fixes the bug and re-adds the (fixed) test. A sandboxed user now only sees their own user when hitting `/api/user/recipients`.
      Unverified
      c6dd2765
    • Oisin Coveney's avatar
  5. Mar 26, 2024
  6. Mar 25, 2024
  7. Mar 22, 2024
  8. Mar 21, 2024
  9. Mar 20, 2024
    • Cam Saul's avatar
      E2E support for CRUD + running pMBQL queries; new MLv2 normalization [WIP] (#39969) · efffd589
      Cam Saul authored
      * E2E support for CRUD + running pMBQL queries; new MLv2 normalization
      
      * More work on improved normalization
      
      * Update schema references
      
      * Test fixes :wrench:
      
      * Move the MBQL parameters schema
      
      * Performance improvements
      
      * Improved pivot code etc.
      
      * Clean namespaces
      
      * Fixes :wrench:
      
      * Wow
      
      * Test fix :wrench:
      
      * Fixes
      
      * Actions should use strings for column names (fix :update-row and :create-row normalization)
      
      * MLv2 schema should check against keys for the other query type
      
      * Ok, have I fixed things?
      
      * More fixes :wrench:
      
      * Fix indentation
      
      * Another round of test fixes. :wrench:
      
      * Split pivot stuff off
      
      * Hopefully the last few test fixes :wrench:
      
      * We need to test normalization for queries that have keyword keys as well.
      
      * Fix Cljs i18n namespaces
      
      * Sort namespaces
      
      * Only test against H2
      
      * Test fixes :wrench:
      
      * Register MBQL clause schemas and test fixes :wrench:
      
      * Test fixes and PR feedback
      
      * Test fix
      
      * Remove the normalization tests
      
      * Test fixes :wrench:
      
      * Fix kondo
      
      * Test fix
      
      * Another fix
      
      * Test fix :wrench:
      Unverified
      efffd589
    • bryan's avatar
      Feature branch for airgap-token: Milestone 1 (#39733) · bcda8468
      bryan authored
      
      * decrypt and read values from airgap token
      
      - Adds notion of "AirgapToken"
      - Adds max-users and company optional fields to `TokenStatus`
      - Adds branch to `fetch-token-status*` for handling airgapped tokens
      
      * Add support for handling airgap tokens
      
      - validate airgap token valid-thru date
      
      * enforce user creation limits using airgap token
      
      * fix airgap token reads + fill in the token data
      
      * in oss mode don't try to read the airgap_ token
      
      * use airgap-token? helper
      
      * tighten the user-creation logic
      
      - make the check correct
      - account for archived users
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      
      * check airgap user count
      
      setting premium-embedding-token
      app startup
      
      * move decryption code into ee namespace
      
      * add some tests for token decryption
      
      * fix tests and add tests
      
      * move ee features into ee tests
      
      * add typehint + warn on reflection
      
      * add a check for missing public key resource
      
      * respond to review
      
      - add docstring to AirgapToken
      - remove outdated comment
      - fix off-by-1 error
      
      * valid-now? takes a TokenStatus instead of a :map
      
      * revert usage of mt/with-temporary-setting-values
      
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Unverified
      bcda8468
    • bryan's avatar
    • Raphael Krut-Landau's avatar
    • Alexander Solovyov's avatar
      OpenAPI docs (#40162) · 22e3963b
      Alexander Solovyov authored
      Unverified
      22e3963b
    • adam-james's avatar
      Autodescribe Question Prompt adjustments (#40319) · 49d76b6a
      adam-james authored
      In a working meeting, some prompt adjustments were tried. This change felt like the best incremental improvement,
      considering feedback from users on stats.
      
      We attempted to guide the LLM to return descriptions that:
      
       - don't state the chart type as if its *very* important (we can see what it is already, so its not that important)
       - do call out caveats and important specifics as implied by the question's filters, aggregations, and breakouts
       - are descriptive but not verbose
       - try not to state caveats too strongly
      Unverified
      49d76b6a
    • Alexander Solovyov's avatar
      Fix caching tests flakes (#40379) · 4eadd09e
      Alexander Solovyov authored
      Unverified
      4eadd09e
    • metamben's avatar
      Rename metric to legacy-metric (#39232) · 8e89c578
      metamben authored
      * Rename :model/Metric to :model/LegacyMetric
      * Rename ::lib.schema.metadata/metric tp ::lib.schema.metadata/legacy-metric
      * Rename models.metric/Metric to models.metric/LegacyMetric
      * Move /api/metric endpoints to /api/legacy-metric
      Unverified
      8e89c578
    • Alexander Solovyov's avatar
    • Ngoc Khuat's avatar
  10. Mar 19, 2024
Loading