Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 04, 2024
  2. Mar 02, 2024
  3. Mar 01, 2024
    • Nick Fitzpatrick's avatar
      :sparkles: :file_folder: New Collection Picker :file_folder: :sparkles: (#38315) · ee5e9e10
      Nick Fitzpatrick authored
      * Entity Picker Squash
      
      rough table selection. dont fire me plz
      
      make stuff prettier
      
      make mysql work in table picker
      
      make a tabbed entity picker
      
      reorganize stuff
      
      WIP collectionPicker
      
      collection picker works
      
      NextedItemPicker Styling
      
      more collectionpicker work
      
      make collectionpicker work
      
      Single Picker UI
      
      adding scroll left
      
      Tabbed UI
      
      add search
      
      fix key?
      
      Splitting up components
      
      yolo animation
      
      isolate search input
      
      reorg and fix some types
      
      nested item picker unit test
      
      types are much better
      
      scroll left when needed on mount
      
      handle snippets and some other stuff
      
      Modal unit tests
      
      Modal transition, default options adjustments, fixing endless searching
      
      allow all personal collections
      
      fix some types
      
      createNewCollection
      
      disable collection creation for read-only collections
      
      using entity loaders
      
      goodbye refs
      
      started working on types. Still some stuff to do
      
      I give up. Ryan help plz
      
      wip
      
      wip
      
      more wip
      
      fix stuff
      
      cool stuff
      
      cool stuff
      
      cool stuff
      
      more stuff
      
      fix backwards traversal
      
      use effective_location
      
      testing helpers
      
      # Conflicts:
      #	frontend/src/metabase/common/components/EntityPicker/components/NestedItemPicker/NestedItemPicker.tsx
      
      dont use entity picker for move modal yet
      
      add a logical ui location
      
      takes a location like `/1/2/3/4/` and returns a "logical" ui location
      that includes only collections that the user can see.
      
      For instance, in the above location, if the user lacked permissions to
      collection 3, they could still see collection 4 but would see it as a
      child of 2, so it's effective ui location would be `/1/2/4/`
      
      remove location from other model types
      
      ie cards, snippets, etc would have a nil location. just remove
      
      test for ui logical location
      
      switch to existing `effective_location`
      
      had reinvented the wheel. There's already an effective_location which
      does exactly what we want.
      
      Add can-write? for UI concerns
      
      want it for collection picker UI info (remove or show greyed out). Tests
      are failing but want for them to start
      
      {:test 35, :pass 270, :fail 14, :error 0, :type :summary}
      
      better personal collection pathing
      
      no root permissions
      
      Basic version of Models in Browse Data (#37707)
      
      * Add Models and Databases tabs
      * Models are organized by collection
      * Exclude items in personal collections
      * Simplify BrowseHeader
      
      dashboard spec passing
      
      Initial collection selected
      
      infinite scroll right, fixing rebase issue
      
      native and models e2e
      
      getting better. remember to look at moderator icon styling
      
      adding search result filter, collection lookup for new collection modal
      
      use correct icons for special things
      
      top folder for snippets
      
      Endless API requests :sweat_smile:
      
      virtualize lists
      
      e2e tests are.... green??
      
      now green e2e plz
      
      UI adjustments, empty collection state
      
      Lots of moving around. Types should be fairly happy, and started writing unit tests
      
      happy-ish unit tests?
      
      fix backend tests
      
      remove test/table pickers
      
      nicer loader
      
      use personal endpoint
      
      remove questionPicker
      
      use generic types where possible
      
      resolving import order stuff
      
      some type stuff sorted
      
      :white_check_mark::white_check_mark: type checks :white_check_mark::white_check_mark:
      
      
      
      more prettier
      
      fix lint error
      
      Nick is embarassed
      
      types back to green
      
      fix rebase conflicts
      
      * new collection modal polish, bad nav link stuff
      
      * removing TFolder
      
      * gathering collection picker components
      
      * auto selecting newly created collections
      
      * handle confirm on Enter
      
      * formCollectionPicker cleanup
      
      * border on selected search result
      
      * NavLink variants
      
      * virtualize search results
      
      * fixing icon color on variants
      
      * empty collection and search results state
      
      * default options spread, removing commented tests, actionButtons
      
      * moving New Collection Dialog, localizing header
      
      * make entityPickerModal generic
      
      * cleanup
      
      * update unit tests
      
      * update e2e tests
      
      * fix type exports
      
      * fix 1 more unit test
      
      * last test fixes plz
      
      * better loading behaviors
      
      * improved x-scrolling
      
      * remove imperative handle on scroll, scroll to selected item on mount
      
      * fix virtualizer type
      
      * scroll after measuring
      
      * clean up your hooks man
      
      * smooth out loading behavior
      
      * happy little typescript types
      
      * update collection id type
      
      * cancel pending search requests
      
      * handle whitespace search
      
      * cleanup
      
      * more cleanup
      
      * lets null coalesce instead
      
      * fix type
      
      * small type fix
      
      * Make a more versatile and easy-to-use list virtualizer
      
      * better mock
      
      * fix rebase conflicts
      
      * even more cleanup
      
      * ok raffi was right about the scrolling
      
      * test fixes
      
      * submit button niceties
      
      * wider new collection button
      
      * make jsdom happy
      
      * lighter navlink variant
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      ee5e9e10
    • metamben's avatar
      Generate unique user name in table-privileges-test (#39457) · b3f47b34
      metamben authored
      * Generate unique user name in table-privileges-test
      b3f47b34
    • Jesse Devaney's avatar
      Fix click behavior when routing to a different tab on the same dashboard (#39319) · 99e4ce44
      Jesse Devaney authored
      * fix click behavior for routing to a new tab on the same dashboard
      
      * update changes
      
      * add test to validate behavior
      99e4ce44
    • Nemanja Glumac's avatar
    • Case Nelson's avatar
      Fix snowflake ssh tunnel (#39283) · 398ff345
      Case Nelson authored
      * Fix snowflake ssh tunnel
      
      * Put test where it will run in CI
      
      * Override incorporate-ssh-tunnel
      
      * Revert snowflake in util.ssh-test
      
      * Move tunnel connection tests to sql_jdbc
      
      * Add mock-server fixture
      
      * Exclude drivers from tunnel test
      
      * Fix up reconnection tests
      
      * Exclude more drivers
      
      * Address PR feedback
      398ff345
    • Anton Kulyk's avatar
      Fix dashboard tabs drop animation (#39444) · 3fe8aaad
      Anton Kulyk authored
      * Fix dashboard tabs drop animation
      
      * Remove animation delay from an e2e test
      3fe8aaad
    • Nicolò Pretto's avatar
      License activation step - ms1 (#39257) · 636d7185
      Nicolò Pretto authored
      * adds /api/setup/token-check and add license-token to POST /api/setup (#38858)
      
      * adds /api/setup/token-check and add license-token to POST /api/setup
      
      * refactor tests
      
      * license-token => license_token for consistency
      
      * fixed test message
      
      * fix nesting in test
      
      * Add the step in the FE and pass the token to the setup api call (#38953)
      
      * refactor: go back to saving the index for the step, to avoid having to use a selector that needs global state in the reducer
      
      * Revert "refactor: go back to saving the index for the step, to avoid having to use a selector that needs global state in the reducer"
      
      This reverts commit ee7e44f48788528e059c3f1f8816a73b675e082b.
      
      * feat: adds UI and token api logic
      
      * test structure for paid features
      
      * initSetup action as workaround
      
      * pass token to the /setup endpoint
      
      * add jest tests for ee without token case
      
      * add warning comment  on getIsPaidPlan
      
      * copy old schema for better diff
      
      * add license_token step seen event in the schema
      
      * update e2e tests to make them pass
      
      * should make e2e pass
      
      * explicitly check that the license activation step is not rendered
      
      * useStep hook
      
      * refactor: simplify logic in step_number
      
      * refactor: getInactiveStepTitle
      
      * fix too many slashes in import
      
      * refactor: rename selectThisStep to handleStepSelect
      
      * use isSetupCompleted from useStep
      
      * adds expect().toBeInTheDocument
      
      * remove waitFor in favor of await findBy
      
      * add submit snowplow event and increase the onboarding version in the events (#39151)
      
      * trackLicenseTokenStepSubmitted
      
      * adds a test and makes sure we're passing the token as undefined, not as null
      
      * clean up
      
      * remove waitFor
      
      * goToNextStep in all thunks (#39103)
      
      * Revert "initSetup action as workaround"
      
      This reverts commit 0318a55b.
      
      * goToNextStep thunk
      
      * Change the Next button to skip for the license activation step (#39292)
      
      * change the Next button to be Skip
      
      * trim token input
      
      * fix e2e test
      
      * fix quotes
      
      * hide error when the user changes the token (#39440)
      
      * keep token visible when going back (#39443)
      636d7185
    • Anton Kulyk's avatar
    • Jeff Bruemmer's avatar
      docs - updates to installation (#39228) · 42661387
      Jeff Bruemmer authored
      42661387
    • Uladzimir Havenchyk's avatar
      Utilize diagnoseExpression to detect expression errors (#39263) · a5b9817e
      Uladzimir Havenchyk authored
      * Utilize diagnoseExpression to detect expression errors
      
      * Add expressionPosition
      
      * Replace boolean with filter for startRule
      
      * Revert "Replace boolean with filter for startRule"
      
      This reverts commit 9d4cca4734a7a14021a2669a54f58584b0c5c7c9.
      
      * Remove console
      
      * Fix comments
      a5b9817e
Loading