Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 15, 2021
  2. Apr 14, 2021
  3. Apr 13, 2021
    • Cam Saul's avatar
      Fix login history emails (#15606) · 9990c81f
      Cam Saul authored
      * Much simpler impl
      
      * Remove unused var
      
      * Java 11+ test fixes :wrench:
      9990c81f
    • Howon Lee's avatar
      Date breakout quicker fix #15445 (#15600) · 6cb3341c
      Howon Lee authored
      Does not make it so window scrolling will mutate position of the second popover. However, you will be able to see the actual contents of the second popover.
      6cb3341c
    • Cam Saul's avatar
    • Cam Saul's avatar
    • Ariya Hidayat's avatar
      Don't add temporal subdimensions to a FieldIDDimension (#15582) · 65b6582e
      Ariya Hidayat authored
      * Don't add temporal subdimensions to a FieldIDDimension
      
      This restores the behavior just like before MBQL field refactoring (back
      when FieldIDDimension still existed).
      
      * Adjust expectation in another test
      65b6582e
    • Jeff Bruemmer's avatar
      docs - account settings page (#15583) · f25ac924
      Jeff Bruemmer authored
      f25ac924
    • Ellie Mary's avatar
      Update Python code snippet for Python 3.7 (#14424) · 92510356
      Ellie Mary authored
      This is the fastest resolution for this bug: https://github.com/metabase/metabase/issues/14423
      92510356
    • dpsutton's avatar
      Cleanup migration comment (#15594) · 223cf250
      dpsutton authored
      223cf250
    • dpsutton's avatar
      Remove unixtimestamp type (#15533) · 4910a3e2
      dpsutton authored
      * Remove type/UNIX* and type/ISO8601* from frontend
      
      * Set effective-type and coercion strategy when syncing
      
      these values will most likely only be available when using tests, as
      metadata is very unlikely to have this. As far as I can tell the
      toucannery apparatus is the only bit that has this. Its quite
      artificial. I'm not sure if this is a good idea.
      
      * :type/UNIXTimestampSeconds and type/ISO8601DateTimeString out of type
      
      remove the coercions from the type hierarchy. This brought up a
      strange issue that has been present for a while: all liquidbase
      migrations run and then all data migrations run. They are not
      interleaved. This allows for the following scenario:
      
      - data migration migrates all X values to Y in version 26
      - liquibase migration migrates all Y values to Z in version 28
      
      But these are not run in version order, but all liquibase migrations
      are run and then all data migrations are run. If you were on an old
      version for a while, you could end up with Y values even though the
      liquibase migration which comes "after" the data migration turns all Y
      values into Z values.
      
      This impacts this change because a data migration in this way:
      - liquibase changesets 287, 288, 289, and 290 remove all 'type/UNIX*'
      and 'type/ISO8601*' semantic types. These were in 0.39
      - data migration `migrate-field-types` added in 0.20.0 was looking for
      special_type's of "timestamp_milliseconds" and migrating them to
      "type/UNIXTimestampMilliseconds".
      
      Since the liquibase runs before the migrate-field-types, it's possible
      for a 'type/UNIX*' semantic type to reappear. And since these were
      removed from the type system it would fail validation and blow up. In
      this case it actually can't happen since the field its attempting to
      migrate (special_type) no longer exists. But since the migrations are
      not interleaved this problem still exists.
      
      * whatever prettier
      
      * Appease the machines
      
      * Restore the unix and iso semantic types to hierarchy
      
      migration tests still use these
      `(impl/test-migrations [283 296] [migrate!] ...)`
      
      A few things in tension: the field requires valid semantic_types,
      these _were_ valid semantic_types until v39.
      
      * Remove old "coercion" semantic types
      
      * Migrate the v20 version semantic types for unix epoch
      
      * Time travelling migrations
      
      these target v20 and v29 which at the time they existed had a column
      special type not semantic type. But these run after all of the schema
      migrations, not interleaved, so they will have a semantic_type not
      special_type when they actually run even though they target v20 or v29
      data. strange world
      
      * add migration's new checksum
      4910a3e2
    • Anton Kulyk's avatar
      Fix Duplicate action visibile with read permission (#15573) · 22e039bd
      Anton Kulyk authored
      * Fix Duplicate action visible with read permission
      
      For `/collection/root` page
      
      * Fix Duplicate action visible with read permission
      
      For `/dashboard/:id` page
      
      * Move dashboard permission test to collection suite
      22e039bd
  4. Apr 12, 2021
    • Nemanja Glumac's avatar
    • Howon Lee's avatar
      Popover movement #15502 (#15524) · 9baaff76
      Howon Lee authored
      Popover movement is with reference to #15502 but also with reference to #15277 and #15534 and #15502 but not #15445, except for the mutation movement portion of #15445 which is not a whole fix.
      
      Confusingly, the overlap portion of #15502 is almost a completely separate bug but a fix is in here anyways.
      9baaff76
    • Alexander Lesnenko's avatar
      Support both 0 and null values in a dimension for X axis (#15554) · bfbc3c45
      Alexander Lesnenko authored
      * support both 0 and null values in a dimension for X-axis
      bfbc3c45
    • Nemanja Glumac's avatar
    • Dalton's avatar
      Dashboard parameter field filter operators feature flag (#15519) · a362e2f3
      Dalton authored
      
      * Backend feature flag for new field filters
      
      * Feature flag new parameter options
      
      When the "field-filter-operators-enabled?" flag is disabled we do the following:
      1. Replace new operator options with old category and location/city, etc., options
         in the PARAMETER_OPTIONS list found in metabase/meta/Parameter.js
      2. Hide numbers section in the PARAMETER_SECTIONS list found in
         metabase/meta/Dashboard.js
      3. Return args as-is in the mapUIParameterToQueryParameter function
         found in metabase/meta/Parameter.js
      
      React/UI code handles both old options and new options so doesn't need
      to change. Old parameter types like "category" and "location/city" are
      treated like "string/=" in the UI but retain their own parameter type
      when used to send a new query.
      
      * Fix FE issues caused by meta/Parameter refactor
      
      * mock the field operator param flag to make tests pass
      
      * add/fix cypress tests
      
      * fix import in ParametersPopover
      
      * update widget tag type
      
      * Enable field filter operators for cypress tests
      
      * Question marks are questionable
      
      * Conditionally use category or string/= if field filters are enabled
      
      * rmv mocks where we don't need them
      
      * rmv mock from chained-filters test
      
      * env vars as string in project.clj, alignment
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      a362e2f3
    • Cam Saul's avatar
    • Jeff Evans's avatar
      Various improvements to version update checks (#15517) · 9392ddd7
      Jeff Evans authored
      * Various improvements to version update checks
      
      ***************************
      * Release project changes *
      ***************************
      
      Updating version_info.clj code to build version-info-ee.json file for Enterprise Edition build
      
      Adding test for both oss and ee version info file generation logic
      
      Decoupling GitHub milestone from version and setting it to be the OSS value for :ee release build
      
      Adding nREPL alias for release deps.edn project and usage note
      
      ************************
      * Core product changes *
      ************************
      
      Adding new :ee version of :mb-version-info-url (:mb-version-info-ee-url) with default value to match the file name generated by the release code
      
      Making enterprise-edition? public from core.clj, since it's now needed from the upgrade check code to switch between the URLs
      
      Adding new setting to store when updates were last checked (since it's on a 12-hour interval)
      
      Changing update check code to both set this new timestamp setting (always) to the current time, and set version-info itself to nil if the update check fails (so that users won't see "latest and greatest" if the update check succeeded at some point in the past, but then started failing
      
      Frontend changes:
      
      Showing the "last checked" timestamp (in user's browser timezone) when we show the "Sorry" text because of being unable to check for updates, so they know when the last check was made
      
      Removing custom implementation of MetabaseSettings.versionInfo from EE frontend code since it's no longer needed (and never worked), because the EE backend will now be hitting a different URL with the version info specifically for EE releases
      
      Linking to https://www.metabase.com/docs/<newVersion>/operations-guide/upgrading-metabase.html URL instead of simply /start
      9392ddd7
    • Dalton's avatar
    • Nemanja Glumac's avatar
  5. Apr 10, 2021
  6. Apr 09, 2021
  7. Apr 08, 2021
    • Nemanja Glumac's avatar
      Fix flakiness in `scatter` visualization tests (#15520) · 22d17fa2
      Nemanja Glumac authored
      - Fixes a flake in scatter.cy.spec.js that started appearing after throttle was introduced to the ExplicitSize component in #15235
      - Also fixes a flake with brush filter that apparently wasn't fully fixed in the previous attempt
      
      ## Additional Info:
      - Stress testing this fix in isolation with GitHub actions shows 20/20 runs passing :white_check_mark:
      - Stress testing "brush date filter" revealed that it still fails approximately 4-5x out of 20!
      
      - The reason seems to be that `mouseup` event doesn't always happen at the same time so the resulting filter doesn't have the same ending month every time (for example I've seen: "Created At between May, 2016 September, 2016", "Created At between May, 2016 July, 2016" and even "Created At between May, 2016 May, 2016")
      - It is more than enough that we assert that this filter exists in the first place so I changed the assertion to: `cy.contains(/^Created At between May, 2016/);` since the beginning of this string is the only thing we care about
      22d17fa2
Loading