This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 15, 2021
-
-
Nemanja Glumac authored
-
Anton Kulyk authored
* Fix collections without children have expand arrow * Bring back issue reference to Cypress test
-
Dalton authored
* add string parameter to dashboards instead of replacing location/category * merge category and string sections * make location options strings when flag flipped * update strings in cy tests * filter location fields when using text/category parameter * Microcopy tweaks * update more cy strings * replace location switch default with isLocation Co-authored-by:
Maz Ameli <maz@metabase.com>
-
Maz Ameli authored
-
Nemanja Glumac authored
-
- Apr 14, 2021
-
-
Jeff Evans authored
Updated the updateSectionsWithPlugins fn to sort the sections again after reducing by PLUGIN_ADMIN_SETTINGS_UPDATES, because those update functions might change the order of keys Adding explicit order property for the items in SECTIONS to facilitate that re-sorting Fix expected property type for SettingsEditorApp sections (which is truly an object, not an array), and fixed the null case accordingly Incorporate Cypress test written by Nemanja Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Howon Lee authored
Scrolling gets disabled for the modal and then is supposed to be reenabled when modal is closed. However, SandboxedPortal eats the events that would tell the modal to go and do this. Do it on React lifecycle bits instead.
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Tim Macdonald authored
Bit of context here: https://metaboat.slack.com/archives/C505ZNNH4/p1618417989013200
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Alexander Lesnenko authored
* fix inability to filter by a field of a joined table * fix filtering by columns of other tables in the simple question mode
-
Tim Macdonald authored
* #15080 Repro: Archived items not shown in archive (#15198) * /search returns archived items again [Fixes #15080] Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Nemanja Glumac authored
* Add repro for #15563 * Fix "post-join filters" flake * Unskip the test (fixed by #15582) * Use explicit assertion
-
- Apr 13, 2021
-
-
Cam Saul authored
* Much simpler impl * Remove unused var * Java 11+ test fixes
-
Howon Lee authored
Does not make it so window scrolling will mutate position of the second popover. However, you will be able to see the actual contents of the second popover.
-
Cam Saul authored
-
Cam Saul authored
-
Ariya Hidayat authored
* Don't add temporal subdimensions to a FieldIDDimension This restores the behavior just like before MBQL field refactoring (back when FieldIDDimension still existed). * Adjust expectation in another test
-
Jeff Bruemmer authored
-
Ellie Mary authored
This is the fastest resolution for this bug: https://github.com/metabase/metabase/issues/14423
-
dpsutton authored
-
dpsutton authored
* Remove type/UNIX* and type/ISO8601* from frontend * Set effective-type and coercion strategy when syncing these values will most likely only be available when using tests, as metadata is very unlikely to have this. As far as I can tell the toucannery apparatus is the only bit that has this. Its quite artificial. I'm not sure if this is a good idea. * :type/UNIXTimestampSeconds and type/ISO8601DateTimeString out of type remove the coercions from the type hierarchy. This brought up a strange issue that has been present for a while: all liquidbase migrations run and then all data migrations run. They are not interleaved. This allows for the following scenario: - data migration migrates all X values to Y in version 26 - liquibase migration migrates all Y values to Z in version 28 But these are not run in version order, but all liquibase migrations are run and then all data migrations are run. If you were on an old version for a while, you could end up with Y values even though the liquibase migration which comes "after" the data migration turns all Y values into Z values. This impacts this change because a data migration in this way: - liquibase changesets 287, 288, 289, and 290 remove all 'type/UNIX*' and 'type/ISO8601*' semantic types. These were in 0.39 - data migration `migrate-field-types` added in 0.20.0 was looking for special_type's of "timestamp_milliseconds" and migrating them to "type/UNIXTimestampMilliseconds". Since the liquibase runs before the migrate-field-types, it's possible for a 'type/UNIX*' semantic type to reappear. And since these were removed from the type system it would fail validation and blow up. In this case it actually can't happen since the field its attempting to migrate (special_type) no longer exists. But since the migrations are not interleaved this problem still exists. * whatever prettier * Appease the machines * Restore the unix and iso semantic types to hierarchy migration tests still use these `(impl/test-migrations [283 296] [migrate!] ...)` A few things in tension: the field requires valid semantic_types, these _were_ valid semantic_types until v39. * Remove old "coercion" semantic types * Migrate the v20 version semantic types for unix epoch * Time travelling migrations these target v20 and v29 which at the time they existed had a column special type not semantic type. But these run after all of the schema migrations, not interleaved, so they will have a semantic_type not special_type when they actually run even though they target v20 or v29 data. strange world * add migration's new checksum
-
Anton Kulyk authored
* Fix Duplicate action visible with read permission For `/collection/root` page * Fix Duplicate action visible with read permission For `/dashboard/:id` page * Move dashboard permission test to collection suite
-
- Apr 12, 2021
-
-
Howon Lee authored
Popover movement is with reference to #15502 but also with reference to #15277 and #15534 and #15502 but not #15445, except for the mutation movement portion of #15445 which is not a whole fix. Confusingly, the overlap portion of #15502 is almost a completely separate bug but a fix is in here anyways.
-
Alexander Lesnenko authored
* support both 0 and null values in a dimension for X-axis
-
Nemanja Glumac authored
-
Dalton authored
* Backend feature flag for new field filters * Feature flag new parameter options When the "field-filter-operators-enabled?" flag is disabled we do the following: 1. Replace new operator options with old category and location/city, etc., options in the PARAMETER_OPTIONS list found in metabase/meta/Parameter.js 2. Hide numbers section in the PARAMETER_SECTIONS list found in metabase/meta/Dashboard.js 3. Return args as-is in the mapUIParameterToQueryParameter function found in metabase/meta/Parameter.js React/UI code handles both old options and new options so doesn't need to change. Old parameter types like "category" and "location/city" are treated like "string/=" in the UI but retain their own parameter type when used to send a new query. * Fix FE issues caused by meta/Parameter refactor * mock the field operator param flag to make tests pass * add/fix cypress tests * fix import in ParametersPopover * update widget tag type * Enable field filter operators for cypress tests * Question marks are questionable * Conditionally use category or string/= if field filters are enabled * rmv mocks where we don't need them * rmv mock from chained-filters test * env vars as string in project.clj, alignment Co-authored-by:
dan sutton <dan@dpsutton.com>
-
Cam Saul authored
-
Jeff Evans authored
* Various improvements to version update checks *************************** * Release project changes * *************************** Updating version_info.clj code to build version-info-ee.json file for Enterprise Edition build Adding test for both oss and ee version info file generation logic Decoupling GitHub milestone from version and setting it to be the OSS value for :ee release build Adding nREPL alias for release deps.edn project and usage note ************************ * Core product changes * ************************ Adding new :ee version of :mb-version-info-url (:mb-version-info-ee-url) with default value to match the file name generated by the release code Making enterprise-edition? public from core.clj, since it's now needed from the upgrade check code to switch between the URLs Adding new setting to store when updates were last checked (since it's on a 12-hour interval) Changing update check code to both set this new timestamp setting (always) to the current time, and set version-info itself to nil if the update check fails (so that users won't see "latest and greatest" if the update check succeeded at some point in the past, but then started failing Frontend changes: Showing the "last checked" timestamp (in user's browser timezone) when we show the "Sorry" text because of being unable to check for updates, so they know when the last check was made Removing custom implementation of MetabaseSettings.versionInfo from EE frontend code since it's no longer needed (and never worked), because the EE backend will now be hitting a different URL with the version info specifically for EE releases Linking to https://www.metabase.com/docs/<newVersion>/operations-guide/upgrading-metabase.html URL instead of simply /start
-
Dalton authored
-
Nemanja Glumac authored
- Apr 10, 2021
-
-
Cam Saul authored
* datetime fields in nested queries should get auto-bucketed the same way as top-level ones * Test fix
-
- Apr 09, 2021
-
-
Cam Saul authored
* Revert name case changes * Test fix
* Test fix -
Jeff Bruemmer authored
-
Ariya Hidayat authored
This restores the behavior just like before MBQL field refactoring (back when the specialized class JoinedDimension and FKDimension still existed): the subdimensions for a joined/FK dimension are exactly those of the parent class, Dimension.dimensions(), and not more. Also, each subdimension must still carry the join alias/source field option.
-
- Apr 08, 2021
-
-
Nemanja Glumac authored
- Fixes a flake in scatter.cy.spec.js that started appearing after throttle was introduced to the ExplicitSize component in #15235 - Also fixes a flake with brush filter that apparently wasn't fully fixed in the previous attempt ## Additional Info: - Stress testing this fix in isolation with GitHub actions shows 20/20 runs passing
- Stress testing "brush date filter" revealed that it still fails approximately 4-5x out of 20! - The reason seems to be that `mouseup` event doesn't always happen at the same time so the resulting filter doesn't have the same ending month every time (for example I've seen: "Created At between May, 2016 September, 2016", "Created At between May, 2016 July, 2016" and even "Created At between May, 2016 May, 2016") - It is more than enough that we assert that this filter exists in the first place so I changed the assertion to: `cy.contains(/^Created At between May, 2016/);` since the beginning of this string is the only thing we care about
-