Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 29, 2020
  2. Jul 28, 2020
  3. Jul 22, 2020
  4. Jul 20, 2020
  5. Jul 17, 2020
  6. Jul 16, 2020
  7. Jul 15, 2020
  8. Jul 09, 2020
  9. Jul 07, 2020
  10. Jul 06, 2020
  11. Jul 02, 2020
  12. Jun 30, 2020
  13. Jun 25, 2020
  14. Jun 24, 2020
  15. Jun 15, 2020
  16. Jun 12, 2020
  17. Jun 08, 2020
    • Walter Leibbrandt's avatar
      Native query snippets (#11965) · 0409161d
      Walter Leibbrandt authored
      
      * Support substituting SQL snippets in queries
      
      * Rename SQL snippets to native query snippets
      
      * Add migration and model for native query snippet table
      
      * Add API endpoints for native query snippets CRUD
      
      Tests are incomplete. Consequently the API is not well tested.
      
      * Cosmetic: Docstring typo and indentation
      
      * Remove pre-delete handler that prevents deletion
      
      It breaks in cases where deletion is reasonable, like during tests. No
      DELETE API endpoint will be added, so no it shouldn't be necessary to
      add any additional safeguards.
      
      * Fix `:database_id` field reference
      
      And remove unused import.
      
      * Test snippets listing via API
      
      * Add more API test stubs
      
      * Refactor snippets listing endpoint for improved readability
      
      * Align NativeQuerySnippet model behavior with Segment model's
      
      * Clean ns
      
      * Fix and test individual snippet read via API
      
      * Fix snippet name schema
      
      * Test creation of snippets via API
      
      * Test update API endpoint for native query snippets
      
      * Handle query snippet model in H2 dump/load commands
      
      * Port load-from-h2 tests to clojure.test
      
      * Deduplicate models list used to dump/load H2 dbs
      
      The failing load-from-h2 test that checks that all models are accounted
      for alerted me that I need to handle the new `NativeQuerySnippet` model.
      However, there was no such test for dump-to-h2. Instead of adding such a
      test, I opted to simply use load-from-h2's list in dump-to-h2 to
      eliminate the problem, rather than testing for it.
      
      * Dump/load collections before models that depend on it
      
      * Linter appeasement
      
      * Use snippet ID and content in query parameter record
      
      * Implement snippet lookup for template tags with ID
      
      * Basic FE support for snippet template tags
      
      * Use shorter "snippet" prefix instead of "native-query-snippet"
      
      * Use simpler `tru` instead of `str` with `deferred-tru`
      
      * Allow whitespace between snippet prefix and name
      
      Also accept any sequence of characters after prefix.
      
      * Don't allow snippet names to start with whitespace
      
      Whitespace is allowed between the `snippet:` template tag prefix and the
      snippet name. That whitespace is trimmed out when extracting the snippet
      name.
      
      * Add database ID to snippet template tags before expanding parameters
      
      * Ensure that snippet db matches query db
      
      * Avoid setting `:template-tags` for native queries without it
      
      * Factor out snippet database ID validation
      
      * Test snippet database ID validation
      
      * Avoid validating nil snippets
      
      * First pass at nested template tags in snippets
      
      * Pass parent query parameters on to nested sub-queries
      
      * Remove unused let-binding
      
      * Added disabled test for reading query param from template tag
      
      * Temporarily disable failing test
      
      * Remove half baked nested snippet support
      
      * Snippet model perms = native query perms
      
      * Rename param k→ks for clarity
      
      * Remove superfluous `some?` call
      
      * Use utility functions to reduce cruft
      
      * Test expansion of multiple snippets in (sub-)query
      
      * Rather use testing utils from metabase.test
      
      * Check for snippet changes only in provided fields
      
      * Deduplicate field checks, with added test case output
      
      * remove unused import from bad merge
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      Co-authored-by: default avatarPaul Rosenzweig <paulrosenzweig@users.noreply.github.com>
      Unverified
      0409161d
  18. Jun 05, 2020
    • Tom Robinson's avatar
      Support changing the language in the FE at runtime (#12566) · 1f3a7680
      Tom Robinson authored
      * Support changing the language in the FE at runtime via MetabaseSettings.set("user-locale", locale). Note that some strings evaluated at load time won't be refreshed, so doing a window.location.reload() at an appropriate time is necessary
      
      * Convert metabase.api.session-test to new style
      
      * Support X-Metabase-Locale header
      
      * Pass X-Metabase-Locale to /api/session/properties, update language in setup form
      
      * Test fixes & some code cleanup
      
      * Fix circular dependency
      
      * Add dt DeferredTTagString
      
      * wrap ttag rather than patching it
      
      * refresh the UI language after updating user or site locale
      
      * remove deferred ttag wrappers
      
      * switch to hard refreshes, remove local from new user form
      
      * update e2e test to use new url
      
      * small string fixes
      
      * add missing "?" in e2e test
      
      * try and set default language from browser's setting
      
      * Fix wonky merge :wrench:
      
      
      
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      Unverified
      1f3a7680
  19. Jun 04, 2020
    • Cam Saul's avatar
      Backport a few tweaks from EE (#12611) · 10c8c56b
      Cam Saul authored
      * Backported fixes
      
      * Explicitly include data.xml as a dep
      
      * Use OffsetDateTime instead of org.h2.api.TimestampWithTimeZone [ci mysql]
      
      * Revert JUnit tweaks -- don't seem to be working correctly
      Unverified
      10c8c56b
  20. Jun 03, 2020
  21. Jun 02, 2020
  22. Jun 01, 2020
  23. May 29, 2020
  24. May 28, 2020
Loading