This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 07, 2023
-
-
Nemanja Glumac authored
We stopped using Currents.dev analytics a few months ago. This PR removes the stray project ID from E2E workflow. [ci skip]
-
Alexander Polyankin authored
-
- Jun 06, 2023
-
-
Ngoc Khuat authored
* hydrate orders-tabs for public/embed dashboard * adds test * return dashboard_tab_id when hydrate ordered_cards for public dashboard * show tabs in `PublicDashboard` on FE * remove unused export * update e2e test * remove duplicated implementation for macro in test * makes the macro public for testing * run prettier on DashboardTabs.tsx --------- Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu>
-
Tim Macdonald authored
See discussion at https://metaboat.slack.com/archives/C5XHN8GLW/p1685964332028149
-
Tim Macdonald authored
* Sync but don't scan tables from uploaded CSVs Delete the CSV file afterwards * Delete the CSV file more intelligently * Scan asynchronously never mind about the file deletion * Turn file deletion back on * Humanize model name for uploaded CSVs * Update Cypress test with humanized name * Only scan new tables, not the whole DB * Only sync tables * Get schema name properly * Fix error-handling; don't create errant table * Check for syncable schemas * Fix E2E test * Tidy up include-schema? usage
-
- Jun 05, 2023
-
-
Kamil Mielnik authored
* Make NativeQueryEditor testable - Mock just NativeQueryEditor.prototype.loadAceEditor instead of entire NativeQueryEditor * Fix invalid propTypes * Fix DatasetQueryEditor not re-rendering when props change - remove custom arePropsEqual argument from React.memo() on NativeQueryEditor - Fixes #30680 * Add a dirty initial NativeQueryEditor test setup * Add DatasetQueryEditor tests * Revert "Add a dirty initial NativeQueryEditor test setup" This reverts commit 0f985db272a2e8f1be755bda07c3b642fdf90f83. * Get rid of test errors * Clean up DatasetQueryEditor test * Add a test case for re-rendering of DatasetQueryEditor * Make setup function more reusable * Add 2 more test cases * Bring back global NativeQueryEditor mock as many tests depend on it * Add an e2e test for #30680 * Optimize DatasetEditor by conditionally rendering DatasetQueryEditor only when it can be seen * Remove redundant code * ESLint * Use createMockCollection instead of a cast * Move all Native Query creation to createMockNativeDatasetQuery * Use setupCollectionsEndpoints * Introduce setupNativeQuerySnippetEndpoints and use it in DatasetQueryEditor.unit.spec.tsx * Extract explanatory importDatasetQueryEditor * Remove file accidentally added when merging master * Add missing data-testid that got lost during a merge
-
- Jun 03, 2023
-
-
Denis Berezin authored
-
- Jun 02, 2023
-
-
Maz Ameli authored
* arrow_left * check mark * arrow_up and chevrons * add, close, contract, embed, expand, sort * change viewbox to 16 * icons in +New menu, search, and sidebar toggle * info_outlined, connections or fk icon, and tweaks to x-ray suggestion icons * fix database icon * ellipsis, person, and tweak ellipsis size in collections sidebar * home, reference or book, pencil or edit, table * dashboard action icons, and remove reference to unused ClockIcon.jsx * question action icons and related component tweaks * larger icons on HomeModelCard on homepage * dashboard and add_to_dash * snippet and variables * all the chart type icons and some field type ones * mail and groups * make sidebar icons darker blue * fix add-your-data icon * filled mail icon and use it on events modal * stars * bolt and x-rays and a bunch more * granular, metric, revision history * arrows, formula, snippets * click, cloud, boolean, unpin * return, hourglass, popover * pause, ldap, burger * gear info list pin moon sum sun verified warning * fix size of row details modal icons * fix size of left nav icons * fix size on filter widgets and some selects * set default size to 16 to fix entity menu icons etc * fix pagination icons * size and color on ItemPicker * bump up database icon in /browse to 32px * /browse bolt icon size * find and remove instances of 14px size declarations * sql editor icons * sql expand/contract button alignment * collection breadcrumbs * remove two more size 14 declarations * viz selector * fix add icon in New button * fix size of ModelDetailLink * icon for question list empty state * get rid of model_framed icon * try to fix event tick icons, replace balloons with cake * standardize size of question footer actions * fix dinosaur * switch star_outline to star, and star to star_filled * fix notebook sort action * switch data picker from table2 to table * fix slack icon * restyle HomeXrayCard * fix List icon * fix sidebar toggle icon size * fix icon size in field picker popovers * fix summarize sidebar field type icons * fix summarize sidebar Add buttons * table heading sort icons * fix filter icon, resize button icons * bulk filters icons * admin datamodel icons sizing * fix datamodel metric and segment icons, and sort icon * dashboard interactivity sidebar close icon * get rid of grabber2 * bookmark and question actions icon sizes * revert icon * Icons cleanup (#31147) * remove timeline event icon stroke * cleanup * add 16x16 viewbox to svgs that were missing it * add slack_colorized * correct the join_full_outer icon * timeline events, cleanup * fix broken icons * more cleanup * fix storybook * fix all types * add stories * try fixing arrow_split --------- Co-authored-by:
Maz Ameli <maz@metabase.com> * fix specs * fix specs * remove unused icons * use constants * increase node memory allocation * bump for chromatic too * fixes * fix arrow_split icon * fix arrow_split path attributes * fix path again and fix sizing of drillthrough menu icons * more spec fixes * prettier --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Ryan Laurie authored
* [Model Indexes] Use model metadata to determine indexability (#31048) * [Model Indexes] Allow Updating Metadata at the same time as adding an index (#31049) * [Model Indexes] Fix Model Index Front End Cache Invalidation (#31094)
-
Oisin Coveney authored
-
- Jun 01, 2023
-
-
Oisin Coveney authored
-
Ngoc Khuat authored
-
Nemanja Glumac authored
@jaril informed me that Replay.io is missing metadata from Metabase E2E tests. Apparently trying to access system environment variable from Cypress support file didn't work. The solution for this is to prefix the environment variable with `CYPRESS_` and then to read it using `Cypress.env()` This is what Cypress documentation suggests: https://docs.cypress.io/guides/guides/environment-variables#Option-3-CYPRESS_ [ci skip]
-
Nemanja Glumac authored
* Make custom `button` command chainable * Chain `.button` directly No need to use `.within()` anymore. We can chain the button command directly because it now receives the previously yielded subject. * Fix collections bulk actions test
-
- May 31, 2023
-
-
Kyle Doherty authored
* remove /reference pages + reducers * Remove redundant metadata selectors * Remove redundant metadata actions * Remove `QueryButton` component * Remove `List` component * Remove dead link * Move `NoDatabasesEmptyState` to `NewModelOptions` * remove obvious /reference specific e2e tests and ask a bunch of questions [ci skip] * Remove data reference section from e2e test suite [ci skip] * Remove segments data reference e2e tests [ci skip] * Remove reference section from the browse page test [ci skip] * Remove the last few mentions of the reference page in e2e tests [ci skip] * Fix sso button lint error --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
Oisin Coveney authored
-
Nemanja Glumac authored
[ci skip]
-
Nemanja Glumac authored
* Make E2E custom icon command chainable * Refactor E2E helpers We can now chain the `.icon()` command on the previous subject. * Chain `.icon()` on prev subject in all tests * Fix moderation-question test
-
Nemanja Glumac authored
The underlying issue was fixed, but we are not sure exactly when. This reproduction should prevent future regressions.
-
Kamil Mielnik authored
* Update 15946 e2e test - modal() expects ModalContent to be present in DOM, but NativeQuerymodal uses ModalBody directly - add extra check for run button to be enabled * Ensure collection is present in dataset query during query conversion * Unskip e2e test for #15946 * Handle string tableId
-
- May 30, 2023
-
-
Mahatthana (Kelvin) Nomsawadi authored
This is because `source-field` was missing from a field dimension.
-
- May 26, 2023
-
-
Denis Berezin authored
* Update underlying records drill - bring to top, label changes (#29984) * Zoom in Drill (#30208) * Add updated zoom drill title * Fix e2e tests * Add title unit tests * Fix for Records drill UI when it is the only one displayed * Review fixes * Add pivot drill common popover (#30275) * Add grouping for Pivot drill options * Reuse filterField type * Fix date formatting after rebase * Move Automatic insight action to a common popover (#30370) * Refactor ChartClickActionsView, reuse it component in drills (#30706) * 26836 separate views for quick cell click filters (#30532) * Added separate views for QuickFilterDrill * Add tests, fix styles issues * 26836 contains/does not contain quick filter for tables (#30778) * Add contains/does not contain quick filter for tables * Self review fixes * Fix for column header filter search options cropped * Fix for icon margin difference for contains / does not contain filters * Fix contains filter actions icon styles * Add quick filters support for aggregated queries * Not show contains filter for joined fields * Fix typecheck * Adjust string field quick filter section title to have column name (#30888) * 26836 Add View details action for quick filters (#30967) * Add View details action to quick filters * Self review fixes * Fix e2e tests * Fix review issues
-
Aleksandr Lesnenko authored
* fix the question description icon placement in the collection view * fix specs
-
Braden Shepherdson authored
This has never worked (see #11371) and produces bad results which group by every individual value of the column, rather than binning/bucketing correctly. This can theoretically be supported, but needs BE work to construct correct queries. To be addressed after MLv2.
-
Nemanja Glumac authored
* Install `replay.io` library * Register `replay.io` in the Cypress config * Run E2E tests using Replay chromium browser but only in CI * Upload Replay.io recordings to the dashboard * Manually install Replay.io browser * Always upload recordings * Pass in a custom test run id * Disable asserts and send replays to a separate team * Upload OSS recordings as well * Use specific Ubuntu version * Record and run Replay.io on `master` only * Do not toggle CI browsers in the config * Test run: pass `replay-chromium` browser as CLI flag in a run * Fix multi-line command * Use replay plugin conditionally * Set the flag correctly * Require node process * Remove sourcemap vars * Record using replay.io on schedule * Explicitly name replay runs --------- Co-authored-by:
Jaril <jarilvalenciano@gmail.com>
-
Ngoc Khuat authored
* Dashboard Tab entity (#29802) * add dashboard tab entity * Dashboard tabs CRUD (#29861) * Dashboard tabs frontend (#30189) * rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx` commit-id:7cdfd86a * add tabs to dash commit-id:d3c2fa74 * improve code structure and other fixes * rename `dashboardtab_id` to `dashboard_tab_id` * remove explicit `position` logic * improve code quality * add renaming functionality * add two new tabs when creating first tab * hide tabs if there is only one * add unit test for `DashboardTabs` component * refactor * fix type errors * add `tabId` to text cards * add `tabId` to link cards * add `tabId` to action button * use disabled state when only one tab remains * refetch cards with filter value when changing tabs * add e2e test * fix broken e2e tests * add horizontal scrolling * fix unit test * fix create tab button being on right * fix performance issue when switching tabs * add `ttag` to `tabs.ts` * use `aria-label` in e2e test helper * fix type error after rebasing * making ordered_tabs optional for tests purposes * fix failing unit tests * fix failing e2e tests * fix flaky revision history e2e test * fix type error after merging feature branch with master and rebasing * fix revisions unit test * fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * migrating revision logic to BE * handle description for multiple cards add/remove * test fixes * adds tests * make sures events are started so tests work * remove additional `:maybe` that was added while rebasing * add title and has_multile_changes to revision * fixes potential test flake * more tests * remove debug code * handles collection change description in card and dashboard * fixes fail to build * use backend for revision history (#30772) * use BE response for revision history * update `service.unit.spec.js` * sort revision and moderation events for question timeline * test fixes * create revision directly instead of via API to avoid flake * reverted to an earlier revision => reverted to an earlier version * translate the model name too * Rename functions: - diff-strs -> diff-strings - diff-strings -> diff-strings* - diff-strings* -> diff-string * move the diff to diff-strings* * use case instead of map for model-str->i18n-str * remove title from API response * do not translate test model * rename var `title_text` to `titleText` * address comments * stringify the display name * fix revert button not working * add loading wrapper to fix unit test * fix tests * fix type error * fix QuestionActivityTimeline test * add a dot for edited this --------- Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu>
-
Alexander Polyankin authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Consolidate auto-apply filters toggle action (#30978) So that when we start tracking the event on Snowplow, we can only do that in a single place. * Track disabling auto-apply filters in Snowplow (#30987) * Fix dashboard ID type
-
Nemanja Glumac authored
-
- May 25, 2023
-
-
Nick Fitzpatrick authored
* Adding admin settings * updating homepage * permissions * Include custom homepage on current user Response from `/api/user/current/` now always includes a key `custom_homepage`. It is nil unless `custom-homepage` setting is true and `custom-homepage-dashboard` is set to an id that is a valid dashboard that the user can read. (note this includes archived dashboards). In this circumstance, the response will be ``` ... "custom_homepage": { "dashboard_id": 87 }, ... ``` * adding unit tests * Homepage CTA * cleanup and types * e2e tests, small adustments * lint * type fix * Editing Dashboard Reminder * fixing unit test * ensure custom homepage dashboard exists and is not archived * handling dashboard archived scenario, use-dashboard-query * polish * Copy updates, removing personal collections from picker * PR Feedback * CI checks * PR Feedback * Adding default filter function --------- Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- May 24, 2023
-
-
Ryan Laurie authored
* indexed entities schema * schema * endpoint with create and delete * hooked up tasks * first tests and hooking it all together * some e2e tests * search * search had to rename value -> name. The search stuff works well for stuff that looks the same. And previously was renaming `:value` to name in the search result, but it uses the searchable-columns-for-model for which values to score on and wasn't finding :value. So easier to just let name flow through. * include model_pk in results * send pk back as id, include pk_ref * rename fk constraint (had copied it) * populate indexed values with name not value * GET http://localhost:3000/api/model_index?model_id=135 * populate indexed values on post done here for ease of demo. followup work will schedule the task immediately, but for now, do it on thread and return info * test search results * fix t2 delete syntax on h2 * fix h2 * tests work on h2 and postgres app dbs * ...
-
Cal Herries authored
Fix column settings being duplicated when fields have the same `id-or-name`, but different `join-alias` (#27487)
-
Alexander Polyankin authored
-
Nick Fitzpatrick authored
* Add onDisplayUpdate function to visualizations to update settings * Moving update settings to ChartTypeSidebar * updating test name
-
Alexander Polyankin authored
-
- May 23, 2023
-
-
Nemanja Glumac authored
* Introduce stress-test E2E workflow * Explain how to stress-test an E2E flake fix * Disallow test retries in stress-test mode * Increase the job timeout * Re-word the number of times to run the test * Keep labels casing uniform * Address review suggestion * Fix unintentional line break * Multi-line command fix * Format the spec path example as code
-
Ngoc Khuat authored
* WIP adding a new endpoint /api/card/series to fetch compatible series for a given card * change endpoint convention and add tests * tighten the types and more tests * here comes the tests * indent * Update test/metabase/api/card_test.clj * more tests * fix mis-use of MLv2 * wrong args order * update the tests to cover over limit case * use id as last_cursor and sort id desc by default * use the new endpoint to fetch compatible cards in the add series modal (#30410) * use new api handler for compatible series * exclude selected cards * rename payload prop * add exclude_ids param * update contract * use multiple value for single param pattern instead of jsonified strings * remove debug code * cleanup * specs * fix failing 20637 e2e test due to missing viz-settings in test data * do not exclude selected cards from search * Noah's comments * kondo * test fix --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Kyle Doherty authored
* remove activity frontend * remove the activity page code * remove GET api/activity/ route + tests * regen dox for activity routes - Not for GET /api/activity/ which has been removed. * nix more things only used for GET /api/activity/ * pull out more only-used-for-get-api/activity/ code * force namespace to be loaded (?) to be found --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by:
Bryan Maass <bryan.maass@gmail.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
Maz Ameli authored
* remove unused const and import * update download button helper --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
Ryan Laurie authored
-