Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 07, 2023
  2. Jun 06, 2023
  3. Jun 05, 2023
    • Kamil Mielnik's avatar
      Fix - Native editor buttons are incorrectly rendering on top of model metadata screen (#31142) · f7377e8b
      Kamil Mielnik authored
      * Make NativeQueryEditor testable
      - Mock just NativeQueryEditor.prototype.loadAceEditor instead of entire NativeQueryEditor
      
      * Fix invalid propTypes
      
      * Fix DatasetQueryEditor not re-rendering when props change
      - remove custom arePropsEqual argument from React.memo() on NativeQueryEditor
      - Fixes #30680
      
      * Add a dirty initial NativeQueryEditor test setup
      
      * Add DatasetQueryEditor tests
      
      * Revert "Add a dirty initial NativeQueryEditor test setup"
      
      This reverts commit 0f985db272a2e8f1be755bda07c3b642fdf90f83.
      
      * Get rid of test errors
      
      * Clean up DatasetQueryEditor test
      
      * Add a test case for re-rendering of DatasetQueryEditor
      
      * Make setup function more reusable
      
      * Add 2 more test cases
      
      * Bring back global NativeQueryEditor mock as many tests depend on it
      
      * Add an e2e test for #30680
      
      * Optimize DatasetEditor by conditionally rendering DatasetQueryEditor only when it can be seen
      
      * Remove redundant code
      
      * ESLint
      
      * Use createMockCollection instead of a cast
      
      * Move all Native Query creation to createMockNativeDatasetQuery
      
      * Use setupCollectionsEndpoints
      
      * Introduce setupNativeQuerySnippetEndpoints and use it in DatasetQueryEditor.unit.spec.tsx
      
      * Extract explanatory importDatasetQueryEditor
      
      * Remove file accidentally added when merging master
      
      * Add missing data-testid that got lost during a merge
      Unverified
      f7377e8b
  4. Jun 03, 2023
  5. Jun 02, 2023
    • Maz Ameli's avatar
      New icons (#31096) · a1b09db0
      Maz Ameli authored
      
      * arrow_left
      
      * check mark
      
      * arrow_up and chevrons
      
      * add, close, contract, embed, expand, sort
      
      * change viewbox to 16
      
      * icons in +New menu, search, and sidebar toggle
      
      * info_outlined, connections or fk icon, and tweaks to x-ray suggestion icons
      
      * fix database icon
      
      * ellipsis, person, and tweak ellipsis size in collections sidebar
      
      * home, reference or book, pencil or edit, table
      
      * dashboard action icons, and remove reference to unused ClockIcon.jsx
      
      * question action icons and related component tweaks
      
      * larger icons on HomeModelCard on homepage
      
      * dashboard and add_to_dash
      
      * snippet and variables
      
      * all the chart type icons and some field type ones
      
      * mail and groups
      
      * make sidebar icons darker blue
      
      * fix add-your-data icon
      
      * filled mail icon and use it on events modal
      
      * stars
      
      * bolt and x-rays and a bunch more
      
      * granular, metric, revision history
      
      * arrows, formula, snippets
      
      * click, cloud, boolean, unpin
      
      * return, hourglass, popover
      
      * pause, ldap, burger
      
      * gear info list pin moon sum sun verified warning
      
      * fix size of row details modal icons
      
      * fix size of left nav icons
      
      * fix size on filter widgets and some selects
      
      * set default size to 16 to fix entity menu icons etc
      
      * fix pagination icons
      
      * size and color on ItemPicker
      
      * bump up database icon in /browse to 32px
      
      * /browse bolt icon size
      
      * find and remove instances of 14px size declarations
      
      * sql editor icons
      
      * sql expand/contract button alignment
      
      * collection breadcrumbs
      
      * remove two more size 14 declarations
      
      * viz selector
      
      * fix add icon in New button
      
      * fix size of ModelDetailLink
      
      * icon for question list empty state
      
      * get rid of model_framed icon
      
      * try to fix event tick icons, replace balloons with cake
      
      * standardize size of question footer actions
      
      * fix dinosaur
      
      * switch star_outline to star, and star to star_filled
      
      * fix notebook sort action
      
      * switch data picker from table2 to table
      
      * fix slack icon
      
      * restyle HomeXrayCard
      
      * fix List icon
      
      * fix sidebar toggle icon size
      
      * fix icon size in field picker popovers
      
      * fix summarize sidebar field type icons
      
      * fix summarize sidebar Add buttons
      
      * table heading sort icons
      
      * fix filter icon, resize button icons
      
      * bulk filters icons
      
      * admin datamodel icons sizing
      
      * fix datamodel metric and segment icons, and sort icon
      
      * dashboard interactivity sidebar close icon
      
      * get rid of grabber2
      
      * bookmark and question actions icon sizes
      
      * revert icon
      
      * Icons cleanup (#31147)
      
      * remove timeline event icon stroke
      
      * cleanup
      
      * add 16x16 viewbox to svgs that were missing it
      
      * add slack_colorized
      
      * correct the join_full_outer icon
      
      * timeline events, cleanup
      
      * fix broken icons
      
      * more cleanup
      
      * fix storybook
      
      * fix all types
      
      * add stories
      
      * try fixing arrow_split
      
      ---------
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      
      * fix specs
      
      * fix specs
      
      * remove unused icons
      
      * use constants
      
      * increase node memory allocation
      
      * bump for chromatic too
      
      * fixes
      
      * fix arrow_split icon
      
      * fix arrow_split path attributes
      
      * fix path again and fix sizing of drillthrough menu icons
      
      * more spec fixes
      
      * prettier
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      a1b09db0
    • Ryan Laurie's avatar
      Model Index Bugfixes (#31048) (#31049) (#31094) · 9a2c0190
      Ryan Laurie authored
      * [Model Indexes] Use model metadata to determine indexability (#31048)
      * [Model Indexes] Allow Updating Metadata at the same time as adding an index (#31049)
      * [Model Indexes] Fix Model Index Front End Cache Invalidation (#31094)
      Unverified
      9a2c0190
    • Oisin Coveney's avatar
  6. Jun 01, 2023
  7. May 31, 2023
  8. May 30, 2023
  9. May 26, 2023
    • Denis Berezin's avatar
      [Epic PR] Make drill-through chiller (#26836) (#30273) · 45dcf573
      Denis Berezin authored
      * Update underlying records drill - bring to top, label changes (#29984)
      
      * Zoom in Drill (#30208)
      
      * Add updated zoom drill title
      
      * Fix e2e tests
      
      * Add title unit tests
      
      * Fix for Records drill UI when it is the only one displayed
      
      * Review fixes
      
      * Add pivot drill common popover (#30275)
      
      * Add grouping for Pivot drill options
      
      * Reuse filterField type
      
      * Fix date formatting after rebase
      
      * Move Automatic insight action to a common popover (#30370)
      
      * Refactor ChartClickActionsView, reuse it component in drills (#30706)
      
      * 26836 separate views for quick cell click filters (#30532)
      
      * Added separate views for QuickFilterDrill
      
      * Add tests, fix styles issues
      
      * 26836 contains/does not contain quick filter for tables (#30778)
      
      * Add contains/does not contain quick filter for tables
      
      * Self review fixes
      
      * Fix for column header filter search options cropped
      
      * Fix for icon margin difference for contains / does not contain filters
      
      * Fix contains filter actions icon styles
      
      * Add quick filters support for aggregated queries
      
      * Not show contains filter for joined fields
      
      * Fix typecheck
      
      * Adjust string field quick filter section title to have column name (#30888)
      
      * 26836 Add View details action for quick filters (#30967)
      
      * Add View details action to quick filters
      
      * Self review fixes
      
      * Fix e2e tests
      
      * Fix review issues
      Unverified
      45dcf573
    • Aleksandr Lesnenko's avatar
      fix the question description icon placement in the collection view (#31051) · bfd25306
      Aleksandr Lesnenko authored
      * fix the question description icon placement in the collection view
      
      * fix specs
      Unverified
      bfd25306
    • Braden Shepherdson's avatar
      For a breakout on a custom column, hide the binning/bucketing options (#31037) · 94d3d37d
      Braden Shepherdson authored
      This has never worked (see #11371) and produces bad results which group
      by every individual value of the column, rather than binning/bucketing
      correctly.
      
      This can theoretically be supported, but needs BE work to construct
      correct queries. To be addressed after MLv2.
      Unverified
      94d3d37d
    • Nemanja Glumac's avatar
      [E2E] Cypress Replay.io Integration (#29787) · 5e359e20
      Nemanja Glumac authored
      
      * Install `replay.io` library
      
      * Register `replay.io` in the Cypress config
      
      * Run E2E tests using Replay chromium browser but only in CI
      
      * Upload Replay.io recordings to the dashboard
      
      * Manually install Replay.io browser
      
      * Always upload recordings
      
      * Pass in a custom test run id
      
      * Disable asserts and send replays to a separate team
      
      * Upload OSS recordings as well
      
      * Use specific Ubuntu version
      
      * Record and run Replay.io on `master` only
      
      * Do not toggle CI browsers in the config
      
      * Test run: pass `replay-chromium` browser as CLI flag in a run
      
      * Fix multi-line command
      
      * Use replay plugin conditionally
      
      * Set the flag correctly
      
      * Require node process
      
      * Remove sourcemap vars
      
      * Record using replay.io on schedule
      
      * Explicitly name replay runs
      
      ---------
      
      Co-authored-by: default avatarJaril <jarilvalenciano@gmail.com>
      Unverified
      5e359e20
    • Ngoc Khuat's avatar
      Move logic to infer revision.description to BE (#30502) · edc969ce
      Ngoc Khuat authored
      
      * Dashboard Tab entity (#29802)
      
      * add dashboard tab entity
      
      * Dashboard tabs CRUD (#29861)
      
      * Dashboard tabs frontend (#30189)
      
      * rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx`
      
      commit-id:7cdfd86a
      
      * add tabs to dash
      
      commit-id:d3c2fa74
      
      * improve code structure and other fixes
      
      * rename `dashboardtab_id` to `dashboard_tab_id`
      
      * remove explicit `position` logic
      
      * improve code quality
      
      * add renaming functionality
      
      * add two new tabs when creating first tab
      
      * hide tabs if there is only one
      
      * add unit test for `DashboardTabs` component
      
      * refactor
      
      * fix type errors
      
      * add `tabId` to text cards
      
      * add `tabId` to link cards
      
      * add `tabId` to action button
      
      * use disabled state when only one tab remains
      
      * refetch cards with filter value when changing tabs
      
      * add e2e test
      
      * fix broken e2e tests
      
      * add horizontal scrolling
      
      * fix unit test
      
      * fix create tab button being on right
      
      * fix performance issue when switching tabs
      
      * add `ttag` to `tabs.ts`
      
      * use `aria-label` in e2e test helper
      
      * fix type error after rebasing
      
      * making ordered_tabs optional for tests purposes
      
      * fix failing unit tests
      
      * fix failing e2e tests
      
      * fix flaky revision history e2e test
      
      * fix type error after merging feature branch with master and rebasing
      
      * fix revisions unit test
      
      * fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * migrating revision logic to BE
      
      * handle description for multiple cards add/remove
      
      * test fixes
      
      * adds tests
      
      * make sures events are started so tests work
      
      * remove additional `:maybe` that was added while rebasing
      
      * add title and has_multile_changes to revision
      
      * fixes potential test flake
      
      * more tests
      
      * remove debug code
      
      * handles collection change description in card and dashboard
      
      * fixes fail to build
      
      * use backend for revision history (#30772)
      
      * use BE response for revision history
      
      * update `service.unit.spec.js`
      
      * sort revision and moderation events for question timeline
      
      * test fixes
      
      * create revision directly instead of via API to avoid flake
      
      * reverted to an earlier revision => reverted to an earlier version
      
      * translate the model name too
      
      * Rename functions:
      - diff-strs -> diff-strings
      - diff-strings -> diff-strings*
      - diff-strings* -> diff-string
      
      * move the diff to diff-strings*
      
      * use case instead of map for model-str->i18n-str
      
      * remove title from API response
      
      * do not translate test model
      
      * rename var `title_text` to `titleText`
      
      * address comments
      
      * stringify the display name
      
      * fix revert button not working
      
      * add loading wrapper to fix unit test
      
      * fix tests
      
      * fix type error
      
      * fix QuestionActivityTimeline test
      
      * add a dot for edited this
      
      ---------
      
      Co-authored-by: default avatarEmmad Usmani <emmadusmani@berkeley.edu>
      Unverified
      edc969ce
    • Alexander Polyankin's avatar
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Merge Track disabling auto-apply filters in Snowplow to master #30796 (#31020) · 9f575cd1
      Mahatthana (Kelvin) Nomsawadi authored
      * Consolidate auto-apply filters toggle action (#30978)
      
      So that when we start tracking the event on Snowplow, we can only do that in a single place.
      
      * Track disabling auto-apply filters in Snowplow (#30987)
      
      * Fix dashboard ID type
      Unverified
      9f575cd1
    • Nemanja Glumac's avatar
      [CI] Fix stress-test workflow (#31028) · 3090dfaf
      Nemanja Glumac authored
      Unverified
      3090dfaf
  10. May 25, 2023
    • Nick Fitzpatrick's avatar
      Custom homepage (#30545) · 111c47ee
      Nick Fitzpatrick authored
      
      * Adding admin settings
      
      * updating homepage
      
      * permissions
      
      * Include custom homepage on current user
      
      Response from `/api/user/current/` now always includes a key
      `custom_homepage`. It is nil unless `custom-homepage` setting is true
      and `custom-homepage-dashboard` is set to an id that is a valid
      dashboard that the user can read. (note this includes archived
      dashboards). In this circumstance, the response will be
      
      ```
        ...
        "custom_homepage": {
          "dashboard_id": 87
        },
        ...
      ```
      
      * adding unit tests
      
      * Homepage CTA
      
      * cleanup and types
      
      * e2e tests, small adustments
      
      * lint
      
      * type fix
      
      * Editing Dashboard Reminder
      
      * fixing unit test
      
      * ensure custom homepage dashboard exists and is not archived
      
      * handling dashboard archived scenario, use-dashboard-query
      
      * polish
      
      * Copy updates, removing personal collections from picker
      
      * PR Feedback
      
      * CI checks
      
      * PR Feedback
      
      * Adding default filter function
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Unverified
      111c47ee
  11. May 24, 2023
  12. May 23, 2023
Loading